media: smiapp: avoid printing an uninitialized variable
Subsystems (2)
PATCH 1/1 media: smiapp: avoid printing an uninitialized variable
From: Arnd Bergmann <[email protected]>
There is no intialization for the 'reg' variable, so printing it produces undefined behavior as well as a compile-time warning:
drivers/media/i2c/ccs/ccs-core.c:314:49: error: variable 'reg' is uninitialized when used here [-Werror,-Wuninitialized]
"0x%8.8x %s pixels: %d %s (pixelcode %u)\n", reg,
Remove the variable and stop printing it.
--- drivers/media/i2c/ccs/ccs-core.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/media/i2c/ccs/ccs-core.c +1 -2
@@ -257,7 +257,6 @@ static int ccs_read_frame_fmt(struct ccs_sensor *sensor)u32 pixels;char *which;char *what; -u32 reg;if (fmt_model_type ==CCS_FRAME_FORMAT_MODEL_TYPE_2_BYTE ) { desc =CCS_LIM_AT (sensor,FRAME_FORMAT_DESCRIPTOR , i);
@@ -311,7 +310,7 @@ static int ccs_read_frame_fmt(struct ccs_sensor *sensor) }dev_dbg (&client->dev, -"0x%8.8x %s pixels: %d %s (pixelcode %u)\n" , reg, +"%s pixels: %d %s (pixelcode %u)\n" , what, pixels, which, pixelcode);if (i < ncol_desc) {
Signature · 1 line
2.27.0
Sakari Ailus
maintainerHi Arnd,
Thanks for the patch.
Quoted 11 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
There is no intialization for the 'reg' variable, so printing it produces undefined behavior as well as a compile-time warning:
drivers/media/i2c/ccs/ccs-core.c:314:49: error: variable 'reg' is uninitialized when used here [-Werror,-Wuninitialized]"0x%8.8x %s pixels: %d %s (pixelcode %u)\n", reg,Remove the variable and stop printing it.
Fixes b24cc2a18c50 ("media: smiapp: Rename as "ccs"")
The patch introducing this was
fd9065812c7b ("media: smiapp: Obtain frame descriptor from CCS limits")
so I'll use it instead. Also s/smiapp/ccs/ in the subject.
Interesting that GCC 8.3 didn't complain.
Signature · 3 lines
Kind regards, Sakari Ailus