Skip to contentSkip to conversation

cpufreq: scmi: add COMMON_CLK dependency

PATCH In review Arnd Bergmann 2 participants 2 messages Dec 3, 2020 – Dec 7, 2020 CPU frequency scaling framework

lore
Share & tools
lore

Arnd Bergmann

author
#0 lore raw

PATCH 1/1 cpufreq: scmi: add COMMON_CLK dependency

From: Arnd Bergmann <[email protected]>

Wtihout CONFIG_COMMON_CLK, the scmi driver fails to link:

arm-linux-gnueabi-ld: drivers/cpufreq/scmi-cpufreq.o: in function `scmi_cpufreq_probe':
scmi-cpufreq.c:(.text+0x20c): undefined reference to `devm_of_clk_add_hw_provider'
arm-linux-gnueabi-ld: scmi-cpufreq.c:(.text+0x22c): undefined reference to `of_clk_hw_simple_get'

Add a Kconfig dependency for it.

Fixes 8410e7f3b31e ("cpufreq: scmi: Fix OPP addition failure with a dummy clock provider")
Signed-off-by Arnd Bergmann <[email protected]>
---
 drivers/cpufreq/Kconfig.arm | 1 +
 1 file changed, 1 insertion(+)
drivers/cpufreq/Kconfig.arm +1 -0
index 1f73fa75b1a0..434ef03d2762 100644
@@ -264,6 +264,7 @@ config ARM_SA1110_CPUFREQ
 config ARM_SCMI_CPUFREQ
 	tristate "SCMI based CPUfreq driver"
 	depends on ARM_SCMI_PROTOCOL || COMPILE_TEST
+	depends on COMMON_CLK
 	select PM_OPP
 	help
 	  This adds the CPUfreq driver support for ARM platforms using SCMI
Signature · 1 line
2.27.0
maintainer
#1 lore raw
Quoted 21 lines · Arnd Bergmann

From: Arnd Bergmann <[email protected]>

Wtihout CONFIG_COMMON_CLK, the scmi driver fails to link:

arm-linux-gnueabi-ld: drivers/cpufreq/scmi-cpufreq.o: in function `scmi_cpufreq_probe':
scmi-cpufreq.c:(.text+0x20c): undefined reference to `devm_of_clk_add_hw_provider'
arm-linux-gnueabi-ld: scmi-cpufreq.c:(.text+0x22c): undefined reference to `of_clk_hw_simple_get'

Add a Kconfig dependency for it.

Fixes 8410e7f3b31e ("cpufreq: scmi: Fix OPP addition failure with a dummy clock provider")
Signed-off-by Arnd Bergmann <[email protected]>
---
 drivers/cpufreq/Kconfig.arm | 1 +
 1 file changed, 1 insertion(+)
drivers/cpufreq/Kconfig.arm +0 -0
index 1f73fa75b1a0..434ef03d2762 100644

drivers/cpufreq/Kconfig.arm config ARM_SA1110_CPUFREQ · line 270

Quoted 7 lines
drivers/cpufreq/Kconfig.arm +1 -0
@@ -264,6 +264,7 @@ config ARM_SA1110_CPUFREQ
 config ARM_SCMI_CPUFREQ
 	tristate "SCMI based CPUfreq driver"
 	depends on ARM_SCMI_PROTOCOL || COMPILE_TEST
+	depends on COMMON_CLK
 	select PM_OPP
 	help
 	  This adds the CPUfreq driver support for ARM platforms using SCMI

This is already fixed by:

commit f943849f7206 ("cpufreq: scmi: Fix build for !CONFIG_COMMON_CLK")

Signature · 1 line
viresh