Skip to contentSkip to conversation

ASoC: qcom: fix QDSP6 dependencies, attempt #3

PATCH In review Arnd Bergmann 3 participants 3 messages Dec 3, 2020 – Dec 4, 2020

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ASoC: qcom: fix QDSP6 dependencies, attempt #3

From: Arnd Bergmann <[email protected]>

The previous fix left another warning in randconfig builds:

WARNING: unmet direct dependencies detected for SND_SOC_QDSP6
Depends on [n]: SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && SND_SOC_QCOM [=y] && QCOM_APR [=y] && COMMON_CLK [=n] Selected by [y]:
- SND_SOC_MSM8996 [=y] && SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && SND_SOC_QCOM [=y] && QCOM_APR [=y]

Add one more dependency for this one.

Fixes 2bc8831b135c ("ASoC: qcom: fix SDM845 & QDSP6 dependencies more")
---
 sound/soc/qcom/Kconfig | 1 +
 1 file changed, 1 insertion(+)
sound/soc/qcom/Kconfig +1 -0
index 27f93006be96..cc7c1de2f1d9 100644
@@ -106,6 +106,7 @@ config SND_SOC_QDSP6
 config SND_SOC_MSM8996
 	tristate "SoC Machine driver for MSM8996 and APQ8096 boards"
 	depends on QCOM_APR
+	depends on COMMON_CLK
 	select SND_SOC_QDSP6
 	select SND_SOC_QCOM_COMMON
 	help
Signature · 1 line
2.27.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 9 lines · Arnd Bergmann

From: Arnd Bergmann <[email protected]>

The previous fix left another warning in randconfig builds:

WARNING: unmet direct dependencies detected for SND_SOC_QDSP6
Depends on [n]: SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && SND_SOC_QCOM [=y] && QCOM_APR [=y] && COMMON_CLK [=n] Selected by [y]:
- SND_SOC_MSM8996 [=y] && SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && SND_SOC_QCOM [=y] && QCOM_APR [=y]

Quoted 4 lines

Add one more dependency for this one.

Fixes 2bc8831b135c ("ASoC: qcom: fix SDM845 & QDSP6 dependencies more")

Thanks for the patch,

Quoted 17 lines
---
  sound/soc/qcom/Kconfig | 1 +
  1 file changed, 1 insertion(+)
sound/soc/qcom/Kconfig +1 -0
index 27f93006be96..cc7c1de2f1d9 100644
@@ -106,6 +106,7 @@ config SND_SOC_QDSP6
  config SND_SOC_MSM8996
  	tristate "SoC Machine driver for MSM8996 and APQ8096 boards"
  	depends on QCOM_APR
+	depends on COMMON_CLK
  	select SND_SOC_QDSP6
  	select SND_SOC_QCOM_COMMON
  	help
maintainer
#2 lore raw
In reply to Arnd Bergmann
Quoted 8 lines · Arnd Bergmann

The previous fix left another warning in randconfig builds:

WARNING: unmet direct dependencies detected for SND_SOC_QDSP6
Depends on [n]: SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && SND_SOC_QCOM [=y] && QCOM_APR [=y] && COMMON_CLK [=n] Selected by [y]:
- SND_SOC_MSM8996 [=y] && SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && SND_SOC_QCOM [=y] && QCOM_APR [=y]

[...]

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: qcom: fix QDSP6 dependencies, attempt #3

      commit: b1b8eb1283c90a953089d988930d7b6156418958

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark