media: i2c: fix an uninitialized error code
Subsystems (4)
PATCH v2 1/1 media: i2c: fix an uninitialized error code
From: Arnd Bergmann <[email protected]>
Clang points out that the error handling in ov02a10_s_stream() is broken, and just returns a random error code:
drivers/media/i2c/ov02a10.c:537:6: warning: variable 'ret' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized]
if (ov02a10->streaming == on)
^~~~~~~~~~~~~~~~~~~~~~~~
drivers/media/i2c/ov02a10.c:568:9: note: uninitialized use occurs here
return ret;
^~~
drivers/media/i2c/ov02a10.c:537:2: note: remove the 'if' if its condition is always false
if (ov02a10->streaming == on)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~If streaming is already on, leave it that way and return success.
Suggested-by Dongchun Zhu <[email protected]>
Fixes 91807efbe8ec ("media: i2c: add OV02A10 image sensor driver")
Signed-off-by Arnd Bergmann <[email protected]>
---
v2:
- return success instead of -EBUSY, according to feedback from Dongchun Zhu
- remove incorrect advice from warning message citation
--- drivers/media/i2c/ov02a10.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/media/i2c/ov02a10.c +3 -1
@@ -534,8 +534,10 @@ static int ov02a10_s_stream(struct v4l2_subdev *sd, int on)mutex_lock (&ov02a10->mutex); -if (ov02a10->streaming == on) +if (ov02a10->streaming == on) { + ret =0 ; goto unlock_and_return; + }if (on) { ret =pm_runtime_get_sync (&client->dev);
Signature · 7 lines
2.27.0 _______________________________________________ Linux-mediatek mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-mediatek