block/nvme: Do not allow image creation with NVMe block driver
PATCH 1/1 block/nvme: Do not allow image creation with NVMe block driver
The NVMe driver does not support image creation.
The full drive has to be passed to the guest.
Before:
$ qemu-img create -f raw nvme://0000:04:00.0/1 20G Formatting 'nvme://0000:04:00.0/1', fmt=raw size=21474836480
$ qemu-img info nvme://0000:04:00.0/1 image: nvme://0000:04:00.0/1 file format: raw virtual size: 349 GiB (375083606016 bytes) disk size: unavailable
After:
$ qemu-img create -f raw nvme://0000:04:00.0/1 20G qemu-img: nvme://0000:04:00.0/1: Protocol driver 'nvme' does not support image creation
---
Cc: Maxim Levitsky <[email protected]>
--- block/nvme.c | 3 --- 1 file changed, 3 deletions(-)
block/nvme.c +0 -3
@@ -1515,9 +1515,6 @@ static BlockDriver bdrv_nvme = { .protocol_name = "nvme", .instance_size = sizeof(BDRVNVMeState), - .bdrv_co_create_opts = bdrv_co_create_opts_simple, - .create_opts = &bdrv_create_opts_simple, - .bdrv_parse_filename = nvme_parse_filename, .bdrv_file_open = nvme_file_open, .bdrv_close = nvme_close,
Signature · 1 line
2.26.2
Quoted 14 lines · Philippe Mathieu-Daudé
The NVMe driver does not support image creation.
The full drive has to be passed to the guest.Before:
$ qemu-img create -f raw nvme://0000:04:00.0/1 20G Formatting 'nvme://0000:04:00.0/1', fmt=raw size=21474836480$ qemu-img info nvme://0000:04:00.0/1 image: nvme://0000:04:00.0/1 file format: raw virtual size: 349 GiB (375083606016 bytes) disk size: unavailable
Quoted 8 lines
After:
$ qemu-img create -f raw nvme://0000:04:00.0/1 20G qemu-img: nvme://0000:04:00.0/1: Protocol driver 'nvme' does not support image creationFixes 5a5e7f8cd86 ("block: trickle down the fallback image creation function use to the block drivers")Reported-by Xueqiang Wei <[email protected]>Suggested-by Max Reitz <[email protected]>
Well Max didn't suggest the change but pointed me to commit 5a5e7f8cd86.
Quoted 22 lines
Signed-off-by Philippe Mathieu-Daudé <[email protected]>---
Cc: Maxim Levitsky <[email protected]>--- block/nvme.c | 3 --- 1 file changed, 3 deletions(-)block/nvme.c +0
-3@@ -1515,9 +1515,6 @@ static BlockDriver bdrv_nvme = { .protocol_name = "nvme", .instance_size = sizeof(BDRVNVMeState), - .bdrv_co_create_opts = bdrv_co_create_opts_simple, - .create_opts = &bdrv_create_opts_simple, - .bdrv_parse_filename = nvme_parse_filename, .bdrv_file_open = nvme_file_open, .bdrv_close = nvme_close,
Quoted 6 lines · Philippe Mathieu-Daudé
Quoted 5 lines · Philippe Mathieu-Daudé
The NVMe driver does not support image creation.
The full drive has to be passed to the guest.Before:
Quoted 8 lines
Quoted 8 lines
$ qemu-img create -f raw nvme://0000:04:00.0/1 20G Formatting 'nvme://0000:04:00.0/1', fmt=raw size=21474836480$ qemu-img info nvme://0000:04:00.0/1 image: nvme://0000:04:00.0/1 file format: raw virtual size: 349 GiB (375083606016 bytes) disk size: unavailable
Maybe I should not forbid all formats... But 'raw' is kinda dangerous, as there is no way to enforce the next layer to access beside the size allocated.
Safe drive partitioning can be achieved creating namespaces, feature which is not yet implemented.
Quoted 35 lines
Quoted 9 lines
After:
$ qemu-img create -f raw nvme://0000:04:00.0/1 20G qemu-img: nvme://0000:04:00.0/1: Protocol driver 'nvme' does not support image creationFixes 5a5e7f8cd86 ("block: trickle down the fallback image creation function use to the block drivers")Reported-by Xueqiang Wei <[email protected]>Suggested-by Max Reitz <[email protected]>Well Max didn't suggest the change but pointed me to commit
5a5e7f8cd86.Quoted 22 lines
Signed-off-by Philippe Mathieu-Daudé <[email protected]>---
Cc: Maxim Levitsky <[email protected]>--- block/nvme.c | 3 --- 1 file changed, 3 deletions(-)block/nvme.c +0
-3@@ -1515,9 +1515,6 @@ static BlockDriver bdrv_nvme = { .protocol_name = "nvme", .instance_size = sizeof(BDRVNVMeState), - .bdrv_co_create_opts = bdrv_co_create_opts_simple, - .create_opts = &bdrv_create_opts_simple, - .bdrv_parse_filename = nvme_parse_filename, .bdrv_file_open = nvme_file_open, .bdrv_close = nvme_close,
Quoted 16 lines · Philippe Mathieu-Daudé
Quoted 6 lines · Philippe Mathieu-Daudé
Quoted 5 lines · Philippe Mathieu-Daudé
The NVMe driver does not support image creation.
The full drive has to be passed to the guest.Before:
Quoted 8 lines
Quoted 8 lines
$ qemu-img create -f raw nvme://0000:04:00.0/1 20G Formatting 'nvme://0000:04:00.0/1', fmt=raw size=21474836480$ qemu-img info nvme://0000:04:00.0/1 image: nvme://0000:04:00.0/1 file format: raw virtual size: 349 GiB (375083606016 bytes) disk size: unavailable
Quoted 6 lines
Maybe I should not forbid all formats... But 'raw' is kinda dangerous, as there is no way to enforce the next layer to access beside the size allocated.
Safe drive partitioning can be achieved creating namespaces, feature which is not yet implemented.
I don't see the need for this patch. Or if there is a need then block/file-posix.c, block/iscsi.c, and block/nbd.c should also be changed (anything that uses bdrv_co_create_opts_simple()).
Instead I suggest adding a warning at creation time if a raw format image is created on top of a BDS that is larger than requested. The warning should remind the user that they need to use the raw format drivers's size= open option to restrict the disk capacity when opening the image.
Stefan
Am 17.12.2020 um 17:17 hat Stefan Hajnoczi geschrieben:
Quoted 28 lines · Philippe Mathieu-Daudé
Quoted 16 lines · Philippe Mathieu-Daudé
Quoted 6 lines · Philippe Mathieu-Daudé
Quoted 5 lines
The NVMe driver does not support image creation.
The full drive has to be passed to the guest.Before:
Quoted 8 lines
Quoted 8 lines
$ qemu-img create -f raw nvme://0000:04:00.0/1 20G Formatting 'nvme://0000:04:00.0/1', fmt=raw size=21474836480$ qemu-img info nvme://0000:04:00.0/1 image: nvme://0000:04:00.0/1 file format: raw virtual size: 349 GiB (375083606016 bytes) disk size: unavailableQuoted 6 lines
Maybe I should not forbid all formats... But 'raw' is kinda dangerous, as there is no way to enforce the next layer to access beside the size allocated.
Safe drive partitioning can be achieved creating namespaces, feature which is not yet implemented.
I don't see the need for this patch. Or if there is a need then
block/file-posix.c,block/iscsi.c, andblock/nbd.cshould also be changed (anything that usesbdrv_co_create_opts_simple()).
Quoted 5 lines
Instead I suggest adding a warning at creation time if a raw format image is created on top of a BDS that is larger than requested. The warning should remind the user that they need to use the raw format drivers's size= open option to restrict the disk capacity when opening the image.
This sounds like a good idea to me.
Kevin