remoteproc: sysmon: fix shutdown_acked state
Subsystems (2)
PATCH 1/1 remoteproc: sysmon: fix shutdown_acked state
From: Arnd Bergmann <[email protected]>
The latest version of sysmon_stop() starts by initializing the sysmon->shutdown_acked variable, but then overwrites it with an uninitialized variable later:
drivers/remoteproc/qcom_sysmon.c:551:11: error: variable 'acked' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized]
else if (sysmon->ept)
^~~~~~~~~~~
drivers/remoteproc/qcom_sysmon.c:554:27: note: uninitialized use occurs here
sysmon->shutdown_acked = acked;
^~~~~Remove the local 'acked' variable again and set the state directly.
--- drivers/remoteproc/qcom_sysmon.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-)
drivers/remoteproc/qcom_sysmon.c +2 -5
@@ -533,7 +533,6 @@ static void sysmon_stop(struct rproc_subdev *subdev, bool crashed) .subsys_name = sysmon->name, .ssr_event = SSCTL_SSR_EVENT_BEFORE_SHUTDOWN }; -bool acked; sysmon->shutdown_acked = false;
@@ -547,11 +546,9 @@ static void sysmon_stop(struct rproc_subdev *subdev, bool crashed)return ;if (sysmon->ssctl_version) - acked =ssctl_request_shutdown (sysmon); + sysmon->shutdown_acked =ssctl_request_shutdown (sysmon);else if (sysmon->ept) - acked =sysmon_request_shutdown (sysmon); - - sysmon->shutdown_acked = acked; + sysmon->shutdown_acked =sysmon_request_shutdown (sysmon); }static void sysmon_unprepare (struct rproc_subdev *subdev)
Signature · 1 line
2.27.0
This patch was applied to andersson/remoteproc.git (refs/heads/for-next):
Hello:
This patch was applied to andersson/remoteproc.git (refs/heads/for-next):
Quoted 6 lines · On Fri, 4 Dec 2020 20:37:35 +0100 you wrote:
From: Arnd Bergmann <[email protected]>
The latest version of
sysmon_stop()starts by initializing thesysmon->shutdown_ackedvariable, but then overwrites it with an uninitialized variable later:
Quoted 8 lines
drivers/remoteproc/qcom_sysmon.c:551:11: error: variable 'acked' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized]else if (sysmon->ept) ^~~~~~~~~~~ drivers/remoteproc/qcom_sysmon.c:554:27: note: uninitialized use occurs here sysmon->shutdown_acked = acked; ^~~~~[...]
Here is the summary with links:
- remoteproc: sysmon: fix shutdown_acked state
https://git.kernel.org/andersson/remoteproc/c/9d7b4a40387d
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
This patch was applied to qcom/linux.git (refs/heads/for-next):
Hello:
This patch was applied to qcom/linux.git (refs/heads/for-next):
Quoted 6 lines · On Fri, 4 Dec 2020 20:37:35 +0100 you wrote:
From: Arnd Bergmann <[email protected]>
The latest version of
sysmon_stop()starts by initializing thesysmon->shutdown_ackedvariable, but then overwrites it with an uninitialized variable later:
Quoted 8 lines
drivers/remoteproc/qcom_sysmon.c:551:11: error: variable 'acked' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized]else if (sysmon->ept) ^~~~~~~~~~~ drivers/remoteproc/qcom_sysmon.c:554:27: note: uninitialized use occurs here sysmon->shutdown_acked = acked; ^~~~~[...]
Here is the summary with links:
- remoteproc: sysmon: fix shutdown_acked state
https://git.kernel.org/qcom/c/9d7b4a40387d
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html