doc: fix wrong hugepages setting path
PATCH 1/1 doc: fix wrong hugepages setting path
From: Wang Liming <[email protected]>
Remove redundant "nr_hugepages" words from mlx4 and mlx5 doc.
--- doc/guides/nics/mlx4.rst | 2 +- doc/guides/nics/mlx5.rst | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
doc/guides/nics/mlx4.rst +1 -1
@@ -405,7 +405,7 @@ devices managed by librte_net_mlx4. #. Request huge pages:: - echo 1024 > /sys/kernel/mm/hugepages/hugepages-2048kB/nr_hugepages/nr_hugepages + echo 1024 > /sys/kernel/mm/hugepages/hugepages-2048kB/nr_hugepages #. Start testpmd with basic parameters::
doc/guides/nics/mlx5.rst +1 -1
@@ -1594,7 +1594,7 @@ ConnectX-4/ConnectX-5/ConnectX-6/BlueField devices managed by librte_net_mlx5. #. Request huge pages:: - echo 1024 > /sys/kernel/mm/hugepages/hugepages-2048kB/nr_hugepages/nr_hugepages + echo 1024 > /sys/kernel/mm/hugepages/hugepages-2048kB/nr_hugepages #. Start testpmd with basic parameters::
Signature · 1 line
2.25.1
Quoted 28 lines · On Mon, 7 Dec 2020 01:31:14 +0800 [email protected] wrote:
From: Wang Liming <[email protected]>
Remove redundant "
nr_hugepages" words from mlx4 and mlx5 doc.Signed-off-by Wang Liming <[email protected]>--- doc/guides/nics/mlx4.rst | 2 +- doc/guides/nics/mlx5.rst | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)doc/guides/nics/mlx4.rst +1
-1@@ -405,7 +405,7 @@ devices managed by librte_net_mlx4. #. Request huge pages:: - echo 1024 > /sys/kernel/mm/hugepages/hugepages-2048kB/nr_hugepages/nr_hugepages + echo 1024 > /sys/kernel/mm/hugepages/hugepages-2048kB/nr_hugepages #. Start testpmd with basic parameters::doc/guides/nics/mlx5.rst +0
-0
doc/guides/nics/mlx5.rst ConnectX-4/ConnectX-5/ConnectX-6/BlueField devices managed by librte_net_mlx5. · line 1600
Quoted 8 lines
doc/guides/nics/mlx5.rst +1
-1@@ -1594,7 +1594,7 @@ ConnectX-4/ConnectX-5/ConnectX-6/BlueField devices managed by librte_net_mlx5. #. Request huge pages:: - echo 1024 > /sys/kernel/mm/hugepages/hugepages-2048kB/nr_hugepages/nr_hugepages + echo 1024 > /sys/kernel/mm/hugepages/hugepages-2048kB/nr_hugepages #. Start testpmd with basic parameters::
Could we change the drivers to refer to the existing hugepages script rather than doing "roll your own"
06/12/2020 18:43, Stephen Hemminger:
Quoted 12 lines
Quoted 9 lines · On Mon, 7 Dec 2020 01:31:14 +0800 [email protected] wrote:
From: Wang Liming <[email protected]>
Remove redundant "
nr_hugepages" words from mlx4 and mlx5 doc.Signed-off-by Wang Liming <[email protected]>--- doc/guides/nics/mlx4.rst | 2 +- doc/guides/nics/mlx5.rst | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
[...]
Quoted 9 lines
doc/guides/nics/mlx5.rst
Quoted 6 lines
doc/guides/nics/mlx5.rst +1
-1#. Request huge pages:: - echo 1024 > /sys/kernel/mm/hugepages/hugepages-2048kB/nr_hugepages/nr_hugepages + echo 1024 > /sys/kernel/mm/hugepages/hugepages-2048kB/nr_hugepagesCould we change the drivers to refer to the existing hugepages script rather than doing "roll your own"
I agree. I've sent a patch to use the new script wherever needed:
https://patches.dpdk.org/patch/87877/