scsi: ufs: Allow regulators being always on
Subsystems (2)
cover scsi: ufs: Allow regulators being always on
Hi,
This series allow vendors to keep the regulator always-on, and provide an implementation on MediaTek UFS platforms.
Stanley Chu (2):
scsi: ufs: Allow regulators being always-on
scsi: ufs-mediatek: Keep VCC always-on for specific devices
drivers/scsi/ufs/ufs-mediatek.c | 21 +++++++++++++++++++++ drivers/scsi/ufs/ufs-mediatek.h | 1 + drivers/scsi/ufs/ufs.h | 1 + drivers/scsi/ufs/ufshcd.c | 2 +- 4 files changed, 24 insertions(+), 1 deletion(-)
Signature · 1 line
2.18.0
PATCH 1/2 scsi: ufs: Allow regulators being always-on
Introduce a flag "always_on" in struct ufs_vreg to allow vendors to keep the regulator always-on.
--- drivers/scsi/ufs/ufs.h | 1 + drivers/scsi/ufs/ufshcd.c | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-)
drivers/scsi/ufs/ufs.h +1 -0
@@ -513,6 +513,7 @@ struct ufs_query_res {struct ufs_vreg {struct regulator *reg;const char *name; +bool always_on;bool enabled;int min_uV;int max_uV;
drivers/scsi/ufs/ufshcd.c +1 -1
@@ -7973,7 +7973,7 @@ static int ufshcd_disable_vreg(struct device *dev, struct ufs_vreg *vreg) {int ret =0 ; -if (!vreg || !vreg->enabled) +if (!vreg || !vreg->enabled || vreg->always_on) goto out; ret =regulator_disable (vreg->reg);
Signature · 1 line
2.18.0
PATCH 2/2 scsi: ufs-mediatek: Keep VCC always-on for specific devices
In reply to Stanley ChuFor some devices which needs extra delay after VCC power down, VCC shall be kept always-on in some MediaTek UFS platforms to ensure the stability of such devices because the extra delay may not be enough in those platforms.
--- drivers/scsi/ufs/ufs-mediatek.c | 21 +++++++++++++++++++++ drivers/scsi/ufs/ufs-mediatek.h | 1 + 2 files changed, 22 insertions(+)
drivers/scsi/ufs/ufs-mediatek.c +21 -0
@@ -70,6 +70,13 @@ static bool ufs_mtk_is_va09_supported(struct ufs_hba *hba)return !!(host->caps &UFS_MTK_CAP_VA09_PWR_CTRL ); } +static bool ufs_mtk_is_broken_vcc (struct ufs_hba *hba) +{ +struct ufs_mtk_host *host =ufshcd_get_variant (hba); + +return !!(host->caps &UFS_MTK_CAP_BROKEN_VCC ); +} +static void ufs_mtk_cfg_unipro_cg (struct ufs_hba *hba,bool enable) {u32 tmp;
@@ -514,6 +521,9 @@ static void ufs_mtk_init_host_caps(struct ufs_hba *hba)if (of_property_read_bool (np,"mediatek,ufs-disable-ah8" )) host->caps |=UFS_MTK_CAP_DISABLE_AH8 ; +if (of_property_read_bool (np,"mediatek,ufs-broken-vcc" )) + host->caps |=UFS_MTK_CAP_BROKEN_VCC ; +dev_info (hba->dev,"caps: 0x%x" , host->caps); }
@@ -1003,6 +1013,17 @@ static int ufs_mtk_apply_dev_quirks(struct ufs_hba *hba)static void ufs_mtk_fixup_dev_quirks (struct ufs_hba *hba) {ufshcd_fixup_dev_quirks (hba, ufs_mtk_dev_fixups); + +if (ufs_mtk_is_broken_vcc (hba) && hba->vreg_info.vcc && + (hba->dev_quirks &UFS_DEVICE_QUIRK_DELAY_AFTER_LPM )) { + hba->vreg_info.vcc->always_on = true; +/* +* VCC will be kept always-on thus we don't +* need any delay during regulator operations +*/ + hba->dev_quirks &= ~(UFS_DEVICE_QUIRK_DELAY_BEFORE_LPM | +UFS_DEVICE_QUIRK_DELAY_AFTER_LPM ); + } } static void ufs_mtk_event_notify(struct ufs_hba *hba,
drivers/scsi/ufs/ufs-mediatek.h +1 -0
@@ -81,6 +81,7 @@ enum ufs_mtk_host_caps {UFS_MTK_CAP_BOOST_CRYPT_ENGINE =1 <<0 ,UFS_MTK_CAP_VA09_PWR_CTRL =1 <<1 ,UFS_MTK_CAP_DISABLE_AH8 =1 <<2 , + UFS_MTK_CAP_BROKEN_VCC = 1 << 3, }; struct ufs_mtk_crypt_cfg {
Signature · 1 line
2.18.0
Martin K. Petersen
AppliedStanley,
Quoted 2 lines
This series allow vendors to keep the regulator always-on, and provide an implementation on MediaTek UFS platforms.
Applied to 5.11/scsi-staging, thanks!
Signature · 6 lines
Martin K. Petersen Oracle Linux Engineering _______________________________________________ Linux-mediatek mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-mediatek