Skip to contentSkip to conversation

ALSA: hda/ca0132 - Fix AE-5 rear headphone pincfg.

PATCH Superseded Connor McAdams 2 participants 6 messages Dec 7, 2020 – Dec 10, 2020 Sound

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/3 ALSA: hda/ca0132 - Fix AE-5 rear headphone pincfg.

The Windows driver sets the pincfg for the AE-5's rear-headphone to report as a microphone. This causes issues with Pulseaudio mistakenly believing there is no headphone plugged in. In Linux, we should instead set it to be a headphone.

---
 sound/pci/hda/patch_ca0132.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
sound/pci/hda/patch_ca0132.c +1 -1
index 4fbec4258f58..e96db73c32f5 100644
@@ -1223,7 +1223,7 @@ static const struct hda_pintbl ae5_pincfgs[] = {
 	{ 0x0e, 0x01c510f0 }, /* SPDIF In */
 	{ 0x0f, 0x01017114 }, /* Port A -- Rear L/R. */
 	{ 0x10, 0x01017012 }, /* Port D -- Center/LFE or FP Hp */
-	{ 0x11, 0x01a170ff }, /* Port B -- LineMicIn2 / Rear Headphone */
+	{ 0x11, 0x012170ff }, /* Port B -- LineMicIn2 / Rear Headphone */
 	{ 0x12, 0x01a170f0 }, /* Port C -- LineIn1 */
 	{ 0x13, 0x908700f0 }, /* What U Hear In*/
 	{ 0x18, 0x50d000f0 }, /* N/A */
Signature · 1 line
2.25.1
#1 lore raw

PATCH 2/3 ALSA: hda/ca0132 - Change Input Source enum strings.

Change the Input Source enumerated control's strings to make it play nice with pulseaudio.

---
 sound/pci/hda/patch_ca0132.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
sound/pci/hda/patch_ca0132.c +1 -1
index e96db73c32f5..793dc5d501a5 100644
@@ -95,7 +95,7 @@ enum {
 };
 
 /* Strings for Input Source Enum Control */
-static const char *const in_src_str[3] = {"Rear Mic", "Line", "Front Mic" };
+static const char *const in_src_str[3] = { "Microphone", "Line In", "Front Microphone" };
 #define IN_SRC_NUM_OF_INPUTS 3
 enum {
 	REAR_MIC,
Signature · 1 line
2.25.1
#2 lore raw

PATCH 3/3 ALSA: hda/ca0132 - Unmute surround when speaker output is selected.

In reply to Connor McAdams

Make sure GPIO pin for surround channel mute is set to 0 when speaker output is selected.

---
 sound/pci/hda/patch_ca0132.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
sound/pci/hda/patch_ca0132.c +1 -1
index 793dc5d501a5..6d647d461eab 100644
@@ -1390,7 +1390,7 @@ static const struct ca0132_alt_out_set_quirk_data quirk_out_set_data[] = {
 		  .has_hda_gpio     = false,
 		  .mmio_gpio_count  = 3,
 		  .mmio_gpio_pin    = { 2, 3, 5 },
-		  .mmio_gpio_set    = { 1, 1, 0 },
+		  .mmio_gpio_set    = { 1, 0, 0 },
 		  .scp_cmds_count   = 0,
 		  .has_chipio_write = false,
 		},
Signature · 1 line
2.25.1
#3 lore raw

Re: [PATCH 3/3] ALSA: hda/ca0132 - Unmute surround when speaker output is selected.

Apologies, this patch seems to be a mistake.

I don't know why I thought this was the case.

Quoted 25 lines · Connor McAdams

Make sure GPIO pin for surround channel mute is set to 0 when speaker output is selected.

---
 sound/pci/hda/patch_ca0132.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
sound/pci/hda/patch_ca0132.c +1 -2
index 793dc5d501a5..6d647d461eab 100644
@@ -1390,7 +1390,7 @@ static const struct ca0132_alt_out_set_quirk_data quirk_out_set_data[] = {
                  .has_hda_gpio     = false,
                  .mmio_gpio_count  = 3,
                  .mmio_gpio_pin    = { 2, 3, 5 },
-                 .mmio_gpio_set    = { 1, 1, 0 },
+                 .mmio_gpio_set    = { 1, 0, 0 },
                  .scp_cmds_count   = 0,
                  .has_chipio_write = false,
                },
--

2.25.1

#4 lore raw
In reply to Connor McAdams
Quoted 7 lines · Connor McAdams

The Windows driver sets the pincfg for the AE-5's rear-headphone to report as a microphone. This causes issues with Pulseaudio mistakenly believing there is no headphone plugged in. In Linux, we should instead set it to be a headphone.

Those patches are relevant with your previous patches, right? If it's a fix for a specific commit, it'd be appreciated to have a "Fixes:" tag with the commit id and "Cc:" tag to stable in the patch.

thanks,

Takashi

#5 lore raw

Will do, thanks for the info.

Quoted 19 lines · Takashi Iwai
Quoted 7 lines · Connor McAdams

The Windows driver sets the pincfg for the AE-5's rear-headphone to report as a microphone. This causes issues with Pulseaudio mistakenly believing there is no headphone plugged in. In Linux, we should instead set it to be a headphone.

Those patches are relevant with your previous patches, right? If it's a fix for a specific commit, it'd be appreciated to have a "Fixes:" tag with the commit id and "Cc:" tag to stable in the patch.

thanks,

Takashi