target/arm: various changes to cpu.h
cover target/arm: various changes to cpu.h
First, fix a typo in ID_AA64PFR1 (SBSS -> SSBS).
Second, turn clidr in the ARMCPU struct 64-bit, to support all fields defined by the ARM ARM.
Third, add field definitions for CLIDR (excepting the Ttype<n> fields, since I was unsure of prefererred naming - Ttype7-Ttype1?).
Fourth add all ID_AA64 registers/fields present in ARM DDI 0487F.c,
Lastly, add all ID_ (aarch32) registers/fields.
Some of the ID_AA64 fields will be used by some patches Rebecca Cran will be submitting shortly, and some of those features also exist for aarch32.
Leif Lindholm (5):
target/arm: fix typo in cpu.h ID_AA64PFR1 field name target/arm: make ARMCPU.clidr 64-bit
target/arm: add descriptions of CLIDR_EL1, CCSIDR_EL1, CTR_EL0 to
cpu.h
target/arm: add aarch64 ID register fields to cpu.h target/arm: add aarch32 ID register fields to cpu.h
target/arm/cpu.h | 80 ++++++++++++++++++++++++++++++++++++++++++++++-- 1 file changed, 78 insertions(+), 2 deletions(-)
Signature · 1 line
2.20.1
PATCH 1/5 target/arm: fix typo in cpu.h ID_AA64PFR1 field name
SBSS -> SSBS
--- target/arm/cpu.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
target/arm/cpu.h +1 -1
@@ -1851,7 +1851,7 @@ FIELD(ID_AA64PFR0, RAS, 28, 4) FIELD(ID_AA64PFR0, SVE, 32, 4) FIELD(ID_AA64PFR1, BT, 0, 4) -FIELD(ID_AA64PFR1, SBSS, 4, 4) +FIELD(ID_AA64PFR1, SSBS, 4, 4) FIELD(ID_AA64PFR1, MTE, 8, 4)FIELD (ID_AA64PFR1 ,RAS_FRAC ,12 ,4 )
Signature · 1 line
2.20.1
Re: [PATCH 1/5] target/arm: fix typo in cpu.h ID_AA64PFR1 field name
Quoted 1 line · Leif Lindholm
SBSS -> SSBS
For Speculative Store Bypassing State.
Quoted 5 lines
Signed-off-by Leif Lindholm <[email protected]>--- target/arm/cpu.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Re: [PATCH 1/5] target/arm: fix typo in cpu.h ID_AA64PFR1 field name
In reply to Leif LindholmQuoted 4 lines · Leif Lindholm
SBSS -> SSBS
Signed-off-by Leif Lindholm <[email protected]>
thanks
-- PMM
PATCH 2/5 target/arm: make ARMCPU.clidr 64-bit
In reply to Leif LindholmThe AArch64 view of CLIDR_EL1 extends the ICB field to include also bit 32, as well as adding a Ttype<n> field when FEAT_MTE is implemented. Extend the clidr field to be able to hold this context.
--- target/arm/cpu.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
target/arm/cpu.h +1 -1
@@ -938,7 +938,7 @@ struct ARMCPU {uint32_t id_afr0;uint64_t id_aa64afr0;uint64_t id_aa64afr1; -uint32_t clidr; +uint64_t clidr;uint64_t mp_affinity;/* MP ID without feature bits */ /* The elements of this array are the CCSIDR values for each cache, * in the order L1DCache, L1ICache, L2DCache, L2ICache, etc.
Signature · 1 line
2.20.1
Re: [PATCH 2/5] target/arm: make ARMCPU.clidr 64-bit
Quoted 8 lines · Leif Lindholm
The AArch64 view of
CLIDR_EL1extends the ICB field to include also bit 32, as well as adding a Ttype<n> field whenFEAT_MTEis implemented. Extend the clidr field to be able to hold this context.Signed-off-by Leif Lindholm <[email protected]>--- target/arm/cpu.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Re: [PATCH 2/5] target/arm: make ARMCPU.clidr 64-bit
In reply to Leif LindholmQuoted 6 lines · Leif Lindholm
The AArch64 view of
CLIDR_EL1extends the ICB field to include also bit 32, as well as adding a Ttype<n> field whenFEAT_MTEis implemented. Extend the clidr field to be able to hold this context.Signed-off-by Leif Lindholm <[email protected]>
(checked that none of the uses of this field are implicitly assuming it's 32-bits.)
thanks
-- PMM
PATCH 3/5 target/arm: add descriptions of CLIDR_EL1, CCSIDR_EL1, CTR_EL0 to cpu.h
In reply to Leif Lindholm--- target/arm/cpu.h | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+)
target/arm/cpu.h +24 -0
@@ -1713,6 +1713,30 @@ FIELD(V7M_FPCCR, ASPEN, 31, 1)/* * System register ID fields. */ +FIELD(CLIDR_EL1, CTYPE1, 0, 3) +FIELD(CLIDR_EL1, CTYPE2, 3, 3) +FIELD(CLIDR_EL1, CTYPE3, 6, 3) +FIELD(CLIDR_EL1, CTYPE4, 9, 3) +FIELD(CLIDR_EL1, CTYPE5, 12, 3) +FIELD(CLIDR_EL1, CTYPE6, 15, 3) +FIELD(CLIDR_EL1, CTYPE7, 18, 3) +FIELD(CLIDR_EL1, LOUIS, 21, 3) +FIELD(CLIDR_EL1, LOC, 24, 3) +FIELD(CLIDR_EL1, LOUU, 27, 3) +FIELD(CLIDR_EL1, ICB, 30, 3) + +FIELD(CCSIDR_EL1, LINESIZE, 0, 3) +FIELD(CCSIDR_EL1, ASSOCIATIVITY, 3, 20) +FIELD(CCSIDR_EL1, NUMSETS, 32, 23) + +FIELD(CTR_EL0, IMINLINE, 0, 4) +FIELD(CTR_EL0, L1IP, 14, 2) +FIELD(CTR_EL0, DMINLINE, 16, 4) +FIELD(CTR_EL0, ERG, 20, 4) +FIELD(CTR_EL0, CWG, 24, 4) +FIELD(CTR_EL0, IDC, 28, 1) +FIELD(CTR_EL0, DIC, 29, 1) + FIELD(MIDR_EL1, REVISION, 0, 4) FIELD(MIDR_EL1, PARTNUM, 4, 12)FIELD (MIDR_EL1 ,ARCHITECTURE ,16 ,4 )
Signature · 1 line
2.20.1
Re: [PATCH 3/5] target/arm: add descriptions of CLIDR_EL1, CCSIDR_EL1, CTR_EL0 to cpu.h
Quoted 18 lines · Leif Lindholm
Signed-off-by Leif Lindholm <[email protected]>--- target/arm/cpu.h | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+)target/arm/cpu.h +4
-0@@ -1713,6 +1713,30 @@ FIELD(V7M_FPCCR, ASPEN, 31, 1)/* * System register ID fields. */ +FIELD(CLIDR_EL1, CTYPE1, 0, 3) +FIELD(CLIDR_EL1, CTYPE2, 3, 3) +FIELD(CLIDR_EL1, CTYPE3, 6, 3) +FIELD (CLIDR_EL1 ,CTYPE4 ,9 ,3 )
target/arm/cpu.h FIELD(V7M_FPCCR, ASPEN, 31, 1) · line 1729
Quoted 10 lines
target/arm/cpu.h +10
-0+FIELD(CLIDR_EL1, CTYPE5, 12, 3) +FIELD(CLIDR_EL1, CTYPE6, 15, 3) +FIELD(CLIDR_EL1, CTYPE7, 18, 3) +FIELD(CLIDR_EL1, LOUIS, 21, 3) +FIELD(CLIDR_EL1, LOC, 24, 3) +FIELD(CLIDR_EL1, LOUU, 27, 3) +FIELD(CLIDR_EL1, ICB, 30, 3) + +FIELD(CCSIDR_EL1, LINESIZE, 0, 3) +FIELD (CCSIDR_EL1 ,ASSOCIATIVITY ,3 ,20 )
The ASSOCIATIVITY field is bits [23:3], so it's 21 bits long, not 20, right ?
target/arm/cpu.h FIELD(V7M_FPCCR, ASPEN, 31, 1) · line 1730
Quoted 1 line
target/arm/cpu.h +1
-0+FIELD (CCSIDR_EL1 ,NUMSETS ,32 ,23 )
Similarly, NUMSETS is [55:32] so 24 bits long.
target/arm/cpu.h FIELD(V7M_FPCCR, ASPEN, 31, 1) · line 1742
Quoted 12 lines
target/arm/cpu.h +9
-0+ +FIELD(CTR_EL0, IMINLINE, 0, 4) +FIELD(CTR_EL0, L1IP, 14, 2) +FIELD(CTR_EL0, DMINLINE, 16, 4) +FIELD(CTR_EL0, ERG, 20, 4) +FIELD(CTR_EL0, CWG, 24, 4) +FIELD(CTR_EL0, IDC, 28, 1) +FIELD(CTR_EL0, DIC, 29, 1) + FIELD(MIDR_EL1, REVISION, 0, 4) FIELD(MIDR_EL1, PARTNUM, 4, 12)FIELD (MIDR_EL1 ,ARCHITECTURE ,16 ,4 )
Any reason not to define the other fields here? FIELD(MIDR_EL1, VARIANT, 20, 4) FIELD(MIDR_EL1, IMPLEMENTER, 24, 8)
Otherwise
thanks
-- PMM
Re: [PATCH 3/5] target/arm: add descriptions of CLIDR_EL1, CCSIDR_EL1, CTR_EL0 to cpu.h
Quoted 24 lines · Peter Maydell
Quoted 23 lines · Leif Lindholm
Signed-off-by Leif Lindholm <[email protected]>--- target/arm/cpu.h | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+)target/arm/cpu.h +9
-0@@ -1713,6 +1713,30 @@ FIELD(V7M_FPCCR, ASPEN, 31, 1)/* * System register ID fields. */ +FIELD(CLIDR_EL1, CTYPE1, 0, 3) +FIELD(CLIDR_EL1, CTYPE2, 3, 3) +FIELD(CLIDR_EL1, CTYPE3, 6, 3) +FIELD(CLIDR_EL1, CTYPE4, 9, 3) +FIELD(CLIDR_EL1, CTYPE5, 12, 3) +FIELD(CLIDR_EL1, CTYPE6, 15, 3) +FIELD(CLIDR_EL1, CTYPE7, 18, 3) +FIELD(CLIDR_EL1, LOUIS, 21, 3) +FIELD (CLIDR_EL1 ,LOC ,24 ,3 )
Quoted 8 lines
target/arm/cpu.h FIELD(V7M_FPCCR, ASPEN, 31, 1) · line 1729
Quoted 5 lines
target/arm/cpu.h +5
-0+FIELD(CLIDR_EL1, LOUU, 27, 3) +FIELD(CLIDR_EL1, ICB, 30, 3) + +FIELD(CCSIDR_EL1, LINESIZE, 0, 3) +FIELD (CCSIDR_EL1 ,ASSOCIATIVITY ,3 ,20 )The ASSOCIATIVITY field is bits [23:3], so it's 21 bits long, not 20, right ?
Err, indeed.
Quoted 3 lines
target/arm/cpu.h FIELD(V7M_FPCCR, ASPEN, 31, 1) · line 1730
Quoted 1 line
target/arm/cpu.h +1
-0+FIELD (CCSIDR_EL1 ,NUMSETS ,32 ,23 )Similarly, NUMSETS is [55:32] so 24 bits long.
Sorry, brain must have taken holiday.
Would you like a v2 of this patch, fixing those?
Quoted 8 lines
Quoted 8 lines
target/arm/cpu.h +8
-0+ +FIELD(CTR_EL0, IMINLINE, 0, 4) +FIELD(CTR_EL0, L1IP, 14, 2) +FIELD(CTR_EL0, DMINLINE, 16, 4) +FIELD(CTR_EL0, ERG, 20, 4) +FIELD(CTR_EL0, CWG, 24, 4) +FIELD(CTR_EL0, IDC, 28, 1) +FIELD (CTR_EL0 ,DIC ,29 ,1 )
Quoted 8 lines
target/arm/cpu.h FIELD(V7M_FPCCR, ASPEN, 31, 1) · line 1742
Quoted 4 lines
target/arm/cpu.h +1
-0+ FIELD(MIDR_EL1, REVISION, 0, 4) FIELD(MIDR_EL1, PARTNUM, 4, 12)FIELD (MIDR_EL1 ,ARCHITECTURE ,16 ,4 )Any reason not to define the other fields here?
FIELD(MIDR_EL1, VARIANT, 20, 4)FIELD(MIDR_EL1, IMPLEMENTER, 24, 8)
Those are just context, not added by this patch. (Glad to see I'm not the only one making that mistake...)
Best Regards,
Leif
Quoted 5 lines
Otherwise
Reviewed-by Peter Maydell <[email protected]>thanks
-- PMM
Re: [PATCH 3/5] target/arm: add descriptions of CLIDR_EL1, CCSIDR_EL1, CTR_EL0 to cpu.h
Quoted 13 lines · Leif Lindholm
Quoted 8 lines · Peter Maydell
Quoted 4 lines · Leif Lindholm
Signed-off-by Leif Lindholm <[email protected]>+FIELD(CCSIDR_EL1, ASSOCIATIVITY, 3, 20)
The ASSOCIATIVITY field is bits [23:3], so it's 21 bits long, not 20, right ?
Err, indeed.
Quoted 7 lines
Quoted 3 lines
Quoted 1 line
+FIELD(CCSIDR_EL1, NUMSETS, 32, 23)
Similarly, NUMSETS is [55:32] so 24 bits long.
Sorry, brain must have taken holiday.
Would you like a v2 of this patch, fixing those?
Yes please.
Quoted 17 lines
Quoted 8 lines
Quoted 8 lines
target/arm/cpu.h +8
-0+ +FIELD(CTR_EL0, IMINLINE, 0, 4) +FIELD(CTR_EL0, L1IP, 14, 2) +FIELD(CTR_EL0, DMINLINE, 16, 4) +FIELD(CTR_EL0, ERG, 20, 4) +FIELD(CTR_EL0, CWG, 24, 4) +FIELD(CTR_EL0, IDC, 28, 1) +FIELD (CTR_EL0 ,DIC ,29 ,1 )Quoted 8 lines
Quoted 4 lines
+
FIELD(MIDR_EL1, REVISION, 0, 4)
FIELD(MIDR_EL1, PARTNUM, 4, 12)
FIELD(MIDR_EL1, ARCHITECTURE, 16, 4)Any reason not to define the other fields here?
FIELD(MIDR_EL1, VARIANT, 20, 4)FIELD(MIDR_EL1, IMPLEMENTER, 24, 8)
Quoted 2 lines
Those are just context, not added by this patch. (Glad to see I'm not the only one making that mistake...)
Doh!
thanks
-- PMM
PATCH 4/5 target/arm: add aarch64 ID register fields to cpu.h
In reply to Leif LindholmAdd entries present in ARM DDI 0487F.c (August 2020).
--- target/arm/cpu.h | 15 +++++++++++++++ 1 file changed, 15 insertions(+)
target/arm/cpu.h +15 -0
@@ -1863,6 +1863,9 @@ FIELD(ID_AA64ISAR1, GPI, 28, 4) FIELD(ID_AA64ISAR1, FRINTTS, 32, 4) FIELD(ID_AA64ISAR1, SB, 36, 4) FIELD(ID_AA64ISAR1, SPECRES, 40, 4) +FIELD(ID_AA64ISAR1, BF16, 44, 4) +FIELD(ID_AA64ISAR1, DGH, 48, 4) +FIELD(ID_AA64ISAR1, I8MM, 52, 4) FIELD(ID_AA64PFR0, EL0, 0, 4)FIELD (ID_AA64PFR0 ,EL1 ,4 ,4 )
@@ -1873,11 +1876,18 @@ FIELD(ID_AA64PFR0, ADVSIMD, 20, 4) FIELD(ID_AA64PFR0, GIC, 24, 4) FIELD(ID_AA64PFR0, RAS, 28, 4) FIELD(ID_AA64PFR0, SVE, 32, 4) +FIELD(ID_AA64PFR0, SEL2, 36, 4) +FIELD(ID_AA64PFR0, MPAM, 40, 4) +FIELD(ID_AA64PFR0, AMU, 44, 4) +FIELD(ID_AA64PFR0, DIT, 48, 4) +FIELD(ID_AA64PFR0, CSV2, 56, 4) +FIELD(ID_AA64PFR0, CSV3, 60, 4) FIELD(ID_AA64PFR1, BT, 0, 4) FIELD(ID_AA64PFR1, SSBS, 4, 4) FIELD(ID_AA64PFR1, MTE, 8, 4) FIELD(ID_AA64PFR1, RAS_FRAC, 12, 4) +FIELD(ID_AA64PFR1, MPAM_FRAC, 16, 4) FIELD(ID_AA64MMFR0, PARANGE, 0, 4)FIELD (ID_AA64MMFR0 ,ASIDBITS ,4 ,4 )
@@ -1891,6 +1901,8 @@ FIELD(ID_AA64MMFR0, TGRAN16_2, 32, 4) FIELD(ID_AA64MMFR0, TGRAN64_2, 36, 4) FIELD(ID_AA64MMFR0, TGRAN4_2, 40, 4) FIELD(ID_AA64MMFR0, EXS, 44, 4) +FIELD(ID_AA64MMFR0, FGT, 56, 4) +FIELD(ID_AA64MMFR0, ECV, 60, 4) FIELD(ID_AA64MMFR1, HAFDBS, 0, 4)FIELD (ID_AA64MMFR1 ,VMIDBITS ,4 ,4 )
@@ -1900,6 +1912,8 @@ FIELD(ID_AA64MMFR1, LO, 16, 4) FIELD(ID_AA64MMFR1, PAN, 20, 4) FIELD(ID_AA64MMFR1, SPECSEI, 24, 4) FIELD(ID_AA64MMFR1, XNX, 28, 4) +FIELD(ID_AA64MMFR1, TWED, 32, 4) +FIELD(ID_AA64MMFR1, ETS, 36, 4) FIELD(ID_AA64MMFR2, CNP, 0, 4)FIELD (ID_AA64MMFR2 ,UAO ,4 ,4 )
@@ -1926,6 +1940,7 @@ FIELD(ID_AA64DFR0, CTX_CMPS, 28, 4) FIELD(ID_AA64DFR0, PMSVER, 32, 4) FIELD(ID_AA64DFR0, DOUBLELOCK, 36, 4) FIELD(ID_AA64DFR0, TRACEFILT, 40, 4) +FIELD(ID_AA64DFR0, MTPMU, 48, 4) FIELD(ID_DFR0, COPDBG, 0, 4)FIELD (ID_DFR0 ,COPSDBG ,4 ,4 )
Signature · 1 line
2.20.1
Re: [PATCH 4/5] target/arm: add aarch64 ID register fields to cpu.h
Quoted 4 lines · Leif Lindholm
Add entries present in ARM DDI
0487F.c(August 2020).Signed-off-by Leif Lindholm <[email protected]>
thanks
-- PMM
PATCH 5/5 target/arm: add aarch32 ID register fields to cpu.h
In reply to Leif LindholmAdd entries present in ARM DDI 0487F.c (August 2020).
--- target/arm/cpu.h | 37 +++++++++++++++++++++++++++++++++++++ 1 file changed, 37 insertions(+)
target/arm/cpu.h +37 -0
@@ -1800,6 +1800,8 @@ FIELD(ID_ISAR6, DP, 4, 4) FIELD(ID_ISAR6, FHM, 8, 4) FIELD(ID_ISAR6, SB, 12, 4) FIELD(ID_ISAR6, SPECRES, 16, 4) +FIELD(ID_ISAR6, BF16, 20, 4) +FIELD(ID_ISAR6, I8MM, 24, 4) FIELD(ID_MMFR0, VMSA, 0, 4)FIELD (ID_MMFR0 ,PMSA ,4 ,4 )
@@ -1810,6 +1812,24 @@ FIELD(ID_MMFR0, AUXREG, 20, 4) FIELD(ID_MMFR0, FCSE, 24, 4) FIELD(ID_MMFR0, INNERSHR, 28, 4) +FIELD(ID_MMFR1, L1HVDVA, 0, 4) +FIELD(ID_MMFR1, L1UNIVA, 4, 4) +FIELD(ID_MMFR1, L1HVDSW, 8, 4) +FIELD(ID_MMFR1, L1UNISW, 12, 4) +FIELD(ID_MMFR1, L1HVD, 16, 4) +FIELD(ID_MMFR1, L1UNI, 20, 4) +FIELD(ID_MMFR1, L1TSTCLN, 24, 4) +FIELD(ID_MMFR1, BPRED, 28, 4) + +FIELD(ID_MMFR2, L1HVDFG, 0, 4) +FIELD(ID_MMFR2, L1HVDBG, 4, 4) +FIELD(ID_MMFR2, L1HVDRNG, 8, 4) +FIELD(ID_MMFR2, HVDTLB, 12, 4) +FIELD(ID_MMFR2, UNITLB, 16, 4) +FIELD(ID_MMFR2, MEMBARR, 20, 4) +FIELD(ID_MMFR2, WFISTALL, 24, 4) +FIELD(ID_MMFR2, HWACCFLG, 28, 4) + FIELD(ID_MMFR3, CMAINTVA, 0, 4) FIELD(ID_MMFR3, CMAINTSW, 4, 4)FIELD (ID_MMFR3 ,BPMAINT ,8 ,4 )
@@ -1828,6 +1848,17 @@ FIELD(ID_MMFR4, LSM, 20, 4) FIELD(ID_MMFR4, CCIDX, 24, 4) FIELD(ID_MMFR4, EVT, 28, 4) +FIELD(ID_MMFR5, ETS, 0, 4) + +FIELD(ID_PFR0, STATE0, 0, 4) +FIELD(ID_PFR0, STATE1, 4, 4) +FIELD(ID_PFR0, STATE2, 8, 4) +FIELD(ID_PFR0, STATE3, 12, 4) +FIELD(ID_PFR0, CSV2, 16, 4) +FIELD(ID_PFR0, AMU, 20, 4) +FIELD(ID_PFR0, DIT, 24, 4) +FIELD(ID_PFR0, RAS, 28, 4) + FIELD(ID_PFR1, PROGMOD, 0, 4) FIELD(ID_PFR1, SECURITY, 4, 4)FIELD (ID_PFR1 ,MPROGMOD ,8 ,4 )
@@ -1837,6 +1868,10 @@ FIELD(ID_PFR1, SEC_FRAC, 20, 4) FIELD(ID_PFR1, VIRT_FRAC, 24, 4) FIELD(ID_PFR1, GIC, 28, 4) +FIELD(ID_PFR2, CSV3, 0, 4) +FIELD(ID_PFR2, SSBS, 4, 4) +FIELD(ID_PFR2, RAS_FRAC, 8, 4) + FIELD(ID_AA64ISAR0, AES, 4, 4) FIELD(ID_AA64ISAR0, SHA1, 8, 4)FIELD (ID_AA64ISAR0 ,SHA2 ,12 ,4 )
@@ -1951,6 +1986,8 @@ FIELD(ID_DFR0, MPROFDBG, 20, 4) FIELD(ID_DFR0, PERFMON, 24, 4) FIELD(ID_DFR0, TRACEFILT, 28, 4) +FIELD(ID_DFR1, MTPMU, 0, 4) + FIELD(DBGDIDR, SE_IMP, 12, 1) FIELD(DBGDIDR, NSUHD_IMP, 14, 1)FIELD (DBGDIDR ,VERSION ,16 ,4 )
Signature · 1 line
2.20.1
Re: [PATCH 5/5] target/arm: add aarch32 ID register fields to cpu.h
Quoted 11 lines · Leif Lindholm
Add entries present in ARM DDI
0487F.c(August 2020).Signed-off-by Leif Lindholm <[email protected]>--- target/arm/cpu.h | 37 +++++++++++++++++++++++++++++++++++++ 1 file changed, 37 insertions(+)
FIELD(ID_MMFR4, CCIDX, 24, 4)
FIELD(ID_MMFR4, EVT, 28, 4)
target/arm/cpu.h FIELD(ID_MMFR4, LSM, 20, 4) · line 1860
Quoted 10 lines
target/arm/cpu.h +10
-0+FIELD(ID_MMFR5, ETS, 0, 4) + +FIELD(ID_PFR0, STATE0, 0, 4) +FIELD(ID_PFR0, STATE1, 4, 4) +FIELD(ID_PFR0, STATE2, 8, 4) +FIELD(ID_PFR0, STATE3, 12, 4) +FIELD(ID_PFR0, CSV2, 16, 4) +FIELD(ID_PFR0, AMU, 20, 4) +FIELD(ID_PFR0, DIT, 24, 4) +FIELD (ID_PFR0 ,RAS ,28 ,4 )
The ID_PFR0 definitions are already in master now
commit 46f4976f22a45 has gone in.
Otherwise
thanks
-- PMM