mm/madvise: remove racy mm ownership check
Subsystems (2)
PATCH 1/1 mm/madvise: remove racy mm ownership check
Jann spotted the security hole due to race of mm ownership check. If the task is sharing the mm_struct but goes through execve() before mm_access(), it could skip process_madvise_behavior_valid check. That makes *any advice hint* to reach into the remote process.
This patch removes the mm ownership check. With it, it will lose the ability that local process could give *any* advice hint with vector interface for some reason(e.g., performance). Since there is no concrete example in upstream yet, it would be better to remove the abiliity at this moment and need to review when such new advice comes up.
--- mm/madvise.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
mm/madvise.c +1 -2
@@ -1204,8 +1204,7 @@ SYSCALL_DEFINE5(process_madvise, int, pidfd, const struct iovec __user *, vec, goto put_pid; } -if (task->mm != current->mm && - !process_madvise_behavior_valid (behavior)) { +if (!process_madvise_behavior_valid (behavior)) { ret = -EINVAL ; goto release_task; }
Signature · 1 line
2.29.2.576.ga3fc446d84-goog
Quoted 7 lines · Minchan Kim
Jann spotted the security hole due to race of mm ownership check. If the task is sharing the
mm_structbut goes throughexecve()beforemm_access(), it could skipprocess_madvise_behavior_validcheck. That makes *any advice hint* to reach into the remote process.This patch removes the mm ownership check.
Applied directly - I'm not sure Andrew has anything else pending, so might as well short-circuit it.
Linus