net/mlx5:fix storing the synced MAC to internal table

During the mlx5_dev_spawn(), it tries to sync the MAC address of the Device to the internal MAC table. In case of SR-IOV VF , the mlx5_nl_mac_addr_sync() gets, 2 MAC address in the fresh start. One the unicast MAC assigned to the VF on the host and the second the multicast mac of 33:33:00:00:00:01. Currently without check the type of MAC we try to add the MAC 33:33:00:00:00:01 to the first free place in the MAC table which will be mostly index 1, as index 0 stores the unicast MAC assigned to the VF. This causes issues subsequently when we try to add multicast address list. As every IPv6 IP generates differnet multicast MAC, to support multiple IP on a single interface, we need to add a list of multicast MAC. As an example, if we try to add 3 multicast MAC as mentioned below
mcast addr 0 - 33:33:00:00:00:01
mcast addr 1 - 01:00:5e:00:00:01
mcast addr 2 - 33:33:ff:68:fe:7d
then, the addition of these MAC will fail with error -EADDRINUSE in mlx5_internal_mac_addr_add(), and none of the MAC address will be added to the device, which will lead of packet drop in case multicast promiscuous is not enable.
To make this work, we should store the synced MAC to the proper section of the internal table, after checking the type of the MAC synced. This check will make the MAC of 33:33:00:00:00:01(synced MAC) to be stored at index 128(starting of MLX5_MAX_MC_MAC_ADDRESSES), which will be removed and added again during the mlx5_set_mc_addr_list(). This will make sure that all the multicast MACs are added properly to both the internal table and also the device, specially in case of SR-IOV VF.

Souvik Dey (1):
net/mlx5:fix storing the synced MAC to internal table

 drivers/common/mlx5/linux/mlx5_nl.c | 20 +++++++++++++++-----
 1 file changed, 15 insertions(+), 5 deletions(-)

2.9.3.windows.1

As the internal MAC table is divided into Unicast and Multicast address section, we should check the type of synced MAC address before storing it to the internal table. Currently the check is not done, and the synced MAC of 33:33:00:00:00:01 gets stored in the unicast section (mostly index 1) which causes all subsequent mlx5_set_mc_addr_list() to fail with error -EADDRINUSE, as the mac_list conatins the MAC 33:33:00:00:00:01. This denies adding of any new multicast address to the internal list and also fails to add the MAC address to the device in case of SR-IOV VF case.

---
 drivers/common/mlx5/linux/mlx5_nl.c | 20 +++++++++++++++-----
 1 file changed, 15 insertions(+), 5 deletions(-)

index 40d8620..da56add 100644
@@ -758,11 +758,21 @@ mlx5_nl_mac_addr_sync(int nlsk_fd, unsigned int iface_idx,
 				break;
 		if (j != n)
 			continue;
-		/* Find the first entry available. */
-		for (j = 0; j != n; ++j) {
-			if (rte_is_zero_ether_addr(&mac_addrs[j])) {
-				mac_addrs[j] = macs[i];
-				break;
+		if (is_multicast_ether_addr(&macs[i])) {
+			/* Find the first entry available. */
+			for (j = MLX5_MAX_UC_MAC_ADDRESSES; j != n; ++j) {
+				if (rte_is_zero_ether_addr(&mac_addrs[j])) {
+					mac_addrs[j] = macs[i];
+					break;
+				}
+			}
+		} else {
+			/* Find the first entry available. */
+			for (j = 0; j != MLX5_MAX_UC_MAC_ADDRESSES; ++j) {
+				if (rte_is_zero_ether_addr(&mac_addrs[j])) {
+					mac_addrs[j] = macs[i];
+					break;
+				}
 			}
 		}
 	}

2.9.3.windows.1