ALSA: hda: Fix regressions on clear and reconfig sysfs
PATCH 1/1 ALSA: hda: Fix regressions on clear and reconfig sysfs
It seems that the HD-audio clear and reconfig sysfs don't work any longer after the recent driver core change. There are multiple issues around that: the linked list corruption and the dead device handling. The former issue is fixed by another patch for the driver core itself, while the latter patch needs to be addressed in HD-audio side.
This patch corresponds to the latter, it recovers those broken functions by replacing the device detach and attach actions with the standard core API functions, which are almost equivalent with unbind and bind actions.
Fixes 654888327e9f ("driver core: Avoid binding drivers to dead devices")
Cc <[email protected]>
Signed-off-by Takashi Iwai <[email protected]>
--- sound/pci/hda/hda_codec.c | 2 +- sound/pci/hda/hda_sysfs.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
sound/pci/hda/hda_codec.c +1 -1
@@ -1803,7 +1803,7 @@ int snd_hda_codec_reset(struct hda_codec *codec)return -EBUSY ;/* OK, let it free */ -snd_hdac_device_unregister (&codec->core); +device_release_driver (hda_codec_dev (codec));/* allow device access again */ snd_hda_unlock_devices (bus);
sound/pci/hda/hda_sysfs.c +1 -1
@@ -139,7 +139,7 @@ static int reconfig_codec(struct hda_codec *codec) "The codec is being used, can't reconfigure.\n"); goto error; } - err =snd_hda_codec_configure (codec); + err =device_reprobe (hda_codec_dev (codec));if (err <0 ) goto error; err =snd_card_register (codec->card);
Signature · 1 line
2.26.2