ARM: dts: exynos: correct PMIC interrupt trigger level on Artik 5
Subsystems (4)
Krzysztof Kozlowski
maintainerPATCH 1/9 ARM: dts: exynos: correct PMIC interrupt trigger level on Artik 5
The Samsung PMIC datasheets describe the interrupt line as active low with a requirement of acknowledge from the CPU. Without specifying the interrupt type in Devicetree, kernel might apply some fixed configuration, not necessarily working for this hardware.
--- arch/arm/boot/dts/exynos3250-artik5.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/exynos3250-artik5.dtsi +1 -1
@@ -79,7 +79,7 @@ &i2c_0 { pmic@66 { compatible = "samsung,s2mps14-pmic"; interrupt-parent = <&gpx3>; - interrupts = <5 IRQ_TYPE_NONE>; + interrupts = <5 IRQ_TYPE_LEVEL_LOW>; pinctrl-names = "default"; pinctrl-0 = <&s2mps14_irq>; reg = <0x66>;
Signature · 1 line
2.25.1
Krzysztof Kozlowski
maintainerPATCH 2/9 ARM: dts: exynos: correct PMIC interrupt trigger level on Monk
The Samsung PMIC datasheets describe the interrupt line as active low with a requirement of acknowledge from the CPU. Without specifying the interrupt type in Devicetree, kernel might apply some fixed configuration, not necessarily working for this hardware.
--- arch/arm/boot/dts/exynos3250-monk.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/exynos3250-monk.dts +1 -1
@@ -200,7 +200,7 @@ &i2c_0 { pmic@66 { compatible = "samsung,s2mps14-pmic"; interrupt-parent = <&gpx0>; - interrupts = <7 IRQ_TYPE_NONE>; + interrupts = <7 IRQ_TYPE_LEVEL_LOW>; reg = <0x66>; wakeup-source;
Signature · 1 line
2.25.1
Krzysztof Kozlowski
maintainerPATCH 3/9 ARM: dts: exynos: correct PMIC interrupt trigger level on Rinato
In reply to Krzysztof KozlowskiThe Samsung PMIC datasheets describe the interrupt line as active low with a requirement of acknowledge from the CPU. Without specifying the interrupt type in Devicetree, kernel might apply some fixed configuration, not necessarily working for this hardware.
--- arch/arm/boot/dts/exynos3250-rinato.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/exynos3250-rinato.dts +1 -1
@@ -270,7 +270,7 @@ &i2c_0 { pmic@66 { compatible = "samsung,s2mps14-pmic"; interrupt-parent = <&gpx0>; - interrupts = <7 IRQ_TYPE_NONE>; + interrupts = <7 IRQ_TYPE_LEVEL_LOW>; reg = <0x66>; wakeup-source;
Signature · 7 lines
2.25.1 _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Re: [PATCH 3/9] ARM: dts: exynos: correct PMIC interrupt trigger level on Rinato
Quoted 9 lines · Krzysztof Kozlowski
The Samsung PMIC datasheets describe the interrupt line as active low with a requirement of acknowledge from the CPU. Without specifying the interrupt type in Devicetree, kernel might apply some fixed configuration, not necessarily working for this hardware.
Fixes faaf348ef468 ("ARM: dts: Add board dts file for exynos3250-rinato")Signed-off-by Krzysztof Kozlowski <[email protected]>--- arch/arm/boot/dts/exynos3250-rinato.dts | 2 +-
Quoted 7 lines
1 file changed, 1 insertion(+), 1 deletion(-)arch/arm/boot/dts/exynos3250-rinato.dts +0
-0
arch/arm/boot/dts/exynos3250-rinato.dts &i2c_0 { · line 276
Quoted 8 lines
arch/arm/boot/dts/exynos3250-rinato.dts +1
-1@@ -270,7 +270,7 @@ &i2c_0 { pmic@66 { compatible = "samsung,s2mps14-pmic"; interrupt-parent = <&gpx0>; - interrupts = <7 IRQ_TYPE_NONE>; + interrupts = <7 IRQ_TYPE_LEVEL_LOW>; reg = <0x66>; wakeup-source;
Best regards
Signature · 8 lines
Marek Szyprowski, PhD Samsung R&D Institute Poland _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Krzysztof Kozlowski
maintainerPATCH 4/9 ARM: dts: exynos: correct PMIC interrupt trigger level on Spring
In reply to Krzysztof KozlowskiThe Samsung PMIC datasheets describe the interrupt line as active low with a requirement of acknowledge from the CPU. Without specifying the interrupt type in Devicetree, kernel might apply some fixed configuration, not necessarily working for this hardware.
--- arch/arm/boot/dts/exynos5250-spring.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/exynos5250-spring.dts +1 -1
@@ -109,7 +109,7 @@ pmic@66 { compatible = "samsung,s5m8767-pmic"; reg = <0x66>; interrupt-parent = <&gpx3>; - interrupts = <2 IRQ_TYPE_NONE>; + interrupts = <2 IRQ_TYPE_LEVEL_LOW>; pinctrl-names = "default"; pinctrl-0 = <&s5m8767_irq &s5m8767_dvs &s5m8767_ds>; wakeup-source;
Signature · 7 lines
2.25.1 _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Krzysztof Kozlowski
maintainerPATCH 5/9 ARM: dts: exynos: correct PMIC interrupt trigger level on Arndale Octa
In reply to Krzysztof KozlowskiThe Samsung PMIC datasheets describe the interrupt line as active low with a requirement of acknowledge from the CPU. The falling edge interrupt will mostly work but it's not correct.
--- arch/arm/boot/dts/exynos5420-arndale-octa.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/exynos5420-arndale-octa.dts +1 -1
@@ -349,7 +349,7 @@ pmic@66 { reg = <0x66>; interrupt-parent = <&gpx3>; - interrupts = <2 IRQ_TYPE_EDGE_FALLING>; + interrupts = <2 IRQ_TYPE_LEVEL_LOW>; pinctrl-names = "default"; pinctrl-0 = <&s2mps11_irq>;
Signature · 7 lines
2.25.1 _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Re: [PATCH 5/9] ARM: dts: exynos: correct PMIC interrupt trigger level on Arndale Octa
Quoted 8 lines · Krzysztof Kozlowski
The Samsung PMIC datasheets describe the interrupt line as active low with a requirement of acknowledge from the CPU. The falling edge interrupt will mostly work but it's not correct.
Fixes 1fed2252713e ("ARM: dts: fix pinctrl for s2mps11-irq on exynos5420-arndale-octa")Signed-off-by Krzysztof Kozlowski <[email protected]>--- arch/arm/boot/dts/exynos5420-arndale-octa.dts | 2 +-
Quoted 7 lines
1 file changed, 1 insertion(+), 1 deletion(-)arch/arm/boot/dts/exynos5420-arndale-octa.dts +0
-0
arch/arm/boot/dts/exynos5420-arndale-octa.dts pmic@66 { · line 355
Quoted 8 lines
arch/arm/boot/dts/exynos5420-arndale-octa.dts +1
-1@@ -349,7 +349,7 @@ pmic@66 { reg = <0x66>; interrupt-parent = <&gpx3>; - interrupts = <2 IRQ_TYPE_EDGE_FALLING>; + interrupts = <2 IRQ_TYPE_LEVEL_LOW>; pinctrl-names = "default"; pinctrl-0 = <&s2mps11_irq>;
Best regards
Signature · 8 lines
Marek Szyprowski, PhD Samsung R&D Institute Poland _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Krzysztof Kozlowski
maintainerPATCH 6/9 ARM: dts: exynos: correct PMIC interrupt trigger level on Odroid XU3 family
In reply to Krzysztof KozlowskiThe Samsung PMIC datasheets describe the interrupt line as active low with a requirement of acknowledge from the CPU. The falling edge interrupt will mostly work but it's not correct.
--- arch/arm/boot/dts/exynos5422-odroid-core.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/exynos5422-odroid-core.dtsi +1 -1
@@ -509,7 +509,7 @@ pmic@66 { samsung,s2mps11-acokb-ground; interrupt-parent = <&gpx0>; - interrupts = <4 IRQ_TYPE_EDGE_FALLING>; + interrupts = <4 IRQ_TYPE_LEVEL_LOW>; pinctrl-names = "default"; pinctrl-0 = <&s2mps11_irq>;
Signature · 1 line
2.25.1
Re: [PATCH 6/9] ARM: dts: exynos: correct PMIC interrupt trigger level on Odroid XU3 family
Quoted 8 lines · Krzysztof Kozlowski
The Samsung PMIC datasheets describe the interrupt line as active low with a requirement of acknowledge from the CPU. The falling edge interrupt will mostly work but it's not correct.
Fixes aac4e0615341 ("ARM: dts: odroidxu3: Enable wake alarm of S2MPS11 RTC")Signed-off-by Krzysztof Kozlowski <[email protected]>--- arch/arm/boot/dts/exynos5422-odroid-core.dtsi | 2 +-
Quoted 7 lines
1 file changed, 1 insertion(+), 1 deletion(-)arch/arm/boot/dts/exynos5422-odroid-core.dtsi +0
-0
arch/arm/boot/dts/exynos5422-odroid-core.dtsi pmic@66 { · line 515
Quoted 8 lines
arch/arm/boot/dts/exynos5422-odroid-core.dtsi +1
-1@@ -509,7 +509,7 @@ pmic@66 { samsung,s2mps11-acokb-ground; interrupt-parent = <&gpx0>; - interrupts = <4 IRQ_TYPE_EDGE_FALLING>; + interrupts = <4 IRQ_TYPE_LEVEL_LOW>; pinctrl-names = "default"; pinctrl-0 = <&s2mps11_irq>;
Best regards
Signature · 8 lines
Marek Szyprowski, PhD Samsung R&D Institute Poland _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Krzysztof Kozlowski
maintainerPATCH 7/9 arm64: dts: exynos: correct PMIC interrupt trigger level on TM2
In reply to Krzysztof KozlowskiThe Samsung PMIC datasheets describe the interrupt line as active low with a requirement of acknowledge from the CPU. Without specifying the interrupt type in Devicetree, kernel might apply some fixed configuration, not necessarily working for this hardware.
--- arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi +1 -1
@@ -388,7 +388,7 @@ &hsi2c_0 { pmic@66 { compatible = "samsung,s2mps13-pmic"; interrupt-parent = <&gpa0>; - interrupts = <7 IRQ_TYPE_NONE>; + interrupts = <7 IRQ_TYPE_LEVEL_LOW>; reg = <0x66>; samsung,s2mps11-wrstbi-ground;
Signature · 1 line
2.25.1
Re: [PATCH 7/9] arm64: dts: exynos: correct PMIC interrupt trigger level on TM2
Quoted 7 lines · Krzysztof Kozlowski
The Samsung PMIC datasheets describe the interrupt line as active low with a requirement of acknowledge from the CPU. Without specifying the interrupt type in Devicetree, kernel might apply some fixed configuration, not necessarily working for this hardware.
Fixes 01e5d2352152 ("arm64: dts: exynos: Add dts file for Exynos5433-based TM2 board")Signed-off-by Krzysztof Kozlowski <[email protected]>
Quoted 9 lines
--- arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi +0
-0
arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi &hsi2c_0 { · line 394
Quoted 8 lines
arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi +1
-1@@ -388,7 +388,7 @@ &hsi2c_0 { pmic@66 { compatible = "samsung,s2mps13-pmic"; interrupt-parent = <&gpa0>; - interrupts = <7 IRQ_TYPE_NONE>; + interrupts = <7 IRQ_TYPE_LEVEL_LOW>; reg = <0x66>; samsung,s2mps11-wrstbi-ground;
Best regards
Signature · 2 lines
Marek Szyprowski, PhD Samsung R&D Institute Poland
Krzysztof Kozlowski
maintainerPATCH 8/9 arm64: dts: exynos: correct PMIC interrupt trigger level on Espresso
In reply to Krzysztof KozlowskiThe Samsung PMIC datasheets describe the interrupt line as active low with a requirement of acknowledge from the CPU. Without specifying the interrupt type in Devicetree, kernel might apply some fixed configuration, not necessarily working for this hardware.
--- arch/arm64/boot/dts/exynos/exynos7-espresso.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/exynos/exynos7-espresso.dts +1 -1
@@ -90,7 +90,7 @@ &hsi2c_4 { pmic@66 { compatible = "samsung,s2mps15-pmic"; reg = <0x66>; - interrupts = <2 IRQ_TYPE_NONE>; + interrupts = <2 IRQ_TYPE_LEVEL_LOW>; interrupt-parent = <&gpa0>; pinctrl-names = "default"; pinctrl-0 = <&pmic_irq>;
Signature · 1 line
2.25.1
Krzysztof Kozlowski
maintainerPATCH 9/9 mfd: sec-irq: Do not enforce (incorrect) interrupt trigger type
In reply to Krzysztof KozlowskiInterrupt line can be configured on different hardware in different way, even inverted. Therefore driver should not enforce specific trigger type - edge falling - but instead rely on Devicetree to configure it.
The Samsung PMIC drivers are used only on Devicetree boards.
Additionally, the PMIC datasheets describe the interrupt line as active low with a requirement of acknowledge from the CPU therefore the edge falling is not correct.
---
This patch should wait till DTS changes are merged, as it relies on proper Devicetree.
--- drivers/mfd/sec-irq.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/mfd/sec-irq.c +1 -2
@@ -480,8 +480,7 @@ int sec_irq_init(struct sec_pmic_dev *sec_pmic) } ret =devm_regmap_add_irq_chip (sec_pmic->dev, sec_pmic->regmap_pmic, - sec_pmic->irq, -IRQF_TRIGGER_FALLING |IRQF_ONESHOT , + sec_pmic->irq,IRQF_ONESHOT , sec_pmic->irq_base, sec_irq_chip, &sec_pmic->irq_data);if (ret !=0 ) {
Signature · 1 line
2.25.1
Re: [PATCH 9/9] mfd: sec-irq: Do not enforce (incorrect) interrupt trigger type
Quoted 11 lines · Krzysztof Kozlowski
Interrupt line can be configured on different hardware in different way, even inverted. Therefore driver should not enforce specific trigger type - edge falling - but instead rely on Devicetree to configure it.
The Samsung PMIC drivers are used only on Devicetree boards.
Additionally, the PMIC datasheets describe the interrupt line as active low with a requirement of acknowledge from the CPU therefore the edge falling is not correct.
Signed-off-by Krzysztof Kozlowski <[email protected]>
It looks that this together with DTS change fixes RTC alarm failure that I've observed from time to time on TM2e board!
Quoted 13 lines
---
This patch should wait till DTS changes are merged, as it relies on proper Devicetree.
--- drivers/mfd/sec-irq.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)drivers/mfd/sec-irq.c +0
-0
drivers/mfd/sec-irq.c int sec_irq_init(struct sec_pmic_dev *sec_pmic) · line 486
Quoted 9 lines
drivers/mfd/sec-irq.c +1
-2@@ -480,8 +480,7 @@ int sec_irq_init(struct sec_pmic_dev *sec_pmic) } ret =devm_regmap_add_irq_chip (sec_pmic->dev, sec_pmic->regmap_pmic, - sec_pmic->irq, -IRQF_TRIGGER_FALLING |IRQF_ONESHOT , + sec_pmic->irq,IRQF_ONESHOT , sec_pmic->irq_base, sec_irq_chip, &sec_pmic->irq_data);if (ret !=0 ) {
Best regards
Signature · 2 lines
Marek Szyprowski, PhD Samsung R&D Institute Poland
Krzysztof Kozlowski
maintainerRe: [PATCH 9/9] mfd: sec-irq: Do not enforce (incorrect) interrupt trigger type
Quoted 11 lines · Marek Szyprowski
Quoted 10 lines · Krzysztof Kozlowski
Interrupt line can be configured on different hardware in different way, even inverted. Therefore driver should not enforce specific trigger type - edge falling - but instead rely on Devicetree to configure it.
The Samsung PMIC drivers are used only on Devicetree boards.
Additionally, the PMIC datasheets describe the interrupt line as active low with a requirement of acknowledge from the CPU therefore the edge falling is not correct.
Quoted 6 lines
Quoted 1 line
Signed-off-by Krzysztof Kozlowski <[email protected]>Tested-by Marek Szyprowski <[email protected]>It looks that this together with DTS change fixes RTC alarm failure that I've observed from time to time on TM2e board!
Great! I'll add this to the commit msg.
Thanks for testing.
Best regards,
Krzysztof
Quoted 6 lines
Quoted 6 lines
---
This patch should wait till DTS changes are merged, as it relies on proper Devicetree.
---
Re: [PATCH 9/9] mfd: sec-irq: Do not enforce (incorrect) interrupt trigger type
Hi Krzysztof,
Quoted 12 lines · Krzysztof Kozlowski
Quoted 11 lines · Marek Szyprowski
Quoted 10 lines · Krzysztof Kozlowski
Interrupt line can be configured on different hardware in different way, even inverted. Therefore driver should not enforce specific trigger type - edge falling - but instead rely on Devicetree to configure it.
The Samsung PMIC drivers are used only on Devicetree boards.
Additionally, the PMIC datasheets describe the interrupt line as active low with a requirement of acknowledge from the CPU therefore the edge falling is not correct.
Quoted 8 lines
Quoted 5 lines
Quoted 1 line
Signed-off-by Krzysztof Kozlowski <[email protected]>Tested-by Marek Szyprowski <[email protected]>It looks that this together with DTS change fixes RTC alarm failure that I've observed from time to time on TM2e board!
Great! I'll add this to the commit msg.
Thanks for testing.
BTW, while playing with this, maybe it would make sense to fix the reported interrupt type for the PMIC sub-interrupts:
# grep s2mps /proc/interrupts 120: 0 gpa0 7 Level s2mps13 121: 0 s2mps13 10 Edge rtc-alarm0
Best regards
Signature · 2 lines
Marek Szyprowski, PhD Samsung R&D Institute Poland
Krzysztof Kozlowski
maintainerRe: [PATCH 9/9] mfd: sec-irq: Do not enforce (incorrect) interrupt trigger type
Quoted 22 lines · Marek Szyprowski
Hi Krzysztof,
Quoted 19 lines · Krzysztof Kozlowski
Quoted 11 lines · Marek Szyprowski
Quoted 10 lines · Krzysztof Kozlowski
Interrupt line can be configured on different hardware in different way, even inverted. Therefore driver should not enforce specific trigger type - edge falling - but instead rely on Devicetree to configure it.
The Samsung PMIC drivers are used only on Devicetree boards.
Additionally, the PMIC datasheets describe the interrupt line as active low with a requirement of acknowledge from the CPU therefore the edge falling is not correct.
Quoted 5 lines
Quoted 1 line
Signed-off-by Krzysztof Kozlowski <[email protected]>Tested-by Marek Szyprowski <[email protected]>It looks that this together with DTS change fixes RTC alarm failure that I've observed from time to time on TM2e board!
Great! I'll add this to the commit msg.
Quoted 8 lines
Quoted 1 line
Thanks for testing.
BTW, while playing with this, maybe it would make sense to fix the reported interrupt type for the PMIC sub-interrupts:
# grep s2mps /proc/interrupts 120: 0 gpa0 7 Level s2mps13 121: 0 s2mps13 10 Edge rtc-alarm0
I also spotted this. It's a virtual interrupt and I am not sure whether we can actually configure it when the hardware does not allow to set the type (the regmap_irq_type requires register offsets).
Best regards,
Krzysztof
Re: [PATCH 9/9] mfd: sec-irq: Do not enforce (incorrect) interrupt trigger type
Quoted 25 lines · Krzysztof Kozlowski
Quoted 24 lines · Marek Szyprowski
Quoted 12 lines · Krzysztof Kozlowski
Quoted 11 lines · Marek Szyprowski
Quoted 10 lines · Krzysztof Kozlowski
Interrupt line can be configured on different hardware in different way, even inverted. Therefore driver should not enforce specific trigger type - edge falling - but instead rely on Devicetree to configure it.
The Samsung PMIC drivers are used only on Devicetree boards.
Additionally, the PMIC datasheets describe the interrupt line as active low with a requirement of acknowledge from the CPU therefore the edge falling is not correct.
Quoted 8 lines
Quoted 5 lines
Quoted 1 line
Signed-off-by Krzysztof Kozlowski <[email protected]>Tested-by Marek Szyprowski <[email protected]>It looks that this together with DTS change fixes RTC alarm failure that I've observed from time to time on TM2e board!
Great! I'll add this to the commit msg.
Thanks for testing.
BTW, while playing with this, maybe it would make sense to fix the reported interrupt type for the PMIC sub-interrupts:
Quoted 6 lines
Quoted 3 lines
# grep s2mps /proc/interrupts 120: 0 gpa0 7 Level s2mps13 121: 0 s2mps13 10 Edge rtc-alarm0I also spotted this. It's a virtual interrupt and I am not sure whether we can actually configure it when the hardware does not allow to set the type (the
regmap_irq_typerequires register offsets).
I know that it is virtual, but maybe the regmap code could simply copy the interrupt type from its parent interrupt?
Best regards
Signature · 2 lines
Marek Szyprowski, PhD Samsung R&D Institute Poland
Quoted 9 lines · Krzysztof Kozlowski
The Samsung PMIC datasheets describe the interrupt line as active low with a requirement of acknowledge from the CPU. Without specifying the interrupt type in Devicetree, kernel might apply some fixed configuration, not necessarily working for this hardware.
Fixes b004a34bd0ff ("ARM: dts: exynos: Add exynos3250-artik5 dtsi file for ARTIK5 module")Signed-off-by Krzysztof Kozlowski <[email protected]>--- arch/arm/boot/dts/exynos3250-artik5.dtsi | 2 +-
Quoted 7 lines
1 file changed, 1 insertion(+), 1 deletion(-)arch/arm/boot/dts/exynos3250-artik5.dtsi +0
-0
arch/arm/boot/dts/exynos3250-artik5.dtsi &i2c_0 { · line 85
Quoted 8 lines
arch/arm/boot/dts/exynos3250-artik5.dtsi +1
-1@@ -79,7 +79,7 @@ &i2c_0 { pmic@66 { compatible = "samsung,s2mps14-pmic"; interrupt-parent = <&gpx3>; - interrupts = <5 IRQ_TYPE_NONE>; + interrupts = <5 IRQ_TYPE_LEVEL_LOW>; pinctrl-names = "default"; pinctrl-0 = <&s2mps14_irq>; reg = <0x66>;
Best regards
Signature · 8 lines
Marek Szyprowski, PhD Samsung R&D Institute Poland _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Quoted 4 lines · Krzysztof Kozlowski
The Samsung PMIC datasheets describe the interrupt line as active low with a requirement of acknowledge from the CPU. Without specifying the interrupt type in Devicetree, kernel might apply some fixed configuration, not necessarily working for this hardware.
Applied, thanks!
[1/9] ARM: dts: exynos: correct PMIC interrupt trigger level on Artik 5
commit: 58139a7837133538099dc59447f33765b61f5c27
[2/9] ARM: dts: exynos: correct PMIC interrupt trigger level on Monk
commit: c9b260c91ab61d4094a3c152546d88d41259d647
[3/9] ARM: dts: exynos: correct PMIC interrupt trigger level on Rinato
commit: 2c9f52d2b09abd25bd00ef2a5a35d9246fc92d88
[4/9] ARM: dts: exynos: correct PMIC interrupt trigger level on Spring
commit: 1d6f6eee94da4f60ddb2107ffcf55629083711df
[5/9] ARM: dts: exynos: correct PMIC interrupt trigger level on Arndale Octa
commit: 4a96ea5cf0550766397f5e9221c4f2a949492ee6
[6/9] ARM: dts: exynos: correct PMIC interrupt trigger level on Odroid XU3 family
commit: 0274326ce6796813842998141174bd5a0e9ff908
[7/9] arm64: dts: exynos: correct PMIC interrupt trigger level on TM2
commit: 9fd8f10d119c6c48899ace33ff0f7e8702ad1d66
[8/9] arm64: dts: exynos: correct PMIC interrupt trigger level on Espresso
commit: acdd83e384c41d20d66bc0045f5eb67b6d67ed69Best regards,
Signature · 1 line
Krzysztof Kozlowski <[email protected]>