Skip to contentSkip to conversation

Update SPDX-License-Identifier tags from GPL-2.0 to MIT

PATCH In review Adam Stiles 2 participants 4 messages Dec 13, 2020 – Dec 15, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Update SPDX-License-Identifier tags from GPL-2.0 to MIT

---
 Sources/WireGuardApp/UI/macOS/View/highlighter.c | 2 +-
 Sources/WireGuardApp/UI/macOS/View/highlighter.h | 2 +-
 Sources/WireGuardKitC/key.c                      | 2 +-
 Sources/WireGuardKitC/key.h                      | 2 +-
 Sources/WireGuardKitC/x25519.c                   | 2 +-
 Sources/WireGuardKitGo/Makefile                  | 2 +-
 Sources/WireGuardKitGo/wireguard.h               | 2 +-
 7 files changed, 7 insertions(+), 7 deletions(-)
Sources/WireGuardApp/UI/macOS/View/highlighter.c +1 -1
index e0d4e04..55fabfd 100644
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0
+// SPDX-License-Identifier: MIT
 /*
  * Copyright (C) 2015-2020 Jason A. Donenfeld <[email protected]>. All Rights Reserved.
  */
Sources/WireGuardApp/UI/macOS/View/highlighter.h +1 -1
index 885db2d..8b86acb 100644
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0 */
+/* SPDX-License-Identifier: MIT */
 /*
  * Copyright (C) 2015-2019 Jason A. Donenfeld <[email protected]>. All Rights Reserved.
  */
Sources/WireGuardKitC/key.c +1 -1
index 140f278..84e7f16 100644
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0
+// SPDX-License-Identifier: MIT
 /*
  * Copyright (C) 2015-2019 Jason A. Donenfeld <[email protected]>. All Rights Reserved.
  *
Sources/WireGuardKitC/key.h +1 -1
index 149e4ed..5353ade 100644
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0 */
+/* SPDX-License-Identifier: MIT */
 /*
  * Copyright (C) 2015-2019 Jason A. Donenfeld <[email protected]>. All Rights Reserved.
  */
Sources/WireGuardKitC/x25519.c +1 -1
index b77da0b..9ceed9f 100644
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0+
+/* SPDX-License-Identifier: MIT+
  *
  * Copyright (C) 2015-2019 Jason A. Donenfeld <[email protected]>. All Rights Reserved.
  *
Sources/WireGuardKitGo/Makefile +1 -1
index 767edbd..d59c61d 100644
@@ -1,4 +1,4 @@
-# SPDX-License-Identifier: GPL-2.0
+# SPDX-License-Identifier: MIT
 #
 # Copyright (C) 2018-2019 Jason A. Donenfeld <[email protected]>. All Rights Reserved.
 
Sources/WireGuardKitGo/wireguard.h +1 -1
index 9da8cef..8cefa49 100644
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0
+/* SPDX-License-Identifier: MIT
  *
  * Copyright (C) 2018-2020 WireGuard LLC. All Rights Reserved.
  */

--
2.21.0

#1 lore raw

Hi,

a little drive-by review, since I happened to see the patch. In case I misunderstood something, I apologise in advance.

Quoted 16 lines · Adam Stiles
---
 Sources/WireGuardApp/UI/macOS/View/highlighter.c | 2 +-
 Sources/WireGuardApp/UI/macOS/View/highlighter.h | 2 +-
 Sources/WireGuardKitC/key.c                      | 2 +-
 Sources/WireGuardKitC/key.h                      | 2 +-
 Sources/WireGuardKitC/x25519.c                   | 2 +-
 Sources/WireGuardKitGo/Makefile                  | 2 +-
 Sources/WireGuardKitGo/wireguard.h               | 2 +-
 7 files changed, 7 insertions(+), 7 deletions(-)
Sources/WireGuardApp/UI/macOS/View/highlighter.c +0 -0
index e0d4e04..55fabfd 100644

Sources/WireGuardApp/UI/macOS/View/highlighter.c line 1

Quoted 2 lines
Sources/WireGuardApp/UI/macOS/View/highlighter.c +1 -1
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0
+// SPDX-License-Identifier: MIT

AFAIUI, such a change expresses a relicensing of the code, and it should (IMHO) be made clear in the commit message that this is the case.

All authors of the code must agree to a relicensing. It would be nice to see the list of authors in the commit message, along with a confirmation that all agreed to relicense the code to MIT.

Sources/WireGuardApp/UI/macOS/View/highlighter.c line 2

Quoted 2 lines
Sources/WireGuardApp/UI/macOS/View/highlighter.c +1 -1
-/* SPDX-License-Identifier: GPL-2.0+
+/* SPDX-License-Identifier: MIT+

I think MIT+ is an editing error. It's not on the official SPDX license identifier list, in any case.

Best regards,
Jonathan Neuschäfer

#2 lore raw

Hi Jonathan,

Thanks for looking at the patch. In retrospect, I should have asked about this before I submitted it. I wasn't intending a re-license. Rather, I assumed those SPDX identifiers were missed when repo was converted from GPL to MIT a couple of years ago. Apologies,

Adam

Quoted 42 lines · Jonathan Neuschäfer

Hi,

a little drive-by review, since I happened to see the patch. In case I misunderstood something, I apologise in advance.

Quoted 16 lines · Adam Stiles
---
 Sources/WireGuardApp/UI/macOS/View/highlighter.c | 2 +-
 Sources/WireGuardApp/UI/macOS/View/highlighter.h | 2 +-
 Sources/WireGuardKitC/key.c                      | 2 +-
 Sources/WireGuardKitC/key.h                      | 2 +-
 Sources/WireGuardKitC/x25519.c                   | 2 +-
 Sources/WireGuardKitGo/Makefile                  | 2 +-
 Sources/WireGuardKitGo/wireguard.h               | 2 +-
 7 files changed, 7 insertions(+), 7 deletions(-)
Sources/WireGuardApp/UI/macOS/View/highlighter.c +0 -0
index e0d4e04..55fabfd 100644

Sources/WireGuardApp/UI/macOS/View/highlighter.c line 1

Quoted 2 lines
Sources/WireGuardApp/UI/macOS/View/highlighter.c +1 -1
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0
+// SPDX-License-Identifier: MIT

AFAIUI, such a change expresses a relicensing of the code, and it should (IMHO) be made clear in the commit message that this is the case.

All authors of the code must agree to a relicensing. It would be nice to see the list of authors in the commit message, along with a confirmation that all agreed to relicense the code to MIT.

Sources/WireGuardApp/UI/macOS/View/highlighter.c line 2

Quoted 2 lines
Sources/WireGuardApp/UI/macOS/View/highlighter.c +1 -1
-/* SPDX-License-Identifier: GPL-2.0+
+/* SPDX-License-Identifier: MIT+

I think MIT+ is an editing error. It's not on the official SPDX license identifier list, in any case.

Best regards,
Jonathan Neuschäfer

#3 lore raw
Quoted 6 lines · Adam Stiles

Hi Jonathan,

Thanks for looking at the patch. In retrospect, I should have asked about this before I submitted it. I wasn't intending a re-license. Rather, I assumed those SPDX identifiers were missed when repo was converted from GPL to MIT a couple of years ago.

I missed that detail. If you send a second version of the patch, please mention it in the commit message, so that misunderstandings can be avoided by reading the commit message.

Quoted 3 lines

Apologies,

Adam

No problem :)

Best regards,
Jonathan