net/mlx4: Use true,false for bool variable
Subsystems (5)
PATCH 1/1 net/mlx4: Use true,false for bool variable
Fix en_rx.c:687:1-17: WARNING: Assignment of 0/1 to bool variable Fix main.c:4465:5-13: WARNING: Comparison of 0/1 to bool variable
--- drivers/net/ethernet/mellanox/mlx4/en_rx.c | 2 +- drivers/net/ethernet/mellanox/mlx4/main.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/net/ethernet/mellanox/mlx4/en_rx.c +1 -1
@@ -684,7 +684,7 @@ int mlx4_en_process_rx_cq(struct net_device *dev, struct mlx4_en_cq *cq, int bud xdp_prog =rcu_dereference (ring->xdp_prog); xdp.rxq = &ring->xdp_rxq; xdp.frame_sz = priv->frag_info[0 ].frag_stride; - doorbell_pending =0 ; + doorbell_pending = false;/* We assume a 1:1 mapping between CQEs and Rx descriptors, so Rx * descriptor offset can be deduced from the CQE index instead of
drivers/net/ethernet/mellanox/mlx4/main.c +1 -1
@@ -4462,7 +4462,7 @@ static int __init mlx4_verify_params(void)pr_warn ("mlx4_core: log_num_vlan - obsolete module param, using %d\n" ,MLX4_LOG_NUM_VLANS ); -if (use_prio !=0 ) +if (use_prio != false)pr_warn ("mlx4_core: use_prio - obsolete module param, ignored\n" );if ((log_mtts_per_seg <0 ) || (log_mtts_per_seg >7 )) {
Signature · 1 line
2.17.1
Quoted 2 lines · Vasyl Gomonovych
Fix en_rx.c:687:1-17: WARNING: Assignment of 0/1 to bool variable Fix main.c:4465:5-13: WARNING: Comparison of 0/1 to bool variable
[]
drivers/net/ethernet/mellanox/mlx4/main.c
Quoted 1 line
drivers/net/ethernet/mellanox/mlx4/main.c +0
-0
[]
Quoted 8 lines
drivers/net/ethernet/mellanox/mlx4/main.c +0
-0@@ -4462,7 +4462,7 @@ static int __init mlx4_verify_params(void) pr_warn("mlx4_core: log_num_vlan - obsolete module param, using %d\n", MLX4_LOG_NUM_VLANS);drivers/net/ethernet/mellanox/mlx4/main.c +1
-1-if (use_prio !=0 ) +if (use_prio != false)
pr_warn("mlx4_core: use_prio - obsolete module param, ignored\n");
Generally, assuming use_prio is bool, this would be written
if (use_prio)
pr_warn("etc...")Jakub Kicinski
maintainerQuoted 2 lines · On Fri, 11 Dec 2020 11:05:18 +0100 Vasyl Gomonovych wrote:
Fix en_rx.c:687:1-17: WARNING: Assignment of 0/1 to bool variable Fix main.c:4465:5-13: WARNING: Comparison of 0/1 to bool variable
Apart from addressing Joe's comment please name the tool which produced those.
PATCH v2 1/1 net/mlx4: Use true,false for bool variable
It is fix for semantic patch warning available in scripts/coccinelle/misc/boolinit.cocci
Fix en_rx.c:687:1-17: WARNING: Assignment of 0/1 to bool variable Fix main.c:4465:5-13: WARNING: Comparison of 0/1 to bool variable
---
- Add coccicheck script name
- Simplify if condition
--- drivers/net/ethernet/mellanox/mlx4/en_rx.c | 2 +- drivers/net/ethernet/mellanox/mlx4/main.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/net/ethernet/mellanox/mlx4/en_rx.c +1 -1
@@ -684,7 +684,7 @@ int mlx4_en_process_rx_cq(struct net_device *dev, struct mlx4_en_cq *cq, int bud xdp_prog =rcu_dereference (ring->xdp_prog); xdp.rxq = &ring->xdp_rxq; xdp.frame_sz = priv->frag_info[0 ].frag_stride; - doorbell_pending =0 ; + doorbell_pending = false;/* We assume a 1:1 mapping between CQEs and Rx descriptors, so Rx * descriptor offset can be deduced from the CQE index instead of
drivers/net/ethernet/mellanox/mlx4/main.c +1 -1
@@ -4462,7 +4462,7 @@ static int __init mlx4_verify_params(void)pr_warn ("mlx4_core: log_num_vlan - obsolete module param, using %d\n" ,MLX4_LOG_NUM_VLANS ); -if (use_prio !=0 ) +if (use_prio)pr_warn ("mlx4_core: use_prio - obsolete module param, ignored\n" );if ((log_mtts_per_seg <0 ) || (log_mtts_per_seg >7 )) {
Signature · 1 line
2.17.1
Quoted 5 lines · Vasyl Gomonovych
It is fix for semantic patch warning available in
scripts/coccinelle/misc/boolinit.cocci
Fix en_rx.c:687:1-17: WARNING: Assignment of 0/1 to bool variable Fix main.c:4465:5-13: WARNING: Comparison of 0/1 to bool variable
Quoted 8 lines
Signed-off-by Vasyl Gomonovych <[email protected]>---
- Add coccicheck script name
- Simplify if condition--- drivers/net/ethernet/mellanox/mlx4/en_rx.c | 2 +- drivers/net/ethernet/mellanox/mlx4/main.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
Please refrain from sending new version of patches as reply-to to previous variants. It makes to appear previous patches out-of-order while viewing in threaded mode.
Thanks
Jakub Kicinski
maintainerQuoted 15 lines · On Mon, 14 Dec 2020 13:16:08 +0200 Leon Romanovsky wrote:
Quoted 5 lines · Vasyl Gomonovych
It is fix for semantic patch warning available in
scripts/coccinelle/misc/boolinit.cocci
Fix en_rx.c:687:1-17: WARNING: Assignment of 0/1 to bool variable Fix main.c:4465:5-13: WARNING: Comparison of 0/1 to bool variableQuoted 8 lines
Signed-off-by Vasyl Gomonovych <[email protected]>---
- Add coccicheck script name
- Simplify if condition--- drivers/net/ethernet/mellanox/mlx4/en_rx.c | 2 +- drivers/net/ethernet/mellanox/mlx4/main.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
Quoted 3 lines
Please refrain from sending new version of patches as reply-to to previous variants. It makes to appear previous patches out-of-order while viewing in threaded mode.
Yes, please! I'm glad I'm not the only one who feels this way! :)
Quoted 16 lines · Jakub Kicinski
Quoted 15 lines · On Mon, 14 Dec 2020 13:16:08 +0200 Leon Romanovsky wrote:
Quoted 13 lines · Vasyl Gomonovych
It is fix for semantic patch warning available in
scripts/coccinelle/misc/boolinit.cocci
Fix en_rx.c:687:1-17: WARNING: Assignment of 0/1 to bool variable Fix main.c:4465:5-13: WARNING: Comparison of 0/1 to bool variableSigned-off-by Vasyl Gomonovych <[email protected]>---
- Add coccicheck script name
- Simplify if condition
---
drivers/net/ethernet/mellanox/mlx4/en_rx.c | 2 +-drivers/net/ethernet/mellanox/mlx4/main.c| 2 +-2 files changed, 2 insertions(+), 2 deletions(-)
Quoted 5 lines
Quoted 3 lines
Please refrain from sending new version of patches as reply-to to previous variants. It makes to appear previous patches out-of-order while viewing in threaded mode.
Yes, please! I'm glad I'm not the only one who feels this way! :)
I'm the other way.
I prefer revisions to single patches (as opposed to large patch series) in the same thread.
There is no other easy way for changes to a patch to be tracked AFAIK.
Most email clients use both In-Reply-To: and References: headers as the mechanism to thread replies.
Keeping the latest messages at the bottom of a thread works well to see revision sequences.
Jakub Kicinski
maintainerQuoted 6 lines · On Mon, 14 Dec 2020 11:30:08 +0100 Vasyl Gomonovych wrote:
It is fix for semantic patch warning available in
scripts/coccinelle/misc/boolinit.cocci
Fix en_rx.c:687:1-17: WARNING: Assignment of 0/1 to bool variable Fix main.c:4465:5-13: WARNING: Comparison of 0/1 to bool variableSigned-off-by Vasyl Gomonovych <[email protected]>
Looks like it doesn't apply to net-next, please respin based on:
https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/
Quoted 21 lines · Joe Perches
Quoted 20 lines · Jakub Kicinski
Quoted 18 lines · On Mon, 14 Dec 2020 13:16:08 +0200 Leon Romanovsky wrote:
Quoted 5 lines · Vasyl Gomonovych
It is fix for semantic patch warning available in
scripts/coccinelle/misc/boolinit.cocci
Fix en_rx.c:687:1-17: WARNING: Assignment of 0/1 to bool variable Fix main.c:4465:5-13: WARNING: Comparison of 0/1 to bool variableQuoted 8 lines
Signed-off-by Vasyl Gomonovych <[email protected]>---
- Add coccicheck script name
- Simplify if condition
---
drivers/net/ethernet/mellanox/mlx4/en_rx.c | 2 +-drivers/net/ethernet/mellanox/mlx4/main.c| 2 +-2 files changed, 2 insertions(+), 2 deletions(-)Please refrain from sending new version of patches as reply-to to previous variants. It makes to appear previous patches out-of-order while viewing in threaded mode.
Quoted 6 lines
Quoted 1 line
Yes, please! I'm glad I'm not the only one who feels this way! :)
I'm the other way.
I prefer revisions to single patches (as opposed to large patch series) in the same thread.
It depends which side you are in that game. From the reviewer point of view, such submission breaks flow very badly. It unfolds the already reviewed thread, messes with the order and many more little annoying things.
Quoted 2 lines
There is no other easy way for changes to a patch to be tracked AFAIK.
Not really, I'm using very simple convention to keep tracking of changes. The changelog together with lorifier does the trick.
https://github.com/danrue/lorifier
https://lore.kernel.org/linux-rdma/[email protected]/
So I'm simply adding link to the previous version when sending new one.
Quoted 3 lines
Most email clients use both In-Reply-To: and References: headers as the mechanism to thread replies.
Right, and this is exactly what we don't want for vX patches.
Quoted 3 lines
Keeping the latest messages at the bottom of a thread works well to see revision sequences.
I have a different workflow.
Thanks
Quoted 8 lines · Leon Romanovsky
Quoted 2 lines · Joe Perches
I prefer revisions to single patches (as opposed to large patch series) in the same thread.
It depends which side you are in that game. From the reviewer point of view, such submission breaks flow very badly. It unfolds the already reviewed thread, messes with the order and many more little annoying things.
This is where I disagree with you. I am a reviewer here.
Not having context to be able to inspect vN -> vN+1 is made more difficult not having the original patch available and having to search history for it.
Almost no one adds URL links to older submissions below the ---.
Were that a standard mechanism below the --- line, then it would be OK.
Quoted 11 lines · Joe Perches
Quoted 8 lines · Leon Romanovsky
Quoted 2 lines · Joe Perches
I prefer revisions to single patches (as opposed to large patch series) in the same thread.
It depends which side you are in that game. From the reviewer point of view, such submission breaks flow very badly. It unfolds the already reviewed thread, messes with the order and many more little annoying things.
This is where I disagree with you. I am a reviewer here.
It is ok, different people have different views.
Quoted 4 lines
Not having context to be able to inspect vN -> vN+1 is made more difficult not having the original patch available and having to search history for it.
I'm following after specific subsystems and see all patches there, so for me and Jakub context already exists.
Bottom line, it depends on the workflow.
Quoted 2 lines
Almost no one adds URL links to older submissions below the ---.
Too bad, maybe it is time to enforce it.
Quoted 3 lines
Were that a standard mechanism below the --- line, then it would be OK.
So let's me summarize, we (RDMA and netdev subsystems) would like to ask do not submit new patch revisions as reply-to.
Thanks
Hi,
Ouuu it was fixed recently in net-next.
Sorry, I missed that.
Thanks for submitting policy clarification I am going to adapt to it.
Thanks
Quoted 39 lines · Leon Romanovsky
Quoted 11 lines · Joe Perches
Quoted 8 lines · Leon Romanovsky
Quoted 2 lines · Joe Perches
I prefer revisions to single patches (as opposed to large patch series) in the same thread.
It depends which side you are in that game. From the reviewer point of view, such submission breaks flow very badly. It unfolds the already reviewed thread, messes with the order and many more little annoying things.
This is where I disagree with you. I am a reviewer here.
It is ok, different people have different views.
Quoted 4 lines
Not having context to be able to inspect vN -> vN+1 is made more difficult not having the original patch available and having to search history for it.
I'm following after specific subsystems and see all patches there, so for me and Jakub context already exists.
Bottom line, it depends on the workflow.
Quoted 2 lines
Almost no one adds URL links to older submissions below the ---.
Too bad, maybe it is time to enforce it.
Quoted 3 lines
Were that a standard mechanism below the --- line, then it would be OK.
So let's me summarize, we (RDMA and netdev subsystems) would like to ask do not submit new patch revisions as reply-to.
Thanks
Signature · 1 line
Доброї вам пори дня.