drm/tegra: sor: Don't warn on probe deferral
Subsystems (9)
Sasha Levin
maintainerPATCH 5/23 gfs2: set lockdep subclass for iopen glocks
In reply to Sasha LevinFrom: Alexander Aring <[email protected]>
[ Upstream commit 515b269d5bd29a986d5e1c0a0cba87fa865a48b4 ]
This patch introduce a new globs attribute to define the subclass of the glock lockref spinlock. This avoid the following lockdep warning, which occurs when we lock an inode lock while an iopen lock is held:
============================================
WARNING: possible recursive locking detected
5.10.0-rc3+ #4990 Not tainted
--------------------------------------------
kworker/0:1/12 is trying to acquire lock:ffff9067d45672d8 (&gl->gl_lockref.lock){+.+.}-{3:3}, at: lockref_get+0x9/0x20
but task is already holding lock:ffff9067da308588 (&gl->gl_lockref.lock){+.+.}-{3:3}, at: delete_work_func+0x164/0x260
other info that might help us debug this:
Possible unsafe locking scenario:
CPU0
---- lock(&gl->gl_lockref.lock);
lock(&gl->gl_lockref.lock);
*** DEADLOCK ***
May be due to missing lock nesting notation
3 locks held by kworker/0:1/12:
#0: ffff9067c1bfdd38 ((wq_completion)delete_workqueue){+.+.}-{0:0}, at: process_one_work+0x1b7/0x540 #1: ffffac594006be70 ((work_completion)(&(&gl->gl_delete)->work)){+.+.}-{0:0}, at: process_one_work+0x1b7/0x540 #2: ffff9067da308588 (&gl->gl_lockref.lock){+.+.}-{3:3}, at: delete_work_func+0x164/0x260
stack backtrace: CPU: 0 PID: 12 Comm: kworker/0:1 Not tainted 5.10.0-rc3+ #4990 Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.13.0-2.fc32 04/01/2014 Workqueue: delete_workqueue delete_work_func Call Trace: dump_stack+0x8b/0xb0 __lock_acquire.cold+0x19e/0x2e3 lock_acquire+0x150/0x410 ? lockref_get+0x9/0x20 _raw_spin_lock+0x27/0x40 ? lockref_get+0x9/0x20 lockref_get+0x9/0x20 delete_work_func+0x188/0x260 process_one_work+0x237/0x540 worker_thread+0x4d/0x3b0 ? process_one_work+0x540/0x540 kthread+0x127/0x140 ? __kthread_bind_mask+0x60/0x60 ret_from_fork+0x22/0x30
--- fs/gfs2/glock.c | 1 + fs/gfs2/glops.c | 1 + fs/gfs2/incore.h | 1 + 3 files changed, 3 insertions(+)
fs/gfs2/glock.c +1 -0
@@ -1038,6 +1038,7 @@ int gfs2_glock_get(struct gfs2_sbd *sdp, u64 number, gl->gl_node.next =NULL ; gl->gl_flags =0 ; gl->gl_name = name; +lockdep_set_subclass (&gl->gl_lockref.lock, glops->go_subclass); gl->gl_lockref.count =1 ; gl->gl_state =LM_ST_UNLOCKED ; gl->gl_target =LM_ST_UNLOCKED ;
fs/gfs2/glops.c +1 -0
@@ -751,6 +751,7 @@ const struct gfs2_glock_operations gfs2_iopen_glops = { .go_callback = iopen_go_callback, .go_demote_ok = iopen_go_demote_ok, .go_flags = GLOF_LRU | GLOF_NONDISK, + .go_subclass = 1, };const struct gfs2_glock_operations gfs2_flock_glops = {
fs/gfs2/incore.h +1 -0
@@ -243,6 +243,7 @@ struct gfs2_glock_operations { const char *fs_id_buf);void (*go_callback)(struct gfs2_glock *gl,bool remote);void (*go_free)(struct gfs2_glock *gl); +const int go_subclass;const int go_type;const unsigned long go_flags;#define GLOF_ASPACE 1/* address space attached */
Signature · 1 line
2.27.0
Sasha Levin
maintainerPATCH 1/23 drm/tegra: sor: Don't warn on probe deferral
From: Jon Hunter <[email protected]>
[ Upstream commit cb7ff314e1d9f3d6c62fa2c392e41174721ed0b3 ]
Deferred probe is an expected return value for tegra_output_probe(). Given that the driver deals with it properly, there's no need to output a warning that may potentially confuse users.
--- drivers/gpu/drm/tegra/sor.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)
drivers/gpu/drm/tegra/sor.c +3 -4
@@ -3759,10 +3759,9 @@ static int tegra_sor_probe(struct platform_device *pdev)return err; err =tegra_output_probe (&sor->output); -if (err <0 ) { -dev_err (&pdev->dev,"failed to probe output: %d\n" , err); -return err; - } +if (err <0 ) +return dev_err_probe (&pdev->dev, err, +"failed to probe output\n" );if (sor->ops && sor->ops->probe) { err = sor->ops->probe (sor);
Signature · 6 lines
2.27.0 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Sasha Levin
maintainerPATCH 3/23 drm/tegra: replace idr_init() by idr_init_base()
From: Deepak R Varma <[email protected]>
[ Upstream commit 41f71629b4c432f8dd47d70ace813be5f79d4d75 ]
idr_init() uses base 0 which is an invalid identifier for this driver. The new function idr_init_base allows IDR to set the ID lookup from base 1. This avoids all lookups that otherwise starts from 0 since 0 is always unused.
References: commit 6ce711f27500 ("idr: Make 1-based IDRs more efficient")
--- drivers/gpu/drm/tegra/drm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/tegra/drm.c +1 -1
@@ -90,7 +90,7 @@ static int tegra_drm_open(struct drm_device *drm, struct drm_file *filp)if (!fpriv)return -ENOMEM ; -idr_init (&fpriv->contexts); +idr_init_base (&fpriv->contexts,1 );mutex_init (&fpriv->lock); filp->driver_priv = fpriv;
Signature · 6 lines
2.27.0 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Sasha Levin
maintainerPATCH 2/23 drm/tegra: sor: Ensure regulators are disabled on teardown
In reply to Sasha LevinFrom: Marc Zyngier <[email protected]>
[ Upstream commit 5c1d644c09dbc13b2dc652435786e42b05ac1bb7 ]
The Tegra SOR driver uses the devm infrastructure to request regulators, but enables them without registering them with the infrastructure.
This results in the following splat if probing fails for any odd resaon (such as dependencies not being available):
[ 8.974187] tegra-sor 15580000.sor: cannot get HDMI supply: -517 [ 9.414403] tegra-sor 15580000.sor: failed to probe HDMI: -517 [ 9.421240] ------------[ cut here ]------------ [ 9.425879] WARNING: CPU: 1 PID: 164 at drivers/regulator/core.c:2089 _regulator_put.part.0+0x16c/0x174 [ 9.435259] Modules linked in: tegra_drm(E+) cec(E) ahci_tegra(E) drm_kms_helper(E) drm(E) libahci_platform(E) libahci(E) max77620_regulator(E) xhci_tegra(E+) sdhci_tegra(E) xhci_hcd(E) libata(E) sdhci_pltfm(E) cqhci(E) fixed(E) usbcore(E) scsi_mod(E) sdhci(E) host1x(E) [ 9.459211] CPU: 1 PID: 164 Comm: systemd-udevd Tainted: G S D W E 5.9.0-rc7-00298-gf6337624c4fe #1980 [ 9.469285] Hardware name: NVIDIA Jetson TX2 Developer Kit (DT) [ 9.475202] pstate: 80000005 (Nzcv daif -PAN -UAO BTYPE=--) [ 9.480784] pc : _regulator_put.part.0+0x16c/0x174 [ 9.485581] lr : regulator_put+0x44/0x60 [ 9.489501] sp : ffffffc011d837b0 [ 9.492814] x29: ffffffc011d837b0 x28: ffffff81dd085900 [ 9.498141] x27: ffffff81de1c8ec0 x26: ffffff81de1c8c10 [ 9.503464] x25: ffffff81dd085800 x24: ffffffc008f2c6b0 [ 9.508790] x23: ffffffc0117373f0 x22: 0000000000000005 [ 9.514101] x21: ffffff81dd085900 x20: ffffffc01172b098 [ 9.515822] ata1: SATA link down (SStatus 0 SControl 300) [ 9.519426] x19: ffffff81dd085100 x18: 0000000000000030 [ 9.530122] x17: 0000000000000000 x16: 0000000000000000 [ 9.535453] x15: 0000000000000000 x14: 000000000000038f [ 9.540777] x13: 0000000000000003 x12: 0000000000000040 [ 9.546105] x11: ffffff81eb800000 x10: 0000000000000ae0 [ 9.551417] x9 : ffffffc0106fea24 x8 : ffffff81de83e6c0 [ 9.556728] x7 : 0000000000000018 x6 : 00000000000003c3 [ 9.562064] x5 : 0000000000005660 x4 : 0000000000000000 [ 9.567392] x3 : ffffffc01172b388 x2 : ffffff81de83db80 [ 9.572702] x1 : 0000000000000000 x0 : 0000000000000001 [ 9.578034] Call trace: [ 9.580494] _regulator_put.part.0+0x16c/0x174 [ 9.584940] regulator_put+0x44/0x60 [ 9.588522] devm_regulator_release+0x20/0x2c [ 9.592885] release_nodes+0x1c8/0x2c0 [ 9.596636] devres_release_all+0x44/0x6c [ 9.600649] really_probe+0x1ec/0x504 [ 9.604316] driver_probe_device+0x100/0x170 [ 9.608589] device_driver_attach+0xcc/0xd4 [ 9.612774] __driver_attach+0xb0/0x17c [ 9.616614] bus_for_each_dev+0x7c/0xd4 [ 9.620450] driver_attach+0x30/0x3c [ 9.624027] bus_add_driver+0x154/0x250 [ 9.627867] driver_register+0x84/0x140 [ 9.631719] __platform_register_drivers+0xa0/0x180 [ 9.636660] host1x_drm_init+0x60/0x1000 [tegra_drm] [ 9.641629] do_one_initcall+0x54/0x2d0 [ 9.645490] do_init_module+0x68/0x29c [ 9.649244] load_module+0x2178/0x26c0 [ 9.652997] __do_sys_finit_module+0xb0/0x120 [ 9.657356] __arm64_sys_finit_module+0x2c/0x40 [ 9.661902] el0_svc_common.constprop.0+0x80/0x240 [ 9.666701] do_el0_svc+0x30/0xa0 [ 9.670022] el0_svc+0x18/0x50 [ 9.673081] el0_sync_handler+0x90/0x318 [ 9.677006] el0_sync+0x158/0x180 [ 9.680324] ---[ end trace 90f6c89d62d85ff6 ]---
Instead, let's register a callback that will disable the regulators on teardown. This allows for the removal of the .remove callbacks, which are not needed anymore.
--- drivers/gpu/drm/tegra/sor.c | 59 +++++++++++++++---------------------- 1 file changed, 24 insertions(+), 35 deletions(-)
drivers/gpu/drm/tegra/sor.c +24 -35
@@ -397,7 +397,6 @@ struct tegra_sor;struct tegra_sor_ops {const char *name;int (*probe)(struct tegra_sor *sor); -int (*remove)(struct tegra_sor *sor);void (*audio_enable)(struct tegra_sor *sor);void (*audio_disable)(struct tegra_sor *sor); };
@@ -2942,6 +2941,24 @@ static const struct drm_encoder_helper_funcs tegra_sor_dp_helpers = { .atomic_check = tegra_sor_encoder_atomic_check, }; +static void tegra_sor_disable_regulator (void *data) +{ +struct regulator *reg = data; + +regulator_disable (reg); +} + +static int tegra_sor_enable_regulator (struct tegra_sor *sor,struct regulator *reg) +{ +int err; + + err =regulator_enable (reg); +if (err) +return err; + +return devm_add_action_or_reset (sor->dev, tegra_sor_disable_regulator, reg); +} +static int tegra_sor_hdmi_probe (struct tegra_sor *sor) {int err;
@@ -2953,7 +2970,7 @@ static int tegra_sor_hdmi_probe(struct tegra_sor *sor)return PTR_ERR (sor->avdd_io_supply); } - err =regulator_enable (sor->avdd_io_supply); + err =tegra_sor_enable_regulator (sor, sor->avdd_io_supply);if (err <0 ) {dev_err (sor->dev,"failed to enable AVDD I/O supply: %d\n" , err);
@@ -2967,7 +2984,7 @@ static int tegra_sor_hdmi_probe(struct tegra_sor *sor)return PTR_ERR (sor->vdd_pll_supply); } - err =regulator_enable (sor->vdd_pll_supply); + err =tegra_sor_enable_regulator (sor, sor->vdd_pll_supply);if (err <0 ) {dev_err (sor->dev,"failed to enable VDD PLL supply: %d\n" , err);
@@ -2981,7 +2998,7 @@ static int tegra_sor_hdmi_probe(struct tegra_sor *sor)return PTR_ERR (sor->hdmi_supply); } - err =regulator_enable (sor->hdmi_supply); + err =tegra_sor_enable_regulator (sor, sor->hdmi_supply);if (err <0 ) {dev_err (sor->dev,"failed to enable HDMI supply: %d\n" , err);return err;
@@ -2992,19 +3009,9 @@ static int tegra_sor_hdmi_probe(struct tegra_sor *sor)return 0 ; } -static int tegra_sor_hdmi_remove (struct tegra_sor *sor) -{ -regulator_disable (sor->hdmi_supply); -regulator_disable (sor->vdd_pll_supply); -regulator_disable (sor->avdd_io_supply); - -return 0 ; -} -static const struct tegra_sor_ops tegra_sor_hdmi_ops = { .name ="HDMI" , .probe = tegra_sor_hdmi_probe, - .remove = tegra_sor_hdmi_remove, .audio_enable = tegra_sor_hdmi_audio_enable, .audio_disable = tegra_sor_hdmi_audio_disable, };
@@ -3017,7 +3024,7 @@ static int tegra_sor_dp_probe(struct tegra_sor *sor)if (IS_ERR (sor->avdd_io_supply))return PTR_ERR (sor->avdd_io_supply); - err =regulator_enable (sor->avdd_io_supply); + err =tegra_sor_enable_regulator (sor, sor->avdd_io_supply);if (err <0 )return err;
@@ -3025,25 +3032,16 @@ static int tegra_sor_dp_probe(struct tegra_sor *sor)if (IS_ERR (sor->vdd_pll_supply))return PTR_ERR (sor->vdd_pll_supply); - err =regulator_enable (sor->vdd_pll_supply); + err =tegra_sor_enable_regulator (sor, sor->vdd_pll_supply);if (err <0 )return err;return 0 ; } -static int tegra_sor_dp_remove (struct tegra_sor *sor) -{ -regulator_disable (sor->vdd_pll_supply); -regulator_disable (sor->avdd_io_supply); - -return 0 ; -} -static const struct tegra_sor_ops tegra_sor_dp_ops = { .name ="DP" , .probe = tegra_sor_dp_probe, - .remove = tegra_sor_dp_remove, };static int tegra_sor_init (struct host1x_client *client)
@@ -3768,7 +3766,7 @@ static int tegra_sor_probe(struct platform_device *pdev)if (err <0 ) {dev_err (&pdev->dev,"failed to probe %s: %d\n" , sor->ops->name, err); - goto output; + goto remove; } }
@@ -3949,9 +3947,6 @@ unregister: rpm_disable:pm_runtime_disable (&pdev->dev); remove: -if (sor->ops && sor->ops->remove) - sor->ops->remove (sor); -output:tegra_output_remove (&sor->output);return err; }
@@ -3970,12 +3965,6 @@ static int tegra_sor_remove(struct platform_device *pdev)pm_runtime_disable (&pdev->dev); -if (sor->ops && sor->ops->remove) { - err = sor->ops->remove (sor); -if (err <0 ) -dev_err (&pdev->dev,"failed to remove SOR: %d\n" , err); - } -tegra_output_remove (&sor->output);return 0 ;
Signature · 6 lines
2.27.0 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Sasha Levin
maintainerPATCH 8/23 drm/tegra: sor: Disable clocks on error in tegra_sor_init()
In reply to Sasha LevinFrom: Qinglang Miao <[email protected]>
[ Upstream commit bf3a3cdcad40e5928a22ea0fd200d17fd6d6308d ]
Fix the missing clk_disable_unprepare() before return from tegra_sor_init() in the error handling case.
--- drivers/gpu/drm/tegra/sor.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-)
drivers/gpu/drm/tegra/sor.c +8 -2
@@ -3143,6 +3143,7 @@ static int tegra_sor_init(struct host1x_client *client)if (err <0 ) {dev_err (sor->dev,"failed to deassert SOR reset: %d\n" , err); +clk_disable_unprepare (sor->clk);return err; }
@@ -3150,12 +3151,17 @@ static int tegra_sor_init(struct host1x_client *client) } err =clk_prepare_enable (sor->clk_safe); -if (err <0 ) +if (err <0 ) { +clk_disable_unprepare (sor->clk);return err; + } err =clk_prepare_enable (sor->clk_dp); -if (err <0 ) +if (err <0 ) { +clk_disable_unprepare (sor->clk_safe); +clk_disable_unprepare (sor->clk);return err; + }return 0 ; }
Signature · 6 lines
2.27.0 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Sasha Levin
maintainerPATCH 20/23 drm/amd/display: Init clock value by current vbios CLKs
In reply to Sasha LevinFrom: Brandon Syu <[email protected]>
[ Upstream commit 7e0b367db85ef7b91399006253759a024eab7653 ]
[Why]
While booting into OS, driver updates DPP/DISP CLKs. But init clock value is zero which is invalid.
[How]
Get current clocks value to update init clocks. To avoid underflow.
--- .../drm/amd/display/dc/clk_mgr/dcn21/rn_clk_mgr.c | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-)
drivers/gpu/drm/amd/display/dc/clk_mgr/dcn21/rn_clk_mgr.c +11 -2
@@ -163,8 +163,17 @@ void rn_update_clocks(struct clk_mgr *clk_mgr_base, new_clocks->dppclk_khz =100000 ; } -if (should_set_clock (safe_to_lower, new_clocks->dppclk_khz, clk_mgr->base.clks.dppclk_khz)) { -if (clk_mgr->base.clks.dppclk_khz > new_clocks->dppclk_khz) +/* +* Temporally ignore thew 0 cases for disp and dpp clks. +* We may have a new feature that requires 0 clks in the future. +*/ +if (new_clocks->dppclk_khz ==0 || new_clocks->dispclk_khz ==0 ) { + new_clocks->dppclk_khz = clk_mgr_base->clks.dppclk_khz; + new_clocks->dispclk_khz = clk_mgr_base->clks.dispclk_khz; + } + +if (should_set_clock (safe_to_lower, new_clocks->dppclk_khz, clk_mgr_base->clks.dppclk_khz)) { +if (clk_mgr_base->clks.dppclk_khz > new_clocks->dppclk_khz) dpp_clock_lowered = true; clk_mgr_base->clks.dppclk_khz = new_clocks->dppclk_khz; update_dppclk = true;
Signature · 6 lines
2.27.0 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Sasha Levin
maintainerPATCH 6/23 ASoC: rt5682: change SAR voltage threshold
In reply to Sasha LevinFrom: Shuming Fan <[email protected]>
[ Upstream commit aa4cb898b80a28a610e26d1513e6dd42d995c225 ]
To fix errors in some 4 poles headset detection cases, this patch adjusts the voltage threshold for mic detection.
--- sound/soc/codecs/rt5682.c | 1 + 1 file changed, 1 insertion(+)
sound/soc/codecs/rt5682.c +1 -0
@@ -43,6 +43,7 @@ static const struct reg_sequence patch_list[] = { {RT5682_DAC_ADC_DIG_VOL1, 0xa020}, {RT5682_I2C_CTRL, 0x000f}, {RT5682_PLL2_INTERNAL, 0x8266}, + {RT5682_SAR_IL_CMD_3, 0x8365}, };void rt5682_apply_patch_list (struct rt5682_priv *rt5682,struct device *dev)
Signature · 1 line
2.27.0
Sasha Levin
maintainerPATCH 4/23 dm integrity: don't use drivers that have CRYPTO_ALG_ALLOCATES_MEMORY
In reply to Sasha LevinFrom: Mikulas Patocka <[email protected]>
[ Upstream commit a7a10bce8a04f48238a8306ec97d430b77917015 ]
Don't use crypto drivers that have the flag CRYPTO_ALG_ALLOCATES_MEMORY set. These drivers allocate memory and thus they are not suitable for block I/O processing.
--- drivers/md/dm-integrity.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/md/dm-integrity.c +2 -2
@@ -3462,7 +3462,7 @@ static int get_mac(struct crypto_shash **hash, struct alg_spec *a, char **error,int r;if (a->alg_string) { - *hash =crypto_alloc_shash (a->alg_string,0 ,0 ); + *hash =crypto_alloc_shash (a->alg_string,0 ,CRYPTO_ALG_ALLOCATES_MEMORY );if (IS_ERR (*hash)) { *error = error_alg; r =PTR_ERR (*hash);
@@ -3519,7 +3519,7 @@ static int create_journal(struct dm_integrity_c *ic, char **error)struct journal_completion comp; comp.ic = ic; - ic->journal_crypt =crypto_alloc_skcipher (ic->journal_crypt_alg.alg_string,0 ,0 ); + ic->journal_crypt =crypto_alloc_skcipher (ic->journal_crypt_alg.alg_string,0 ,CRYPTO_ALG_ALLOCATES_MEMORY );if (IS_ERR (ic->journal_crypt)) { *error ="Invalid journal cipher" ; r =PTR_ERR (ic->journal_crypt);
Signature · 1 line
2.27.0
Sasha Levin
maintainerPATCH 12/23 arm64: syscall: exit userspace before unmasking exceptions
In reply to Sasha LevinFrom: Mark Rutland <[email protected]>
[ Upstream commit ca1314d73eed493c49bb1932c60a8605530db2e4 ]
In el0_svc_common() we unmask exceptions before we call user_exit(), and so there's a window where an IRQ or debug exception can be taken while RCU is not watching. In do_debug_exception() we account for this in via debug_exception_{enter,exit}(), but in the el1_irq asm we do not and we call trace functions which rely on RCU before we have a guarantee that RCU is watching.
Let's avoid this by having el0_svc_common() exit userspace before unmasking exceptions, matching what we do for all other EL0 entry paths. We can use user_exit_irqoff() to avoid the pointless save/restore of IRQ flags while we're sure exceptions are masked in DAIF.
The workaround for Cortex-A76 erratum 1463225 may trigger a debug exception before this point, but the debug code invoked in this case is safe even when RCU is not watching.
--- arch/arm64/kernel/syscall.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/kernel/syscall.c +1 -1
@@ -120,8 +120,8 @@ static void el0_svc_common(struct pt_regs *regs, int scno, int sc_nr,*/ cortex_a76_erratum_1463225_svc_handler (); +user_exit_irqoff ();local_daif_restore (DAIF_PROCCTX ); -user_exit ();if (has_syscall_work (flags)) {/*
Signature · 7 lines
2.27.0 _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Sasha Levin
maintainerPATCH 7/23 kernel/cpu: add arch override for clear_tasks_mm_cpumask() mm handling
In reply to Sasha LevinFrom: Nicholas Piggin <[email protected]>
[ Upstream commit 8ff00399b153440c1c83e20c43020385b416415b ]
powerpc/64s keeps a counter in the mm which counts bits set in mm_cpumask as well as other things. This means it can't use generic code to clear bits out of the mask and doesn't adjust the arch specific counter.
Add an arch override that allows powerpc/64s to use clear_tasks_mm_cpumask().
--- kernel/cpu.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)
kernel/cpu.c +5 -1
@@ -815,6 +815,10 @@ void __init cpuhp_threads_init(void) }#ifdef CONFIG_HOTPLUG_CPU +#ifndef arch_clear_mm_cpumask_cpu +#define arch_clear_mm_cpumask_cpu (cpu, mm) cpumask_clear_cpu(cpu, mm_cpumask(mm)) +#endif +/** * clear_tasks_mm_cpumask - Safely clear tasks' mm_cpumask for a CPU * @cpu: a CPU id
@@ -850,7 +854,7 @@ void clear_tasks_mm_cpumask(int cpu) t =find_lock_task_mm (p);if (!t)continue ; -cpumask_clear_cpu (cpu,mm_cpumask (t->mm)); +arch_clear_mm_cpumask_cpu (cpu, t->mm);task_unlock (t); }rcu_read_unlock ();
Signature · 1 line
2.27.0
Sasha Levin
maintainerPATCH 10/23 habanalabs: free host huge va_range if not used
In reply to Sasha LevinFrom: Ofir Bitton <[email protected]>
[ Upstream commit c8c39fbd01d42c30454e42c16bcd69c17260b90a ]
If huge range is not valid, driver uses the host range also for huge page allocations, but driver never frees its allocation. This introduces a memory leak every time a user closes its context.
--- drivers/misc/habanalabs/common/memory.c | 1 + 1 file changed, 1 insertion(+)
drivers/misc/habanalabs/common/memory.c +1 -0
@@ -1616,6 +1616,7 @@ static int vm_ctx_init_with_ranges(struct hl_ctx *ctx, goto host_hpage_range_err; } }else { +kfree (ctx->host_huge_va_range); ctx->host_huge_va_range = ctx->host_va_range; }
Signature · 1 line
2.27.0
Sasha Levin
maintainerPATCH 13/23 vxlan: Add needed_headroom for lower device
In reply to Sasha LevinFrom: Sven Eckelmann <[email protected]>
[ Upstream commit 0a35dc41fea67ac4495ce7584406bf9557a6e7d0 ]
It was observed that sending data via batadv over vxlan (on top of wireguard) reduced the performance massively compared to raw ethernet or batadv on raw ethernet. A check of perf data showed that the vxlan_build_skb was calling all the time pskb_expand_head to allocate enough headroom for:
min_headroom = LL_RESERVED_SPACE(dst->dev) + dst->header_len
+ VXLAN_HLEN + iphdr_len;
But the vxlan_config_apply only requested needed headroom for:
lowerdev->hard_header_len + VXLAN6_HEADROOM or VXLAN_HEADROOM
So it completely ignored the needed_headroom of the lower device. The first caller of net_dev_xmit could therefore never make sure that enough headroom was allocated for the rest of the transmit path.
--- drivers/net/vxlan.c | 1 + 1 file changed, 1 insertion(+)
drivers/net/vxlan.c +1 -0
@@ -3802,6 +3802,7 @@ static void vxlan_config_apply(struct net_device *dev, dev->gso_max_segs = lowerdev->gso_max_segs; needed_headroom = lowerdev->hard_header_len; + needed_headroom += lowerdev->needed_headroom; max_mtu = lowerdev->mtu - (use_ipv6 ?VXLAN6_HEADROOM :VXLAN_HEADROOM );
Signature · 1 line
2.27.0
Sasha Levin
maintainerPATCH 22/23 kbuild: avoid split lines in .mod files
In reply to Sasha LevinFrom: Masahiro Yamada <[email protected]>
[ Upstream commit 7d32358be8acb119dcfe39b6cf67ec6d94bf1fe7 ]
"xargs echo" is not a safe way to remove line breaks because the input may exceed the command line limit and xargs may break it up into multiple invocations of echo. This should never happen because scripts/gen_autoksyms.sh expects all undefined symbols are placed in the second line of .mod files.
One possible way is to replace "xargs echo" with
"sed ':x;N;$!bx;s/\n/ /g'" or something, but I rewrote the code by using awk because it is more readable.
This issue was reported by Sami Tolvanen; in his Clang LTO patch set, $(multi-used-m) is no longer an ELF object, but a thin archive that contains LLVM bitcode files. llvm-nm prints out symbols for each archive member separately, which results a lot of dupications, in some places, beyond the system-defined limit.
This problem must be fixed irrespective of LTO, and we must ensure zero possibility of having this issue.
--- scripts/Makefile.build | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-)
scripts/Makefile.build +4 -8
@@ -252,6 +252,9 @@ objtool_dep = $(objtool_obj) \ ifdef CONFIG_TRIM_UNUSED_KSYMS cmd_gen_ksymdeps = \ $(CONFIG_SHELL) $(srctree)/scripts/gen_ksymdeps.sh $@ >> $(dot-target).cmd + +# List module undefined symbols +undefined_syms = $(NM) $< | $(AWK) '$$1 == "U" { printf("%s%s", x++ ? " " : "", $$2) }'; endif define rule_cc_o_c
@@ -271,13 +274,6 @@ define rule_as_o_S $(call cmd,modversions_S) endef -# List module undefined symbols (or empty line if not enabled) -ifdef CONFIG_TRIM_UNUSED_KSYMS -cmd_undef_syms = $(NM) $< | sed -n 's/^ *U //p' | xargs echo -else -cmd_undef_syms = echo -endif - # Built-in and composite module parts $(obj)/%.o: $(src)/%.c $(recordmcount_source) $(objtool_dep) FORCE $(call if_changed_rule,cc_o_c)
@@ -285,7 +281,7 @@ $(obj)/%.o: $(src)/%.c $(recordmcount_source) $(objtool_dep) FORCE cmd_mod = { \ echo $(if $($*-objs)$($*-y)$($*-m), $(addprefix $(obj)/, $($*-objs) $($*-y) $($*-m)), $(@:.mod=.o)); \ - $(cmd_undef_syms); \ + $(undefined_syms) echo; \ } > $@ $(obj)/%.mod: $(obj)/%.o FORCE
Signature · 1 line
2.27.0
Sasha Levin
maintainerPATCH 11/23 habanalabs: put devices before driver removal
In reply to Sasha LevinFrom: Ofir Bitton <[email protected]>
[ Upstream commit 5555b7c56bdec7a29c789fec27f84d40f52fbdfa ]
Driver never puts its device and control_device objects, hence a memory leak is introduced every driver removal.
--- drivers/misc/habanalabs/common/device.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-)
drivers/misc/habanalabs/common/device.c +8 -8
@@ -227,16 +227,16 @@ delete_cdev_device:static void device_cdev_sysfs_del (struct hl_device *hdev) { -/* device_release() won't be called so must free devices explicitly */ -if (!hdev->cdev_sysfs_created) { -kfree (hdev->dev_ctrl); -kfree (hdev->dev); -return ; - } +if (!hdev->cdev_sysfs_created) + goto put_devices;hl_sysfs_fini (hdev);cdev_device_del (&hdev->cdev_ctrl, hdev->dev_ctrl);cdev_device_del (&hdev->cdev, hdev->dev); + +put_devices: +put_device (hdev->dev); +put_device (hdev->dev_ctrl); }/*
@@ -1362,9 +1362,9 @@ sw_fini: early_fini:device_early_fini (hdev); free_dev_ctrl: -kfree (hdev->dev_ctrl); +put_device (hdev->dev_ctrl); free_dev: -kfree (hdev->dev); +put_device (hdev->dev); out_disabled: hdev->disabled = true;if (add_cdev_sysfs_on_err)
Signature · 1 line
2.27.0
Sasha Levin
maintainerPATCH 15/23 scsi: storvsc: Validate length of incoming packet in storvsc_on_channel_callback()
In reply to Sasha LevinFrom: "Andrea Parri (Microsoft)" <[email protected]>
[ Upstream commit 3b8c72d076c42bf27284cda7b2b2b522810686f8 ]
Check that the packet is of the expected size at least, don't copy data past the packet.
--- drivers/scsi/storvsc_drv.c | 5 +++++ 1 file changed, 5 insertions(+)
drivers/scsi/storvsc_drv.c +5 -0
@@ -1246,6 +1246,11 @@ static void storvsc_on_channel_callback(void *context) request = (struct storvsc_cmd_request *) ((unsigned long )desc->trans_id); +if (hv_pkt_datalen (desc) <sizeof (struct vstor_packet ) - vmscsi_size_delta) { +dev_err (&device->device,"Invalid packet len\n" ); +continue ; + } +if (request == &stor_device->init_request || request == &stor_device->reset_request) { memcpy(&request->vstor_packet, packet,
Signature · 1 line
2.27.0
Sasha Levin
maintainerPATCH 16/23 scsi: mpt3sas: Increase IOCInit request timeout to 30s
In reply to Sasha LevinFrom: Sreekanth Reddy <[email protected]>
[ Upstream commit 85dad327d9b58b4c9ce08189a2707167de392d23 ]
Currently the IOCInit request message timeout is set to 10s. This is not sufficient in some scenarios such as during HBA FW downgrade operations.
Increase the IOCInit request timeout to 30s.
--- drivers/scsi/mpt3sas/mpt3sas_base.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/scsi/mpt3sas/mpt3sas_base.c +1 -1
@@ -6441,7 +6441,7 @@ _base_send_ioc_init(struct MPT3SAS_ADAPTER *ioc) r =_base_handshake_req_reply_wait (ioc,sizeof (Mpi2IOCInitRequest_t), (u32 *)&mpi_request, -sizeof (Mpi2IOCInitReply_t), (u16 *)&mpi_reply,10 ); +sizeof (Mpi2IOCInitReply_t), (u16 *)&mpi_reply,30 );if (r !=0 ) {ioc_err (ioc,"%s: handshake failed (r=%d)\n" , __func__, r);
Signature · 1 line
2.27.0
Sasha Levin
maintainerPATCH 18/23 iwlwifi: pcie: add one missing entry for AX210
In reply to Sasha LevinFrom: Luca Coelho <[email protected]>
[ Upstream commit 5febcdef30902fa870128b9789b873199f13aff1 ]
The 0x0024 subsytem device ID was missing from the list, so some AX210 devices were not recognized. Add it.
--- drivers/net/wireless/intel/iwlwifi/pcie/drv.c | 1 + 1 file changed, 1 insertion(+)
drivers/net/wireless/intel/iwlwifi/pcie/drv.c +1 -0
@@ -536,6 +536,7 @@ static const struct pci_device_id iwl_hw_card_ids[] = { {IWL_PCI_DEVICE(0x2725, 0x0090, iwlax211_2ax_cfg_so_gf_a0)}, {IWL_PCI_DEVICE(0x2725, 0x0020, iwlax210_2ax_cfg_ty_gf_a0)}, + {IWL_PCI_DEVICE(0x2725, 0x0024, iwlax210_2ax_cfg_ty_gf_a0)}, {IWL_PCI_DEVICE(0x2725, 0x0310, iwlax210_2ax_cfg_ty_gf_a0)}, {IWL_PCI_DEVICE(0x2725, 0x0510, iwlax210_2ax_cfg_ty_gf_a0)}, {IWL_PCI_DEVICE(0x2725, 0x0A10, iwlax210_2ax_cfg_ty_gf_a0)},
Signature · 1 line
2.27.0
Sasha Levin
maintainerPATCH 23/23 tools/testing/selftests/vm: fix build error
In reply to Sasha LevinFrom: Xingxing Su <[email protected]>
[ Upstream commit d8cbe8bfa7df3c680ddfd5e1eee3a5c86d8dc764 ]
Only x86 and PowerPC implement the pkey-xxx.h, and an error was reported when compiling protection_keys.c.
Add a Arch judgment to compile "protection_keys" in the Makefile.
If other arch implement this, add the arch name to the Makefile. eg:
ifneq (,$(findstring $(ARCH),powerpc mips ... ))
Following build errors:
pkey-helpers.h:93:2: error: #error Architecture not supported
#error Architecture not supported
pkey-helpers.h:96:20: error: `PKEY_DISABLE_ACCESS' undeclared
#define PKEY_MASK (PKEY_DISABLE_ACCESS | PKEY_DISABLE_WRITE)
^
protection_keys.c:218:45: error: `PKEY_DISABLE_WRITE' undeclared
pkey_assert(flags & (PKEY_DISABLE_ACCESS | PKEY_DISABLE_WRITE));
^
--- tools/testing/selftests/vm/Makefile | 4 ++++ 1 file changed, 4 insertions(+)
tools/testing/selftests/vm/Makefile +4 -0
@@ -43,9 +43,13 @@ ifeq ($(CAN_BUILD_X86_64),1) TEST_GEN_FILES += $(BINARIES_64) endif else + +ifneq (,$(findstring $(ARCH),powerpc)) TEST_GEN_FILES += protection_keys endif +endif + ifneq (,$(filter $(MACHINE),arm64 ia64 mips64 parisc64 ppc64 ppc64le riscv64 s390x sh64 sparc64 x86_64)) TEST_GEN_FILES += va_128TBswitch TEST_GEN_FILES += virtual_address_range
Signature · 1 line
2.27.0
Sasha Levin
maintainerPATCH 17/23 dm table: Remove BUG_ON(in_interrupt())
In reply to Sasha LevinFrom: Thomas Gleixner <[email protected]>
[ Upstream commit e7b624183d921b49ef0a96329f21647d38865ee9 ]
The BUG_ON(in_interrupt()) in dm_table_event() is a historic leftover from a rework of the dm table code which changed the calling context.
Issuing a BUG for a wrong calling context is frowned upon and in_interrupt() is deprecated and only covering parts of the wrong contexts. The sanity check for the context is covered by CONFIG_DEBUG_ATOMIC_SLEEP and other debug facilities already.
--- drivers/md/dm-table.c | 6 ------ 1 file changed, 6 deletions(-)
drivers/md/dm-table.c +0 -6
@@ -1298,12 +1298,6 @@ void dm_table_event_callback(struct dm_table *t,void dm_table_event (struct dm_table *t) { -/* -* You can no longer call dm_table_event() from interrupt -* context, use a bottom half instead. -*/ -BUG_ON (in_interrupt ()); -mutex_lock (&_event_lock);if (t->event_fn) t->event_fn (t->event_context);
Signature · 7 lines
2.27.0 -- dm-devel mailing list [email protected] https://www.redhat.com/mailman/listinfo/dm-devel
Sasha Levin
maintainerPATCH 19/23 iwlwifi: pcie: add some missing entries for AX210
In reply to Sasha LevinFrom: Golan Ben Ami <[email protected]>
[ Upstream commit 9b15596c5006d82b2f82810e8cbf80d8c6e7e7b4 ]
Some subsytem device IDs were missing from the list, so some AX210 devices were not recognized. Add them.
--- drivers/net/wireless/intel/iwlwifi/pcie/drv.c | 5 +++++ 1 file changed, 5 insertions(+)
drivers/net/wireless/intel/iwlwifi/pcie/drv.c +5 -0
@@ -540,6 +540,11 @@ static const struct pci_device_id iwl_hw_card_ids[] = { {IWL_PCI_DEVICE(0x2725, 0x0310, iwlax210_2ax_cfg_ty_gf_a0)}, {IWL_PCI_DEVICE(0x2725, 0x0510, iwlax210_2ax_cfg_ty_gf_a0)}, {IWL_PCI_DEVICE(0x2725, 0x0A10, iwlax210_2ax_cfg_ty_gf_a0)}, + {IWL_PCI_DEVICE(0x2725, 0xE020, iwlax210_2ax_cfg_ty_gf_a0)}, + {IWL_PCI_DEVICE(0x2725, 0xE024, iwlax210_2ax_cfg_ty_gf_a0)}, + {IWL_PCI_DEVICE(0x2725, 0x4020, iwlax210_2ax_cfg_ty_gf_a0)}, + {IWL_PCI_DEVICE(0x2725, 0x6020, iwlax210_2ax_cfg_ty_gf_a0)}, + {IWL_PCI_DEVICE(0x2725, 0x6024, iwlax210_2ax_cfg_ty_gf_a0)}, {IWL_PCI_DEVICE(0x2725, 0x00B0, iwlax411_2ax_cfg_sosnj_gf4_a0)}, {IWL_PCI_DEVICE(0x2726, 0x0090, iwlax211_cfg_snj_gf_a0)}, {IWL_PCI_DEVICE(0x2726, 0x00B0, iwlax411_2ax_cfg_sosnj_gf4_a0)},
Signature · 1 line
2.27.0
Sasha Levin
maintainerPATCH 21/23 perf/x86/intel: Check PEBS status correctly
In reply to Sasha LevinFrom: Stephane Eranian <[email protected]>
[ Upstream commit fc17db8aa4c53cbd2d5469bb0521ea0f0a6dbb27 ]
The kernel cannot disambiguate when 2+ PEBS counters overflow at the same time. This is what the comment for this code suggests. However, I see the comparison is done with the unfiltered p->status which is a copy of IA32_PERF_GLOBAL_STATUS at the time of the sample. This register contains more than the PEBS counter overflow bits. It also includes many other bits which could also be set.
--- arch/x86/events/intel/ds.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/events/intel/ds.c +1 -1
@@ -1913,7 +1913,7 @@ static void intel_pmu_drain_pebs_nhm(struct pt_regs *iregs)* that caused the PEBS record. It's called collision. * If collision happened, the record will be dropped. */ -if (p->status != (1ULL << bit)) { +if (pebs_status != (1ULL << bit)) {for_each_set_bit (i, (unsigned long *)&pebs_status, size) error[i]++;continue ;
Signature · 1 line
2.27.0
Sasha Levin
maintainerPATCH 9/23 selftests: tc-testing: enable CONFIG_NET_SCH_RED as a module
In reply to Sasha LevinFrom: Davide Caratti <[email protected]>
[ Upstream commit e14038a7ead09faa180eb072adc4a2157a0b475f ]
a proper kernel configuration for running kselftest can be obtained with:
$ yes | make kselftest-merge
enable compile support for the 'red' qdisc: otherwise, tdc kselftest fail when trying to run tdc test items contained in red.json.
--- tools/testing/selftests/tc-testing/config | 1 + 1 file changed, 1 insertion(+)
tools/testing/selftests/tc-testing/config +1 -0
@@ -59,6 +59,7 @@ CONFIG_NET_IFE_SKBPRIO=m CONFIG_NET_IFE_SKBTCINDEX=m CONFIG_NET_SCH_FIFO=y CONFIG_NET_SCH_ETS=m +CONFIG_NET_SCH_RED=m # ## Network testing
Signature · 1 line
2.27.0
Sasha Levin
maintainerPATCH 14/23 vxlan: Copy needed_tailroom from lowerdev
In reply to Sasha LevinFrom: Sven Eckelmann <[email protected]>
[ Upstream commit a5e74021e84bb5eadf760aaf2c583304f02269be ]
While vxlan doesn't need any extra tailroom, the lowerdev might need it. In that case, copy it over to reduce the chance for additional (re)allocations in the transmit path.
--- drivers/net/vxlan.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/net/vxlan.c +2 -0
@@ -3804,6 +3804,8 @@ static void vxlan_config_apply(struct net_device *dev, needed_headroom = lowerdev->hard_header_len; needed_headroom += lowerdev->needed_headroom; + dev->needed_tailroom = lowerdev->needed_tailroom; + max_mtu = lowerdev->mtu - (use_ipv6 ?VXLAN6_HEADROOM :VXLAN_HEADROOM );if (max_mtu <ETH_MIN_MTU )
Signature · 1 line
2.27.0
Re: [PATCH AUTOSEL 5.9 15/23] scsi: storvsc: Validate length of incoming packet in storvsc_on_channel_callback()
In reply to Sasha LevinHi Sasha,
Quoted 3 lines · Sasha Levin
From: "Andrea Parri (Microsoft)" <[email protected]>
[ Upstream commit
3b8c72d076c42bf27284cda7b2b2b522810686f8]
FYI, we found that this commit introduced a regression and posted a revert:
https://lkml.kernel.org/r/[email protected]
Same comment for the AUTOSEL 5.4, 4.19 and 4.14 you've just posted.
Andrea
Quoted 35 lines
Check that the packet is of the expected size at least, don't copy data past the packet.
Cc "James E.J. Bottomley" <[email protected]>Cc "Martin K. Petersen" <[email protected]>Reported-by Saruhan Karademir <[email protected]>Signed-off-by Andrea Parri (Microsoft) <[email protected]>Signed-off-by Martin K. Petersen <[email protected]>Signed-off-by Sasha Levin <[email protected]>--- drivers/scsi/storvsc_drv.c | 5 +++++ 1 file changed, 5 insertions(+)drivers/scsi/storvsc_drv.c +5
-0@@ -1246,6 +1246,11 @@ static void storvsc_on_channel_callback(void *context) request = (struct storvsc_cmd_request *) ((unsigned long )desc->trans_id); +if (hv_pkt_datalen (desc) <sizeof (struct vstor_packet ) - vmscsi_size_delta) { +dev_err (&device->device,"Invalid packet len\n" ); +continue ; + } +if (request == &stor_device->init_request || request == &stor_device->reset_request) { memcpy(&request->vstor_packet, packet,Signature · 1 line
2.27.0
Sasha Levin
maintainerRe: [PATCH AUTOSEL 5.9 15/23] scsi: storvsc: Validate length of incoming packet in storvsc_on_channel_callback()
Quoted 5 lines · Andrea Parri
Hi Sasha,
Quoted 2 lines · Sasha Levin
From: "Andrea Parri (Microsoft)" <[email protected]>
Quoted 8 lines
Quoted 1 line
[ Upstream commit
3b8c72d076c42bf27284cda7b2b2b522810686f8]FYI, we found that this commit introduced a regression and posted a revert:
https://lkml.kernel.org/r/[email protected]
Same comment for the AUTOSEL 5.4, 4.19 and 4.14 you've just posted.
I'll drop those, thanks!
Signature · 2 lines
Thanks, Sasha
Re: [PATCH AUTOSEL 5.9 15/23] scsi: storvsc: Validate length of incoming packet in storvsc_on_channel_callback()
In reply to Andrea ParriQuoted 5 lines · Andrea Parri
Hi Sasha,
Quoted 2 lines · Sasha Levin
From: "Andrea Parri (Microsoft)" <[email protected]>
Quoted 9 lines
Quoted 1 line
[ Upstream commit
3b8c72d076c42bf27284cda7b2b2b522810686f8]FYI, we found that this commit introduced a regression and posted a revert:
https://lkml.kernel.org/r/[email protected]
Same comment for the AUTOSEL 5.4, 4.19 and 4.14 you've just posted.
Konstantin, is there anyway we could make searching lore.kernel.org search all the mailing lists? Right now we can only search one mailing list at a time.
Part of the stable process should be to search lore.kernel.org for
But, unfortunately, git revert sets people up for failure by not including a fixes tag so we'd also have to search for:
This reverts commit 3b8c72d076c42bf27284cda7b2b2b522810686f8.
regards,
dan carpenter
Re: [PATCH AUTOSEL 5.9 15/23] scsi: storvsc: Validate length of incoming packet in storvsc_on_channel_callback()
Quoted 11 lines · Dan Carpenter
Quoted 10 lines · Andrea Parri
Hi Sasha,
Quoted 3 lines · Sasha Levin
From: "Andrea Parri (Microsoft)" <[email protected]>
[ Upstream commit
3b8c72d076c42bf27284cda7b2b2b522810686f8]FYI, we found that this commit introduced a regression and posted a revert:
Quoted 8 lines
Quoted 4 lines
https://lkml.kernel.org/r/[email protected]
Same comment for the AUTOSEL 5.4, 4.19 and 4.14 you've just posted.
Konstantin, is there anyway we could make searching lore.kernel.org search all the mailing lists? Right now we can only search one mailing list at a time.
This functionality is coming in the next version of public-inbox and should be available on lore.kernel.org within the next little while.
https://lore.kernel.org/workflows/20201201184814.GA32272@dcvr/
-K
Sasha Levin
maintainerRe: [PATCH AUTOSEL 5.9 15/23] scsi: storvsc: Validate length of incoming packet in storvsc_on_channel_callback()
Quoted 17 lines · Konstantin Ryabitsev
Quoted 16 lines · Dan Carpenter
Quoted 14 lines · Andrea Parri
Hi Sasha,
Quoted 3 lines · Sasha Levin
From: "Andrea Parri (Microsoft)" <[email protected]>
[ Upstream commit
3b8c72d076c42bf27284cda7b2b2b522810686f8]FYI, we found that this commit introduced a regression and posted a revert:
https://lkml.kernel.org/r/[email protected]
Same comment for the AUTOSEL 5.4, 4.19 and 4.14 you've just posted.
Quoted 6 lines
Quoted 3 lines
Konstantin, is there anyway we could make searching lore.kernel.org search all the mailing lists? Right now we can only search one mailing list at a time.
This functionality is coming in the next version of public-inbox and should be available on lore.kernel.org within the next little while.
That's a good idea Dan; I had something running on linux-next, but I guess it's not enough and cases such as these sneak in.
I wrote a script to do what you've suggested by simply cloning the repos on erol.kernel.org locally and then doing a simple search for the "Fixes:" and revert patterns.
Signature · 2 lines
Thanks, Sasha