Skip to contentSkip to conversation

tests/docker: Include 'ccache' in Debian base image

PATCH In review Philippe Mathieu-Daudé 3 participants 5 messages Dec 13, 2020 – Jan 5, 2021

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tests/docker: Include 'ccache' in Debian base image

Include the 'ccache' package to speed up compilation.

---
 tests/docker/dockerfiles/debian10.docker | 1 +
 1 file changed, 1 insertion(+)
tests/docker/dockerfiles/debian10.docker +1 -0
index 73a3caac9cd..9d42b5a4b81 100644
@@ -20,6 +20,7 @@ RUN apt update && \
         bc \
         build-essential \
         ca-certificates \
+        ccache \
         clang \
         dbus \
         gdb-multiarch \
Signature · 1 line
2.26.2
#1 lore raw
Quoted 12 lines · Philippe Mathieu-Daudé

Include the 'ccache' package to speed up compilation.

---
 tests/docker/dockerfiles/debian10.docker | 1 +
 1 file changed, 1 insertion(+)
tests/docker/dockerfiles/debian10.docker +0 -0
index 73a3caac9cd..9d42b5a4b81 100644

tests/docker/dockerfiles/debian10.docker RUN apt update && \ · line 26

Quoted 7 lines
tests/docker/dockerfiles/debian10.docker +1 -0
@@ -20,6 +20,7 @@ RUN apt update && \
         bc \
         build-essential \
         ca-certificates \
+        ccache \
         clang \
         dbus \
         gdb-multiarch \

Don't you need some additional setup for this? Like caching the corresponding directory during CI runs?

Thomas

#2 lore raw

Hi Thomas,

Quoted 8 lines · Thomas Huth
Quoted 7 lines · Philippe Mathieu-Daudé

Include the 'ccache' package to speed up compilation.

---
 tests/docker/dockerfiles/debian10.docker | 1 +
 1 file changed, 1 insertion(+)
Quoted 15 lines

tests/docker/dockerfiles/debian10.docker RUN apt update && \ · line 26

Quoted 12 lines
tests/docker/dockerfiles/debian10.docker +1 -0
index 73a3caac9cd..9d42b5a4b81 100644
@@ -20,6 +20,7 @@ RUN apt update && \
         bc \
         build-essential \
         ca-certificates \
+        ccache \
         clang \
         dbus \
         gdb-multiarch \

Don't you need some additional setup for this? Like caching the corresponding directory during CI runs?

I hadn't looked at CI (too many CI series in fly).

w.r.t. Docker this is in use since 4 years, see:
324027c24cd ("Makefile: Rules for docker testing") 36ac78e65a0 ("docker: Don't mount ccache db if NOUSER=1")

I suppose we forgot the package when introducing debian10 base image in commit d6db2a1cdf6 ("docker: add debian-buster-arm64-cross").

Regards,

Phil.

#3 lore raw

Hi,

Quoted 27 lines · Philippe Mathieu-Daudé
Quoted 8 lines · Thomas Huth
Quoted 7 lines · Philippe Mathieu-Daudé

Include the 'ccache' package to speed up compilation.

---
 tests/docker/dockerfiles/debian10.docker | 1 +
 1 file changed, 1 insertion(+)
Quoted 15 lines

tests/docker/dockerfiles/debian10.docker RUN apt update && \ · line 26

Quoted 12 lines
tests/docker/dockerfiles/debian10.docker +1 -0
index 73a3caac9cd..9d42b5a4b81 100644
@@ -20,6 +20,7 @@ RUN apt update && \
         bc \
         build-essential \
         ca-certificates \
+        ccache \
         clang \
         dbus \
         gdb-multiarch \

Don't you need some additional setup for this? Like caching the corresponding directory during CI runs?

I hadn't looked at CI (too many CI series in fly).

Quoted 7 lines

w.r.t. Docker this is in use since 4 years, see:
324027c24cd ("Makefile: Rules for docker testing") 36ac78e65a0 ("docker: Don't mount ccache db if NOUSER=1")

I suppose we forgot the package when introducing debian10 base image in commit d6db2a1cdf6 ("docker: add debian-buster-arm64-cross").

Should I do something else with this patch?

Thanks,

Phil.

#4 lore raw
Quoted 34 lines · Philippe Mathieu-Daudé

Hi,

Quoted 31 lines · Philippe Mathieu-Daudé
Quoted 8 lines · Thomas Huth
Quoted 7 lines · Philippe Mathieu-Daudé

Include the 'ccache' package to speed up compilation.

---
 tests/docker/dockerfiles/debian10.docker | 1 +
 1 file changed, 1 insertion(+)
Quoted 15 lines

tests/docker/dockerfiles/debian10.docker RUN apt update && \ · line 26

Quoted 12 lines
tests/docker/dockerfiles/debian10.docker +1 -0
index 73a3caac9cd..9d42b5a4b81 100644
@@ -20,6 +20,7 @@ RUN apt update && \
         bc \
         build-essential \
         ca-certificates \
+        ccache \
         clang \
         dbus \
         gdb-multiarch \

Don't you need some additional setup for this? Like caching the corresponding directory during CI runs?

I hadn't looked at CI (too many CI series in fly).

w.r.t. Docker this is in use since 4 years, see:
324027c24cd ("Makefile: Rules for docker testing") 36ac78e65a0 ("docker: Don't mount ccache db if NOUSER=1")

Quoted 5 lines
Quoted 3 lines

I suppose we forgot the package when introducing debian10 base image in commit d6db2a1cdf6 ("docker: add debian-buster-arm64-cross").

Should I do something else with this patch?

Queued to testing/next, thanks.

Signature · 1 line
Alex Bennée