Skip to contentSkip to conversation

selftests/vm: Fix building protection keys test

PATCH Superseded Harish 2 participants 2 messages Dec 14, 2020 Kselftest

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Harish

author
#0 lore raw

PATCH 1/1 selftests/vm: Fix building protection keys test

The previous patch tries to include a arch check for powerpc using findstring, which prevents test from building on powerpc arch. Fix this with filtering using machine type.

---
 tools/testing/selftests/vm/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/testing/selftests/vm/Makefile +1 -1
index 691893afc15d..0dc632cdbc73 100644
@@ -61,7 +61,7 @@ TEST_GEN_FILES += $(BINARIES_64)
 endif
 else
 
-ifneq (,$(findstring $(ARCH),powerpc))
+ifneq (,$(filter $(MACHINE),ppc64 ppc64le))
 TEST_GEN_FILES += protection_keys
 endif
 
Signature · 1 line
2.26.2
#1 lore raw
Quoted 1 line · On Mon, 14 Dec 2020 22:09:51 +0530 Harish <[email protected]> wrote:

The previous patch

d8cbe8bfa7d ("tools/testing/selftests/vm: fix build error"), yes?

Quoted 2 lines

tries to include a arch check for powerpc using findstring, which prevents test from building on powerpc arch.

Why is that? Please describe the error fully. Presumably by pasting the error messages?

Quoted 2 lines

Fix
this with filtering using machine type.

How does this fix whatever-the-problem-was?

Presumably the 5.10 build fails under some circumstances, yes? In which case a Fixes: line and a cc:[email protected] are needed.

Quoted 20 lines
---
 tools/testing/selftests/vm/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/testing/selftests/vm/Makefile +1 -1
index 691893afc15d..0dc632cdbc73 100644
@@ -61,7 +61,7 @@ TEST_GEN_FILES += $(BINARIES_64)
 endif
 else
 
-ifneq (,$(findstring $(ARCH),powerpc))
+ifneq (,$(filter $(MACHINE),ppc64 ppc64le))
 TEST_GEN_FILES += protection_keys
 endif
 
Signature · 1 line
2.26.2