Skip to contentSkip to conversation

arm64: dts: qcom: sc7180: Drop pinconf on dp_hot_plug_det

PATCH Applied Stephen Boyd 3 participants 3 messages Dec 15, 2020 – Dec 29, 2020

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm64: dts: qcom: sc7180: Drop pinconf on dp_hot_plug_det

We shouldn't put any pinconf here in case someone decides to invert this HPD signal or remove an external pull-down. It's better to leave that to the board pinconf nodes, so drop it here.

Cc Tanmay Shah <[email protected]>
Fixes 681a607ad21a ("arm64: dts: qcom: sc7180: Add DisplayPort HPD pin dt node")
---
 arch/arm64/boot/dts/qcom/sc7180.dtsi | 6 ------
 1 file changed, 6 deletions(-)
arch/arm64/boot/dts/qcom/sc7180.dtsi +0 -6
index 22b832fc62e3..268fa40a1774 100644
@@ -1468,12 +1468,6 @@ pinmux {
 					pins = "gpio117";
 					function = "dp_hot";
 				};
-
-				pinconf {
-					pins = "gpio117";
-					bias-disable;
-					input-enable;
-				};
 			};
 
 			qspi_clk: qspi-clk {
Signature · 1 line
https://chromeos.dev
Reviewed-by on v1 1/1
#1 lore raw

Hi,

Quoted 5 lines · Stephen Boyd

We shouldn't put any pinconf here in case someone decides to invert this HPD signal or remove an external pull-down. It's better to leave that to the board pinconf nodes, so drop it here.

Quoted 7 lines
Cc Tanmay Shah <[email protected]>
Fixes 681a607ad21a ("arm64: dts: qcom: sc7180: Add DisplayPort HPD pin dt node")
---
 arch/arm64/boot/dts/qcom/sc7180.dtsi | 6 ------
 1 file changed, 6 deletions(-)
#2 lore raw
In reply to Stephen Boyd
This patch was applied to qcom/linux.git (refs/heads/for-next):

Hello:

This patch was applied to qcom/linux.git (refs/heads/for-next):

Quoted 10 lines · On Mon, 14 Dec 2020 18:00:04 -0800 you wrote:

We shouldn't put any pinconf here in case someone decides to invert this HPD signal or remove an external pull-down. It's better to leave that to the board pinconf nodes, so drop it here.

Cc Tanmay Shah <[email protected]>
Fixes 681a607ad21a ("arm64: dts: qcom: sc7180: Add DisplayPort HPD pin dt node")

[...]

Here is the summary with links:
- arm64: dts: qcom: sc7180: Drop pinconf on dp_hot_plug_det

    https://git.kernel.org/qcom/c/8d079bf20410

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html