Skip to contentSkip to conversation

greybus: remove h from printk format specifier

PATCH In review [email protected] 2 participants 2 messages Dec 15, 2020 Greybus

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 greybus: remove h from printk format specifier

From: Tom Rix <[email protected]>

See Documentation/core-api/printk-formats.rst.
h should no longer be used in the format specifier for printk.

---
 drivers/greybus/greybus_trace.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/greybus/greybus_trace.h +3 -3
index 1bc9f1275c65..616a3bd61aa6 100644
@@ -40,7 +40,7 @@ DECLARE_EVENT_CLASS(gb_message,
 		__entry->result = message->header->result;
 	),
 
-	TP_printk("size=%hu operation_id=0x%04x type=0x%02x result=0x%02x",
+	TP_printk("size=%u operation_id=0x%04x type=0x%02x result=0x%02x",
 		  __entry->size, __entry->operation_id,
 		  __entry->type, __entry->result)
 );
@@ -317,7 +317,7 @@ DECLARE_EVENT_CLASS(gb_interface,
 		__entry->mode_switch = intf->mode_switch;
 	),
 
-	TP_printk("intf_id=%hhu device_id=%hhu module_id=%hhu D=%d J=%d A=%d E=%d M=%d",
+	TP_printk("intf_id=%u device_id=%u module_id=%u D=%d J=%d A=%d E=%d M=%d",
 		__entry->id, __entry->device_id, __entry->module_id,
 		__entry->disconnected, __entry->ejected, __entry->active,
 		__entry->enabled, __entry->mode_switch)
@@ -391,7 +391,7 @@ DECLARE_EVENT_CLASS(gb_module,
 		__entry->disconnected = module->disconnected;
 	),
 
-	TP_printk("hd_bus_id=%d module_id=%hhu num_interfaces=%zu disconnected=%d",
+	TP_printk("hd_bus_id=%d module_id=%u num_interfaces=%zu disconnected=%d",
 		__entry->hd_bus_id, __entry->module_id,
 		__entry->num_interfaces, __entry->disconnected)
 );
Signature · 1 line
2.27.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 6 lines · On 12/15/20 8:53 AM, [email protected] wrote:

From: Tom Rix <[email protected]>

See Documentation/core-api/printk-formats.rst.
h should no longer be used in the format specifier for printk.

Looks good.

Quoted 36 lines
---
  drivers/greybus/greybus_trace.h | 6 +++---
  1 file changed, 3 insertions(+), 3 deletions(-)
drivers/greybus/greybus_trace.h +3 -3
index 1bc9f1275c65..616a3bd61aa6 100644
@@ -40,7 +40,7 @@ DECLARE_EVENT_CLASS(gb_message,
  		__entry->result = message->header->result;
  	),
 
-	TP_printk("size=%hu operation_id=0x%04x type=0x%02x result=0x%02x",
+	TP_printk("size=%u operation_id=0x%04x type=0x%02x result=0x%02x",
  		  __entry->size, __entry->operation_id,
  		  __entry->type, __entry->result)
  );
@@ -317,7 +317,7 @@ DECLARE_EVENT_CLASS(gb_interface,
  		__entry->mode_switch = intf->mode_switch;
  	),
 
-	TP_printk("intf_id=%hhu device_id=%hhu module_id=%hhu D=%d J=%d A=%d E=%d M=%d",
+	TP_printk("intf_id=%u device_id=%u module_id=%u D=%d J=%d A=%d E=%d M=%d",
  		__entry->id, __entry->device_id, __entry->module_id,
  		__entry->disconnected, __entry->ejected, __entry->active,
  		__entry->enabled, __entry->mode_switch)
@@ -391,7 +391,7 @@ DECLARE_EVENT_CLASS(gb_module,
  		__entry->disconnected = module->disconnected;
  	),
 
-	TP_printk("hd_bus_id=%d module_id=%hhu num_interfaces=%zu disconnected=%d",
+	TP_printk("hd_bus_id=%d module_id=%u num_interfaces=%zu disconnected=%d",
  		__entry->hd_bus_id, __entry->module_id,
  		__entry->num_interfaces, __entry->disconnected)
  );