selftests-vm-only-some-gup_test-items-are-really-benchmarks.patch removed from -mm tree
The patch titled
Subject: selftests/vm: only some gup_test items are really benchmarks
has been removed from the -mm tree. Its filename was
selftests-vm-only-some-gup_test-items-are-really-benchmarks.patch
This patch was dropped because it was merged into mainline or a subsystem tree
------------------------------------------------------
From: John Hubbard <[email protected]>
Subject: selftests/vm: only some gup_test items are really benchmarks
Therefore, some minor cleanup and improvements are in order:
1. Rename the other items appropriately.
2. Stop reporting timing information on the non-benchmark items. It's still being recorded and is available, but there's no point in cluttering up the report with data that no one reasonably needs to check.
3. Don't do iterations, for non-benchmark items.
4. Print out a shorter, more appropriate report for the non-benchmark tests.
5. Add the command that was run, to the report. This really helps, as there are quite a lot of options now.
6. Use a larger integer type for cmd, now that it's being compared Otherwise it doesn't work, because in this case cmd is about 3 billion, which is the perfect size for problems with signed vs unsigned int.
---
Documentation/core-api/pin_user_pages.rst | 2 mm/gup_test.c | 14 ++--- mm/gup_test.h | 8 +-- tools/testing/selftests/vm/gup_test.c | 47 ++++++++++++++++---- 4 files changed, 51 insertions(+), 20 deletions(-)
Documentation/core-api/pin_user_pages.rst renamed from Documentation/core-api/pin_user_pages.rst~selftests-vm-only-some-gup_test-items-are-really-benchmarks +1 -1
@@ -226,7 +226,7 @@ This file:: has the following new calls to exercise the new pin*() wrapper functions: * PIN_FAST_BENCHMARK (./gup_test -a) -* PIN_BENCHMARK (./gup_test -b) +* PIN_BASIC_TEST (./gup_test -b) You can monitor how many total dma-pinned pages have been acquired and released since the system was booted, via two new /proc/vmstat entries: ::
mm/gup_test.c renamed from mm/gup_test.c~selftests-vm-only-some-gup_test-items-are-really-benchmarks +7 -7
@@ -13,13 +13,13 @@ static void put_back_pages(unsigned intswitch (cmd) {case GUP_FAST_BENCHMARK : -case GUP_BENCHMARK : +case GUP_BASIC_TEST :for (i =0 ; i < nr_pages; i++)put_page (pages[i]);break ;case PIN_FAST_BENCHMARK : -case PIN_BENCHMARK : +case PIN_BASIC_TEST :case PIN_LONGTERM_BENCHMARK :unpin_user_pages (pages, nr_pages);break ;
@@ -34,7 +34,7 @@ static void verify_dma_pinned(unsigned iswitch (cmd) {case PIN_FAST_BENCHMARK : -case PIN_BENCHMARK : +case PIN_BASIC_TEST :case PIN_LONGTERM_BENCHMARK :for (i =0 ; i < nr_pages; i++) { page = pages[i];
@@ -94,7 +94,7 @@ static int __gup_test_ioctl(unsigned int nr =get_user_pages_fast (addr, nr, gup->flags, pages + i);break ; -case GUP_BENCHMARK : +case GUP_BASIC_TEST : nr =get_user_pages (addr, nr, gup->flags, pages + i,NULL );break ;
@@ -102,7 +102,7 @@ static int __gup_test_ioctl(unsigned int nr =pin_user_pages_fast (addr, nr, gup->flags, pages + i);break ; -case PIN_BENCHMARK : +case PIN_BASIC_TEST : nr =pin_user_pages (addr, nr, gup->flags, pages + i,NULL );break ;
@@ -157,10 +157,10 @@ static long gup_test_ioctl(struct file *switch (cmd) {case GUP_FAST_BENCHMARK : -case GUP_BENCHMARK :case PIN_FAST_BENCHMARK : -case PIN_BENCHMARK :case PIN_LONGTERM_BENCHMARK : +case GUP_BASIC_TEST : +case PIN_BASIC_TEST :break ;default :return -EINVAL ;
mm/gup_test.h renamed from mm/gup_test.h~selftests-vm-only-some-gup_test-items-are-really-benchmarks +4 -4
@@ -5,10 +5,10 @@#include <linux/types.h> #define GUP_FAST_BENCHMARK _IOWR('g', 1, struct gup_test) -#define GUP_BENCHMARK _IOWR('g', 2, struct gup_test) -#define PIN_FAST_BENCHMARK _IOWR('g', 3, struct gup_test) -#define PIN_BENCHMARK _IOWR('g', 4, struct gup_test) -#define PIN_LONGTERM_BENCHMARK _IOWR('g', 5, struct gup_test) +#define PIN_FAST_BENCHMARK _IOWR('g', 2, struct gup_test) +#define PIN_LONGTERM_BENCHMARK _IOWR('g', 3, struct gup_test) +#define GUP_BASIC_TEST _IOWR('g', 4, struct gup_test) +#define PIN_BASIC_TEST _IOWR('g', 5, struct gup_test)struct gup_test {__u64 get_delta_usec;
tools/testing/selftests/vm/gup_test.c renamed from tools/testing/selftests/vm/gup_test.c~selftests-vm-only-some-gup_test-items-are-really-benchmarks +39 -8
83 lines not on this page · raw message
_
Patches currently in -mm which might be from [email protected] are
secretmem-test-add-basic-selftest-for-memfd_secret2-fix.patch