PM / devfreq: Replace devfreq->dev.parent as dev in devfreq_add_device

PATCH Applied pierre Kuo 2 participants 3 messages Dec 16, 2020 – Jan 5, 2021 Device frequency (devfreq)

lore

Share & tools

lore

pierre Kuo

author

2020-12-16 02:26 UTC #0 lore raw

PATCH 1/1 PM / devfreq: Replace devfreq->dev.parent as dev in devfreq_add_device

In devfreq_add_device, replace devfreq->dev.parent as dev to keep code simple.

Signed-off-by pierre Kuo <[email protected]>

---
 drivers/devfreq/devfreq.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

drivers/devfreq/devfreq.c +2 -2

index 6aa10de792b3..94cc25fd68da 100644
@@ -893,13 +893,13 @@ struct devfreq *devfreq_add_device(struct device *dev,
 		goto err_devfreq;
 
 	devfreq->nb_min.notifier_call = qos_min_notifier_call;
-	err = dev_pm_qos_add_notifier(devfreq->dev.parent, &devfreq->nb_min,
+	err = dev_pm_qos_add_notifier(dev, &devfreq->nb_min,
 				      DEV_PM_QOS_MIN_FREQUENCY);
 	if (err)
 		goto err_devfreq;
 
 	devfreq->nb_max.notifier_call = qos_max_notifier_call;
-	err = dev_pm_qos_add_notifier(devfreq->dev.parent, &devfreq->nb_max,
+	err = dev_pm_qos_add_notifier(dev, &devfreq->nb_max,
 				      DEV_PM_QOS_MAX_FREQUENCY);
 	if (err)
 		goto err_devfreq;

Signature · 1 line

2.17.1

pierre kuo

author

2020-12-28 15:23 UTC #1 lore raw

Hi myungjoo, kyungmin and cw:
Would you please help to review this patch?

Thanks a lot.

pierre Kuo <[email protected]> 於 2020年12月16日週三上午10:26寫道：

Quoted 32 lines

In devfreq_add_device, replace devfreq->dev.parent as dev to keep code simple.

Signed-off-by pierre Kuo <[email protected]>

---
 drivers/devfreq/devfreq.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

drivers/devfreq/devfreq.c +2 -3

index 6aa10de792b3..94cc25fd68da 100644
@@ -893,13 +893,13 @@ struct devfreq *devfreq_add_device(struct device *dev,
                goto err_devfreq;
 
        devfreq->nb_min.notifier_call = qos_min_notifier_call;
-       err = dev_pm_qos_add_notifier(devfreq->dev.parent, &devfreq->nb_min,
+       err = dev_pm_qos_add_notifier(dev, &devfreq->nb_min,
                                      DEV_PM_QOS_MIN_FREQUENCY);
        if (err)
                goto err_devfreq;
 
        devfreq->nb_max.notifier_call = qos_max_notifier_call;
-       err = dev_pm_qos_add_notifier(devfreq->dev.parent, &devfreq->nb_max,
+       err = dev_pm_qos_add_notifier(dev, &devfreq->nb_max,
                                      DEV_PM_QOS_MAX_FREQUENCY);
        if (err)
                goto err_devfreq;
--

2.17.1

Chanwoo Choi

Applied

2021-01-05 01:05 UTC #2 lore raw

Quoted 30 lines · pierre kuo

Hi myungjoo, kyungmin and cw:
Would you please help to review this patch?

Thanks a lot.

pierre Kuo <[email protected]> 於 2020年12月16日週三上午10:26寫道：

Quoted 23 lines

In devfreq_add_device, replace devfreq->dev.parent as dev to keep code simple.

Signed-off-by pierre Kuo <[email protected]>

---
 drivers/devfreq/devfreq.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

drivers/devfreq/devfreq.c +1 -1

index 6aa10de792b3..94cc25fd68da 100644
@@ -893,13 +893,13 @@ struct devfreq *devfreq_add_device(struct device *dev,
                goto err_devfreq;
 
        devfreq->nb_min.notifier_call = qos_min_notifier_call;
-       err = dev_pm_qos_add_notifier(devfreq->dev.parent, &devfreq->nb_min,
+       err = dev_pm_qos_add_notifier(dev, &devfreq->nb_min,
                                      DEV_PM_QOS_MIN_FREQUENCY);
        if (err)
                goto err_devfreq;

Quoted 9 lines

drivers/devfreq/devfreq.c +1 -2

        devfreq->nb_max.notifier_call = qos_max_notifier_call;
-       err = dev_pm_qos_add_notifier(devfreq->dev.parent, &devfreq->nb_max,
+       err = dev_pm_qos_add_notifier(dev, &devfreq->nb_max,
                                      DEV_PM_QOS_MAX_FREQUENCY);
        if (err)
                goto err_devfreq;
--

2.17.1

Applied it. Thanks.

Signature · 2 lines

Best Regards,
Chanwoo Choi