Skip to contentSkip to conversation

tests: update for rename of CentOS8 PowerTools repo

PATCH In review Daniel P. Berrangé 5 participants 6 messages Dec 16, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tests: update for rename of CentOS8 PowerTools repo

This was intentionally renamed recently to be all lowercase:

https://bugs.centos.org/view.php?id=17920
https://wiki.centos.org/Manuals/ReleaseNotes/CentOS8.2011#Yum_repo_file_and_repoid_changes

---

This needs to be merged asap, as CI will break for anyone whose branch triggers a rebuild of the centos container image.

eg current broken git master:

https://gitlab.com/berrange/qemu/-/jobs/915852165

vs with this fix

https://gitlab.com/berrange/qemu/-/jobs/915862731

 tests/docker/dockerfiles/centos8.docker | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tests/docker/dockerfiles/centos8.docker +1 -1
index 54bc6d54cd..06b67962fd 100644
@@ -31,6 +31,6 @@ ENV PACKAGES \
     zlib-devel
 
 RUN dnf install -y dnf-plugins-core && \
-  dnf config-manager --set-enabled PowerTools && \
+  dnf config-manager --set-enabled powertools && \
   dnf install -y $PACKAGES
 RUN rpm -q $PACKAGES | sort > /packages.txt
Signature · 1 line
2.29.2
Reviewed-by on v1 1/1
#1 lore raw
Quoted 14 lines · Daniel P. Berrangé

This was intentionally renamed recently to be all lowercase:

https://bugs.centos.org/view.php?id=17920
https://wiki.centos.org/Manuals/ReleaseNotes/CentOS8.2011#Yum_repo_file_and_repoid_changes

---

This needs to be merged asap, as CI will break for anyone whose branch triggers a rebuild of the centos container image.

eg current broken git master:

Quoted 9 lines

https://gitlab.com/berrange/qemu/-/jobs/915852165

vs with this fix

https://gitlab.com/berrange/qemu/-/jobs/915862731

 tests/docker/dockerfiles/centos8.docker | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
#2 lore raw
In reply to Daniel P. Berrangé
Quoted 28 lines · Daniel P. Berrangé

This was intentionally renamed recently to be all lowercase:

https://bugs.centos.org/view.php?id=17920
https://wiki.centos.org/Manuals/ReleaseNotes/CentOS8.2011#Yum_repo_file_and_repoid_changes

---

This needs to be merged asap, as CI will break for anyone whose branch triggers a rebuild of the centos container image.

eg current broken git master:

https://gitlab.com/berrange/qemu/-/jobs/915852165

vs with this fix

https://gitlab.com/berrange/qemu/-/jobs/915862731

 tests/docker/dockerfiles/centos8.docker | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tests/docker/dockerfiles/centos8.docker +0 -0
index 54bc6d54cd..06b67962fd 100644

tests/docker/dockerfiles/centos8.docker ENV PACKAGES \ · line 36

Quoted 7 lines
tests/docker/dockerfiles/centos8.docker +1 -1
@@ -31,6 +31,6 @@ ENV PACKAGES \
     zlib-devel
 
 RUN dnf install -y dnf-plugins-core && \
-  dnf config-manager --set-enabled PowerTools && \
+  dnf config-manager --set-enabled powertools && \
   dnf install -y $PACKAGES
 RUN rpm -q $PACKAGES | sort > /packages.txt

I tried a test merge of this but it fails in Gitlab CI:

https://gitlab.com/qemu-project/qemu/-/jobs/916041167

#6 7.706 Error: No matching repo to modify: powertools.
#6 ERROR: executor failed running [/bin/sh -c dnf install -y dnf-plugins-core && dnf config-manager --set-enabled powertools && dnf install -y $PACKAGES]: exit code: 1

thanks
-- PMM

#5 lore raw
In reply to Daniel P. Berrangé
Quoted 10 lines · Daniel P. Berrangé

This was intentionally renamed recently to be all lowercase:

https://bugs.centos.org/view.php?id=17920
https://wiki.centos.org/Manuals/ReleaseNotes/CentOS8.2011#Yum_repo_file_and_repoid_changes

---

This needs to be merged asap, as CI will break for anyone whose branch triggers a rebuild of the centos container image.

Your in luck, Queued to pr/161220-testing-1, thanks.

Quoted 24 lines

eg current broken git master:

https://gitlab.com/berrange/qemu/-/jobs/915852165

vs with this fix

https://gitlab.com/berrange/qemu/-/jobs/915862731

 tests/docker/dockerfiles/centos8.docker | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tests/docker/dockerfiles/centos8.docker +1 -1
index 54bc6d54cd..06b67962fd 100644
@@ -31,6 +31,6 @@ ENV PACKAGES \
     zlib-devel
 
 RUN dnf install -y dnf-plugins-core && \
-  dnf config-manager --set-enabled PowerTools && \
+  dnf config-manager --set-enabled powertools && \
   dnf install -y $PACKAGES
 RUN rpm -q $PACKAGES | sort > /packages.txt
Signature · 1 line
Alex Bennée
#3 lore raw
In reply to Peter Maydell
Quoted 39 lines · Peter Maydell
Quoted 28 lines · Daniel P. Berrangé

This was intentionally renamed recently to be all lowercase:

https://bugs.centos.org/view.php?id=17920
https://wiki.centos.org/Manuals/ReleaseNotes/CentOS8.2011#Yum_repo_file_and_repoid_changes

---

This needs to be merged asap, as CI will break for anyone whose branch triggers a rebuild of the centos container image.

eg current broken git master:

https://gitlab.com/berrange/qemu/-/jobs/915852165

vs with this fix

https://gitlab.com/berrange/qemu/-/jobs/915862731

 tests/docker/dockerfiles/centos8.docker | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tests/docker/dockerfiles/centos8.docker +0 -0
index 54bc6d54cd..06b67962fd 100644

tests/docker/dockerfiles/centos8.docker ENV PACKAGES \ · line 36

Quoted 7 lines
tests/docker/dockerfiles/centos8.docker +1 -1
@@ -31,6 +31,6 @@ ENV PACKAGES \
     zlib-devel
 
 RUN dnf install -y dnf-plugins-core && \
-  dnf config-manager --set-enabled PowerTools && \
+  dnf config-manager --set-enabled powertools && \
   dnf install -y $PACKAGES
 RUN rpm -q $PACKAGES | sort > /packages.txt

I tried a test merge of this but it fails in Gitlab CI:

Quoted 6 lines

https://gitlab.com/qemu-project/qemu/-/jobs/916041167

#6 7.706 Error: No matching repo to modify: powertools.
#6 ERROR: executor failed running [/bin/sh -c dnf install -y dnf-plugins-core && dnf config-manager --set-enabled powertools && dnf install -y $PACKAGES]: exit code: 1

#4 [1/4] FROM docker.io/library/centos:8.1.1911@sha256:fe8d824220415eed5477... #4 DONE 0.0s

#5 [2/4] RUN dnf -y update
#5 CACHED

Looks like in the main repo, it is using cached container layer for the "dnf -y update" command, and so not pulling in the new centos-release package.

In forks where the cache is not valid, it'll really run the "dnf update" command and see the failure.

I think if you go to

https://gitlab.com/qemu-project/qemu/container_registry

and delete the currently cached centos8 image, then all subsequent runs will fail until this patch is merged.

Regards,
Daniel

Signature · 3 lines
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|
#4 lore raw
In reply to Peter Maydell
Quoted 39 lines · Peter Maydell
Quoted 28 lines · Daniel P. Berrangé

This was intentionally renamed recently to be all lowercase:

https://bugs.centos.org/view.php?id=17920
https://wiki.centos.org/Manuals/ReleaseNotes/CentOS8.2011#Yum_repo_file_and_repoid_changes

---

This needs to be merged asap, as CI will break for anyone whose branch triggers a rebuild of the centos container image.

eg current broken git master:

   https://gitlab.com/berrange/qemu/-/jobs/915852165

vs with this fix

   https://gitlab.com/berrange/qemu/-/jobs/915862731
  tests/docker/dockerfiles/centos8.docker | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
tests/docker/dockerfiles/centos8.docker +0 -0
index 54bc6d54cd..06b67962fd 100644

tests/docker/dockerfiles/centos8.docker ENV PACKAGES \ · line 36

Quoted 7 lines
tests/docker/dockerfiles/centos8.docker +1 -1
@@ -31,6 +31,6 @@ ENV PACKAGES \
      zlib-devel
 
  RUN dnf install -y dnf-plugins-core && \
-  dnf config-manager --set-enabled PowerTools && \
+  dnf config-manager --set-enabled powertools && \
    dnf install -y $PACKAGES
  RUN rpm -q $PACKAGES | sort > /packages.txt

I tried a test merge of this but it fails in Gitlab CI:

Quoted 6 lines

https://gitlab.com/qemu-project/qemu/-/jobs/916041167

#6 7.706 Error: No matching repo to modify: powertools.
#6 ERROR: executor failed running [/bin/sh -c dnf install -y dnf-plugins-core && dnf config-manager --set-enabled powertools && dnf install -y $PACKAGES]: exit code: 1

That's odd. Could it be that gitlab is still caching the old image here?

ATB,

Mark.