Skip to contentSkip to conversation

fastopen: add require to sch_netem driver

PATCH New Kory Maincent 2 participants 5 messages Dec 17, 2020 – Dec 18, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fastopen: add require to sch_netem driver

---
 testcases/network/tcp_fastopen/tcp_fastopen_run.sh | 1 +
 1 file changed, 1 insertion(+)
testcases/network/tcp_fastopen/tcp_fastopen_run.sh +1 -0
index fb2cb8fc2..0e59ed506 100755
@@ -11,6 +11,7 @@ TST_MIN_KVER="3.7"
 TST_NEEDS_TMPDIR=1
 TST_NEEDS_ROOT=1
 TST_NEEDS_CMDS="tc"
+TST_NEEDS_DRIVERS="sch_netem"
 TST_OPTS="R:"
 TST_USAGE=tcp_fastopen_usage
 TST_PARSE_ARGS=tcp_fastopen_parse_args
Signature · 1 line
2.17.1
#1 lore raw

PATCH 1/1 fastopen: add require to sch_netem driver

Hi Kory,

Quoted 1 line

+TST_NEEDS_DRIVERS="sch_netem"

On my system also veth, xfrm_algo and xfrm_user are loaded.

veth is added because I use network namespaces based testing (I'll add it on separate patch) and xfrm_algo is used xfrm_user.

Thus maybe add also xfrm_user?
TST_NEEDS_DRIVERS="sch_netem xfrm_user"

Kind regards,
Petr

#2 lore raw

PATCH 1/1 fastopen: add require to sch_netem driver

Hi Petr,

Quoted 7 lines · On Thu, 17 Dec 2020 14:25:59 +0100 Petr Vorel <[email protected]> wrote:

Hi Kory,

Quoted 1 line

+TST_NEEDS_DRIVERS="sch_netem"

On my system also veth, xfrm_algo and xfrm_user are loaded.

veth is added because I use network namespaces based testing (I'll add it on separate patch) and xfrm_algo is used xfrm_user.

The xfrm_user driver seems not to be needed for the fastopen test.

Regards,

K?ry

Quoted 6 lines

Thus maybe add also xfrm_user?
TST_NEEDS_DRIVERS="sch_netem xfrm_user"

Kind regards,
Petr

#3 lore raw

PATCH 1/1 fastopen: add require to sch_netem driver

Hi Kory,

Quoted 7 lines
Quoted 5 lines
Quoted 1 line

+TST_NEEDS_DRIVERS="sch_netem"

On my system also veth, xfrm_algo and xfrm_user are loaded.

veth is added because I use network namespaces based testing (I'll add it on separate patch) and xfrm_algo is used xfrm_user.

The xfrm_user driver seems not to be needed for the fastopen test.

Thanks for info. Correct, it's loaded by ip xfrm in tst_init_iface() (which is not required since 250438496).

Kind regards,
Petr