Skip to contentSkip to conversation

ASoC: wm8962: Add optional mclk device tree binding

PATCH In review Adam Ford 5 participants 5 messages Dec 17, 2020 – Jan 4, 2021

Subsystems (3)
Device tree bindings ASoC Wolfson microelectronics drivers
lore
Share & tools
lore

Adam Ford

author
#0 lore raw

PATCH 1/1 ASoC: wm8962: Add optional mclk device tree binding

The driver can request an optional clock for mclk. Update the txt file to reflect this.

Suggested-by Geert Uytterhoeven <[email protected]>
Signed-off-by Adam Ford <[email protected]>
Documentation/devicetree/bindings/sound/wm8962.txt +4 -0
index dcfa9a3369fd..c36c649ddfd0 100644
@@ -9,6 +9,9 @@ Required properties:
   - reg : the I2C address of the device.
 
 Optional properties:
+
+  - clocks : The clock source of the mclk
+
   - spk-mono: This is a boolean property. If present, the SPK_MONO bit
     of R51 (Class D Control 2) gets set, indicating that the speaker is
     in mono mode.

@@ -27,6 +30,7 @@ Example:
 wm8962: codec@1a {
 	compatible = "wlf,wm8962";
 	reg = <0x1a>;
+	clocks = <&clks IMX6QDL_CLK_CKO>;
 
 	gpio-cfg = <
 		0x0000 /* 0:Default */
Signature · 1 line
2.25.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 5 lines · Adam Ford

The driver can request an optional clock for mclk. Update the txt file to reflect this.

Suggested-by Geert Uytterhoeven <[email protected]>
Signed-off-by Adam Ford <[email protected]>
Reviewed-by Geert Uytterhoeven <[email protected]>

Documentation/devicetree/bindings/sound/wm8962.txt Required properties: · line 12

Quoted 7 lines
Documentation/devicetree/bindings/sound/wm8962.txt +1 -0
@@ -9,6 +9,9 @@ Required properties:
   - reg : the I2C address of the device.
 
 Optional properties:
+

This blank line is not needed (but it will probably be removed during a future txt-to-yaml conversion ;-)

Documentation/devicetree/bindings/sound/wm8962.txt Example: · line 36

Quoted 13 lines
Documentation/devicetree/bindings/sound/wm8962.txt +3 -0
+  - clocks : The clock source of the mclk
+
   - spk-mono: This is a boolean property. If present, the SPK_MONO bit
     of R51 (Class D Control 2) gets set, indicating that the speaker is
     in mono mode.

@@ -27,6 +30,7 @@ Example:
 wm8962: codec@1a {
        compatible = "wlf,wm8962";
        reg = <0x1a>;
+       clocks = <&clks IMX6QDL_CLK_CKO>;
 
        gpio-cfg = <
                0x0000 /* 0:Default */

Gr{oetje,eeting}s,

Geert

Signature · 5 lines
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
maintainer
#4 lore raw
In reply to Adam Ford
Quoted 2 lines · Adam Ford

The driver can request an optional clock for mclk. Update the txt file to reflect this.

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: wm8962: Add optional mclk device tree binding

      commit: e33c93b2206fedee35df756940e07af7b1f29768

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark