parisc: Drop out of get_whan() if task is running again
Helge Deller
maintainerPATCH 1/1 parisc: Drop out of get_whan() if task is running again
Signed-off-by Helge Deller <[email protected]>
arch/parisc/kernel/process.c +2 -0
@@ -260,6 +260,8 @@ get_wchan(struct task_struct *p) do { if (unwind_once(&info) < 0) return 0; + if (p->state == TASK_RUNNING) + return 0; ip = info.ip; if (!in_sched_functions(ip)) return ip;
This seems to be a hack to work around a race in p->state. Don't see this check in other implementations.
Quoted 7 lines · Helge Deller
Signed-off-by Helge Deller <[email protected]>arch/parisc/kernel/process.c +0
-0
arch/parisc/kernel/process.c get_wchan(struct task_struct *p) · line 267
Quoted 8 lines
arch/parisc/kernel/process.c +2
-0@@ -260,6 +260,8 @@ get_wchan(struct task_struct *p) do { if (unwind_once(&info) < 0) return 0; + if (p->state == TASK_RUNNING) + return 0; ip = info.ip; if (!in_sched_functions(ip)) return ip;
Dave
Signature · 1 line
John David Anglin [email protected]
Helge Deller
maintainerQuoted 1 line · John David Anglin
This seems to be a hack to work around a race in p->state. Don't see this check in other implementations.
In arch/x86/kernel/process.c:
} while (count++ < 16 && p->state != TASK_RUNNING);
But I think we should implement CONFIG_THREAD_INFO_IN_TASK and thus try_get_task_stack() too..
Helge
Quoted 20 lines · Helge Deller
Quoted 7 lines
Signed-off-by Helge Deller <[email protected]>arch/parisc/kernel/process.c +0
-0arch/parisc/kernel/process.c get_wchan(struct task_struct *p) · line 267
Quoted 8 lines
arch/parisc/kernel/process.c +2
-0@@ -260,6 +260,8 @@ get_wchan(struct task_struct *p) do { if (unwind_once(&info) < 0) return 0; + if (p->state == TASK_RUNNING) + return 0; ip = info.ip; if (!in_sched_functions(ip)) return ip;Dave