media: uapi: Add an entity type for Image Signal Processors
Subsystems (2)
Sakari Ailus
maintainerPATCH 1/1 media: uapi: Add an entity type for Image Signal Processors
Add and document a media entity type for Image Signal Processor devices. Surprisingly we didn't have one, so add one now. More or less all ISP drivers should use this type instead of what they currently are using (or not using anything).
--- Documentation/userspace-api/media/mediactl/media-types.rst | 6 ++++++ include/uapi/linux/media.h | 1 + 2 files changed, 7 insertions(+)
Documentation/userspace-api/media/mediactl/media-types.rst +6 -0
@@ -39,6 +39,7 @@ Types and flags used to represent the media graph elements .. _MEDIA-ENT-F-PROC-VIDEO-STATISTICS: .. _MEDIA-ENT-F-PROC-VIDEO-ENCODER: .. _MEDIA-ENT-F-PROC-VIDEO-DECODER: +.. _MEDIA-ENT-F-PROC-VIDEO-ISP: .. _MEDIA-ENT-F-VID-MUX: .. _MEDIA-ENT-F-VID-IF-BRIDGE: .. _MEDIA-ENT-F-DV-DECODER:
@@ -201,6 +202,11 @@ Types and flags used to represent the media graph elements decompressing a compressed video stream into uncompressed video frames. Must have one sink pad and at least one source pad. + * - ``MEDIA_ENT_F_PROC_VIDEO_ISP`` + - An Image Signal Processor (ISP) device. ISPs generally are one of a + kind devices that have their specific control interfaces. Most devices + have either memory or data bus input. + * - ``MEDIA_ENT_F_VID_MUX`` - Video multiplexer. An entity capable of multiplexing must have at least two sink pads and one source pad, and must pass the video
include/uapi/linux/media.h +1 -0
@@ -127,6 +127,7 @@ struct media_device_info {#define MEDIA_ENT_F_PROC_VIDEO_STATISTICS (MEDIA_ENT_F_BASE + 0x4006)#define MEDIA_ENT_F_PROC_VIDEO_ENCODER (MEDIA_ENT_F_BASE + 0x4007)#define MEDIA_ENT_F_PROC_VIDEO_DECODER (MEDIA_ENT_F_BASE + 0x4008) +#define MEDIA_ENT_F_PROC_VIDEO_ISP (MEDIA_ENT_F_BASE + 0x4009)/* * Switch and bridge entity functions
Signature · 1 line
2.29.2
Hi Sakari,
Thank you for the patch.
Quoted 24 lines · Sakari Ailus
Add and document a media entity type for Image Signal Processor devices. Surprisingly we didn't have one, so add one now. More or less all ISP drivers should use this type instead of what they currently are using (or not using anything).
Signed-off-by Sakari Ailus <[email protected]>--- Documentation/userspace-api/media/mediactl/media-types.rst | 6 ++++++ include/uapi/linux/media.h | 1 + 2 files changed, 7 insertions(+)Documentation/userspace-api/media/mediactl/media-types.rst +1
-0@@ -39,6 +39,7 @@ Types and flags used to represent the media graph elements .. _MEDIA-ENT-F-PROC-VIDEO-STATISTICS: .. _MEDIA-ENT-F-PROC-VIDEO-ENCODER: .. _MEDIA-ENT-F-PROC-VIDEO-DECODER: +.. _MEDIA-ENT-F-PROC-VIDEO-ISP: .. _MEDIA-ENT-F-VID-MUX: .. _MEDIA-ENT-F-VID-IF-BRIDGE: .. _MEDIA-ENT-F-DV-DECODER:
Documentation/userspace-api/media/mediactl/media-types.rst Types and flags used to represent the media graph elements · line 209
Quoted 8 lines
Documentation/userspace-api/media/mediactl/media-types.rst +5
-0@@ -201,6 +202,11 @@ Types and flags used to represent the media graph elements decompressing a compressed video stream into uncompressed video frames. Must have one sink pad and at least one source pad. + * - ``MEDIA_ENT_F_PROC_VIDEO_ISP`` + - An Image Signal Processor (ISP) device. ISPs generally are one of a + kind devices that have their specific control interfaces. Most devices + have either memory or data bus input. +
This looks good to me. I don't think we need to formally define what an ISP is here, it's a fairly well understood concept in the industry and having some flexibility in the definition is useful.
We may want to expand a bit on the "specific control interface", to tell it's about the V4L2 API, and not the hardware interface. Maybe "..., using a combination of custom V4L2 controls and IOCTLs, and parameters supplied in a metadata buffer" ?
Quoted 15 lines
Documentation/userspace-api/media/mediactl/media-types.rst +0
-0* - ``MEDIA_ENT_F_VID_MUX`` - Video multiplexer. An entity capable of multiplexing must have at least two sink pads and one source pad, and must pass the videoinclude/uapi/linux/media.h +1
-0@@ -127,6 +127,7 @@ struct media_device_info {#define MEDIA_ENT_F_PROC_VIDEO_STATISTICS (MEDIA_ENT_F_BASE + 0x4006)#define MEDIA_ENT_F_PROC_VIDEO_ENCODER (MEDIA_ENT_F_BASE + 0x4007)#define MEDIA_ENT_F_PROC_VIDEO_DECODER (MEDIA_ENT_F_BASE + 0x4008) +#define MEDIA_ENT_F_PROC_VIDEO_ISP (MEDIA_ENT_F_BASE + 0x4009)/* * Switch and bridge entity functions
Signature · 3 lines
Regards, Laurent Pinchart
Sakari Ailus
maintainerQuoted 42 lines · Laurent Pinchart
Hi Sakari,
Thank you for the patch.
Quoted 24 lines · Sakari Ailus
Add and document a media entity type for Image Signal Processor devices. Surprisingly we didn't have one, so add one now. More or less all ISP drivers should use this type instead of what they currently are using (or not using anything).
Signed-off-by Sakari Ailus <[email protected]>--- Documentation/userspace-api/media/mediactl/media-types.rst | 6 ++++++ include/uapi/linux/media.h | 1 + 2 files changed, 7 insertions(+)Documentation/userspace-api/media/mediactl/media-types.rst +1
-0@@ -39,6 +39,7 @@ Types and flags used to represent the media graph elements .. _MEDIA-ENT-F-PROC-VIDEO-STATISTICS: .. _MEDIA-ENT-F-PROC-VIDEO-ENCODER: .. _MEDIA-ENT-F-PROC-VIDEO-DECODER: +.. _MEDIA-ENT-F-PROC-VIDEO-ISP: .. _MEDIA-ENT-F-VID-MUX: .. _MEDIA-ENT-F-VID-IF-BRIDGE: .. _MEDIA-ENT-F-DV-DECODER:Documentation/userspace-api/media/mediactl/media-types.rst Types and flags used to represent the media graph elements · line 209
Quoted 8 lines
Documentation/userspace-api/media/mediactl/media-types.rst +5
-0@@ -201,6 +202,11 @@ Types and flags used to represent the media graph elements decompressing a compressed video stream into uncompressed video frames. Must have one sink pad and at least one source pad. + * - ``MEDIA_ENT_F_PROC_VIDEO_ISP`` + - An Image Signal Processor (ISP) device. ISPs generally are one of a + kind devices that have their specific control interfaces. Most devices + have either memory or data bus input. +This looks good to me. I don't think we need to formally define what an ISP is here, it's a fairly well understood concept in the industry and having some flexibility in the definition is useful.
Quoted 6 lines
We may want to expand a bit on the "specific control interface", to tell it's about the V4L2 API, and not the hardware interface. Maybe "..., using a combination of custom V4L2 controls and IOCTLs, and parameters supplied in a metadata buffer" ?
Reviewed-by Laurent Pinchart <[email protected]>
Thanks!
v2 sent.
Signature · 1 line
Sakari Ailus