Skip to contentSkip to conversation

net/bnxt: fix outer UDP cksum Rx offload capability

PATCH In review Lance Richardson 2 participants 2 messages Dec 17, 2020 Network drivers

lore
Share & tools
lore

Lance Richardson

author
#0 lore raw

PATCH 1/1 net/bnxt: fix outer UDP cksum Rx offload capability

From: Lance Richardson <[email protected]>

Rx outer UDP checksum offload has been supported for some time, but this has not been advertised in offload capability flags. Fix this, and allow vector mode receive to be enabled when DEV_RX_OFFLOAD_OUTER_UDP_CKSUM is requested.

Fixes 04a681426d49 ("net/bnxt: fix L4 checksum error indication in Rx")
Signed-off-by Lance Richardson <[email protected]>
Cc [email protected]
---
 drivers/net/bnxt/bnxt.h        | 1 +
 drivers/net/bnxt/bnxt_ethdev.c | 1 +
 2 files changed, 2 insertions(+)
drivers/net/bnxt/bnxt.h +1 -0
index 07d39ee937..ad7d59458c 100644
@@ -583,6 +583,7 @@ struct bnxt_rep_info {
 				     DEV_RX_OFFLOAD_UDP_CKSUM | \
 				     DEV_RX_OFFLOAD_TCP_CKSUM | \
 				     DEV_RX_OFFLOAD_OUTER_IPV4_CKSUM | \
+				     DEV_RX_OFFLOAD_OUTER_UDP_CKSUM | \
 				     DEV_RX_OFFLOAD_JUMBO_FRAME | \
 				     DEV_RX_OFFLOAD_KEEP_CRC | \
 				     DEV_RX_OFFLOAD_VLAN_EXTEND | \
drivers/net/bnxt/bnxt_ethdev.c +1 -0
index 9d5c8aa0f8..a3035def5e 100644
@@ -1179,6 +1179,7 @@ bnxt_receive_function(struct rte_eth_dev *eth_dev)
 		DEV_RX_OFFLOAD_UDP_CKSUM |
 		DEV_RX_OFFLOAD_TCP_CKSUM |
 		DEV_RX_OFFLOAD_OUTER_IPV4_CKSUM |
+		DEV_RX_OFFLOAD_OUTER_UDP_CKSUM |
 		DEV_RX_OFFLOAD_RSS_HASH |
 		DEV_RX_OFFLOAD_VLAN_FILTER)) &&
 	    !BNXT_TRUFLOW_EN(bp) && BNXT_NUM_ASYNC_CPR(bp) &&
Signature · 1 line
2.25.1
#1 lore raw
Quoted 9 lines · Lance Richardson

From: Lance Richardson <[email protected]>

Rx outer UDP checksum offload has been supported for some time, but this has not been advertised in offload capability flags. Fix this, and allow vector mode receive to be enabled when DEV_RX_OFFLOAD_OUTER_UDP_CKSUM is requested.

Quoted 3 lines
Fixes 04a681426d49 ("net/bnxt: fix L4 checksum error indication in Rx")
Signed-off-by Lance Richardson <[email protected]>
Cc [email protected]

Patch applied to dpdk-next-net-brcm. Thanks

Quoted 32 lines
---
 drivers/net/bnxt/bnxt.h        | 1 +
 drivers/net/bnxt/bnxt_ethdev.c | 1 +
 2 files changed, 2 insertions(+)
drivers/net/bnxt/bnxt.h +1 -0
index 07d39ee937..ad7d59458c 100644
@@ -583,6 +583,7 @@ struct bnxt_rep_info {
                                     DEV_RX_OFFLOAD_UDP_CKSUM | \
                                     DEV_RX_OFFLOAD_TCP_CKSUM | \
                                     DEV_RX_OFFLOAD_OUTER_IPV4_CKSUM | \
+                                    DEV_RX_OFFLOAD_OUTER_UDP_CKSUM | \
                                     DEV_RX_OFFLOAD_JUMBO_FRAME | \
                                     DEV_RX_OFFLOAD_KEEP_CRC | \
                                     DEV_RX_OFFLOAD_VLAN_EXTEND | \
drivers/net/bnxt/bnxt_ethdev.c +1 -1
index 9d5c8aa0f8..a3035def5e 100644
@@ -1179,6 +1179,7 @@ bnxt_receive_function(struct rte_eth_dev *eth_dev)
                DEV_RX_OFFLOAD_UDP_CKSUM |
                DEV_RX_OFFLOAD_TCP_CKSUM |
                DEV_RX_OFFLOAD_OUTER_IPV4_CKSUM |
+               DEV_RX_OFFLOAD_OUTER_UDP_CKSUM |
                DEV_RX_OFFLOAD_RSS_HASH |
                DEV_RX_OFFLOAD_VLAN_FILTER)) &&
            !BNXT_TRUFLOW_EN(bp) && BNXT_NUM_ASYNC_CPR(bp) &&
--

2.25.1

Signature · 1 line
Ajit Khaparde