Skip to contentSkip to conversation

unionmount-testsuite: master branch updated to 95be14e

ANNOUNCE Amir Goldstein 1 participant 1 message Dec 18, 2020

lore
Share & tools
lore
#0 lore raw

Hi All,

The master branch on the unionmount-testsuite tree [1] has been updated.

Changes in this update:
- Support for user configurable mount option
- Prepare to run tests with "userxattr" mount option

The previous update brought the ability for users to configure custom paths with a custom filesystem for the underlying layers.
That ability was used to add xfstests wrappers for unionmount-testsuite.

This update brings the ability for users to configure custom overlay mount options. This feature is also intended to be used by xfstests [2].

I used this ability to run tests with the new "userxattr" and "uuid=off" mount option:

$ export UNIONMOUNT_MNTOPTIONS=userxattr
$ ./run --ov --verify
TEST rmdir.py:64: Remove populated directory
- rmtree /mnt/a/dir106
OSError: [Errno 5] Input/output error: '/mnt/a/dir106/pop'
$ export UNIONMOUNT_BASEDIR=/vdf # (xfs filesystem)
$ ./run --ov --verify
TEST hard-link-sym.py:10: Hard link symlink
 ./run --link /vdf/m/a/direct_sym100 /vdf/m/a/no_foo100
/vdf/m/a/no_foo100: inode number/layer changed on copy up...
$ export UNIONMOUNT_MNTOPTIONS="uuid=off"
$ ./run --ov --verify

and came to the following observations:

1) rmdir test as well as other tests involving opaque dir are failing on tmpfs, because tmpfs does not support user.* xattrs
2) hard-link-sym test fails consistent inode number verification also on xfs, because symlink does not support user.* xattrs
3) All the other tests pass on xfs with the userxattr mount option
4) No failures observed with uuid=off

I did not try to run tests inside non init userns. This practice is left to the reader.

Thanks,
Amir.

[1] https://github.com/amir73il/unionmount-testsuite
[2] https://github.com/amir73il/xfstests/commits/unionmount

The head of the master branch is commit:

95be14e Allow user provided options with or without -o

Amir Goldstein (3):
Add support for user defined mount options
Let "userxattr" mount option in UNIONMOUNT_MNTOPTIONS imply --xdev Allow user provided options with or without -o

 mount_union.py   |  6 ++--
 remount_union.py |  4 +--
 run              | 90 ++++++++++++++++++++++++++++++------------------
 settings.py      | 15 +++++---
 tool_box.py      | 18 ++++++++++
 5 files changed, 91 insertions(+), 42 deletions(-)
Signature · 1 line
2.25.1