Skip to contentSkip to conversation

ipsec_lib: make tst_net_run "tst_check_driver" quiet

PATCH New Kory Maincent 2 participants 2 messages Dec 18, 2020 – Dec 21, 2020

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 ipsec_lib: make tst_net_run "tst_check_driver" quiet

Make tst_net_run quiet when using tst_check_drivers to avoid wrong TWARN message

---

Change since v1:
Considered Alexey's review
http://lists.linux.it/pipermail/ltp/2020-December/020285.html

 testcases/network/stress/ipsec/ipsec_lib.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
testcases/network/stress/ipsec/ipsec_lib.sh +1 -1
index 198c9315d..e395e1ff3 100644
@@ -83,7 +83,7 @@ ipsec_lib_setup()
 	ALGR=
 
 	if [ -n "$IPSEC_MODE" ]; then
-		tst_net_run "tst_check_drivers xfrm_user" || \
+		tst_net_run -q "tst_check_drivers xfrm_user" || \
 			tst_brk TCONF "xfrm_user driver not available on lhost or rhost"
 		cleanup_xfrm=1
 	fi
Signature · 1 line
2.17.1
#1 lore raw

PATCH v2 1/1 ipsec_lib: make tst_net_run "tst_check_driver" quiet

Quoted 12 lines · Kory Maincent

Make tst_net_run quiet when using tst_check_drivers to avoid wrong TWARN message

---

Change since v1:
Considered Alexey's review
https://urldefense.com/v3/__http://lists.linux.it/pipermail/ltp/2020-December/020285.html__;!!GqivPVa7Brio!OdHd62f8dF5zyARaPopO0WEuxNw4iqh52VKRlkJFHeFaaBmwFHz9K_6sE7jP0oox9W-4$

 testcases/network/stress/ipsec/ipsec_lib.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Applied the patch, thanks!

testcases/network/stress/ipsec/ipsec_lib.sh ipsec_lib_setup() · line 86

Quoted 10 lines
testcases/network/stress/ipsec/ipsec_lib.sh +1 -1
index 198c9315d..e395e1ff3 100644
@@ -83,7 +83,7 @@ ipsec_lib_setup()
 	ALGR=
 
 	if [ -n "$IPSEC_MODE" ]; then
-		tst_net_run "tst_check_drivers xfrm_user" || \
+		tst_net_run -q "tst_check_drivers xfrm_user" || \

Noticed a minor issue in the test output, when tst_check_drivers prints missing drivers to stderr, I think we should handle it inside tst_net_run with -q somehow...