tools: kconfig: Use scripts/dtc for the MKIMAGE_DTC_PATH
PATCH 1/1 tools: kconfig: Use scripts/dtc for the MKIMAGE_DTC_PATH
Use the dtc executable generated during the U-Boot build process for mkimage. This removes the build dependency on the external dtc.
---
tools/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tools/Kconfig +1 -1
@@ -2,7 +2,7 @@ menu "Tools options" config MKIMAGE_DTC_PATH string "Path to dtc binary for use within mkimage" - default "dtc" + default "scripts/dtc/dtc" help The mkimage host tool will, in order to generate FIT images make calls to the dtc application in order to create the output. In
Signature · 1 line
2.25.1
PATCH 1/1 tools: kconfig: Use scripts/dtc for the MKIMAGE_DTC_PATH
Quoted 10 lines · Bin Meng
Use the dtc executable generated during the U-Boot build process for mkimage. This removes the build dependency on the external dtc.
Signed-off-by Bin Meng <[email protected]>---
tools/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Ping?
PATCH 1/1 tools: kconfig: Use scripts/dtc for the MKIMAGE_DTC_PATH
Quoted 5 lines · Bin Meng
Quoted 4 lines · Bin Meng
Use the dtc executable generated during the U-Boot build process for mkimage. This removes the build dependency on the external dtc.
Quoted 8 lines
Quoted 6 lines
Signed-off-by Bin Meng <[email protected]>---
tools/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)Ping?
OK. I _think_ this is wrong. This changes the compiled in path to "dtc" that mkimage will have. We don't want the system-wide installed "mkimage" tool to call out to "scripts/dtc/dtc", but either "dtc" (so that normal PATH parsing works) or possibly a less-obvious path to the system-wide dtc (based on my commit message about FreeBSD having it in some other location).
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 659 bytes Desc: not available URL: <https://lists.denx.de/pipermail/u-boot/attachments/20210106/1cc926b5/attachment.sig>
PATCH 1/1 tools: kconfig: Use scripts/dtc for the MKIMAGE_DTC_PATH
Quoted 14 lines · Tom Rini
Quoted 12 lines · Bin Meng
Quoted 10 lines · Bin Meng
Use the dtc executable generated during the U-Boot build process for mkimage. This removes the build dependency on the external dtc.
Signed-off-by Bin Meng <[email protected]>---
tools/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 8 lines
Quoted 1 line
Ping?
OK. I _think_ this is wrong. This changes the compiled in path to "dtc" that mkimage will have. We don't want the system-wide installed "mkimage" tool to call out to "
scripts/dtc/dtc", but either "dtc" (so that normal PATH parsing works) or possibly a less-obvious path to the system-wide dtc (based on my commit message about FreeBSD having it in some other location).
Agreed. That's probably why commit 1f6049e2501b ("tools/mkimage: Make the path to the dtc binary that mkimage calls configurable") was introduced. Thanks!
Regards,
Bin