Skip to contentSkip to conversation

app/testpmd: add PF and VF targets to flow action type sample

PATCH Applied [email protected] 3 participants 4 messages Dec 21, 2020 – Feb 2, 2021

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 app/testpmd: add PF and VF targets to flow action type sample

From: Satheesh Paul <[email protected]>

Add support to specify PF or VF as targets in "set sample_actions" command.

---

The changes add support for below usecases.

1. Sample mirror to PF
testpmd>set sample_actions 0 / pf / end
#pkts to VF id 2 will be mirrored to the PF
testpmd>flow create 0 ingress pattern eth / end actions sample ratio 1 \
index 0 / vf id 2 / end

2. Sample mirror to VF
testpmd>set sample_actions 1 / vf id 1 / end
#pkts to VF id 2 will be mirrored to VF id 1
testpmd>flow create 0 ingress pattern eth / end actions sample ratio 1 \
index 1 / vf id 2 / end

 app/test-pmd/cmdline_flow.c | 9 +++++++++
 1 file changed, 9 insertions(+)
app/test-pmd/cmdline_flow.c +9 -0
index 585cab98b..12f2b1664 100644
@@ -560,6 +560,7 @@ struct rte_flow_action_queue sample_queue[RAW_SAMPLE_CONFS_MAX_NUM];
 struct rte_flow_action_count sample_count[RAW_SAMPLE_CONFS_MAX_NUM];
 struct rte_flow_action_port_id sample_port_id[RAW_SAMPLE_CONFS_MAX_NUM];
 struct rte_flow_action_raw_encap sample_encap[RAW_SAMPLE_CONFS_MAX_NUM];
+struct rte_flow_action_vf sample_vf[RAW_SAMPLE_CONFS_MAX_NUM];
 
 /** Maximum number of subsequent tokens and arguments on the stack. */
 #define CTX_STACK_SIZE 16
@@ -7558,6 +7559,14 @@ cmd_set_raw_parsed_sample(const struct buffer *in)
 				(const void *)action->conf, size);
 			action->conf = &sample_port_id[idx];
 			break;
+		case RTE_FLOW_ACTION_TYPE_PF:
+			break;
+		case RTE_FLOW_ACTION_TYPE_VF:
+			size = sizeof(struct rte_flow_action_vf);
+			rte_memcpy(&sample_vf[idx],
+			(const void *)action->conf, size);
+			action->conf = &sample_vf[idx];
+			break;
 		default:
 			printf("Error - Not supported action\n");
 			return;
Signature · 1 line
2.25.4
Acked-by on v1 1/1
#2 lore raw
In reply to [email protected]

Hi,

Quoted 60 lines

-----Original Message-----
From: [email protected] <[email protected]>
Sent: Monday, December 21, 2020 7:47 AM

From: Satheesh Paul <[email protected]>

Add support to specify PF or VF as targets in "set sample_actions" command.

---

The changes add support for below usecases.

1. Sample mirror to PF
testpmd>set sample_actions 0 / pf / end
#pkts to VF id 2 will be mirrored to the PF
testpmd>flow create 0 ingress pattern eth / end actions sample ratio 1 \
index 0 / vf id 2 / end

2. Sample mirror to VF
testpmd>set sample_actions 1 / vf id 1 / end
#pkts to VF id 2 will be mirrored to VF id 1
testpmd>flow create 0 ingress pattern eth / end actions sample ratio 1 \
index 1 / vf id 2 / end

 app/test-pmd/cmdline_flow.c | 9 +++++++++
 1 file changed, 9 insertions(+)
app/test-pmd/cmdline_flow.c +0 -0
index 585cab98b..12f2b1664 100644
@@ -560,6 +560,7 @@ struct rte_flow_action_queue
 sample_queue[RAW_SAMPLE_CONFS_MAX_NUM];
 struct rte_flow_action_count
 sample_count[RAW_SAMPLE_CONFS_MAX_NUM];
 struct rte_flow_action_port_id
 sample_port_id[RAW_SAMPLE_CONFS_MAX_NUM];
 struct rte_flow_action_raw_encap

sample_encap[RAW_SAMPLE_CONFS_MAX_NUM];

app/test-pmd/cmdline_flow.c +9 -0
+struct rte_flow_action_vf sample_vf[RAW_SAMPLE_CONFS_MAX_NUM];
 
 /** Maximum number of subsequent tokens and arguments on the stack. */
 #define CTX_STACK_SIZE 16
@@ -7558,6 +7559,14 @@ cmd_set_raw_parsed_sample(const struct buffer
 *in)
 				(const void *)action->conf, size);
 			action->conf = &sample_port_id[idx];
 			break;
+		case RTE_FLOW_ACTION_TYPE_PF:
+			break;
+		case RTE_FLOW_ACTION_TYPE_VF:
+			size = sizeof(struct rte_flow_action_vf);
+			rte_memcpy(&sample_vf[idx],
+			(const void *)action->conf, size);
+			action->conf = &sample_vf[idx];
+			break;
 		default:
 			printf("Error - Not supported action\n");
Quoted 3 lines

return;
--
2.25.4

Best,
Ori