drm/i915/display: move needs_modeset to an inline in header
Subsystems (3)
PATCH 1/5 drm/i915/display: move needs_modeset to an inline in header
From: Dave Airlie <[email protected]>
This function is going to be used in a later change, so clean it up first before moving it.
--- drivers/gpu/drm/i915/display/intel_display.c | 78 +++++++++---------- .../drm/i915/display/intel_display_types.h | 6 ++ 2 files changed, 42 insertions(+), 42 deletions(-)
drivers/gpu/drm/i915/display/intel_display.c +36 -42
@@ -542,12 +542,6 @@ icl_wa_scalerclkgating(struct drm_i915_private *dev_priv, enum pipe pipe, intel_de_read(dev_priv, CLKGATE_DIS_PSL(pipe)) & ~DPFR_GATING_DIS); } -static bool -needs_modeset (const struct intel_crtc_state *state) -{ -return drm_atomic_crtc_needs_modeset (&state->uapi); -} -static bool is_trans_port_sync_slave (const struct intel_crtc_state *crtc_state) {
@@ -6474,7 +6468,7 @@ static bool hsw_pre_update_disable_ips(const struct intel_crtc_state *old_crtc_sif (!old_crtc_state->ips_enabled)return false; -if (needs_modeset (new_crtc_state)) +if (intel_crtc_needs_modeset (new_crtc_state))return true;/*
@@ -6501,7 +6495,7 @@ static bool hsw_post_update_enable_ips(const struct intel_crtc_state *old_crtc_sif (!new_crtc_state->ips_enabled)return false; -if (needs_modeset (new_crtc_state)) +if (intel_crtc_needs_modeset (new_crtc_state))return true;/*
@@ -6554,7 +6548,7 @@ static bool needs_scalerclk_wa(const struct intel_crtc_state *crtc_state)static bool planes_enabling (const struct intel_crtc_state *old_crtc_state,const struct intel_crtc_state *new_crtc_state) { -return (!old_crtc_state->active_planes ||needs_modeset (new_crtc_state)) && +return (!old_crtc_state->active_planes ||intel_crtc_needs_modeset (new_crtc_state)) && new_crtc_state->active_planes; }
@@ -6562,7 +6556,7 @@ static bool planes_disabling(const struct intel_crtc_state *old_crtc_state, const struct intel_crtc_state *new_crtc_state) {return old_crtc_state->active_planes && - (!new_crtc_state->active_planes ||needs_modeset (new_crtc_state)); + (!new_crtc_state->active_planes ||intel_crtc_needs_modeset (new_crtc_state)); } static void intel_post_plane_update(struct intel_atomic_state *state,
@@ -6685,7 +6679,7 @@ static void intel_pre_plane_update(struct intel_atomic_state *state,* If we're doing a modeset we don't need to do any * pre-vblank watermark programming here. */ -if (!needs_modeset (new_crtc_state)) { +if (!intel_crtc_needs_modeset (new_crtc_state)) {/* * For platforms that support atomic watermarks, program the * 'intermediate' watermarks immediately. On pre-gen9 platforms, these
@@ -12046,7 +12040,7 @@ static void i9xx_update_cursor(struct intel_plane *plane,if (INTEL_GEN (dev_priv) >=9 )skl_write_cursor_wm (plane, crtc_state); -if (!needs_modeset (crtc_state)) +if (!intel_crtc_needs_modeset (crtc_state))intel_psr2_program_plane_sel_fetch (plane, crtc_state, plane_state,0 ); if (plane->cursor.base != base ||
@@ -12616,7 +12610,7 @@ int intel_plane_atomic_calc_changes(const struct intel_crtc_state *old_crtc_statstruct intel_crtc *crtc =to_intel_crtc (crtc_state->uapi.crtc);struct intel_plane *plane =to_intel_plane (plane_state->uapi.plane);struct drm_i915_private *dev_priv =to_i915 (crtc->base.dev); -bool mode_changed =needs_modeset (crtc_state); +bool mode_changed =intel_crtc_needs_modeset (crtc_state);bool was_crtc_enabled = old_crtc_state->hw.active;bool is_crtc_enabled = crtc_state->hw.active;bool turn_off, turn_on, visible, was_visible;
@@ -12980,7 +12974,7 @@ static int intel_crtc_atomic_check(struct intel_atomic_state *state,struct drm_i915_private *dev_priv =to_i915 (crtc->base.dev);struct intel_crtc_state *crtc_state =intel_atomic_get_new_crtc_state (state, crtc); -bool mode_changed =needs_modeset (crtc_state); +bool mode_changed =intel_crtc_needs_modeset (crtc_state);int ret; if (INTEL_GEN(dev_priv) < 5 && !IS_G4X(dev_priv) &&
@@ -14812,7 +14806,7 @@ intel_modeset_verify_crtc(struct intel_crtc *crtc, struct intel_crtc_state *old_crtc_state, struct intel_crtc_state *new_crtc_state) { -if (!needs_modeset (new_crtc_state) && !new_crtc_state->update_pipe) +if (!intel_crtc_needs_modeset (new_crtc_state) && !new_crtc_state->update_pipe)return ;verify_wm_state (crtc, new_crtc_state);
@@ -14907,7 +14901,7 @@ static void intel_modeset_clear_plls(struct intel_atomic_state *state)return ;for_each_new_intel_crtc_in_state (state, crtc, new_crtc_state, i) { -if (!needs_modeset (new_crtc_state)) +if (!intel_crtc_needs_modeset (new_crtc_state))continue ;intel_release_shared_dplls (state, crtc);
@@ -14932,7 +14926,7 @@ static int hsw_mode_set_planes_workaround(struct intel_atomic_state *state)/* look at all crtc's that are going to be enabled in during modeset */ for_each_new_intel_crtc_in_state (state, crtc, crtc_state, i) {if (!crtc_state->hw.active || - !needs_modeset (crtc_state)) + !intel_crtc_needs_modeset (crtc_state))continue ;if (first_crtc_state) {
@@ -14957,7 +14951,7 @@ static int hsw_mode_set_planes_workaround(struct intel_atomic_state *state) crtc_state->hsw_workaround_pipe =INVALID_PIPE ;if (!crtc_state->hw.active || -needs_modeset (crtc_state)) +intel_crtc_needs_modeset (crtc_state))continue ;/* 2 or more enabled crtcs means no need for w/a */
@@ -15276,7 +15270,7 @@ static bool intel_cpu_transcoders_need_modeset(struct intel_atomic_state *state,for_each_new_intel_crtc_in_state (state, crtc, new_crtc_state, i) {if (new_crtc_state->hw.enable && transcoders &BIT (new_crtc_state->cpu_transcoder) && -needs_modeset (new_crtc_state)) +intel_crtc_needs_modeset (new_crtc_state))return true; }
@@ -15297,7 +15291,7 @@ static int intel_atomic_check_bigjoiner(struct intel_atomic_state *state, slave = crtc; master = old_crtc_state->bigjoiner_linked_crtc; master_crtc_state =intel_atomic_get_new_crtc_state (state, master); -if (!master_crtc_state || !needs_modeset (master_crtc_state)) +if (!master_crtc_state || !intel_crtc_needs_modeset (master_crtc_state)) goto claimed; }
@@ -15376,7 +15370,7 @@ static int intel_atomic_check_async(struct intel_atomic_state *state)for_each_oldnew_intel_crtc_in_state (state, crtc, old_crtc_state, new_crtc_state, i) { -if (needs_modeset (new_crtc_state)) { +if (intel_crtc_needs_modeset (new_crtc_state)) {drm_dbg_kms (&i915->drm,"Modeset Required. Async flip not supported\n" );return -EINVAL ; }
@@ -15499,7 +15493,7 @@ static int intel_bigjoiner_add_affected_crtcs(struct intel_atomic_state *state)if (IS_ERR (linked_crtc_state))return PTR_ERR (linked_crtc_state); -if (!needs_modeset (crtc_state)) +if (!intel_crtc_needs_modeset (crtc_state))continue ; linked_crtc_state->uapi.mode_changed = true;
@@ -15516,7 +15510,7 @@ static int intel_bigjoiner_add_affected_crtcs(struct intel_atomic_state *state)for_each_new_intel_crtc_in_state (state, crtc, crtc_state, i) {/* Kill old bigjoiner link, we may re-establish afterwards */ -if (needs_modeset (crtc_state) && +if (intel_crtc_needs_modeset (crtc_state) && crtc_state->bigjoiner && !crtc_state->bigjoiner_slave)kill_bigjoiner_slave (state, crtc_state); }
@@ -15555,7 +15549,7 @@ static int intel_atomic_check(struct drm_device *dev,for_each_oldnew_intel_crtc_in_state (state, crtc, old_crtc_state, new_crtc_state, i) { -if (!needs_modeset (new_crtc_state)) { +if (!intel_crtc_needs_modeset (new_crtc_state)) {/* Light copy */ intel_crtc_copy_uapi_to_hw_state_nomodeset (state, new_crtc_state);
@@ -15586,7 +15580,7 @@ static int intel_atomic_check(struct drm_device *dev,for_each_oldnew_intel_crtc_in_state (state, crtc, old_crtc_state, new_crtc_state, i) { -if (!needs_modeset (new_crtc_state)) +if (!intel_crtc_needs_modeset (new_crtc_state))continue ; ret =intel_modeset_pipe_config_late (new_crtc_state);
@@ -15608,7 +15602,7 @@ static int intel_atomic_check(struct drm_device *dev,* forced a full modeset. */ for_each_new_intel_crtc_in_state (state, crtc, new_crtc_state, i) { -if (!new_crtc_state->hw.enable ||needs_modeset (new_crtc_state)) +if (!new_crtc_state->hw.enable ||intel_crtc_needs_modeset (new_crtc_state))continue ;if (intel_dp_mst_is_slave_trans (new_crtc_state)) {
@@ -15636,7 +15630,7 @@ static int intel_atomic_check(struct drm_device *dev,struct intel_crtc_state *linked_crtc_state =intel_atomic_get_new_crtc_state (state, new_crtc_state->bigjoiner_linked_crtc); -if (needs_modeset (linked_crtc_state)) { +if (intel_crtc_needs_modeset (linked_crtc_state)) { new_crtc_state->uapi.mode_changed = true; new_crtc_state->update_pipe = false; }
@@ -15645,7 +15639,7 @@ static int intel_atomic_check(struct drm_device *dev,for_each_oldnew_intel_crtc_in_state (state, crtc, old_crtc_state, new_crtc_state, i) { -if (needs_modeset (new_crtc_state)) { +if (intel_crtc_needs_modeset (new_crtc_state)) { any_ms = true;continue ; }
@@ -15722,12 +15716,12 @@ static int intel_atomic_check(struct drm_device *dev, goto fail; } -if (!needs_modeset (new_crtc_state) && +if (!intel_crtc_needs_modeset (new_crtc_state) && !new_crtc_state->update_pipe)continue ;intel_dump_pipe_config (new_crtc_state, state, -needs_modeset (new_crtc_state) ? +intel_crtc_needs_modeset (new_crtc_state) ?"[modeset]" :"[fastset]" ); }
@@ -15759,7 +15753,7 @@ static int intel_atomic_prepare_commit(struct intel_atomic_state *state)return ret;for_each_new_intel_crtc_in_state (state, crtc, crtc_state, i) { -bool mode_changed =needs_modeset (crtc_state); +bool mode_changed =intel_crtc_needs_modeset (crtc_state);if (mode_changed || crtc_state->update_pipe || crtc_state->uapi.color_mgmt_changed) {
@@ -15850,7 +15844,7 @@ static void commit_pipe_config(struct intel_atomic_state *state,intel_atomic_get_old_crtc_state (state, crtc);const struct intel_crtc_state *new_crtc_state =intel_atomic_get_new_crtc_state (state, crtc); -bool modeset =needs_modeset (new_crtc_state); +bool modeset =intel_crtc_needs_modeset (new_crtc_state);/* * During modesets pipe configuration was programmed as the
@@ -15884,7 +15878,7 @@ static void intel_enable_crtc(struct intel_atomic_state *state,const struct intel_crtc_state *new_crtc_state =intel_atomic_get_new_crtc_state (state, crtc); -if (!needs_modeset (new_crtc_state)) +if (!intel_crtc_needs_modeset (new_crtc_state))return ;intel_crtc_update_active_timings (new_crtc_state);
@@ -15906,7 +15900,7 @@ static void intel_update_crtc(struct intel_atomic_state *state,intel_atomic_get_old_crtc_state (state, crtc);struct intel_crtc_state *new_crtc_state =intel_atomic_get_new_crtc_state (state, crtc); -bool modeset =needs_modeset (new_crtc_state); +bool modeset =intel_crtc_needs_modeset (new_crtc_state);if (!modeset) { if (new_crtc_state->preload_luts &&
@@ -15998,7 +15992,7 @@ static void intel_commit_modeset_disables(struct intel_atomic_state *state)/* Only disable port sync and MST slaves */ for_each_oldnew_intel_crtc_in_state (state, crtc, old_crtc_state, new_crtc_state, i) { -if (!needs_modeset (new_crtc_state) || old_crtc_state->bigjoiner) +if (!intel_crtc_needs_modeset (new_crtc_state) || old_crtc_state->bigjoiner)continue ;if (!old_crtc_state->hw.active)
@@ -16022,7 +16016,7 @@ static void intel_commit_modeset_disables(struct intel_atomic_state *state)/* Disable everything else left on */ for_each_oldnew_intel_crtc_in_state (state, crtc, old_crtc_state, new_crtc_state, i) { -if (!needs_modeset (new_crtc_state) || +if (!intel_crtc_needs_modeset (new_crtc_state) || (handled &BIT (crtc->pipe)) || old_crtc_state->bigjoiner_slave)continue ;
@@ -16072,7 +16066,7 @@ static void skl_commit_modeset_enables(struct intel_atomic_state *state)continue ;/* ignore allocations for crtc's that have been turned off. */ -if (!needs_modeset (new_crtc_state)) { +if (!intel_crtc_needs_modeset (new_crtc_state)) { entries[pipe] = old_crtc_state->wm.skl.ddb; update_pipes |=BIT (pipe); }else {
@@ -16267,7 +16261,7 @@ static void intel_atomic_commit_tail(struct intel_atomic_state *state)for_each_oldnew_intel_crtc_in_state (state, crtc, old_crtc_state, new_crtc_state, i) { -if (needs_modeset (new_crtc_state) || +if (intel_crtc_needs_modeset (new_crtc_state) || new_crtc_state->update_pipe) { put_domains[crtc->pipe] =
@@ -16293,7 +16287,7 @@ static void intel_atomic_commit_tail(struct intel_atomic_state *state)/* Complete the events for pipes that have now been disabled */ for_each_new_intel_crtc_in_state (state, crtc, new_crtc_state, i) { -bool modeset =needs_modeset (new_crtc_state); +bool modeset =intel_crtc_needs_modeset (new_crtc_state);/* Complete events for now disable pipes here. */ if (modeset && !new_crtc_state->hw.active && new_crtc_state->uapi.event) {
@@ -16341,7 +16335,7 @@ static void intel_atomic_commit_tail(struct intel_atomic_state *state)skl_disable_flip_done (crtc);if (new_crtc_state->hw.active && - !needs_modeset (new_crtc_state) && + !intel_crtc_needs_modeset (new_crtc_state) && !new_crtc_state->preload_luts && (new_crtc_state->uapi.color_mgmt_changed || new_crtc_state->update_pipe))
@@ -16712,7 +16706,7 @@ intel_prepare_plane_fb(struct drm_plane *_plane,* This should only fail upon a hung GPU, in which case we * can safely continue. */ -if (needs_modeset (crtc_state)) { +if (intel_crtc_needs_modeset (crtc_state)) { ret = i915_sw_fence_await_reservation(&state->commit_ready, old_obj->base.resv, NULL, false, 0,
@@ -16937,7 +16931,7 @@ intel_legacy_cursor_update(struct drm_plane *_plane,* * FIXME bigjoiner fastpath would be good */ -if (!crtc_state->hw.active ||needs_modeset (crtc_state) || +if (!crtc_state->hw.active ||intel_crtc_needs_modeset (crtc_state) || crtc_state->update_pipe || crtc_state->bigjoiner) goto slow;
drivers/gpu/drm/i915/display/intel_display_types.h +6 -0
@@ -1777,6 +1777,12 @@ intel_crtc_has_dp_encoder(const struct intel_crtc_state *crtc_state) (1 << INTEL_OUTPUT_EDP)); } +static inline bool +intel_crtc_needs_modeset (const struct intel_crtc_state *crtc_state) +{ +return drm_atomic_crtc_needs_modeset (&crtc_state->uapi); +} +static inline void intel_wait_for_vblank (struct drm_i915_private *dev_priv,enum pipe pipe) {
Signature · 6 lines
2.20.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 2/5 drm/i915/display: move to_intel_frontbuffer to header
From: Dave Airlie <[email protected]>
This will be used for some refactoring in other files, so move it first.
--- drivers/gpu/drm/i915/display/intel_display.c | 6 ------ drivers/gpu/drm/i915/display/intel_display_types.h | 6 ++++++ 2 files changed, 6 insertions(+), 6 deletions(-)
drivers/gpu/drm/i915/display/intel_display.c +0 -6
@@ -3611,12 +3611,6 @@ static void intel_plane_disable_noatomic(struct intel_crtc *crtc,intel_disable_plane (plane, crtc_state); } -static struct intel_frontbuffer * -to_intel_frontbuffer (struct drm_framebuffer *fb) -{ -return fb ?to_intel_framebuffer (fb)->frontbuffer :NULL ; -} -static void intel_find_initial_plane_obj (struct intel_crtc *intel_crtc,struct intel_initial_plane_config *plane_config)
drivers/gpu/drm/i915/display/intel_display_types.h +6 -0
@@ -1805,4 +1805,10 @@ static inline u32 intel_plane_ggtt_offset(const struct intel_plane_state *state) return i915_ggtt_offset(state->vma); } +static inline struct intel_frontbuffer * +to_intel_frontbuffer (struct drm_framebuffer *fb) +{ +return fb ?to_intel_framebuffer (fb)->frontbuffer :NULL ; +} +#endif /* __INTEL_DISPLAY_TYPES_H__ */
Signature · 6 lines
2.20.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 3/5 drm/i915/display: fix misused comma
In reply to Jani NikulaFrom: Dave Airlie <[email protected]>
There is no need for a comma use here.
--- drivers/gpu/drm/i915/display/intel_display.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/display/intel_display.c +2 -1
@@ -989,7 +989,8 @@ chv_find_best_dpll(const struct intel_limit *limit,* set to 2. If requires to support 200Mhz refclk, we need to * revisit this because n may not 1 anymore. */ - clock.n =1 , clock.m1 =2 ; + clock.n =1 ; + clock.m1 =2 ; target *=5 ;/* fast clock */ for (clock.p1 = limit->p1.max; clock.p1 >= limit->p1.min; clock.p1--) {
Signature · 6 lines
2.20.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 4/5 drm/i915: refactor cursor code out of i915_display.c
In reply to Jani NikulaFrom: Dave Airlie <[email protected]>
This file is a monster, let's start simple, the cursor plane code seems pretty standalone, and splits out easily enough.
--- drivers/gpu/drm/i915/Makefile | 1 + drivers/gpu/drm/i915/display/intel_cursor.c | 806 +++++++++++++++++++ drivers/gpu/drm/i915/display/intel_cursor.h | 17 + drivers/gpu/drm/i915/display/intel_display.c | 797 +----------------- drivers/gpu/drm/i915/display/intel_display.h | 7 + 5 files changed, 838 insertions(+), 790 deletions(-) create mode 100644 drivers/gpu/drm/i915/display/intel_cursor.c create mode 100644 drivers/gpu/drm/i915/display/intel_cursor.h
drivers/gpu/drm/i915/Makefile +1 -0
@@ -198,6 +198,7 @@ i915-y += \ display/intel_combo_phy.o \ display/intel_connector.o \ display/intel_csr.o \ + display/intel_cursor.o \ display/intel_display.o \ display/intel_display_power.o \ display/intel_dpio_phy.o \
drivers/gpu/drm/i915/display/intel_cursor.c new file +806 -0
806 lines not on this page · raw message
drivers/gpu/drm/i915/display/intel_cursor.h new file +17 -0
@@ -0,0 +1,17 @@ +/* SPDX-License-Identifier: MIT */ +/* +* Copyright © 2020 Intel Corporation +*/ + +#ifndef _INTEL_CURSOR_H_ +#define _INTEL_CURSOR_H_ + +enum pipe ; +struct drm_i915_private ; +struct intel_plane ; + +struct intel_plane * +intel_cursor_plane_create (struct drm_i915_private *dev_priv, +enum pipe pipe); + +#endif
drivers/gpu/drm/i915/display/intel_display.c +7 -790
857 lines not on this page · raw message
drivers/gpu/drm/i915/display/intel_display.h +7 -0
@@ -647,6 +647,13 @@ bool intel_format_info_is_yuv_semiplanar(const struct drm_format_info *info, uint64_t modifier); +int intel_plane_compute_gtt (struct intel_plane_state *plane_state); +u32 intel_plane_compute_aligned_offset (int *x,int *y, +const struct intel_plane_state *state, +int color_plane); +int intel_plane_pin_fb (struct intel_plane_state *plane_state); +void intel_plane_unpin_fb (struct intel_plane_state *old_plane_state); +/* modesetting */ void intel_modeset_init_hw (struct drm_i915_private *i915);int intel_modeset_init_noirq (struct drm_i915_private *i915);
Signature · 6 lines
2.20.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 5/5 drm/i915: refactor i915 plane code into separate file.
In reply to Jani NikulaFrom: Dave Airlie <[email protected]>
Ville suggested this as a good idea, let's move this before moving the crtc code.
--- drivers/gpu/drm/i915/Makefile | 3 +- drivers/gpu/drm/i915/display/i9xx_plane.c | 704 +++++++++++++++++++ drivers/gpu/drm/i915/display/i9xx_plane.h | 21 + drivers/gpu/drm/i915/display/intel_display.c | 689 +----------------- drivers/gpu/drm/i915/display/intel_display.h | 4 - drivers/gpu/drm/i915/display/intel_sprite.c | 1 + 6 files changed, 729 insertions(+), 693 deletions(-) create mode 100644 drivers/gpu/drm/i915/display/i9xx_plane.c create mode 100644 drivers/gpu/drm/i915/display/i9xx_plane.h
drivers/gpu/drm/i915/Makefile +2 -1
@@ -216,7 +216,8 @@ i915-y += \ display/intel_quirks.o \ display/intel_sprite.o \ display/intel_tc.o \ - display/intel_vga.o + display/intel_vga.o \ + display/i9xx_plane.o i915-$(CONFIG_ACPI) += \ display/intel_acpi.o \ display/intel_opregion.o
drivers/gpu/drm/i915/display/i9xx_plane.c new file +704 -0
704 lines not on this page · raw message
drivers/gpu/drm/i915/display/i9xx_plane.h new file +21 -0
@@ -0,0 +1,21 @@ +/* SPDX-License-Identifier: MIT */ +/* +* Copyright © 2020 Intel Corporation +*/ + +#ifndef _I9XX_PLANE_H_ +#define _I9XX_PLANE_H_ + +enum pipe ; +struct drm_i915_private ; +struct intel_plane ; + +unsigned int i9xx_plane_max_stride (struct intel_plane *plane, +u32 pixel_format,u64 modifier, +unsigned int rotation); +int i9xx_check_plane_surface (struct intel_plane_state *plane_state); + +struct intel_plane * +intel_primary_plane_create (struct drm_i915_private *dev_priv,enum pipe pipe); + +#endif
drivers/gpu/drm/i915/display/intel_display.c +1 -688
707 lines not on this page · raw message
drivers/gpu/drm/i915/display/intel_display.h +0 -4
@@ -630,11 +630,7 @@ u32 skl_plane_ctl_crtc(const struct intel_crtc_state *crtc_state);u32 skl_plane_stride (const struct intel_plane_state *plane_state,int plane);int skl_check_plane_surface (struct intel_plane_state *plane_state); -int i9xx_check_plane_surface (struct intel_plane_state *plane_state);int skl_format_to_fourcc (int format,bool rgb_order,bool alpha); -unsigned int i9xx_plane_max_stride (struct intel_plane *plane, -u32 pixel_format,u64 modifier, -unsigned int rotation);int bdw_get_pipemisc_bpp (struct intel_crtc *crtc);unsigned int intel_plane_fence_y_offset (const struct intel_plane_state *plane_state);
drivers/gpu/drm/i915/display/intel_sprite.c +1 -0
@@ -49,6 +49,7 @@#include "intel_psr.h" #include "intel_dsi.h" #include "intel_sprite.h" +#include "i9xx_plane.h" int intel_usecs_to_scanlines (const struct drm_display_mode *adjusted_mode,int usecs)
Signature · 6 lines
2.20.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI[Intel-gfx] ✗ Fi.CI.BUILD: failure for series starting with [CI,1/5] drm/i915/display: move needs_modeset to an inline in header
In reply to Jani Nikula== Series Details ==
== Series Details ==
Series: series starting with [CI,1/5] drm/i915/display: move needs_modeset to an inline in header
URL : https://patchwork.freedesktop.org/series/85132/
State : failure
== Summary ==
CALL scripts/checksyscalls.sh
CALL scripts/atomic/check-atomics.sh
DESCEND objtool
CHK include/generated/compile.h
HDRTEST drivers/gpu/drm/i915/display/i9xx_plane.h
In file included from <command-line>:./drivers/gpu/drm/i915/display/i9xx_plane.h:14:8: error: unknown type name ‘u32’
u32 pixel_format, u64 modifier,
^~~./drivers/gpu/drm/i915/display/i9xx_plane.h:14:26: error: unknown type name ‘u64’
u32 pixel_format, u64 modifier,
^~~./drivers/gpu/drm/i915/display/i9xx_plane.h:16:37: error: ‘struct intel_plane_state’ declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
int i9xx_check_plane_surface(struct intel_plane_state *plane_state);
^~~~~~~~~~~~~~~~~cc1: all warnings being treated as errorsdrivers/gpu/drm/i915/Makefile:307: recipe for target 'drivers/gpu/drm/i915/display/i9xx_plane.hdrtest' failed make[4]: *** [drivers/gpu/drm/i915/display/i9xx_plane.hdrtest] Error 1 scripts/Makefile.build:496: recipe for target 'drivers/gpu/drm/i915' failed
make[3]: *** [drivers/gpu/drm/i915] Error 2scripts/Makefile.build:496: recipe for target 'drivers/gpu/drm' failed
make[2]: *** [drivers/gpu/drm] Error 2scripts/Makefile.build:496: recipe for target 'drivers/gpu' failed
make[1]: *** [drivers/gpu] Error 2
Makefile:1805: recipe for target 'drivers' failed
make: *** [drivers] Error 2
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v2 1/1 drm/i915: refactor i915 plane code into separate file.
In reply to Jani NikulaFrom: Dave Airlie <[email protected]>
Ville suggested this as a good idea, let's move this before moving the crtc code.
--- drivers/gpu/drm/i915/Makefile | 3 +- drivers/gpu/drm/i915/display/i9xx_plane.c | 704 +++++++++++++++++++ drivers/gpu/drm/i915/display/i9xx_plane.h | 24 + drivers/gpu/drm/i915/display/intel_display.c | 689 +----------------- drivers/gpu/drm/i915/display/intel_display.h | 4 - drivers/gpu/drm/i915/display/intel_sprite.c | 1 + 6 files changed, 732 insertions(+), 693 deletions(-) create mode 100644 drivers/gpu/drm/i915/display/i9xx_plane.c create mode 100644 drivers/gpu/drm/i915/display/i9xx_plane.h
drivers/gpu/drm/i915/Makefile +2 -1
@@ -216,7 +216,8 @@ i915-y += \ display/intel_quirks.o \ display/intel_sprite.o \ display/intel_tc.o \ - display/intel_vga.o + display/intel_vga.o \ + display/i9xx_plane.o i915-$(CONFIG_ACPI) += \ display/intel_acpi.o \ display/intel_opregion.o
drivers/gpu/drm/i915/display/i9xx_plane.c new file +704 -0
704 lines not on this page · raw message
drivers/gpu/drm/i915/display/i9xx_plane.h new file +24 -0
@@ -0,0 +1,24 @@ +/* SPDX-License-Identifier: MIT */ +/* +* Copyright © 2020 Intel Corporation +*/ + +#ifndef _I9XX_PLANE_H_ +#define _I9XX_PLANE_H_ + +#include <linux/types.h> + +enum pipe ; +struct drm_i915_private ; +struct intel_plane ; +struct intel_plane_state ; + +unsigned int i9xx_plane_max_stride (struct intel_plane *plane, +u32 pixel_format,u64 modifier, +unsigned int rotation); +int i9xx_check_plane_surface (struct intel_plane_state *plane_state); + +struct intel_plane * +intel_primary_plane_create (struct drm_i915_private *dev_priv,enum pipe pipe); + +#endif
drivers/gpu/drm/i915/display/intel_display.c +1 -688
707 lines not on this page · raw message
drivers/gpu/drm/i915/display/intel_display.h +0 -4
@@ -630,11 +630,7 @@ u32 skl_plane_ctl_crtc(const struct intel_crtc_state *crtc_state);u32 skl_plane_stride (const struct intel_plane_state *plane_state,int plane);int skl_check_plane_surface (struct intel_plane_state *plane_state); -int i9xx_check_plane_surface (struct intel_plane_state *plane_state);int skl_format_to_fourcc (int format,bool rgb_order,bool alpha); -unsigned int i9xx_plane_max_stride (struct intel_plane *plane, -u32 pixel_format,u64 modifier, -unsigned int rotation);int bdw_get_pipemisc_bpp (struct intel_crtc *crtc);unsigned int intel_plane_fence_y_offset (const struct intel_plane_state *plane_state);
drivers/gpu/drm/i915/display/intel_sprite.c +1 -0
@@ -49,6 +49,7 @@#include "intel_psr.h" #include "intel_dsi.h" #include "intel_sprite.h" +#include "i9xx_plane.h" int intel_usecs_to_scanlines (const struct drm_display_mode *adjusted_mode,int usecs)
Signature · 6 lines
2.20.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [CI,1/5] drm/i915/display: move needs_modeset to an inline in header (rev2)
In reply to Jani Nikula== Series Details ==
== Series Details ==
Series: series starting with [CI,1/5] drm/i915/display: move needs_modeset to an inline in header (rev2)
URL : https://patchwork.freedesktop.org/series/85132/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip f3393b6c2693 drm/i915/display: move needs_modeset to an inline in header e6777135cd18 drm/i915/display: move to_intel_frontbuffer to header c7a3e0296b01 drm/i915/display: fix misused comma 9e8bf3e7db29 drm/i915: refactor cursor code out of i915_display.c -:30: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #30: new file mode 100644
-:529: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #529: FILE: drivers/gpu/drm/i915/display/intel_cursor.c:495:
+ unsigned width = drm_rect_width(&plane_state->uapi.dst);
-:530: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #530: FILE: drivers/gpu/drm/i915/display/intel_cursor.c:496:
+ unsigned height = drm_rect_height(&plane_state->uapi.dst);
-:559: WARNING:REPEATED_WORD: Possible repeated word: 'by' #559: FILE: drivers/gpu/drm/i915/display/intel_cursor.c:525:
+ * The other registers are armed by by the CURBASE write
-:786: CHECK:SPACING: No space is necessary after a cast #786: FILE: drivers/gpu/drm/i915/display/intel_cursor.c:752:
+ cursor->i9xx_plane = (enum i9xx_plane_id) pipe;
total: 0 errors, 4 warnings, 1 checks, 1700 lines checkeda324abeeea6f drm/i915: refactor i915 plane code into separate file.
-:32: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #32:
new file mode 100644
-:570: CHECK:SPACING: spaces preferred around that '*' (ctx:VxV) #570: FILE: drivers/gpu/drm/i915/display/i9xx_plane.c:534:
+ return 32*1024;
^
-:573: CHECK:SPACING: spaces preferred around that '*' (ctx:VxV) #573: FILE: drivers/gpu/drm/i915/display/i9xx_plane.c:537:
+ return 16*1024;
^
-:575: CHECK:SPACING: spaces preferred around that '*' (ctx:VxV) #575: FILE: drivers/gpu/drm/i915/display/i9xx_plane.c:539:
+ return 32*1024;
^
-:578: CHECK:SPACING: spaces preferred around that '*' (ctx:VxV) #578: FILE: drivers/gpu/drm/i915/display/i9xx_plane.c:542:
+ return 8*1024;
^
-:580: CHECK:SPACING: spaces preferred around that '*' (ctx:VxV) #580: FILE: drivers/gpu/drm/i915/display/i9xx_plane.c:544:
+ return 16*1024;
^
-:583: CHECK:SPACING: spaces preferred around that '*' (ctx:VxV) #583: FILE: drivers/gpu/drm/i915/display/i9xx_plane.c:547:
+ return 4*1024;
^
-:585: CHECK:SPACING: spaces preferred around that '*' (ctx:VxV) #585: FILE: drivers/gpu/drm/i915/display/i9xx_plane.c:549:
+ return 8*1024;
^
-:632: CHECK:SPACING: No space is necessary after a cast #632: FILE: drivers/gpu/drm/i915/display/i9xx_plane.c:596:
+ plane->i9xx_plane = (enum i9xx_plane_id) !pipe;
-:634: CHECK:SPACING: No space is necessary after a cast #634: FILE: drivers/gpu/drm/i915/display/i9xx_plane.c:598:
+ plane->i9xx_plane = (enum i9xx_plane_id) pipe;
total: 0 errors, 1 warnings, 9 checks, 1462 lines checked
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [CI,1/5] drm/i915/display: move needs_modeset to an inline in header (rev2)
In reply to Jani Nikula== Series Details ==
== Series Details ==
Series: series starting with [CI,1/5] drm/i915/display: move needs_modeset to an inline in header (rev2)
URL : https://patchwork.freedesktop.org/series/85132/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_9509 -> Patchwork_19191
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19191/index.html
Known issues
------------
Here are the changes found in Patchwork_19191 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@amdgpu/amd_cs_nop@fork-compute0:
- fi-tgl-u2: NOTRUN -> [SKIP][1] ([fdo#109315] / [i915#2575]) +17 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19191/fi-tgl-u2/igt@amdgpu/[email protected]
* igt@i915_pm_rpm@module-reload:
- fi-byt-j1900: [PASS][2] -> [INCOMPLETE][3] ([i915#142] / [i915#2405])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9509/fi-byt-j1900/igt@[email protected]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19191/fi-byt-j1900/igt@[email protected]
* igt@runner@aborted:
- fi-byt-j1900: NOTRUN -> [FAIL][4] ([i915#1814])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19191/fi-byt-j1900/igt@[email protected]
* igt@vgem_basic@setversion:
- fi-tgl-y: [PASS][5] -> [DMESG-WARN][6] ([i915#402]) +2 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9509/fi-tgl-y/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19191/fi-tgl-y/igt@[email protected]
#### Possible fixes ####
* igt@gem_tiled_blits@basic:
- fi-tgl-y: [DMESG-WARN][7] ([i915#402]) -> [PASS][8] +2 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9509/fi-tgl-y/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19191/fi-tgl-y/igt@[email protected]
* igt@i915_selftest@live@hangcheck:
- fi-tgl-u2: [INCOMPLETE][9] -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9509/fi-tgl-u2/igt@i915_selftest@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19191/fi-tgl-u2/igt@i915_selftest@[email protected]
* igt@kms_chamelium@dp-edid-read:
- fi-cml-u2: [FAIL][11] ([i915#2679]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9509/fi-cml-u2/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19191/fi-cml-u2/igt@[email protected]
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[i915#142]: https://gitlab.freedesktop.org/drm/intel/issues/142
[i915#1814]: https://gitlab.freedesktop.org/drm/intel/issues/1814
[i915#2405]: https://gitlab.freedesktop.org/drm/intel/issues/2405
[i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
[i915#2679]: https://gitlab.freedesktop.org/drm/intel/issues/2679
[i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
Participating hosts (42 -> 37)
------------------------------
Missing (5): fi-ilk-m540 fi-hsw-4200u fi-glk-dsi fi-bsw-cyan fi-bdw-samus
Build changes
-------------
* Linux: CI_DRM_9509 -> Patchwork_19191
CI-20190529: 20190529
CI_DRM_9509: 66ecfb1df07b703dc4e83e8c520b186dffe6d2b3 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5913: b30bdfecaf1ff38b83c0bfbcf5981732a968a464 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_19191: a324abeeea6f7aa420eb91630ffb657111fb7cd0 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
a324abeeea6f drm/i915: refactor i915 plane code into separate file. 9e8bf3e7db29 drm/i915: refactor cursor code out of i915_display.c c7a3e0296b01 drm/i915/display: fix misused comma e6777135cd18 drm/i915/display: move to_intel_frontbuffer to header f3393b6c2693 drm/i915/display: move needs_modeset to an inline in header
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19191/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [CI,1/5] drm/i915/display: move needs_modeset to an inline in header (rev2)
In reply to Jani Nikula== Series Details ==
== Series Details ==
Series: series starting with [CI,1/5] drm/i915/display: move needs_modeset to an inline in header (rev2)
URL : https://patchwork.freedesktop.org/series/85132/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_9509_full -> Patchwork_19191_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_19191_full absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in Patchwork_19191_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_19191_full:
### IGT changes ###
#### Possible regressions ####
* igt@gem_exec_whisper@basic-forked:
- shard-iclb: [PASS][1] -> [DMESG-WARN][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9509/shard-iclb5/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19191/shard-iclb2/igt@[email protected]
* igt@i915_selftest@live@hugepages:
- shard-skl: [PASS][3] -> [DMESG-WARN][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9509/shard-skl3/igt@i915_selftest@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19191/shard-skl8/igt@i915_selftest@[email protected]
* igt@kms_cursor_legacy@cursor-vs-flip-legacy:
- shard-hsw: [PASS][5] -> [INCOMPLETE][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9509/shard-hsw8/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19191/shard-hsw8/igt@[email protected]
* igt@kms_flip@basic-flip-vs-wf_vblank:
- shard-iclb: NOTRUN -> [SKIP][7] +4 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19191/shard-iclb2/igt@kms_flip@basic-flip-vs-wf_vblank.html
* igt@syncobj_wait@invalid-wait-bad-flags:
- shard-iclb: [PASS][8] -> [SKIP][9] +19 similar issues
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9509/shard-iclb5/igt@[email protected]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19191/shard-iclb2/igt@[email protected]
#### Warnings ####
* igt@i915_pm_rpm@modeset-non-lpsp:
- shard-iclb: [SKIP][10] ([fdo#110892]) -> [SKIP][11]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9509/shard-iclb5/igt@[email protected]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19191/shard-iclb2/igt@[email protected]
* igt@kms_color_chamelium@pipe-invalid-ctm-matrix-sizes:
- shard-iclb: [SKIP][12] ([fdo#109284] / [fdo#111827]) -> [SKIP][13] +2 similar issues
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9509/shard-iclb5/igt@[email protected]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19191/shard-iclb2/igt@[email protected]
* igt@kms_cursor_legacy@cursora-vs-flipb-toggle:
- shard-iclb: [SKIP][14] ([fdo#109274] / [fdo#109278]) -> [SKIP][15]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9509/shard-iclb5/igt@[email protected]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19191/shard-iclb2/igt@[email protected]
* igt@kms_dp_tiled_display@basic-test-pattern:
- shard-iclb: [SKIP][16] ([i915#426]) -> [SKIP][17]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9509/shard-iclb5/igt@[email protected]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19191/shard-iclb2/igt@[email protected]
Known issues
------------
Here are the changes found in Patchwork_19191_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_persistence@legacy-engines-cleanup:
- shard-hsw: NOTRUN -> [SKIP][18] ([fdo#109271] / [i915#1099]) +1 similar issue
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19191/shard-hsw1/igt@[email protected]
* igt@gem_ctx_persistence@processes:
- shard-iclb: [PASS][19] -> [SKIP][20] ([fdo#109315]) +21 similar issues
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9509/shard-iclb5/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19191/shard-iclb2/igt@[email protected]
* igt@gem_exec_capture@pi@rcs0:
- shard-skl: [PASS][21] -> [INCOMPLETE][22] ([i915#2369])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9509/shard-skl9/igt@gem_exec_capture@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19191/shard-skl6/igt@gem_exec_capture@[email protected]
* igt@gem_exec_schedule@implicit-write-read:
- shard-iclb: NOTRUN -> [SKIP][23] ([fdo#109315]) +3 similar issues
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19191/shard-iclb2/igt@[email protected]
* igt@gem_exec_whisper@basic-queues-forked:
- shard-glk: [PASS][24] -> [DMESG-WARN][25] ([i915#118] / [i915#95])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9509/shard-glk8/igt@[email protected]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19191/shard-glk4/igt@[email protected]
* igt@i915_pm_rc6_residency@rc6-idle:
- shard-hsw: [PASS][26] -> [WARN][27] ([i915#1519])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9509/shard-hsw8/igt@[email protected]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19191/shard-hsw1/igt@[email protected]
* igt@i915_pm_rps@waitboost:
- shard-hsw: [PASS][28] -> [FAIL][29] ([i915#39])
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9509/shard-hsw1/igt@[email protected]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19191/shard-hsw4/igt@[email protected]
* igt@i915_selftest@live@gem_contexts:
- shard-skl: [PASS][30] -> [INCOMPLETE][31] ([i915#198] / [i915#2369])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9509/shard-skl3/igt@i915_selftest@live@gem_contexts.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19191/shard-skl8/igt@i915_selftest@live@gem_contexts.html
* igt@i915_selftest@live@hangcheck:
- shard-iclb: [PASS][32] -> [INCOMPLETE][33] ([i915#926])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9509/shard-iclb5/igt@i915_selftest@[email protected]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19191/shard-iclb2/igt@i915_selftest@[email protected]
* igt@kms_async_flips@alternate-sync-async-flip:
- shard-skl: [PASS][34] -> [FAIL][35] ([i915#2521])
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9509/shard-skl9/igt@[email protected]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19191/shard-skl6/igt@[email protected]
* igt@kms_big_fb@y-tiled-addfb-size-overflow:
- shard-hsw: NOTRUN -> [SKIP][36] ([fdo#109271]) +64 similar issues
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19191/shard-hsw1/igt@[email protected]
* igt@kms_chamelium@hdmi-hpd-enable-disable-mode:
- shard-hsw: NOTRUN -> [SKIP][37] ([fdo#109271] / [fdo#111827]) +6 similar issues
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19191/shard-hsw1/igt@[email protected]
* igt@kms_color@pipe-a-gamma:
- shard-iclb: [PASS][38] -> [SKIP][39] ([i915#1149])
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9509/shard-iclb5/igt@[email protected]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19191/shard-iclb2/igt@[email protected]
* igt@kms_color_chamelium@pipe-c-degamma:
- shard-skl: NOTRUN -> [SKIP][40] ([fdo#109271] / [fdo#111827]) +2 similar issues
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19191/shard-skl3/igt@[email protected]
* igt@kms_cursor_crc@pipe-b-cursor-64x64-offscreen:
- shard-skl: [PASS][41] -> [FAIL][42] ([i915#54]) +1 similar issue
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9509/shard-skl2/igt@[email protected]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19191/shard-skl10/igt@[email protected]
* igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1:
- shard-tglb: [PASS][43] -> [FAIL][44] ([i915#2598])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9509/shard-tglb5/igt@kms_flip@[email protected]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19191/shard-tglb5/igt@kms_flip@[email protected]
* igt@kms_flip@plain-flip-fb-recreate@a-edp1:
- shard-skl: [PASS][45] -> [FAIL][46] ([i915#2122])
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9509/shard-skl8/igt@kms_flip@[email protected]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19191/shard-skl2/igt@kms_flip@[email protected]
* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-indfb-draw-blt:
- shard-skl: NOTRUN -> [SKIP][47] ([fdo#109271]) +10 similar issues
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19191/shard-skl3/igt@[email protected]
* igt@kms_hdr@bpc-switch-dpms:
- shard-skl: [PASS][48] -> [FAIL][49] ([i915#1188]) +1 similar issue
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9509/shard-skl10/igt@[email protected]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19191/shard-skl6/igt@[email protected]
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
- shard-kbl: [PASS][50] -> [DMESG-WARN][51] ([i915#180]) +1 similar issue
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9509/shard-kbl4/igt@[email protected]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19191/shard-kbl3/igt@[email protected]
* igt@kms_psr@psr2_sprite_plane_move:
- shard-iclb: [PASS][52] -> [SKIP][53] ([fdo#109441]) +2 similar issues
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9509/shard-iclb2/igt@kms_psr@psr2_sprite_plane_move.html
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19191/shard-iclb7/igt@kms_psr@psr2_sprite_plane_move.html
#### Possible fixes ####
* igt@gem_eio@in-flight-suspend:
- shard-skl: [INCOMPLETE][54] ([i915#1037] / [i915#198]) -> [PASS][55]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9509/shard-skl1/igt@[email protected]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19191/shard-skl3/igt@[email protected]
* {igt@gem_exec_balancer@fairslice}:
- shard-tglb: [FAIL][56] ([i915#2802]) -> [PASS][57]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9509/shard-tglb1/igt@[email protected]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19191/shard-tglb3/igt@[email protected]
- shard-iclb: [FAIL][58] ([i915#2802]) -> [PASS][59]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9509/shard-iclb1/igt@[email protected]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19191/shard-iclb3/igt@[email protected]
* {igt@gem_exec_schedule@u-fairslice@vcs0}:
- shard-skl: [DMESG-WARN][60] ([i915#1610]) -> [PASS][61]
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9509/shard-skl8/igt@gem_exec_schedule@[email protected]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19191/shard-skl4/igt@gem_exec_schedule@[email protected]
* {igt@gem_vm_create@destroy-race}:
- shard-tglb: [TIMEOUT][62] ([i915#2795]) -> [PASS][63]
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9509/shard-tglb5/igt@[email protected]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19191/shard-tglb1/igt@[email protected]
* igt@kms_big_fb@x-tiled-16bpp-rotate-180:
- shard-snb: [SKIP][64] ([fdo#109271]) -> [PASS][65]
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9509/shard-snb5/igt@[email protected]
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19191/shard-snb5/igt@[email protected]
* igt@kms_cursor_crc@pipe-a-cursor-128x128-random:
- shard-skl: [FAIL][66] ([i915#54]) -> [PASS][67]
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9509/shard-skl6/igt@[email protected]
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19191/shard-skl1/igt@[email protected]
* igt@kms_flip@plain-flip-fb-recreate@a-hdmi-a1:
- shard-glk: [FAIL][68] ([i915#2122]) -> [PASS][69]
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9509/shard-glk9/igt@kms_flip@[email protected]
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19191/shard-glk4/igt@kms_flip@[email protected]
* igt@kms_flip@plain-flip-fb-recreate@b-edp1:
- shard-skl: [FAIL][70] ([i915#2122]) -> [PASS][71]
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9509/shard-skl8/igt@kms_flip@[email protected]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19191/shard-skl2/igt@kms_flip@[email protected]
* igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min:
- shard-skl: [FAIL][72] ([fdo#108145] / [i915#265]) -> [PASS][73]
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9509/shard-skl7/igt@[email protected]
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19191/shard-skl7/igt@[email protected]
* igt@kms_plane_lowres@pipe-b-tiling-yf:
- shard-kbl: [DMESG-WARN][74] ([i915#165] / [i915#180] / [i915#78]) -> [PASS][75]
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9509/shard-kbl2/igt@[email protected]
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19191/shard-kbl7/igt@[email protected]
* igt@kms_psr@psr2_cursor_plane_onoff:
- shard-iclb: [SKIP][76] ([fdo#109441]) -> [PASS][77] +2 similar issues
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9509/shard-iclb5/igt@kms_psr@psr2_cursor_plane_onoff.html
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19191/shard-iclb2/igt@kms_psr@psr2_cursor_plane_onoff.html
#### Warnings ####
* igt@gem_render_copy@yf-tiled-mc-ccs-to-vebox-y-tiled:
- shard-iclb: [SKIP][78] ([i915#768]) -> [SKIP][79] ([fdo#109315])
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9509/shard-iclb5/igt@[email protected]
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19191/shard-iclb2/igt@[email protected]
* igt@gem_userptr_blits@readonly-unsync:
- shard-iclb: [SKIP][80] ([fdo#110426] / [i915#1704]) -> [SKIP][81] ([fdo#109315])
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9509/shard-iclb5/igt@[email protected]
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19191/shard-iclb2/igt@[email protected]
* igt@gen7_exec_parse@chained-batch:
- shard-iclb: [SKIP][82] ([fdo#109289]) -> [SKIP][83] ([fdo#109315])
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9509/shard-iclb5/igt@[email protected]
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19191/shard-iclb2/igt@[email protected]
* igt@gen9_exec_parse@bb-start-out:
- shard-iclb: [SKIP][84] ([fdo#112306]) -> [SKIP][85] ([fdo#109315])
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9509/shard-iclb5/igt@[email protected]
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19191/shard-iclb2/igt@[email protected]
* igt@i915_pm_rc6_residency@rc6-idle:
- shard-iclb: [WARN][86] ([i915#2684]) -> [WARN][87] ([i915#1804] / [i915#2684])
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9509/shard-iclb2/igt@[email protected]
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19191/shard-iclb7/igt@[email protected]
* igt@kms_big_fb@linear-8bpp-rotate-270:
- shard-iclb: [SKIP][88] ([fdo#110725] / [fdo#111614]) -> [SKIP][89] ([fdo#109315])
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9509/shard-iclb5/igt@[email protected]
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19191/shard-iclb2/igt@[email protected]
* igt@kms_cursor_edge_walk@pipe-d-64x64-bottom-edge:
- shard-iclb: [SKIP][90] ([fdo#109278]) -> [SKIP][91] ([fdo#109278] / [fdo#109315])
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9509/shard-iclb5/igt@[email protected]
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19191/shard-iclb2/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-pri-shrfb-draw-mmap-cpu:
- shard-iclb: [SKIP][92] ([fdo#109280]) -> [SKIP][93] ([fdo#109315]) +6 similar issues
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9509/shard-iclb5/igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-pri-shrfb-draw-mmap-cpu.html
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19191/shard-iclb2/igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-pri-shrfb-draw-mmap-cpu.html
* igt@kms_psr@psr2_cursor_mmap_gtt:
- shard-iclb: [SKIP][94] ([fdo#109441]) -> [SKIP][95] ([fdo#109315])
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9509/shard-iclb5/igt@kms_psr@psr2_cursor_mmap_gtt.html
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19191/shard-iclb2/igt@kms_psr@psr2_cursor_mmap_gtt.html
* igt@nouveau_crc@pipe-d-source-outp-complete:
- shard-iclb: [SKIP][96] ([fdo#109278] / [i915#2530]) -> [SKIP][97] ([fdo#109278])
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9509/shard-iclb5/igt@[email protected]
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19191/shard-iclb2/igt@[email protected]
* igt@runner@aborted:
- shard-kbl: ([FAIL][98], [FAIL][99]) ([i915#1814] / [i915#2295] / [i915#483]) -> ([FAIL][100], [FAIL][101], [FAIL][102], [FAIL][103]) ([i915#1436] / [i915#1814] / [i915#2295] / [i915#483])
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9509/shard-kbl7/igt@[email protected]
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9509/shard-kbl6/igt@[email protected]
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19191/shard-kbl3/igt@[email protected]
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19191/shard-kbl2/igt@[email protected]
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19191/shard-kbl4/igt@[email protected]
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19191/shard-kbl3/igt@[email protected]
- shard-glk: ([FAIL][104], [FAIL][105]) ([i915#1814] / [i915#2295] / [k.org#202321]) -> ([FAIL][106], [FAIL][107]) ([i915#1814] / [i915#2295] / [i915#483] / [k.org#202321])
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9509/shard-glk2/igt@[email protected]
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9509/shard-glk9/igt@[email protected]
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19191/shard-glk4/igt@[email protected]
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19191/shard-glk3/igt@[email protected]
- shard-skl: ([FAIL][108], [FAIL][109]) ([i915#2295] / [i915#2426]) -> ([FAIL][110], [FAIL][111], [FAIL][112], [FAIL][113]) ([i915#1436] / [i915#2295] / [i915#2426])
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9509/shard-skl2/igt@[email protected]
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9509/shard-skl8/igt@[email protected]
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19191/shard-skl8/igt@[email protected]
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19191/shard-skl4/igt@[email protected]
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19191/shard-skl2/igt@[email protected]
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19191/shard-skl6/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#110426]: https://bugs.freedesktop.org/show_bug.cgi?id=110426
[fdo#110725]: https://bugs.freedesktop.org/show_bug.cgi?id=110725
[fdo#110892]: https://bugs.freedesktop.org/show_bug.cgi?id=110892
[fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[fdo#112306]: https://bugs.freedesktop.org/show_bug.cgi?id=112306
[i915#1037]: https://gitlab.freedesktop.org/drm/intel/issues/1037
[i915#1099]: https://gitlab.freedesktop.org/drm/intel/issues/1099
[i915#1149]: https://gitlab.freedesktop.org/drm/intel/issues/1149
[i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
[i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188
[i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436
[i915#1519]: https://gitlab.freedesktop.org/drm/intel/issues/1519
[i915#1610]: https://gitlab.freedesktop.org/drm/intel/issues/1610
[i915#165]: https://gitlab.freedesktop.org/drm/intel/issues/165
[i915#1704]: https://gitlab.freedesktop.org/drm/intel/issues/1704
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1804]: https://gitlab.freedesktop.org/drm/intel/issues/1804
[i915#1814]: https://gitlab.freedesktop.org/drm/intel/issues/1814
[i915#198]: https://gitlab.freedesktop.org/drm/intel/issues/198
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2295]: https://gitlab.freedesktop.org/drm/intel/issues/2295
[i915#2369]: https://gitlab.freedesktop.org/drm/intel/issues/2369
[i915#2426]: https://gitlab.freedesktop.org/drm/intel/issues/2426
[i915#2521]: https://gitlab.freedesktop.org/drm/intel/issues/2521
[i915#2530]: https://gitlab.freedesktop.org/drm/intel/issues/2530
[i915#2598]: https://gitlab.freedesktop.org/drm/intel/issues/2598
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#2684]: https://gitlab.freedesktop.org/drm/intel/issues/2684
[i915#2795]: https://gitlab.freedesktop.org/drm/intel/issues/2795
[i915#2802]: https://gitlab.freedesktop.org/drm/intel/issues/2802
[i915#2804]: https://gitlab.freedesktop.org/drm/intel/issues/2804
[i915#39]: https://gitlab.freedesktop.org/drm/intel/issues/39
[i915#426]: https://gitlab.freedesktop.org/drm/intel/issues/426
[i915#483]: https://gitlab.freedesktop.org/drm/intel/issues/483
[i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54
[i915#768]: https://gitlab.freedesktop.org/drm/intel/issues/768
[i915#78]: https://gitlab.freedesktop.org/drm/intel/issues/78
[i915#926]: https://gitlab.freedesktop.org/drm/intel/issues/926
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
[k.org#202321]: https://bugzilla.kernel.org/show_bug.cgi?id=202321
Participating hosts (10 -> 10)
------------------------------
No changes in participating hosts
Build changes
-------------
* Linux: CI_DRM_9509 -> Patchwork_19191
CI-20190529: 20190529
CI_DRM_9509: 66ecfb1df07b703dc4e83e8c520b186dffe6d2b3 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5913: b30bdfecaf1ff38b83c0bfbcf5981732a968a464 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_19191: a324abeeea6f7aa420eb91630ffb657111fb7cd0 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19191/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [CI,1/5] drm/i915/display: move needs_modeset to an inline in header (rev3)
In reply to Jani Nikula== Series Details ==
== Series Details ==
Series: series starting with [CI,1/5] drm/i915/display: move needs_modeset to an inline in header (rev3)
URL : https://patchwork.freedesktop.org/series/85132/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip e8060d01a918 drm/i915/display: move needs_modeset to an inline in header da73a1c19031 drm/i915/display: move to_intel_frontbuffer to header 9b2022983792 drm/i915/display: fix misused comma 864517beaa0c drm/i915: refactor cursor code out of i915_display.c -:30: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #30: new file mode 100644
-:529: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #529: FILE: drivers/gpu/drm/i915/display/intel_cursor.c:495:
+ unsigned width = drm_rect_width(&plane_state->uapi.dst);
-:530: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #530: FILE: drivers/gpu/drm/i915/display/intel_cursor.c:496:
+ unsigned height = drm_rect_height(&plane_state->uapi.dst);
-:559: WARNING:REPEATED_WORD: Possible repeated word: 'by' #559: FILE: drivers/gpu/drm/i915/display/intel_cursor.c:525:
+ * The other registers are armed by by the CURBASE write
-:786: CHECK:SPACING: No space is necessary after a cast #786: FILE: drivers/gpu/drm/i915/display/intel_cursor.c:752:
+ cursor->i9xx_plane = (enum i9xx_plane_id) pipe;
total: 0 errors, 4 warnings, 1 checks, 1700 lines checkeda759b1ea292e drm/i915: refactor i915 plane code into separate file.
-:32: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #32:
new file mode 100644
-:570: CHECK:SPACING: spaces preferred around that '*' (ctx:VxV) #570: FILE: drivers/gpu/drm/i915/display/i9xx_plane.c:534:
+ return 32*1024;
^
-:573: CHECK:SPACING: spaces preferred around that '*' (ctx:VxV) #573: FILE: drivers/gpu/drm/i915/display/i9xx_plane.c:537:
+ return 16*1024;
^
-:575: CHECK:SPACING: spaces preferred around that '*' (ctx:VxV) #575: FILE: drivers/gpu/drm/i915/display/i9xx_plane.c:539:
+ return 32*1024;
^
-:578: CHECK:SPACING: spaces preferred around that '*' (ctx:VxV) #578: FILE: drivers/gpu/drm/i915/display/i9xx_plane.c:542:
+ return 8*1024;
^
-:580: CHECK:SPACING: spaces preferred around that '*' (ctx:VxV) #580: FILE: drivers/gpu/drm/i915/display/i9xx_plane.c:544:
+ return 16*1024;
^
-:583: CHECK:SPACING: spaces preferred around that '*' (ctx:VxV) #583: FILE: drivers/gpu/drm/i915/display/i9xx_plane.c:547:
+ return 4*1024;
^
-:585: CHECK:SPACING: spaces preferred around that '*' (ctx:VxV) #585: FILE: drivers/gpu/drm/i915/display/i9xx_plane.c:549:
+ return 8*1024;
^
-:632: CHECK:SPACING: No space is necessary after a cast #632: FILE: drivers/gpu/drm/i915/display/i9xx_plane.c:596:
+ plane->i9xx_plane = (enum i9xx_plane_id) !pipe;
-:634: CHECK:SPACING: No space is necessary after a cast #634: FILE: drivers/gpu/drm/i915/display/i9xx_plane.c:598:
+ plane->i9xx_plane = (enum i9xx_plane_id) pipe;
total: 0 errors, 1 warnings, 9 checks, 1462 lines checked
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [CI,1/5] drm/i915/display: move needs_modeset to an inline in header (rev3)
In reply to Jani Nikula== Series Details ==
== Series Details ==
Series: series starting with [CI,1/5] drm/i915/display: move needs_modeset to an inline in header (rev3)
URL : https://patchwork.freedesktop.org/series/85132/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_9509 -> Patchwork_19193
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19193/index.html
Known issues
------------
Here are the changes found in Patchwork_19193 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@amdgpu/amd_cs_nop@fork-compute0:
- fi-tgl-u2: NOTRUN -> [SKIP][1] ([fdo#109315] / [i915#2575]) +17 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19193/fi-tgl-u2/igt@amdgpu/[email protected]
* igt@gem_exec_gttfill@basic:
- fi-tgl-y: [PASS][2] -> [DMESG-WARN][3] ([i915#402]) +2 similar issues
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9509/fi-tgl-y/igt@[email protected]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19193/fi-tgl-y/igt@[email protected]
#### Possible fixes ####
* igt@gem_tiled_blits@basic:
- fi-tgl-y: [DMESG-WARN][4] ([i915#402]) -> [PASS][5] +2 similar issues
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9509/fi-tgl-y/igt@[email protected]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19193/fi-tgl-y/igt@[email protected]
* igt@i915_selftest@live@hangcheck:
- fi-tgl-u2: [INCOMPLETE][6] -> [PASS][7]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9509/fi-tgl-u2/igt@i915_selftest@[email protected]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19193/fi-tgl-u2/igt@i915_selftest@[email protected]
* igt@kms_chamelium@dp-edid-read:
- fi-cml-u2: [FAIL][8] ([i915#2679]) -> [PASS][9]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9509/fi-cml-u2/igt@[email protected]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19193/fi-cml-u2/igt@[email protected]
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
[i915#2679]: https://gitlab.freedesktop.org/drm/intel/issues/2679
[i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
Participating hosts (42 -> 37)
------------------------------
Missing (5): fi-ilk-m540 fi-hsw-4200u fi-bsw-cyan fi-bsw-nick fi-bdw-samus
Build changes
-------------
* Linux: CI_DRM_9509 -> Patchwork_19193
CI-20190529: 20190529
CI_DRM_9509: 66ecfb1df07b703dc4e83e8c520b186dffe6d2b3 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5913: b30bdfecaf1ff38b83c0bfbcf5981732a968a464 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_19193: a759b1ea292e30f7d50c2f2aec7cb3d26a5be52b @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
a759b1ea292e drm/i915: refactor i915 plane code into separate file. 864517beaa0c drm/i915: refactor cursor code out of i915_display.c 9b2022983792 drm/i915/display: fix misused comma da73a1c19031 drm/i915/display: move to_intel_frontbuffer to header e8060d01a918 drm/i915/display: move needs_modeset to an inline in header
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19193/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [CI,1/5] drm/i915/display: move needs_modeset to an inline in header (rev3)
In reply to Jani Nikula== Series Details ==
== Series Details ==
Series: series starting with [CI,1/5] drm/i915/display: move needs_modeset to an inline in header (rev3)
URL : https://patchwork.freedesktop.org/series/85132/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_9509_full -> Patchwork_19193_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Known issues
------------
Here are the changes found in Patchwork_19193_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_persistence@legacy-engines-cleanup:
- shard-hsw: NOTRUN -> [SKIP][1] ([fdo#109271] / [i915#1099]) +1 similar issue
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19193/shard-hsw8/igt@[email protected]
* igt@gem_exec_whisper@basic-queues-forked:
- shard-glk: [PASS][2] -> [DMESG-WARN][3] ([i915#118] / [i915#95])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9509/shard-glk8/igt@[email protected]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19193/shard-glk3/igt@[email protected]
* igt@kms_big_fb@y-tiled-addfb-size-overflow:
- shard-hsw: NOTRUN -> [SKIP][4] ([fdo#109271]) +64 similar issues
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19193/shard-hsw8/igt@[email protected]
* igt@kms_chamelium@hdmi-hpd-enable-disable-mode:
- shard-hsw: NOTRUN -> [SKIP][5] ([fdo#109271] / [fdo#111827]) +6 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19193/shard-hsw8/igt@[email protected]
* igt@kms_color@pipe-a-ctm-0-5:
- shard-skl: [PASS][6] -> [DMESG-WARN][7] ([i915#1982]) +2 similar issues
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9509/shard-skl2/igt@[email protected]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19193/shard-skl8/igt@[email protected]
* igt@kms_color_chamelium@pipe-c-degamma:
- shard-skl: NOTRUN -> [SKIP][8] ([fdo#109271] / [fdo#111827]) +2 similar issues
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19193/shard-skl2/igt@[email protected]
* igt@kms_cursor_crc@pipe-a-cursor-128x128-offscreen:
- shard-skl: [PASS][9] -> [FAIL][10] ([i915#54])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9509/shard-skl6/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19193/shard-skl9/igt@[email protected]
* igt@kms_cursor_crc@pipe-a-cursor-128x42-offscreen:
- shard-glk: [PASS][11] -> [FAIL][12] ([i915#54])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9509/shard-glk4/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19193/shard-glk2/igt@[email protected]
* igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy:
- shard-hsw: [PASS][13] -> [FAIL][14] ([i915#96])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9509/shard-hsw8/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19193/shard-hsw6/igt@[email protected]
* igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1:
- shard-tglb: [PASS][15] -> [FAIL][16] ([i915#2598])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9509/shard-tglb5/igt@kms_flip@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19193/shard-tglb8/igt@kms_flip@[email protected]
* igt@kms_flip@plain-flip-fb-recreate@c-edp1:
- shard-skl: [PASS][17] -> [FAIL][18] ([i915#2122])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9509/shard-skl8/igt@kms_flip@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19193/shard-skl10/igt@kms_flip@[email protected]
* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-indfb-draw-blt:
- shard-skl: NOTRUN -> [SKIP][19] ([fdo#109271]) +10 similar issues
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19193/shard-skl2/igt@[email protected]
* igt@kms_hdr@bpc-switch-suspend:
- shard-skl: [PASS][20] -> [FAIL][21] ([i915#1188])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9509/shard-skl6/igt@[email protected]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19193/shard-skl1/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: [PASS][22] -> [FAIL][23] ([fdo#108145] / [i915#265])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9509/shard-skl9/igt@[email protected]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19193/shard-skl3/igt@[email protected]
* igt@kms_psr@psr2_sprite_plane_move:
- shard-iclb: [PASS][24] -> [SKIP][25] ([fdo#109441]) +2 similar issues
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9509/shard-iclb2/igt@kms_psr@psr2_sprite_plane_move.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19193/shard-iclb3/igt@kms_psr@psr2_sprite_plane_move.html
* igt@perf@polling-parameterized:
- shard-iclb: [PASS][26] -> [FAIL][27] ([i915#1542])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9509/shard-iclb4/igt@[email protected]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19193/shard-iclb2/igt@[email protected]
- shard-skl: [PASS][28] -> [FAIL][29] ([i915#1542])
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9509/shard-skl5/igt@[email protected]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19193/shard-skl6/igt@[email protected]
* igt@prime_vgem@sync@bcs0:
- shard-tglb: [PASS][30] -> [INCOMPLETE][31] ([i915#409])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9509/shard-tglb7/igt@prime_vgem@[email protected]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19193/shard-tglb1/igt@prime_vgem@[email protected]
#### Possible fixes ####
* igt@gem_eio@in-flight-suspend:
- shard-skl: [INCOMPLETE][32] ([i915#1037] / [i915#198]) -> [PASS][33]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9509/shard-skl1/igt@[email protected]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19193/shard-skl2/igt@[email protected]
* {igt@gem_exec_schedule@u-fairslice@vcs0}:
- shard-skl: [DMESG-WARN][34] ([i915#1610]) -> [PASS][35]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9509/shard-skl8/igt@gem_exec_schedule@[email protected]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19193/shard-skl10/igt@gem_exec_schedule@[email protected]
* {igt@gem_vm_create@destroy-race}:
- shard-tglb: [TIMEOUT][36] ([i915#2795]) -> [PASS][37]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9509/shard-tglb5/igt@[email protected]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19193/shard-tglb5/igt@[email protected]
* igt@kms_async_flips@test-time-stamp:
- shard-tglb: [FAIL][38] ([i915#2597]) -> [PASS][39]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9509/shard-tglb2/igt@[email protected]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19193/shard-tglb7/igt@[email protected]
* igt@kms_big_fb@x-tiled-16bpp-rotate-180:
- shard-snb: [SKIP][40] ([fdo#109271]) -> [PASS][41]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9509/shard-snb5/igt@[email protected]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19193/shard-snb6/igt@[email protected]
* igt@kms_cursor_crc@pipe-a-cursor-128x128-random:
- shard-skl: [FAIL][42] ([i915#54]) -> [PASS][43] +1 similar issue
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9509/shard-skl6/igt@[email protected]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19193/shard-skl1/igt@[email protected]
* igt@kms_flip@plain-flip-fb-recreate@a-hdmi-a1:
- shard-glk: [FAIL][44] ([i915#2122]) -> [PASS][45]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9509/shard-glk9/igt@kms_flip@[email protected]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19193/shard-glk7/igt@kms_flip@[email protected]
* igt@kms_flip@plain-flip-fb-recreate@b-edp1:
- shard-skl: [FAIL][46] ([i915#2122]) -> [PASS][47]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9509/shard-skl8/igt@kms_flip@[email protected]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19193/shard-skl10/igt@kms_flip@[email protected]
* igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min:
- shard-skl: [FAIL][48] ([fdo#108145] / [i915#265]) -> [PASS][49]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9509/shard-skl7/igt@[email protected]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19193/shard-skl5/igt@[email protected]
* igt@kms_plane_lowres@pipe-b-tiling-yf:
- shard-kbl: [DMESG-WARN][50] ([i915#165] / [i915#180] / [i915#78]) -> [PASS][51]
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9509/shard-kbl2/igt@[email protected]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19193/shard-kbl1/igt@[email protected]
* igt@kms_psr@psr2_primary_mmap_gtt:
- shard-iclb: [SKIP][52] ([fdo#109441]) -> [PASS][53]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9509/shard-iclb4/igt@kms_psr@psr2_primary_mmap_gtt.html
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19193/shard-iclb2/igt@kms_psr@psr2_primary_mmap_gtt.html
#### Warnings ####
* igt@i915_pm_rc6_residency@rc6-idle:
- shard-iclb: [WARN][54] ([i915#2684]) -> [WARN][55] ([i915#1804] / [i915#2684])
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9509/shard-iclb2/igt@[email protected]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19193/shard-iclb4/igt@[email protected]
* igt@kms_cursor_crc@pipe-b-cursor-suspend:
- shard-kbl: [DMESG-WARN][56] ([i915#1602]) -> [INCOMPLETE][57] ([i915#155] / [i915#2405])
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9509/shard-kbl7/igt@[email protected]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19193/shard-kbl2/igt@[email protected]
* igt@runner@aborted:
- shard-kbl: ([FAIL][58], [FAIL][59]) ([i915#1814] / [i915#2295] / [i915#483]) -> [FAIL][60] ([i915#2295] / [i915#483])
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9509/shard-kbl7/igt@[email protected]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9509/shard-kbl6/igt@[email protected]
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19193/shard-kbl4/igt@[email protected]
- shard-iclb: ([FAIL][61], [FAIL][62], [FAIL][63]) ([i915#1814] / [i915#2295] / [i915#2724] / [i915#483]) -> ([FAIL][64], [FAIL][65], [FAIL][66], [FAIL][67]) ([i915#1814] / [i915#2295] / [i915#2426] / [i915#2724] / [i915#483])
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9509/shard-iclb6/igt@[email protected]
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9509/shard-iclb3/igt@[email protected]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9509/shard-iclb3/igt@[email protected]
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19193/shard-iclb5/igt@[email protected]
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19193/shard-iclb6/igt@[email protected]
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19193/shard-iclb3/igt@[email protected]
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19193/shard-iclb5/igt@[email protected]
- shard-glk: ([FAIL][68], [FAIL][69]) ([i915#1814] / [i915#2295] / [k.org#202321]) -> ([FAIL][70], [FAIL][71]) ([i915#1814] / [i915#2295] / [i915#483] / [k.org#202321])
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9509/shard-glk9/igt@[email protected]
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9509/shard-glk2/igt@[email protected]
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19193/shard-glk7/igt@[email protected]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19193/shard-glk7/igt@[email protected]
- shard-tglb: ([FAIL][72], [FAIL][73]) ([i915#1602] / [i915#2295]) -> ([FAIL][74], [FAIL][75]) ([i915#1602] / [i915#2295] / [i915#2426] / [i915#409])
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9509/shard-tglb5/igt@[email protected]
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9509/shard-tglb7/igt@[email protected]
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19193/shard-tglb1/igt@[email protected]
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19193/shard-tglb2/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1037]: https://gitlab.freedesktop.org/drm/intel/issues/1037
[i915#1099]: https://gitlab.freedesktop.org/drm/intel/issues/1099
[i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
[i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188
[i915#1542]: https://gitlab.freedesktop.org/drm/intel/issues/1542
[i915#155]: https://gitlab.freedesktop.org/drm/intel/issues/155
[i915#1602]: https://gitlab.freedesktop.org/drm/intel/issues/1602
[i915#1610]: https://gitlab.freedesktop.org/drm/intel/issues/1610
[i915#165]: https://gitlab.freedesktop.org/drm/intel/issues/165
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1804]: https://gitlab.freedesktop.org/drm/intel/issues/1804
[i915#1814]: https://gitlab.freedesktop.org/drm/intel/issues/1814
[i915#198]: https://gitlab.freedesktop.org/drm/intel/issues/198
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2295]: https://gitlab.freedesktop.org/drm/intel/issues/2295
[i915#2405]: https://gitlab.freedesktop.org/drm/intel/issues/2405
[i915#2426]: https://gitlab.freedesktop.org/drm/intel/issues/2426
[i915#2597]: https://gitlab.freedesktop.org/drm/intel/issues/2597
[i915#2598]: https://gitlab.freedesktop.org/drm/intel/issues/2598
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#2684]: https://gitlab.freedesktop.org/drm/intel/issues/2684
[i915#2724]: https://gitlab.freedesktop.org/drm/intel/issues/2724
[i915#2795]: https://gitlab.freedesktop.org/drm/intel/issues/2795
[i915#2803]: https://gitlab.freedesktop.org/drm/intel/issues/2803
[i915#409]: https://gitlab.freedesktop.org/drm/intel/issues/409
[i915#483]: https://gitlab.freedesktop.org/drm/intel/issues/483
[i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54
[i915#78]: https://gitlab.freedesktop.org/drm/intel/issues/78
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
[i915#96]: https://gitlab.freedesktop.org/drm/intel/issues/96
[k.org#202321]: https://bugzilla.kernel.org/show_bug.cgi?id=202321
Participating hosts (10 -> 10)
------------------------------
No changes in participating hosts
Build changes
-------------
* Linux: CI_DRM_9509 -> Patchwork_19193
CI-20190529: 20190529
CI_DRM_9509: 66ecfb1df07b703dc4e83e8c520b186dffe6d2b3 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5913: b30bdfecaf1ff38b83c0bfbcf5981732a968a464 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_19193: a759b1ea292e30f7d50c2f2aec7cb3d26a5be52b @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19193/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
kernel test robot
build botRe: [Intel-gfx] [CI 5/5] drm/i915: refactor i915 plane code into separate file.
In reply to Jani NikulaI love your patch! Yet something to improve:
Hi Jani,
I love your patch! Yet something to improve:
[auto build test ERROR on drm-tip/drm-tip]
[cannot apply to drm-intel/for-linux-next drm/drm-next v5.10 next-20201223] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Jani-Nikula/drm-i915-display-move-needs_modeset-to-an-inline-in-header/20201221-170703 base: git://anongit.freedesktop.org/drm/drm-tip drm-tip config: i386-randconfig-a016-20201221 (attached as .config) compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 reproduce (this is a W=1 build): # https://github.com/0day-ci/linux/commit/9e3286b51b354c48a7db967eb3f64de01bbe000c git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Jani-Nikula/drm-i915-display-move-needs_modeset-to-an-inline-in-header/20201221-170703 git checkout 9e3286b51b354c48a7db967eb3f64de01bbe000c # save the attached .config to linux build tree make W=1 ARCH=i386
If you fix the issue, kindly add following tag as appropriate
All errors (new ones prefixed by >>):
In file included from <command-line>:
>> drivers/gpu/drm/i915/display/i9xx_plane.h:14:8: error: unknown type name 'u32'
14 | u32 pixel_format, u64 modifier,
| ^~~
>> drivers/gpu/drm/i915/display/i9xx_plane.h:14:26: error: unknown type name 'u64'
14 | u32 pixel_format, u64 modifier,
| ^~~
drivers/gpu/drm/i915/display/i9xx_plane.h:16:37: error: 'struct intel_plane_state' declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
16 | int i9xx_check_plane_surface(struct intel_plane_state *plane_state);
| ^~~~~~~~~~~~~~~~~cc1: all warnings being treated as errors
vim +/u32 +14 drivers/gpu/drm/i915/display/i9xx_plane.h
12
13 unsigned int i9xx_plane_max_stride(struct intel_plane *plane,
> 14 u32 pixel_format, u64 modifier,
15 unsigned int rotation);
16 int i9xx_check_plane_surface(struct intel_plane_state *plane_state);
17 ---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org