Skip to contentSkip to conversation

sysvinit/rc: show text progress

PATCH In review Trevor Woerner 2 participants 5 messages Dec 22, 2020 – Dec 24, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 sysvinit/rc: show text progress

In addition to the progress bar, show which startup routine is running by using the "MSG" facility of psplash.

---
 meta/recipes-core/sysvinit/sysvinit/rc | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
meta/recipes-core/sysvinit/sysvinit/rc +2 -1
index d0d3149821..6995930ee9 100755
@@ -27,6 +27,7 @@ startup_progress() {
     fi
     #echo "PROGRESS is $progress $runlevel $first_step + ($step of $num_steps) $step_change $progress_size"
     if type psplash-write >/dev/null 2>&1; then
+        PSPLASH_FIFO_DIR=/mnt/.psplash psplash-write "MSG $(basename $1 .sh | cut -c 4-)" || true
         PSPLASH_FIFO_DIR=/mnt/.psplash psplash-write "PROGRESS $progress" || true
     fi
 }
@@ -53,7 +54,7 @@ startup() {
 		"$@"
 		;;
   esac
-  startup_progress
+  startup_progress "$1"
 }
 
   # Ignore CTRL-C only in this shell, so we can interrupt subprocesses.
Signature · 1 line
2.30.0.rc0
#1 lore raw
Quoted 4 lines · Trevor Woerner

In addition to the progress bar, show which startup routine is running by using the "MSG" facility of psplash.

This is ok but lets make it optional and controlled via some knob. End products usually want clean graphics

Quoted 32 lines
---
 meta/recipes-core/sysvinit/sysvinit/rc | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
meta/recipes-core/sysvinit/sysvinit/rc +2 -2
index d0d3149821..6995930ee9 100755
@@ -27,6 +27,7 @@ startup_progress() {
     fi
     #echo "PROGRESS is $progress $runlevel $first_step + ($step of $num_steps) $step_change $progress_size"
     if type psplash-write >/dev/null 2>&1; then
+        PSPLASH_FIFO_DIR=/mnt/.psplash psplash-write "MSG $(basename $1 .sh | cut -c 4-)" || true
         PSPLASH_FIFO_DIR=/mnt/.psplash psplash-write "PROGRESS $progress" || true
     fi
 }
@@ -53,7 +54,7 @@ startup() {
                "$@"
                ;;
   esac
-  startup_progress
+  startup_progress "$1"
 }
 
   # Ignore CTRL-C only in this shell, so we can interrupt subprocesses.
--

2.30.0.rc0

#2 lore raw
Quoted 8 lines · Khem Raj
Quoted 4 lines · Trevor Woerner

In addition to the progress bar, show which startup routine is running by using the "MSG" facility of psplash.

This is ok but lets make it optional and controlled via some knob. End products usually want clean graphics

Okay, not a problem.

I've already submitted an "improvement" (i.e. a fix) for this patch since the module that is reported is always one behind after this code. Should I work on adding a knob after my patch that fixes the message reporting, or assuming this patch hasn't been added yet?

#3 lore raw
In reply to Khem Raj
Quoted 8 lines · Khem Raj
Quoted 4 lines · Trevor Woerner

In addition to the progress bar, show which startup routine is running by using the "MSG" facility of psplash.

This is ok but lets make it optional and controlled via some knob. End products usually want clean graphics

I'll add it with a knob, default off.

I'm not sure what you mean by "clean graphics". To clarify: there's a hidden text box already built into the psplash application just above the progress bar, any MSG text sent via the fifo appears centred above the progress bar. I'm displaying the text-name of the currently-running bootup script (e.g. postinsts, networking, sshd, etc) as a means of feedback. As the device boots the user is not looking at a slowing moving progress bar and wondering which service is taking so long to startup.

For example, on first boot, the sshd service takes a while to startup since it may need to generate a bunch of keys. With this enabled the user will see the progress bar stop (momentarily), but they'll also know that it's due to sshd running. Or if you're using dhcp and there's no dhcp server on your network, the user will see the progress bar stop (momentarily) and the text above the progress bar will say "network" so they know that's the cause of the pause.

This doesn't mess up the logo/graphics at all. I could make a video of it, or you could try giving it a whirl once it's added. I think it should be default on :-)

#4 lore raw
Quoted 21 lines · Trevor Woerner
Quoted 8 lines · Khem Raj
Quoted 4 lines · Trevor Woerner

In addition to the progress bar, show which startup routine is running by using the "MSG" facility of psplash.

This is ok but lets make it optional and controlled via some knob. End products usually want clean graphics

I'll add it with a knob, default off.

I'm not sure what you mean by "clean graphics". To clarify: there's a hidden text box already built into the psplash application just above the progress bar, any MSG text sent via the fifo appears centred above the progress bar. I'm displaying the text-name of the currently-running bootup script (e.g. postinsts, networking, sshd, etc) as a means of feedback. As the device boots the user is not looking at a slowing moving progress bar and wondering which service is taking so long to startup.

Quoted 7 lines

For example, on first boot, the sshd service takes a while to startup since it may need to generate a bunch of keys. With this enabled the user will see the progress bar stop (momentarily), but they'll also know that it's due to sshd running. Or if you're using dhcp and there's no dhcp server on your network, the user will see the progress bar stop (momentarily) and the text above the progress bar will say "network" so they know that's the cause of the pause.

I understand that what I am mentioning here is that all this information is good for debugging
diagnostics but not needed when a device is normally booting since this information
is less useful to end-user and sometimes undesired for aesthetics. So while you are here
having this option along with your enhancements is what I am asking for. Hope this helps.

Quoted 3 lines

This doesn't mess up the logo/graphics at all. I could make a video of it, or you could try giving it a whirl once it's added. I think it should be default on :-)