mm: mmap: Remove unnecessary local variable
Subsystems (2)
PATCH 1/1 mm: mmap: Remove unnecessary local variable
From: Adrian Huang <[email protected]>
The local variable 'retval' is assigned just for once in __do_sys_brk(), and the function returns the value of the local variable right after the assignment. Remove unnecessary assignment and local variable declaration.
--- mm/mmap.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
mm/mmap.c +1 -3
@@ -189,7 +189,6 @@ static int do_brk_flags(unsigned long addr, unsigned long request, unsigned long struct list_head *uf); SYSCALL_DEFINE1(brk, unsigned long, brk) { -unsigned long retval;unsigned long newbrk, oldbrk, origbrk;struct mm_struct *mm = current->mm;struct vm_area_struct *next;
@@ -281,9 +280,8 @@ SYSCALL_DEFINE1(brk, unsigned long, brk)return brk; out: - retval = origbrk;mmap_write_unlock (mm); -return retval; +return origbrk; }static inline unsigned long vma_compute_gap (struct vm_area_struct *vma)
Signature · 1 line
2.17.1
Quoted 9 lines · Adrian Huang
From: Adrian Huang <[email protected]>
The local variable 'retval' is assigned just for once in
__do_sys_brk(), and the function returns the value of the local variable right after the assignment. Remove unnecessary assignment and local variable declaration.Signed-off-by Adrian Huang <[email protected]>
Quoted 31 lines
--- mm/mmap.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)mm/mmap.c +1
-4@@ -189,7 +189,6 @@ static int do_brk_flags(unsigned long addr, unsigned long request, unsigned long struct list_head *uf); SYSCALL_DEFINE1(brk, unsigned long, brk) { -unsigned long retval;unsigned long newbrk, oldbrk, origbrk;struct mm_struct *mm = current->mm;struct vm_area_struct *next;@@ -281,9 +280,8 @@ SYSCALL_DEFINE1(brk, unsigned long, brk)return brk; out: - retval = origbrk;mmap_write_unlock (mm); -return retval; +return origbrk; }static inline unsigned long vma_compute_gap (struct vm_area_struct *vma) --2.17.1
Quoted 25 lines · Adrian Huang
From: Adrian Huang <[email protected]>
The local variable 'retval' is assigned just for once in
__do_sys_brk(), and the function returns the value of the local variable right after the assignment. Remove unnecessary assignment and local variable declaration.Signed-off-by Adrian Huang <[email protected]>--- mm/mmap.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)mm/mmap.c +0
-1@@ -189,7 +189,6 @@ static int do_brk_flags(unsigned long addr, unsigned long request, unsigned long struct list_head *uf); SYSCALL_DEFINE1(brk, unsigned long, brk) { -unsigned long retval;unsigned long newbrk, oldbrk, origbrk;struct mm_struct *mm = current->mm;struct vm_area_struct *next;
mm/mmap.c SYSCALL_DEFINE1(brk, unsigned long, brk) · line 285
Quoted 8 lines
mm/mmap.c +1
-2@@ -281,9 +280,8 @@ SYSCALL_DEFINE1(brk, unsigned long, brk)return brk; out: - retval = origbrk;mmap_write_unlock (mm); -return retval; +return origbrk; }
Signature · 3 lines
Thanks, David / dhildenb