Skip to contentSkip to conversation

block: move definition of blk_qc_t to types.h

PATCH In review Jeffle Xu 2 participants 2 messages Dec 23, 2020

Subsystems (2)
lore
Share & tools
lore

Jeffle Xu

author
#0 lore raw

PATCH v2 1/1 block: move definition of blk_qc_t to types.h

So that kiocb.ki_cookie can be defined as blk_qc_t, which will enforce the encapsulation.

---
changes since v1: add trivial comments

---
 include/linux/blk_types.h | 2 +-
 include/linux/fs.h        | 2 +-
 include/linux/types.h     | 3 +++
 3 files changed, 5 insertions(+), 2 deletions(-)
include/linux/blk_types.h +1 -1
index 866f74261b3b..2e05244fc16d 100644
@@ -532,7 +532,7 @@ static inline int op_stat_group(unsigned int op)
 	return op_is_write(op);
 }
 
-typedef unsigned int blk_qc_t;
+/* Macros for blk_qc_t */
 #define BLK_QC_T_NONE		-1U
 #define BLK_QC_T_SHIFT		16
 #define BLK_QC_T_INTERNAL	(1U << 31)
include/linux/fs.h +1 -1
index ad4cf1bae586..58db714c4834 100644
@@ -330,7 +330,7 @@ struct kiocb {
 	u16			ki_hint;
 	u16			ki_ioprio; /* See linux/ioprio.h */
 	union {
-		unsigned int		ki_cookie; /* for ->iopoll */
+		blk_qc_t		ki_cookie; /* for ->iopoll */
 		struct wait_page_queue	*ki_waitq; /* for async buffered IO */
 	};
 
include/linux/types.h +3 -0
index a147977602b5..da5ca7e1bea9 100644
@@ -125,6 +125,9 @@ typedef s64			int64_t;
 typedef u64 sector_t;
 typedef u64 blkcnt_t;
 
+/* cookie used for iopoll */
+typedef unsigned int blk_qc_t;
+
 /*
  * The type of an index into the pagecache.
  */
Signature · 1 line
2.27.0