net/mlx5e: remove h from printk format specifier
Subsystems (5)
PATCH 1/1 net/mlx5e: remove h from printk format specifier
From: Tom Rix <[email protected]>
This change fixes the checkpatch warning described in this commit
commit cbacb5ab0aa0 ("docs: printk-formats: Stop encouraging use of unnecessary %h[xudi] and %hh[xudi]")
Standard integer promotion is already done and %hx and %hhx is useless so do not encourage the use of %hh[xudi] or %h[xudi].
--- drivers/net/ethernet/mellanox/mlx5/core/en/params.c | 2 +- drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-)
drivers/net/ethernet/mellanox/mlx5/core/en/params.c +1 -1
@@ -179,7 +179,7 @@ int mlx5e_validate_params(struct mlx5e_priv *priv, struct mlx5e_params *params) stop_room =mlx5e_calc_sq_stop_room (priv->mdev, params);if (stop_room >= sq_size) { -netdev_err (priv->netdev,"Stop room %hu is bigger than the SQ size %zu\n" , +netdev_err (priv->netdev,"Stop room %u is bigger than the SQ size %zu\n" , stop_room, sq_size);return -EINVAL ; }
drivers/net/ethernet/mellanox/mlx5/core/en_main.c +2 -2
@@ -3763,7 +3763,7 @@ static int set_feature_lro(struct net_device *netdev, bool enable)mutex_lock (&priv->state_lock);if (enable && priv->xsk.refcnt) { -netdev_warn (netdev,"LRO is incompatible with AF_XDP (%hu XSKs are active)\n" , +netdev_warn (netdev,"LRO is incompatible with AF_XDP (%u XSKs are active)\n" , priv->xsk.refcnt); err = -EINVAL ; goto out;
@@ -4005,7 +4005,7 @@ static bool mlx5e_xsk_validate_mtu(struct net_device *netdev, max_mtu_page =mlx5e_xdp_max_mtu (new_params, &xsk); max_mtu =min (max_mtu_frame, max_mtu_page); -netdev_err (netdev,"MTU %d is too big for an XSK running on channel %hu. Try MTU <= %d\n" , +netdev_err (netdev,"MTU %d is too big for an XSK running on channel %u. Try MTU <= %d\n" , new_params->sw_mtu, ix, max_mtu);return false; }
Signature · 1 line
2.27.0
Quoted 5 lines · On Wed, Dec 23, 2020 at 11:45:12AM -0800, [email protected] wrote:
From: Tom Rix <[email protected]>
This change fixes the checkpatch warning described in this commit
commitcbacb5ab0aa0("docs: printk-formats: Stop encouraging use of unnecessary %h[xudi] and %hh[xudi]")
Quoted 9 lines
Standard integer promotion is already done and %hx and %hhx is useless so do not encourage the use of %hh[xudi] or %h[xudi].
Signed-off-by Tom Rix <[email protected]>--- drivers/net/ethernet/mellanox/mlx5/core/en/params.c | 2 +- drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-)
Thanks,
Saeed Mahameed
AppliedQuoted 10 lines · On Wed, 2020-12-23 at 11:45 -0800, [email protected] wrote:
From: Tom Rix <[email protected]>
This change fixes the checkpatch warning described in this commit commit
cbacb5ab0aa0("docs: printk-formats: Stop encouraging use of unnecessary %h[xudi] and %hh[xudi]")Standard integer promotion is already done and %hx and %hhx is useless
so do not encourage the use of %hh[xudi] or %h[xudi].
Quoted 6 lines
Signed-off-by Tom Rix <[email protected]>--- drivers/net/ethernet/mellanox/mlx5/core/en/params.c | 2 +- drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-)
applied to net-next-mlx5,
Thanks