Skip to contentSkip to conversation

libnvdimm/pmem: remove unused header.

PATCH Superseded Jianpeng Ma 3 participants 6 messages Dec 25, 2020 – Jan 5, 2021

Subsystems (2)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 libnvdimm/pmem: remove unused header.

'commit a8b456d01cd6 ("bdi: remove BDI_CAP_SYNCHRONOUS_IO")' forgot remove the related header file.

---
 drivers/nvdimm/pmem.c | 1 -
 1 file changed, 1 deletion(-)
drivers/nvdimm/pmem.c +0 -1
index 875076b0ea6c..f33bdae626ba 100644
@@ -23,7 +23,6 @@
 #include <linux/uio.h>
 #include <linux/dax.h>
 #include <linux/nd.h>
-#include <linux/backing-dev.h>
 #include <linux/mm.h>
 #include <asm/cacheflush.h>
 #include "pmem.h"
Signature · 4 lines
2.29.2
_______________________________________________
Linux-nvdimm mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Reviewed-by on v1 1/1
#1 lore raw
Quoted 1 line · Jianpeng Ma

'commit a8b456d01cd6 ("bdi: remove BDI_CAP_SYNCHRONOUS_IO")' forgot

This information should be part of a fixes tag.

Other than that looks ok.

Quoted 24 lines

remove the related header file.

---
 drivers/nvdimm/pmem.c | 1 -
 1 file changed, 1 deletion(-)
drivers/nvdimm/pmem.c +0 -1
index 875076b0ea6c..f33bdae626ba 100644
@@ -23,7 +23,6 @@
 #include <linux/uio.h>
 #include <linux/dax.h>
 #include <linux/nd.h>
-#include <linux/backing-dev.h>
 #include <linux/mm.h>
 #include <asm/cacheflush.h>
 #include "pmem.h"
Signature · 4 lines
2.29.2
_______________________________________________
Linux-nvdimm mailing list -- [email protected]
To unsubscribe send an email to [email protected]

_______________________________________________
Linux-nvdimm mailing list -- [email protected] To unsubscribe send an email to [email protected]

#2 lore raw
Quoted 5 lines · Ira Weiny
Quoted 1 line · Jianpeng Ma

'commit a8b456d01cd6 ("bdi: remove BDI_CAP_SYNCHRONOUS_IO")' forgot

This information should be part of a fixes tag.

Oh, I was just about to comment "don't provide a Fixes tag for pure cleanups". Fixes is for functional issues that a backporter should consider.
_______________________________________________
Linux-nvdimm mailing list -- [email protected] To unsubscribe send an email to [email protected]

#3 lore raw
Quoted 10 lines · Dan Williams
Quoted 5 lines · Ira Weiny
Quoted 1 line · Jianpeng Ma

'commit a8b456d01cd6 ("bdi: remove BDI_CAP_SYNCHRONOUS_IO")' forgot

This information should be part of a fixes tag.

Oh, I was just about to comment "don't provide a Fixes tag for pure cleanups". Fixes is for functional issues that a backporter should consider.

I thought this was discussed recently and it was concluded that 'fixes' does not indicate something should be backported?

...

https://lore.kernel.org/lkml/[email protected]/

At least that is what Greg KH said. But Dave C. was not happy with this...

:-/

Sorry...

Ira
_______________________________________________
Linux-nvdimm mailing list -- [email protected] To unsubscribe send an email to [email protected]

#4 lore raw
Quoted 13 lines · Ira Weiny
Quoted 10 lines · Dan Williams
Quoted 5 lines · Ira Weiny
Quoted 1 line · Jianpeng Ma

'commit a8b456d01cd6 ("bdi: remove BDI_CAP_SYNCHRONOUS_IO")' forgot

This information should be part of a fixes tag.

Oh, I was just about to comment "don't provide a Fixes tag for pure cleanups". Fixes is for functional issues that a backporter should consider.

Quoted 8 lines

I thought this was discussed recently and it was concluded that 'fixes' does not indicate something should be backported?

...

https://lore.kernel.org/lkml/[email protected]/

At least that is what Greg KH said. But Dave C. was not happy with this...

I was thinking of it more from the distro automation tooling that I know fires up it sees a "Fixes" tag. At a minimum this would make those systems / humans fire up just to notice, "oh, just a plain cleanup with no logical side-effects".
_______________________________________________
Linux-nvdimm mailing list -- [email protected] To unsubscribe send an email to [email protected]

#5 lore raw
Quoted 19 lines · Dan Williams
Quoted 18 lines · Ira Weiny
Quoted 10 lines · Dan Williams
Quoted 5 lines · Ira Weiny
Quoted 1 line · Jianpeng Ma

'commit a8b456d01cd6 ("bdi: remove BDI_CAP_SYNCHRONOUS_IO")' forgot

This information should be part of a fixes tag.

Oh, I was just about to comment "don't provide a Fixes tag for pure cleanups". Fixes is for functional issues that a backporter should consider.

I thought this was discussed recently and it was concluded that 'fixes' does not indicate something should be backported?

...

Quoted 8 lines
Quoted 3 lines

https://lore.kernel.org/lkml/[email protected]/

At least that is what Greg KH said. But Dave C. was not happy with this...

I was thinking of it more from the distro automation tooling that I know fires up it sees a "Fixes" tag. At a minimum this would make those systems / humans fire up just to notice, "oh, just a plain cleanup with no logical side-effects".

I'm not really following but I don't think it is a big deal either way. It just seemed like the text used looked like a 'fixes' line and seemed ok to put in there.

In this case it is probably fine.

Sorry for the noise,
Ira
_______________________________________________
Linux-nvdimm mailing list -- [email protected] To unsubscribe send an email to [email protected]