mm, slub: Consider rest of partial list if acquire_slab() fails
Subsystems (2)
PATCH 1/1 mm, slub: Consider rest of partial list if acquire_slab() fails
acquire_slab() fails if there is contention on the freelist of the page (probably because some other CPU is concurrently freeing an object from the page). In that case, it might make sense to look for a different page (since there might be more remote frees to the page from other CPUs, and we don't want contention on struct page).
However, the current code accidentally stops looking at the partial list completely in that case. Especially on kernels without CONFIG_NUMA set, this means that get_partial() fails and new_slab_objects() falls back to new_slab(), allocating new pages. This could lead to an unnecessary increase in memory fragmentation.
--- mm/slub.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
mm/slub.c +1 -1
@@ -1974,7 +1974,7 @@ static void *get_partial_node(struct kmem_cache *s, struct kmem_cache_node *n, t =acquire_slab (s, n, page, object ==NULL , &objects);if (!t) -break ; +continue ;/* cmpxchg raced */ available += objects;if (!object) {
base-commit: 5c8fe583cce542aa0b84adc939ce85293de36e5e
Signature · 1 line
2.29.2.729.g45daf8777d-goog
Quoted 6 lines · Jann Horn
acquire_slab()fails if there is contention on the freelist of the page (probably because some other CPU is concurrently freeing an object from the page). In that case, it might make sense to look for a different page (since there might be more remote frees to the page from other CPUs, and we don't want contention on struct page).
Quoted 8 lines
However, the current code accidentally stops looking at the partial list completely in that case. Especially on kernels without
CONFIG_NUMAset, this means thatget_partial()fails andnew_slab_objects()falls back tonew_slab(), allocating new pages. This could lead to an unnecessary increase in memory fragmentation.Fixes 7ced37197196 ("slub: Acquire_slab() avoid loop")Signed-off-by Jann Horn <[email protected]>
Indeed, it looks like commit 7ced37197196 ("slub: Acquire_slab() avoid loop") stopped the iteration prematurely.
2020년 12월 28일 (월) 오후 10:10, Jann Horn <[email protected]>님이 작성:
Quoted 7 lines
acquire_slab()fails if there is contention on the freelist of the page (probably because some other CPU is concurrently freeing an object from the page). In that case, it might make sense to look for a different page (since there might be more remote frees to the page from other CPUs, and we don't want contention on struct page).
Quoted 8 lines
However, the current code accidentally stops looking at the partial list completely in that case. Especially on kernels without
CONFIG_NUMAset, this means thatget_partial()fails andnew_slab_objects()falls back tonew_slab(), allocating new pages. This could lead to an unnecessary increase in memory fragmentation.Fixes 7ced37197196 ("slub: Acquire_slab() avoid loop")Signed-off-by Jann Horn <[email protected]>
Thanks.