Skip to contentSkip to conversation

pinctrl: nomadik: remove an unused variable

PATCH In review Arnd Bergmann 3 participants 3 messages Dec 30, 2020 – Jan 5, 2021

Subsystems (3)
GPIO Pin control Arm/nomadik/Ux500 architectures
lore
Share & tools
lore

Arnd Bergmann

author
#0 lore raw

PATCH 1/1 pinctrl: nomadik: remove an unused variable

From: Arnd Bergmann <[email protected]>

A recent patch added a local variable twice:

drivers/pinctrl/nomadik/pinctrl-nomadik.c:953:8: error: unused variable 'wake' [-Werror,-Wunused-variable]

Remove the unused outer declaration

Fixes f3925032d7fd ("pinctrl: nomadik: Use irq_has_action()")
Signed-off-by Arnd Bergmann <[email protected]>
---
 drivers/pinctrl/nomadik/pinctrl-nomadik.c | 1 -
 1 file changed, 1 deletion(-)
drivers/pinctrl/nomadik/pinctrl-nomadik.c +0 -1
index d4ea10803fd9..abfe11c7b49f 100644
@@ -949,7 +949,6 @@ static void nmk_gpio_dbg_show_one(struct seq_file *s,
 	} else {
 		int irq = chip->to_irq(chip, offset);
 		const int pullidx = pull ? 1 : 0;
-		bool wake;
 		int val;
 		static const char * const pulls[] = {
 			"none        ",
Signature · 1 line
2.29.2
Tested-by Reviewed-by on v1 1/1
#1 lore raw
Quoted 29 lines · Arnd Bergmann

From: Arnd Bergmann <[email protected]>

A recent patch added a local variable twice:

drivers/pinctrl/nomadik/pinctrl-nomadik.c:953:8: error: unused variable 'wake' [-Werror,-Wunused-variable]

Remove the unused outer declaration

Fixes f3925032d7fd ("pinctrl: nomadik: Use irq_has_action()")
Signed-off-by Arnd Bergmann <[email protected]>
---
 drivers/pinctrl/nomadik/pinctrl-nomadik.c | 1 -
 1 file changed, 1 deletion(-)
drivers/pinctrl/nomadik/pinctrl-nomadik.c +0 -1
index d4ea10803fd9..abfe11c7b49f 100644
@@ -949,7 +949,6 @@ static void nmk_gpio_dbg_show_one(struct seq_file *s,
 	} else {
 		int irq = chip->to_irq(chip, offset);
 		const int pullidx = pull ? 1 : 0;
-		bool wake;
 		int val;
 		static const char * const pulls[] = {
 			"none        ",
Signature · 1 line
2.29.2

Got rid of the warning for me, I don't have hardware to test on but I don't think that's necessary for this.

Tested-by Andrew Halaney <[email protected]>
Reviewed-by Andrew Halaney <[email protected]>

Thanks,
Andrew

#2 lore raw
In reply to Arnd Bergmann
Quoted 10 lines · Arnd Bergmann

From: Arnd Bergmann <[email protected]>

A recent patch added a local variable twice:

drivers/pinctrl/nomadik/pinctrl-nomadik.c:953:8: error: unused variable 'wake' [-Werror,-Wunused-variable]

Remove the unused outer declaration

Fixes f3925032d7fd ("pinctrl: nomadik: Use irq_has_action()")
Signed-off-by Arnd Bergmann <[email protected]>

I got an identical patch from Nathan Chancellor on dec 29 :D

I'll add your reported-by and Andrews tags.

Yours,
Linus Walleij