Skip to contentSkip to conversation

drm/i915: Clarify error message on failed workaround

PATCH In review Matt Roper 3 participants 4 messages Dec 31, 2020 – Jan 1, 2021

Subsystems (2)
lore
Share & tools
lore

Matt Roper

author
#0 lore raw

PATCH 1/1 drm/i915: Clarify error message on failed workaround

Let's modify the "workaround lost" error message slightly to make it more clear what the various numbers represent. Also, the 'expected' value needs to be &'d with wa->read so that it doesn't include the mask bits for masked registers (those bits are write-only in the hardware and will usually always read out as 0's).

---
 drivers/gpu/drm/i915/gt/intel_workarounds.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/gt/intel_workarounds.c +2 -2
index 42d320e68b60..b0e3a5ba0320 100644
@@ -1383,9 +1383,9 @@ static bool
 wa_verify(const struct i915_wa *wa, u32 cur, const char *name, const char *from)
 {
 	if ((cur ^ wa->set) & wa->read) {
-		DRM_ERROR("%s workaround lost on %s! (%x=%x/%x, expected %x)\n",
+		DRM_ERROR("%s workaround lost on %s! (reg[%x]=0x%x, relevant bits were 0x%x vs expected 0x%x)\n",
 			  name, from, i915_mmio_reg_offset(wa->reg),
-			  cur, cur & wa->read, wa->set);
+			  cur, cur & wa->read, wa->set & wa->read);
 
 		return false;
 	}
Signature · 6 lines
2.24.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#1 lore raw

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Clarify error message on failed workaround

== Series Details ==

== Series Details ==

Series: drm/i915: Clarify error message on failed workaround
URL : https://patchwork.freedesktop.org/series/85361/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_9537 -> Patchwork_19240
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19240/index.html

Known issues
------------

Here are the changes found in Patchwork_19240 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@amdgpu/amd_basic@memory-alloc:
- fi-cml-u2: NOTRUN -> [SKIP][1] ([fdo#109315]) +17 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19240/fi-cml-u2/igt@amdgpu/[email protected]

* igt@gem_exec_fence@basic-busy@bcs0:
- fi-cml-u2: NOTRUN -> [SKIP][2] ([i915#1208]) +1 similar issue
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19240/fi-cml-u2/igt@gem_exec_fence@[email protected]

* igt@gem_exec_suspend@basic-s3:
- fi-tgl-y: [PASS][3] -> [DMESG-WARN][4] ([i915#2411] / [i915#402])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9537/fi-tgl-y/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19240/fi-tgl-y/igt@[email protected]

* igt@gem_huc_copy@huc-copy:
- fi-cml-u2: NOTRUN -> [SKIP][5] ([i915#2190])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19240/fi-cml-u2/igt@[email protected]

* igt@i915_selftest@live@gt_heartbeat:
- fi-kbl-soraka: [PASS][6] -> [DMESG-FAIL][7] ([i915#2291] / [i915#541])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9537/fi-kbl-soraka/igt@i915_selftest@live@gt_heartbeat.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19240/fi-kbl-soraka/igt@i915_selftest@live@gt_heartbeat.html

* igt@kms_chamelium@hdmi-hpd-fast:
- fi-cml-u2: NOTRUN -> [SKIP][8] ([i915#1004]) +2 similar issues
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19240/fi-cml-u2/igt@[email protected]

* igt@kms_chamelium@vga-edid-read:
- fi-cml-u2: NOTRUN -> [SKIP][9] ([fdo#109309]) +1 similar issue
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19240/fi-cml-u2/igt@[email protected]

* igt@kms_force_connector_basic@force-load-detect:
- fi-cml-u2: NOTRUN -> [SKIP][10] ([fdo#109285])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19240/fi-cml-u2/igt@[email protected]

* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d:
- fi-cml-u2: NOTRUN -> [SKIP][11] ([fdo#109278] / [i915#533])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19240/fi-cml-u2/igt@[email protected]

* igt@prime_self_import@basic-with_two_bos:
- fi-tgl-y: [PASS][12] -> [DMESG-WARN][13] ([i915#402]) +1 similar issue
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9537/fi-tgl-y/igt@prime_self_import@basic-with_two_bos.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19240/fi-tgl-y/igt@prime_self_import@basic-with_two_bos.html

#### Possible fixes ####

* igt@debugfs_test@read_all_entries:
- fi-tgl-y: [DMESG-WARN][14] ([i915#402]) -> [PASS][15] +2 similar issues
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9537/fi-tgl-y/igt@debugfs_test@read_all_entries.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19240/fi-tgl-y/igt@debugfs_test@read_all_entries.html

[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109309]: https://bugs.freedesktop.org/show_bug.cgi?id=109309
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[i915#1004]: https://gitlab.freedesktop.org/drm/intel/issues/1004
[i915#1208]: https://gitlab.freedesktop.org/drm/intel/issues/1208
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2291]: https://gitlab.freedesktop.org/drm/intel/issues/2291
[i915#2411]: https://gitlab.freedesktop.org/drm/intel/issues/2411
[i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#541]: https://gitlab.freedesktop.org/drm/intel/issues/541

Participating hosts (41 -> 37)
------------------------------

Additional (1): fi-cml-u2
Missing (5): fi-ilk-m540 fi-hsw-4200u fi-bsw-cyan fi-ctg-p8600 fi-bdw-samus

Build changes
-------------

* Linux: CI_DRM_9537 -> Patchwork_19240

CI-20190529: 20190529
CI_DRM_9537: c232ca705490fdec5109dd0c9b8a413dc3de5ecb @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5934: a5c54153a82fe4cbd3b72cd85eb1b3eea91a1155 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_19240: 97d8c4c5ab267cb4cc1bf5360d7475548e375b00 @ git://anongit.freedesktop.org/gfx-ci/linux

== Linux commits ==

97d8c4c5ab26 drm/i915: Clarify error message on failed workaround

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19240/index.html

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#2 lore raw

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Clarify error message on failed workaround

In reply to Matt Roper
== Series Details ==

== Series Details ==

Series: drm/i915: Clarify error message on failed workaround
URL : https://patchwork.freedesktop.org/series/85361/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_9537_full -> Patchwork_19240_full
====================================================

Summary
-------

**WARNING**

Minor unknown changes coming with Patchwork_19240_full need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in Patchwork_19240_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in Patchwork_19240_full:

### IGT changes ###

#### Warnings ####

* igt@i915_suspend@fence-restore-untiled:
- shard-kbl: [INCOMPLETE][1] ([i915#155]) -> [DMESG-WARN][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9537/shard-kbl3/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19240/shard-kbl7/igt@[email protected]

Known issues
------------

Here are the changes found in Patchwork_19240_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_exec_reloc@basic-many-active@vcs1:
- shard-iclb: NOTRUN -> [FAIL][3] ([i915#2389])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19240/shard-iclb4/igt@gem_exec_reloc@[email protected]

* igt@i915_module_load@reload:
- shard-skl: NOTRUN -> [DMESG-WARN][4] ([i915#1982])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19240/shard-skl8/igt@[email protected]

* igt@i915_pm_rpm@system-suspend-devices:
- shard-iclb: [PASS][5] -> [INCOMPLETE][6] ([i915#1185] / [i915#189])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9537/shard-iclb5/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19240/shard-iclb3/igt@[email protected]

* igt@i915_selftest@live@execlists:
- shard-tglb: [PASS][7] -> [INCOMPLETE][8] ([i915#1037] / [i915#2268])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9537/shard-tglb8/igt@i915_selftest@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19240/shard-tglb1/igt@i915_selftest@[email protected]

* igt@kms_ccs@pipe-c-crc-sprite-planes-basic:
- shard-skl: NOTRUN -> [SKIP][9] ([fdo#109271] / [fdo#111304])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19240/shard-skl2/igt@[email protected]

* igt@kms_chamelium@dp-audio-edid:
- shard-skl: NOTRUN -> [SKIP][10] ([fdo#109271] / [fdo#111827]) +6 similar issues
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19240/shard-skl10/igt@[email protected]

* igt@kms_color@pipe-a-ctm-0-25:
- shard-tglb: NOTRUN -> [FAIL][11] ([i915#1149] / [i915#315])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19240/shard-tglb5/igt@[email protected]

* igt@kms_color@pipe-a-ctm-blue-to-red:
- shard-skl: [PASS][12] -> [FAIL][13] ([i915#129])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9537/shard-skl2/igt@[email protected]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19240/shard-skl3/igt@[email protected]

* igt@kms_color_chamelium@pipe-d-degamma:
- shard-tglb: NOTRUN -> [SKIP][14] ([fdo#109284] / [fdo#111827]) +1 similar issue
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19240/shard-tglb5/igt@[email protected]

* igt@kms_cursor_crc@pipe-c-cursor-256x85-sliding:
- shard-skl: NOTRUN -> [FAIL][15] ([i915#54])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19240/shard-skl4/igt@[email protected]

* igt@kms_cursor_crc@pipe-c-cursor-64x64-random:
- shard-skl: [PASS][16] -> [FAIL][17] ([i915#54]) +3 similar issues
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9537/shard-skl6/igt@[email protected]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19240/shard-skl2/igt@[email protected]

* igt@kms_cursor_crc@pipe-d-cursor-512x512-random:
- shard-tglb: NOTRUN -> [SKIP][18] ([fdo#109279])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19240/shard-tglb5/igt@[email protected]

* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
- shard-skl: NOTRUN -> [FAIL][19] ([i915#2346])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19240/shard-skl2/igt@[email protected]

* igt@kms_draw_crc@draw-method-xrgb8888-mmap-wc-untiled:
- shard-skl: [PASS][20] -> [FAIL][21] ([fdo#108145] / [i915#177] / [i915#52] / [i915#54])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9537/shard-skl2/igt@[email protected]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19240/shard-skl3/igt@[email protected]

* igt@kms_flip@2x-plain-flip-ts-check@ab-hdmi-a1-hdmi-a2:
- shard-glk: [PASS][22] -> [FAIL][23] ([i915#2122])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9537/shard-glk7/igt@kms_flip@[email protected]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19240/shard-glk6/igt@kms_flip@[email protected]

* igt@kms_flip@flip-vs-expired-vblank-interruptible@b-edp1:
- shard-skl: [PASS][24] -> [FAIL][25] ([i915#79])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9537/shard-skl7/igt@kms_flip@[email protected]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19240/shard-skl9/igt@kms_flip@[email protected]

* igt@kms_flip@modeset-vs-vblank-race@b-edp1:
- shard-skl: [PASS][26] -> [FAIL][27] ([i915#407])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9537/shard-skl10/igt@kms_flip@[email protected]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19240/shard-skl8/igt@kms_flip@[email protected]

* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-indfb-draw-blt:
- shard-skl: NOTRUN -> [SKIP][28] ([fdo#109271]) +80 similar issues
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19240/shard-skl2/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-cur-indfb-draw-mmap-gtt:
- shard-tglb: NOTRUN -> [SKIP][29] ([fdo#111825]) +4 similar issues
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19240/shard-tglb5/igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-cur-indfb-draw-mmap-gtt.html

* igt@kms_hdr@bpc-switch-dpms:
- shard-skl: [PASS][30] -> [FAIL][31] ([i915#1188])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9537/shard-skl1/igt@[email protected]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19240/shard-skl7/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min:
- shard-skl: [PASS][32] -> [FAIL][33] ([fdo#108145] / [i915#265]) +1 similar issue
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9537/shard-skl2/igt@[email protected]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19240/shard-skl3/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-b-alpha-opaque-fb:
- shard-skl: NOTRUN -> [FAIL][34] ([fdo#108145] / [i915#265])
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19240/shard-skl10/igt@[email protected]

* igt@kms_psr@psr2_basic:
- shard-iclb: [PASS][35] -> [SKIP][36] ([fdo#109441]) +1 similar issue
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9537/shard-iclb2/igt@kms_psr@psr2_basic.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19240/shard-iclb6/igt@kms_psr@psr2_basic.html

* igt@kms_writeback@writeback-check-output:
- shard-skl: NOTRUN -> [SKIP][37] ([fdo#109271] / [i915#2437])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19240/shard-skl2/igt@[email protected]

* igt@nouveau_crc@pipe-b-ctx-flip-skip-current-frame:
- shard-tglb: NOTRUN -> [SKIP][38] ([i915#2530])
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19240/shard-tglb5/igt@[email protected]

* igt@perf@polling-parameterized:
- shard-skl: [PASS][39] -> [FAIL][40] ([i915#1542])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9537/shard-skl5/igt@[email protected]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19240/shard-skl3/igt@[email protected]

* igt@prime_nv_test@i915_nv_sharing:
- shard-tglb: NOTRUN -> [SKIP][41] ([fdo#109291])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19240/shard-tglb5/igt@prime_nv_test@i915_nv_sharing.html

* igt@prime_vgem@sync@vcs0:
- shard-tglb: [PASS][42] -> [INCOMPLETE][43] ([i915#409])
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9537/shard-tglb6/igt@prime_vgem@[email protected]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19240/shard-tglb3/igt@prime_vgem@[email protected]

#### Possible fixes ####

* {igt@gem_exec_fair@basic-none-share@rcs0}:
- shard-iclb: [FAIL][44] ([i915#2842]) -> [PASS][45] +1 similar issue
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9537/shard-iclb3/igt@gem_exec_fair@[email protected]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19240/shard-iclb1/igt@gem_exec_fair@[email protected]

* {igt@gem_exec_fair@basic-none-solo@rcs0}:
- shard-glk: [FAIL][46] ([i915#2842]) -> [PASS][47]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9537/shard-glk3/igt@gem_exec_fair@[email protected]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19240/shard-glk5/igt@gem_exec_fair@[email protected]

* {igt@gem_exec_schedule@u-fairslice@vecs0}:
- shard-skl: [DMESG-WARN][48] ([i915#1610]) -> [PASS][49]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9537/shard-skl6/igt@gem_exec_schedule@[email protected]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19240/shard-skl2/igt@gem_exec_schedule@[email protected]

* igt@i915_suspend@fence-restore-untiled:
- shard-skl: [INCOMPLETE][50] ([i915#198]) -> [PASS][51]
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9537/shard-skl4/igt@[email protected]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19240/shard-skl4/igt@[email protected]

* igt@kms_color@pipe-b-ctm-negative:
- shard-skl: [DMESG-WARN][52] ([i915#1982]) -> [PASS][53]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9537/shard-skl5/igt@[email protected]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19240/shard-skl6/igt@[email protected]

* igt@kms_cursor_crc@pipe-b-cursor-128x128-random:
- shard-skl: [FAIL][54] ([i915#54]) -> [PASS][55] +5 similar issues
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9537/shard-skl4/igt@[email protected]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19240/shard-skl9/igt@[email protected]

* igt@kms_cursor_legacy@2x-long-cursor-vs-flip-atomic:
- shard-hsw: [FAIL][56] ([i915#96]) -> [PASS][57]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9537/shard-hsw1/igt@[email protected]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19240/shard-hsw4/igt@[email protected]

* igt@kms_cursor_legacy@flip-vs-cursor-busy-crc-atomic:
- shard-skl: [FAIL][58] ([i915#2346]) -> [PASS][59]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9537/shard-skl6/igt@[email protected]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19240/shard-skl2/igt@[email protected]

* igt@kms_cursor_legacy@flip-vs-cursor-toggle:
- shard-tglb: [FAIL][60] ([i915#2346]) -> [PASS][61]
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9537/shard-tglb6/igt@[email protected]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19240/shard-tglb6/igt@[email protected]

* igt@kms_flip@2x-flip-vs-suspend-interruptible@bc-vga1-hdmi-a1:
- shard-hsw: [INCOMPLETE][62] ([i915#2055]) -> [PASS][63]
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9537/shard-hsw4/igt@kms_flip@[email protected]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19240/shard-hsw6/igt@kms_flip@[email protected]

* igt@kms_flip@flip-vs-expired-vblank@a-edp1:
- shard-tglb: [FAIL][64] ([i915#2598]) -> [PASS][65]
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9537/shard-tglb6/igt@kms_flip@[email protected]
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19240/shard-tglb5/igt@kms_flip@[email protected]

* igt@kms_hdr@bpc-switch:
- shard-skl: [FAIL][66] ([i915#1188]) -> [PASS][67]
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9537/shard-skl4/igt@[email protected]
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19240/shard-skl4/igt@[email protected]

* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-d-planes:
- shard-tglb: [INCOMPLETE][68] ([i915#2411] / [i915#456]) -> [PASS][69]
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9537/shard-tglb1/igt@[email protected]
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19240/shard-tglb5/igt@[email protected]

* igt@kms_plane_lowres@pipe-a-tiling-none:
- shard-iclb: [DMESG-FAIL][70] ([i915#1226]) -> [PASS][71]
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9537/shard-iclb5/igt@[email protected]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19240/shard-iclb6/igt@[email protected]

* igt@kms_psr@psr2_cursor_mmap_cpu:
- shard-iclb: [SKIP][72] ([fdo#109441]) -> [PASS][73] +1 similar issue
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9537/shard-iclb8/igt@kms_psr@psr2_cursor_mmap_cpu.html
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19240/shard-iclb2/igt@kms_psr@psr2_cursor_mmap_cpu.html

* igt@kms_vblank@pipe-c-ts-continuation-dpms-suspend:
- shard-skl: [INCOMPLETE][74] ([i915#198] / [i915#2405]) -> [PASS][75]
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9537/shard-skl9/igt@[email protected]
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19240/shard-skl10/igt@[email protected]

#### Warnings ####

* igt@i915_pm_rc6_residency@rc6-fence:
- shard-iclb: [WARN][76] ([i915#2681] / [i915#2684]) -> [WARN][77] ([i915#2684])
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9537/shard-iclb8/igt@[email protected]
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19240/shard-iclb5/igt@[email protected]

* igt@kms_dp_dsc@basic-dsc-enable-edp:
- shard-iclb: [DMESG-WARN][78] ([i915#1226]) -> [SKIP][79] ([fdo#109349])
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9537/shard-iclb2/igt@[email protected]
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19240/shard-iclb4/igt@[email protected]

* igt@runner@aborted:
- shard-hsw: [FAIL][80] ([i915#2295]) -> ([FAIL][81], [FAIL][82]) ([i915#142] / [i915#2292] / [i915#2295] / [i915#2505])
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9537/shard-hsw4/igt@[email protected]
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19240/shard-hsw1/igt@[email protected]
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19240/shard-hsw4/igt@[email protected]
- shard-iclb: ([FAIL][83], [FAIL][84]) ([i915#2295] / [i915#2724] / [i915#483]) -> ([FAIL][85], [FAIL][86], [FAIL][87]) ([i915#1814] / [i915#2295] / [i915#2724] / [i915#483])
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9537/shard-iclb8/igt@[email protected]
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9537/shard-iclb8/igt@[email protected]
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19240/shard-iclb5/igt@[email protected]
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19240/shard-iclb5/igt@[email protected]
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19240/shard-iclb3/igt@[email protected]
- shard-apl: ([FAIL][88], [FAIL][89]) ([i915#2295]) -> ([FAIL][90], [FAIL][91], [FAIL][92]) ([i915#1610] / [i915#2295] / [i915#2426])
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9537/shard-apl2/igt@[email protected]
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9537/shard-apl6/igt@[email protected]
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19240/shard-apl4/igt@[email protected]
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19240/shard-apl2/igt@[email protected]
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19240/shard-apl6/igt@[email protected]
- shard-tglb: ([FAIL][93], [FAIL][94]) ([i915#1602] / [i915#2295] / [i915#2667]) -> ([FAIL][95], [FAIL][96], [FAIL][97]) ([i915#1602] / [i915#1764] / [i915#2295] / [i915#2426] / [i915#2667] / [i915#409])
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9537/shard-tglb2/igt@[email protected]
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9537/shard-tglb5/igt@[email protected]
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19240/shard-tglb8/igt@[email protected]
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19240/shard-tglb3/igt@[email protected]
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19240/shard-tglb3/igt@[email protected]
- shard-skl: ([FAIL][98], [FAIL][99]) ([i915#2295] / [i915#2426]) -> [FAIL][100] ([i915#2295])
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9537/shard-skl6/igt@[email protected]
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9537/shard-skl6/igt@[email protected]
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19240/shard-skl2/igt@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109279]: https://bugs.freedesktop.org/show_bug.cgi?id=109279
[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291
[fdo#109349]: https://bugs.freedesktop.org/show_bug.cgi?id=109349
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#111304]: https://bugs.freedesktop.org/show_bug.cgi?id=111304
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1037]: https://gitlab.freedesktop.org/drm/intel/issues/1037
[i915#1149]: https://gitlab.freedesktop.org/drm/intel/issues/1149
[i915#1185]: https://gitlab.freedesktop.org/drm/intel/issues/1185
[i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188
[i915#1226]: https://gitlab.freedesktop.org/drm/intel/issues/1226
[i915#129]: https://gitlab.freedesktop.org/drm/intel/issues/129
[i915#142]: https://gitlab.freedesktop.org/drm/intel/issues/142
[i915#1542]: https://gitlab.freedesktop.org/drm/intel/issues/1542
[i915#155]: https://gitlab.freedesktop.org/drm/intel/issues/155
[i915#1602]: https://gitlab.freedesktop.org/drm/intel/issues/1602
[i915#1610]: https://gitlab.freedesktop.org/drm/intel/issues/1610
[i915#1764]: https://gitlab.freedesktop.org/drm/intel/issues/1764
[i915#177]: https://gitlab.freedesktop.org/drm/intel/issues/177
[i915#1814]: https://gitlab.freedesktop.org/drm/intel/issues/1814
[i915#189]: https://gitlab.freedesktop.org/drm/intel/issues/189
[i915#198]: https://gitlab.freedesktop.org/drm/intel/issues/198
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2055]: https://gitlab.freedesktop.org/drm/intel/issues/2055
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2268]: https://gitlab.freedesktop.org/drm/intel/issues/2268
[i915#2292]: https://gitlab.freedesktop.org/drm/intel/issues/2292
[i915#2295]: https://gitlab.freedesktop.org/drm/intel/issues/2295
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2389]: https://gitlab.freedesktop.org/drm/intel/issues/2389
[i915#2405]: https://gitlab.freedesktop.org/drm/intel/issues/2405
[i915#2411]: https://gitlab.freedesktop.org/drm/intel/issues/2411
[i915#2426]: https://gitlab.freedesktop.org/drm/intel/issues/2426
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#2505]: https://gitlab.freedesktop.org/drm/intel/issues/2505
[i915#2530]: https://gitlab.freedesktop.org/drm/intel/issues/2530
[i915#2598]: https://gitlab.freedesktop.org/drm/intel/issues/2598
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#2667]: https://gitlab.freedesktop.org/drm/intel/issues/2667
[i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681
[i915#2684]: https://gitlab.freedesktop.org/drm/intel/issues/2684
[i915#2724]: https://gitlab.freedesktop.org/drm/intel/issues/2724
[i915#2795]: https://gitlab.freedesktop.org/drm/intel/issues/2795
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#315]: https://gitlab.freedesktop.org/drm/intel/issues/315
[i915#407]: https://gitlab.freedesktop.org/drm/intel/issues/407
[i915#409]: https://gitlab.freedesktop.org/drm/intel/issues/409
[i915#456]: https://gitlab.freedesktop.org/drm/intel/issues/456
[i915#483]: https://gitlab.freedesktop.org/drm/intel/issues/483
[i915#52]: https://gitlab.freedesktop.org/drm/intel/issues/52
[i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#96]: https://gitlab.freedesktop.org/drm/intel/issues/96

Participating hosts (10 -> 10)
------------------------------

No changes in participating hosts

Build changes
-------------

* Linux: CI_DRM_9537 -> Patchwork_19240

CI-20190529: 20190529
CI_DRM_9537: c232ca705490fdec5109dd0c9b8a413dc3de5ecb @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5934: a5c54153a82fe4cbd3b72cd85eb1b3eea91a1155 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_19240: 97d8c4c5ab267cb4cc1bf5360d7475548e375b00 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19240/index.html

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Reviewed-by on v1 1/1
#3 lore raw
In reply to Matt Roper

Quoting Matt Roper (2020-12-31 19:11:03)

Quoted 16 lines

Let's modify the "workaround lost" error message slightly to make it more clear what the various numbers represent. Also, the 'expected' value needs to be &'d with wa->read so that it doesn't include the mask bits for masked registers (those bits are write-only in the hardware and will usually always read out as 0's).

---
 drivers/gpu/drm/i915/gt/intel_workarounds.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/gt/intel_workarounds.c +0 -0
index 42d320e68b60..b0e3a5ba0320 100644

drivers/gpu/drm/i915/gt/intel_workarounds.c static bool · line 1388

Quoted 8 lines
drivers/gpu/drm/i915/gt/intel_workarounds.c +2 -2
@@ -1383,9 +1383,9 @@ static bool
 wa_verify(const struct i915_wa *wa, u32 cur, const char *name, const char *from)
 {
        if ((cur ^ wa->set) & wa->read) {
-               DRM_ERROR("%s workaround lost on %s! (%x=%x/%x, expected %x)\n",
+               DRM_ERROR("%s workaround lost on %s! (reg[%x]=0x%x, relevant bits were 0x%x vs expected 0x%x)\n",
                          name, from, i915_mmio_reg_offset(wa->reg),
-                         cur, cur & wa->read, wa->set);
+                         cur, cur & wa->read, wa->set & wa->read);

-Chris
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx