dt-bindings: mips: lantiq: Document Lantiq Xway CGU bindings
Subsystems (2)
PATCH 1/1 dt-bindings: mips: lantiq: Document Lantiq Xway CGU bindings
Document the Lantiq Xway SoC series Clock Generation Unit (CGU) bindings.
--- .../bindings/mips/lantiq/lantiq,cgu.yaml | 32 +++++++++++++++++++ 1 file changed, 32 insertions(+) create mode 100644 Documentation/devicetree/bindings/mips/lantiq/lantiq,cgu.yaml
Documentation/devicetree/bindings/mips/lantiq/lantiq,cgu.yaml new file +32 -0
@@ -0,0 +1,32 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/mips/lantiq/lantiq,cgu.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Lantiq Xway SoC series Clock Generation Unit (CGU) + +maintainers: + - John Crispin <[email protected]> + +properties: + compatible: + items: + - enum: + - lantiq,cgu-xway + + reg: + maxItems: 1 + +required: + - compatible + - reg + +additionalProperties: false + +examples: + - | + cgu@103000 { + compatible = "lantiq,cgu-xway"; + reg = <0x103000 0x1000>; + };
Signature · 1 line
2.20.1
Quoted 8 lines · Aleksander Jan Bajkowski
Document the Lantiq Xway SoC series Clock Generation Unit (CGU) bindings.
Signed-off-by Aleksander Jan Bajkowski <[email protected]>--- .../bindings/mips/lantiq/lantiq,cgu.yaml | 32 +++++++++++++++++++ 1 file changed, 32 insertions(+) create mode 100644 Documentation/devicetree/bindings/mips/lantiq/lantiq,cgu.yaml
Quoted 7 lines · Aleksander Jan Bajkowski
Document the Lantiq Xway SoC series Clock Generation Unit (CGU) bindings.
Signed-off-by Aleksander Jan Bajkowski <[email protected]>--- .../bindings/mips/lantiq/lantiq,cgu.yaml | 32 +++++++++++++++++++ 1 file changed, 32 insertions(+) create mode 100644 Documentation/devicetree/bindings/mips/lantiq/lantiq,cgu.yaml
applied to mips-next.
Thomas.
Signature · 2 lines
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]
(sorry for only seeing this late)
[...]
Documentation/devicetree/bindings/mips/lantiq/lantiq,cgu.yaml line 10
Quoted 2 lines
Documentation/devicetree/bindings/mips/lantiq/lantiq,cgu.yaml new file +2
-0+maintainers: + - John Crispin <[email protected]>
personally I think we should get at least John's Acked-by but I don't know if there's any rule for adding a dt-binding for some other maintainer
[...]
Documentation/devicetree/bindings/mips/lantiq/lantiq,cgu.yaml line 23
Quoted 3 lines
Documentation/devicetree/bindings/mips/lantiq/lantiq,cgu.yaml new file +3
-0+required: + - compatible + - reg
based on "DOs and DON’Ts for designing and writing Devicetree bindings" from [0] I think this is incomplete
As far as I know CGU contains some PLLs. These PLLs need at least one
input: the main XTAL which is found on the board
Also the Lantiq code does not use the common clock framework yet. Once that's used we also need #clock-cells = <1>. I don't know if that should be added already (or not).
Documentation/devicetree/bindings/mips/lantiq/lantiq,cgu.yaml line 29
Quoted 3 lines
Documentation/devicetree/bindings/mips/lantiq/lantiq,cgu.yaml new file +3
-0+examples: + - | + cgu@103000 {
this should be clock-controller@...
Best regards,
Martin
[0] https://www.kernel.org/doc/html/latest/devicetree/bindings/writing-bindings.html