i915: fix shift warning
Subsystems (2)
PATCH v2 1/1 i915: fix shift warning
From: Arnd Bergmann <[email protected]>
Randconfig builds on 32-bit machines show lots of warnings for the i915 driver for passing a 32-bit value into __const_hweight64():
drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c:2584:9: error: shift count >= width of type [-Werror,-Wshift-count-overflow]
return hweight64(VDBOX_MASK(&i915->gt));
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~include/asm-generic/bitops/const_hweight.h:29:49: note: expanded from macro 'hweight64'
#define hweight64(w) (__builtin_constant_p(w) ? __const_hweight64(w) : __arch_hweight64(w))
Change it to hweight_long() to avoid the warning.
--- drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c +1 -1
@@ -2581,7 +2581,7 @@ static int eb_submit(struct i915_execbuffer *eb, struct i915_vma *batch)static int num_vcs_engines (const struct drm_i915_private *i915) { -return hweight64 (VDBOX_MASK (&i915->gt)); +return hweight_long (VDBOX_MASK (&i915->gt)); }/*
Signature · 6 lines
2.29.2 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoting Arnd Bergmann (2021-01-03 13:51:44)
Quoted 6 lines
From: Arnd Bergmann <[email protected]>
Randconfig builds on 32-bit machines show lots of warnings for the i915 driver for passing a 32-bit value into
__const_hweight64():
drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c:2584:9: error: shift count >= width of type [-Werror,-Wshift-count-overflow]
Quoted 8 lines
return hweight64(VDBOX_MASK(&i915->gt)); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/asm-generic/bitops/const_hweight.h:29:49: note: expanded from macro 'hweight64'
#define hweight64(w) (__builtin_constant_p(w)?__const_hweight64(w):__arch_hweight64(w))Change it to
hweight_long()to avoid the warning.Signed-off-by Arnd Bergmann <[email protected]>
-Chris
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Patchwork
CI[Intel-gfx] ✗ Fi.CI.BAT: failure for i915: fix shift warning (rev2)
In reply to Arnd Bergmann== Series Details ==
== Series Details ==
Series: i915: fix shift warning (rev2)
URL : https://patchwork.freedesktop.org/series/85448/
State : failure
== Summary ==
Applying: i915: fix shift warning
Using index info to reconstruct a base tree...
M drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
Falling back to patching base and 3-way merge... Auto-merging drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c No changes -- Patch already applied.
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx