Skip to contentSkip to conversation

mkfs: fix wrong inobtcount usage error output

PATCH In review Zorro Lang 2 participants 2 messages Jan 4, 2021

lore
Share & tools
lore

Zorro Lang

author
#0 lore raw

PATCH 1/1 mkfs: fix wrong inobtcount usage error output

When mkfs fails, it shows:
...

  /* metadata */         [-m crc=0|1,finobt=0|1,uuid=xxx,rmapbt=0|1,reflink=0|1,\n\
                           inobtcnt=0|1,bigtime=0|1]\n\

...

The "inobtcnt=0|1" is wrong usage, it must be inobtcount, there's not an alias. To avoid misadvice, fix it.

---
 mkfs/xfs_mkfs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
mkfs/xfs_mkfs.c +1 -1
index 47acc127..0581843f 100644
@@ -928,7 +928,7 @@ usage( void )
 /* blocksize */		[-b size=num]\n\
 /* config file */	[-c options=xxx]\n\
 /* metadata */		[-m crc=0|1,finobt=0|1,uuid=xxx,rmapbt=0|1,reflink=0|1,\n\
-			    inobtcnt=0|1,bigtime=0|1]\n\
+			    inobtcount=0|1,bigtime=0|1]\n\
 /* data subvol */	[-d agcount=n,agsize=n,file,name=xxx,size=num,\n\
 			    (sunit=value,swidth=value|su=num,sw=num|noalign),\n\
 			    sectsize=num\n\
Signature · 1 line
2.25.4
Reviewed-by on v1 1/1
#1 lore raw
Quoted 8 lines · Zorro Lang

When mkfs fails, it shows:
...

  /* metadata */         [-m crc=0|1,finobt=0|1,uuid=xxx,rmapbt=0|1,reflink=0|1,\n\
                           inobtcnt=0|1,bigtime=0|1]\n\

...

The "inobtcnt=0|1" is wrong usage, it must be inobtcount, there's not an alias. To avoid misadvice, fix it.

Good catch, thanks.

(it's funny how we abbreviate some things and not others)

Quoted 1 line
Quoted 18 lines
---
 mkfs/xfs_mkfs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
mkfs/xfs_mkfs.c +1 -1
index 47acc127..0581843f 100644
@@ -928,7 +928,7 @@ usage( void )
 /* blocksize */		[-b size=num]\n\
 /* config file */	[-c options=xxx]\n\
 /* metadata */		[-m crc=0|1,finobt=0|1,uuid=xxx,rmapbt=0|1,reflink=0|1,\n\
-			    inobtcnt=0|1,bigtime=0|1]\n\
+			    inobtcount=0|1,bigtime=0|1]\n\
 /* data subvol */	[-d agcount=n,agsize=n,file,name=xxx,size=num,\n\
 			    (sunit=value,swidth=value|su=num,sw=num|noalign),\n\
 			    sectsize=num\n\