Skip to contentSkip to conversation

spi: renesas_rpc_spi: Fix fallback compatibility string

PATCH New Adam Ford 2 participants 4 messages Jan 4, 2021 – Jan 13, 2021 SPI

lore
Share & tools
lore

Adam Ford

author
#0 lore raw

PATCH 1/1 spi: renesas_rpc_spi: Fix fallback compatibility string

A generic compatibility string was added, but it doesn't match the name used by Linux or the device tree bindings from any of the SoC's. Fix it to read "renesas,rcar-gen3-rpc-if"

Fixes 2f220c639a2a ("spi: renesas_rpc_spi: Add R-Car Gen3 and RZ/G2 fallback compatibility string")
drivers/spi/renesas_rpc_spi.c +1 -1
index d0ff918af8..0724a03a34 100644
@@ -454,7 +454,7 @@ static const struct udevice_id rpc_spi_ids[] = {
 	{ .compatible = "renesas,rpc-r8a77965" },
 	{ .compatible = "renesas,rpc-r8a77970" },
 	{ .compatible = "renesas,rpc-r8a77995" },
-	{ .compatible = "renesas,rcar-gen3-rpc" },
+	{ .compatible = "renesas,rcar-gen3-rpc-if" },
 	{ }
 };
 
Signature · 1 line
2.25.1
#1 lore raw

PATCH 1/1 spi: renesas_rpc_spi: Fix fallback compatibility string

Hi Adam,

Thanks for the patch.

Quoted 11 lines

-----Original Message-----
From: Adam Ford <[email protected]>
Sent: 04 January 2021 17:38
To: u-boot at lists.denx.de
Cc: jagan at amarulasolutions.com; Biju Das <[email protected]>; Adam Ford <[email protected]>
Subject: [PATCH] spi: renesas_rpc_spi: Fix fallback compatibility string

A generic compatibility string was added, but it doesn't match the name used by Linux or the device tree bindings from any of the SoC's. Fix it to read "renesas,rcar-gen3-rpc-if"

The framework used in Linux and u-boot are different. On Linux there is Core RPC-IF driver which has the above compatible string, with support for both spi flash and hyperflash support.

Where as in u-boot, it is supporting only rpc spi flash. Since the driver is not supporting hyperflash in u-boot, may be we could reuse "renesas,rcar-gen3-rpc-if" just for rpc spi flash.

Marek, What do you think?

Cheers,
Biju

Quoted 20 lines
Fixes 2f220c639a2a ("spi: renesas_rpc_spi: Add R-Car Gen3 and RZ/G2

fallback compatibility string")

drivers/spi/renesas_rpc_spi.c +1 -2
index d0ff918af8..0724a03a34 100644
@@ -454,7 +454,7 @@ static const struct udevice_id rpc_spi_ids[] = {
 	{ .compatible = "renesas,rpc-r8a77965" },
 	{ .compatible = "renesas,rpc-r8a77970" },
 	{ .compatible = "renesas,rpc-r8a77995" },
-	{ .compatible = "renesas,rcar-gen3-rpc" },
+	{ .compatible = "renesas,rcar-gen3-rpc-if" },
 	{ }
 };
 
--

2.25.1

author
#2 lore raw

PATCH 1/1 spi: renesas_rpc_spi: Fix fallback compatibility string

Quoted 13 lines · Biju Das

Hi Adam,

Thanks for the patch.

Quoted 8 lines

-----Original Message-----
From: Adam Ford <[email protected]>
Sent: 04 January 2021 17:38
To: u-boot at lists.denx.de
Cc: jagan at amarulasolutions.com; Biju Das <[email protected]>; Adam Ford <[email protected]>
Subject: [PATCH] spi: renesas_rpc_spi: Fix fallback compatibility string

Quoted 5 lines
Quoted 3 lines

A generic compatibility string was added, but it doesn't match the name used by Linux or the device tree bindings from any of the SoC's. Fix it to read "renesas,rcar-gen3-rpc-if"

The framework used in Linux and u-boot are different. On Linux there is Core RPC-IF driver which has the above compatible string, with support for both spi flash and hyperflash support.

Does the hyperflash have a separate .compatible entry?

Quoted 1 line

Where as in u-boot, it is supporting only rpc spi flash. Since the driver is not supporting hyperflash in u-boot, may be we could reuse "renesas,rcar-gen3-rpc-if" just for rpc spi flash.

It seems like we should make the driver compatible flag match, otherwise, we'll be needing to add additional -u-boot.dtsi files with these compatibility flags.

Quoted 2 lines

Marek, What do you think?

Gentle nudge.

adam

Quoted 25 lines

Cheers,
Biju

Quoted 20 lines
Fixes 2f220c639a2a ("spi: renesas_rpc_spi: Add R-Car Gen3 and RZ/G2

fallback compatibility string")

drivers/spi/renesas_rpc_spi.c +1 -2
index d0ff918af8..0724a03a34 100644
@@ -454,7 +454,7 @@ static const struct udevice_id rpc_spi_ids[] = {
      { .compatible = "renesas,rpc-r8a77965" },
      { .compatible = "renesas,rpc-r8a77970" },
      { .compatible = "renesas,rpc-r8a77995" },
-     { .compatible = "renesas,rcar-gen3-rpc" },
+     { .compatible = "renesas,rcar-gen3-rpc-if" },
      { }
 };
 
--

2.25.1

#3 lore raw

PATCH 1/1 spi: renesas_rpc_spi: Fix fallback compatibility string

Hi Adam,

Thanks for the reply.

Quoted 24 lines

-----Original Message-----
Subject: Re: [PATCH] spi: renesas_rpc_spi: Fix fallback compatibility string

Quoted 18 lines · Biju Das

Hi Adam,

Thanks for the patch.

Quoted 12 lines

-----Original Message-----
From: Adam Ford <[email protected]>
Sent: 04 January 2021 17:38
To: u-boot at lists.denx.de
Cc: jagan at amarulasolutions.com; Biju Das <[email protected]>; Adam Ford <[email protected]>
Subject: [PATCH] spi: renesas_rpc_spi: Fix fallback compatibility string

A generic compatibility string was added, but it doesn't match the name used by Linux or the device tree bindings from any of the SoC's. Fix it to read "renesas,rcar-gen3-rpc-if"

Quoted 5 lines
Quoted 1 line

The framework used in Linux and u-boot are different. On Linux there is

Core RPC-IF driver which has the above compatible string, with support for both spi flash and hyperflash support.

Does the hyperflash have a separate .compatible entry?

Core driver [1] and documentation[2] is here [1]https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/drivers/memory/renesas-rpc-if.c?h=next-20210113 [2]https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/Documentation/devicetree/bindings/memory-controllers/renesas,rpc-if.yaml?h=next-20210113

As per [2], hyperflash uses same compatible string and there is no compatible stuff defined in hyperflash driver[3]
[3] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/drivers/mtd/hyperbus/rpc-if.c?h=next-20210113

Quoted 4 lines
Quoted 2 lines

Where as in u-boot, it is supporting only rpc spi flash. Since the

driver is not supporting hyperflash in u-boot, may be we could reuse "renesas,rcar-gen3-rpc-if" just for rpc spi flash.

Sorry , just found that U-boot have hyperflash support[4] and it uses compatible string "renesas,rpc".
[4] https://elixir.bootlin.com/u-boot/v2021.01-rc5/source/drivers/mtd/renesas_rpc_hf.c

Thanks,
Biju

Quoted 22 lines
Quoted 22 lines
Quoted 21 lines
Fixes 2f220c639a2a ("spi: renesas_rpc_spi: Add R-Car Gen3 and RZ/G2

fallback compatibility string")

(quoted diff) +0 -0

b/drivers/spi/renesas_rpc_spi.c index d0ff918af8..0724a03a34 100644

drivers/spi/renesas_rpc_spi.c +1 -2
@@ -454,7 +454,7 @@ static const struct udevice_id rpc_spi_ids[] = {
      { .compatible = "renesas,rpc-r8a77965" },
      { .compatible = "renesas,rpc-r8a77970" },
      { .compatible = "renesas,rpc-r8a77995" },
-     { .compatible = "renesas,rcar-gen3-rpc" },
+     { .compatible = "renesas,rcar-gen3-rpc-if" },
      { }
 };
 
--

2.25.1