media: i2c: ov5648/ov8865: Minor cosmetic fixes
Subsystems (2)
PATCH 1/1 media: i2c: ov5648/ov8865: Minor cosmetic fixes
This solves a few minor cosmetic issues picked up by checkpatch for the OV5648 and OV8865 drivers.
Signed-off-by Paul Kocialkowski <[email protected]>
--- drivers/media/i2c/ov5648.c | 2 +- drivers/media/i2c/ov8865.c | 7 +++---- 2 files changed, 4 insertions(+), 5 deletions(-)
drivers/media/i2c/ov5648.c +1 -1
@@ -496,7 +496,7 @@ container_of(s, struct ov5648_sensor, subdev)#define ov5648_ctrl_subdev (c) \ - (&container_of(c->handler, struct ov5648_sensor, ctrls.handler)->subdev) + (&container_of((c)->handler, struct ov5648_sensor, ctrls.handler)->subdev)/* Data structures */
drivers/media/i2c/ov8865.c +3 -4
@@ -223,7 +223,6 @@#define OV8865_FORMAT2_FLIP_HORZ_SENSOR_EN BIT(1)#define OV8865_FORMAT2_SYNC_HBIN_EN BIT(0) -#define OV8865_INC_Y_ODD_REG 0x382a#define OV8865_INC_Y_ODD (v) ((v) & GENMASK(4, 0))#define OV8865_INC_Y_EVEN_REG 0x382b
@@ -460,7 +459,7 @@ container_of(s, struct ov8865_sensor, subdev)#define ov8865_ctrl_subdev (c) \ - (&container_of(c->handler, struct ov8865_sensor, ctrls.handler)->subdev) + (&container_of((c)->handler, struct ov8865_sensor, ctrls.handler)->subdev)/* Data structures */
@@ -1598,8 +1597,8 @@ static int ov8865_mode_pll1_configure(struct ov8865_sensor *sensor,return ret; ret =ov8865_update_bits (sensor,OV8865_PCLK_SEL_REG , -OV8865_PCLK_SEL_PCLK_DIV_MASK , -OV8865_PCLK_SEL_PCLK_DIV (config->pclk_div)); +OV8865_PCLK_SEL_PCLK_DIV_MASK , +OV8865_PCLK_SEL_PCLK_DIV (config->pclk_div));if (ret)return ret;
Signature · 1 line
2.29.2
Sakari Ailus
maintainerHi Paul,
Thanks for the patch.
Quoted 14 lines · Paul Kocialkowski
This solves a few minor cosmetic issues picked up by checkpatch for the OV5648 and OV8865 drivers.
Signed-off-by Paul Kocialkowski <[email protected]>--- drivers/media/i2c/ov5648.c | 2 +- drivers/media/i2c/ov8865.c | 7 +++---- 2 files changed, 4 insertions(+), 5 deletions(-)drivers/media/i2c/ov5648.c +0
-0
drivers/media/i2c/ov5648.c line 499
Quoted 5 lines
drivers/media/i2c/ov5648.c +1
-1@@ -496,7 +496,7 @@ container_of(s, struct ov5648_sensor, subdev)#define ov5648_ctrl_subdev (c) \ - (&container_of(c->handler, struct ov5648_sensor, ctrls.handler)->subdev) + (&container_of((c)->handler, struct ov5648_sensor, ctrls.handler)->subdev)
Over 80; please wrap.
Quoted 16 lines
drivers/media/i2c/ov5648.c +0
-0/* Data structures */ drivers/media/i2c/ov8865.c +0
-1@@ -223,7 +223,6 @@#define OV8865_FORMAT2_FLIP_HORZ_SENSOR_EN BIT(1)#define OV8865_FORMAT2_SYNC_HBIN_EN BIT(0) -#define OV8865_INC_Y_ODD_REG 0x382a#define OV8865_INC_Y_ODD (v) ((v) & GENMASK(4, 0))#define OV8865_INC_Y_EVEN_REG 0x382b
drivers/media/i2c/ov8865.c line 462
Quoted 5 lines
drivers/media/i2c/ov8865.c +1
-1@@ -460,7 +459,7 @@ container_of(s, struct ov8865_sensor, subdev)#define ov8865_ctrl_subdev (c) \ - (&container_of(c->handler, struct ov8865_sensor, ctrls.handler)->subdev) + (&container_of((c)->handler, struct ov8865_sensor, ctrls.handler)->subdev)
Ditto.
Quoted 17 lines
drivers/media/i2c/ov8865.c +2
-2/* Data structures */ @@ -1598,8 +1597,8 @@ static int ov8865_mode_pll1_configure(struct ov8865_sensor *sensor,return ret; ret =ov8865_update_bits (sensor,OV8865_PCLK_SEL_REG , -OV8865_PCLK_SEL_PCLK_DIV_MASK , -OV8865_PCLK_SEL_PCLK_DIV (config->pclk_div)); +OV8865_PCLK_SEL_PCLK_DIV_MASK , +OV8865_PCLK_SEL_PCLK_DIV (config->pclk_div));if (ret)return ret;Signature · 1 line
2.29.2
Signature · 1 line
Sakari Ailus