sched/fair:Avoid unnecessary assignment to cfs_rq->on_list
PATCH 1/1 sched/fair:Avoid unnecessary assignment to cfs_rq->on_list
From: jun qian <[email protected]>
Obviously, cfs_rq->on_list is already equal to 1 when cfs_rq->on_list is assigned a value of 1, so an else branch is needed to avoid unnecessary assignment operations.
Signed-off-by jun qian <[email protected]>
--- kernel/sched/fair.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
kernel/sched/fair.c +2 -2
@@ -305,8 +305,8 @@ static inline bool list_add_leaf_cfs_rq(struct cfs_rq *cfs_rq)if (cfs_rq->on_list)return rq->tmp_alone_branch == &rq->leaf_cfs_rq_list; - - cfs_rq->on_list =1 ; +else + cfs_rq->on_list =1 ;/* * Ensure we either appear before our parent (if already
Signature · 1 line
2.18.2
Vincent Guittot
maintainerQuoted 17 lines · On Thu, 7 Jan 2021 at 02:57, <[email protected]> wrote:
From: jun qian <[email protected]>
Obviously,
cfs_rq->on_listis already equal to 1 whencfs_rq->on_listis assigned a value of 1, so an else branch is needed to avoid unnecessary assignment operations.Signed-off-by jun qian <[email protected]>--- kernel/sched/fair.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)kernel/sched/fair.c +0
-0
kernel/sched/fair.c static inline bool list_add_leaf_cfs_rq(struct cfs_rq *cfs_rq) · line 307
Quoted 3 lines
kernel/sched/fair.c +0
-0@@ -305,8 +305,8 @@ static inline bool list_add_leaf_cfs_rq(struct cfs_rq *cfs_rq)if (cfs_rq->on_list)return rq->tmp_alone_branch == &rq->leaf_cfs_rq_list;
if cfs_rq->on_list == 1, list_add_leaf_cfs_rq() returns and will not unnecessary set cfs_rq->on_list
so your change is useless but makes the code less readable
Quoted 10 lines
kernel/sched/fair.c +2
-3- - cfs_rq->on_list =1 ; +else + cfs_rq->on_list =1 ;/* * Ensure we either appear before our parent (if already -- 2.18.2