5.10.6-rc1 review
Subsystems (2)
Greg Kroah-Hartman
maintainercover 5.10.6-rc1 review
This is the start of the stable review cycle for the 5.10.6 release. There are 20 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Sat, 09 Jan 2021 14:30:35 +0000. Anything received after that time might be too late.
The whole patch series can be found in one patch at:
https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.6-rc1.gz
or in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y
and the diffstat can be found below.
thanks,
greg k-h
-------------
Pseudo-Shortlog of commits:
Greg Kroah-Hartman <[email protected]>
Linux 5.10.6-rc1
Zhang Xiaohui <[email protected]>
mwifiex: Fix possible buffer overflows in mwifiex_cmd_802_11_ad_hoc_start
Eric W. Biederman <[email protected]>
exec: Transform exec_update_mutex into a rw_semaphore
Eric W. Biederman <[email protected]>
rwsem: Implement down_read_interruptible
Eric W. Biederman <[email protected]>
rwsem: Implement down_read_killable_nested
[email protected] <[email protected]>
perf: Break deadlock involving exec_update_mutex
Miklos Szeredi <[email protected]>
fuse: fix bad inode
Jason Gunthorpe <[email protected]>
RDMA/siw,rxe: Make emulated devices virtual in the device tree
Christoph Hellwig <[email protected]>
RDMA/core: remove use of dma_virt_ops
Stanley Chu <[email protected]>
scsi: ufs: Re-enable WriteBooster after device reset
Adrian Hunter <[email protected]>
scsi: ufs: Allow an error return value from ->device_reset()
Imre Deak <[email protected]>
drm/i915/tgl: Fix Combo PHY DPLL fractional divider for 38.4MHz ref clock
Takashi Iwai <[email protected]>
ALSA: hda/hdmi: Fix incorrect mutex unlock in silent_stream_disable()
Kailang Yang <[email protected]>
ALSA: hda/realtek - Modify Dell platform name
Edward Vear <[email protected]>
Bluetooth: Fix attempting to set RPA timeout when unsupported
Josh Poimboeuf <[email protected]>
kdev_t: always inline major/minor helper functions
Rasmus Villemoes <[email protected]>
dt-bindings: rtc: add reset-source property
Uwe Kleine-König <[email protected]>
rtc: pcf2127: only use watchdog when explicitly available
Uwe Kleine-König <[email protected]>
rtc: pcf2127: move watchdog initialisation to a separate function
Felix Fietkau <[email protected]>
Revert "mtd: spinand: Fix OOB read"
Alex Deucher <[email protected]>
Revert "drm/amd/display: Fix memory leaks in S3 resume"
-------------
Diffstat:
Documentation/devicetree/bindings/rtc/rtc.yaml | 5 ++ Makefile | 4 +- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 +- drivers/gpu/drm/i915/display/intel_dpll_mgr.c | 41 ++++++++----- drivers/infiniband/core/device.c | 43 ++++++------- drivers/infiniband/core/rw.c | 5 +- drivers/infiniband/sw/rdmavt/Kconfig | 1 - drivers/infiniband/sw/rdmavt/mr.c | 6 +- drivers/infiniband/sw/rdmavt/vt.c | 8 --- drivers/infiniband/sw/rxe/Kconfig | 1 - drivers/infiniband/sw/rxe/rxe_net.c | 12 ---- drivers/infiniband/sw/rxe/rxe_verbs.c | 8 --- drivers/infiniband/sw/rxe/rxe_verbs.h | 1 - drivers/infiniband/sw/siw/Kconfig | 1 - drivers/infiniband/sw/siw/siw.h | 1 - drivers/infiniband/sw/siw/siw_main.c | 26 +------- drivers/mtd/nand/spi/core.c | 4 -- drivers/net/wireless/marvell/mwifiex/join.c | 2 + drivers/nvme/target/rdma.c | 3 +- drivers/rtc/rtc-pcf2127.c | 57 ++++++++++-------- drivers/scsi/ufs/ufs-mediatek.c | 4 +- drivers/scsi/ufs/ufs-qcom.c | 6 +- drivers/scsi/ufs/ufshcd.h | 16 +++-- fs/exec.c | 12 ++-- fs/fuse/acl.c | 6 ++ fs/fuse/dir.c | 37 ++++++++++-- fs/fuse/file.c | 19 +++--- fs/fuse/fuse_i.h | 12 ++++ fs/fuse/inode.c | 4 +- fs/fuse/readdir.c | 4 +- fs/fuse/xattr.c | 9 +++ fs/proc/base.c | 10 ++-- include/linux/kdev_t.h | 22 +++---- include/linux/rwsem.h | 3 + include/linux/sched/signal.h | 11 ++-- include/rdma/ib_verbs.h | 73 ++++++++++++++++------- init/init_task.c | 2 +- kernel/events/core.c | 52 ++++++++-------- kernel/fork.c | 6 +- kernel/kcmp.c | 30 +++++----- kernel/locking/rwsem.c | 40 +++++++++++++ kernel/pid.c | 4 +- net/bluetooth/hci_core.c | 2 +- sound/pci/hda/patch_hdmi.c | 2 +- sound/pci/hda/patch_realtek.c | 2 +- 45 files changed, 363 insertions(+), 257 deletions(-)
Greg Kroah-Hartman
maintainerPATCH 1/20 Revert "drm/amd/display: Fix memory leaks in S3 resume"
From: Alex Deucher <[email protected]>
This reverts commit a135a1b4c4db1f3b8cbed9676a40ede39feb3362.
This leads to blank screens on some boards after replugging a display. Revert until we understand the root cause and can fix both the leak and the blank screen after replug.
--- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +1 -2
@@ -2278,8 +2278,7 @@ void amdgpu_dm_update_connector_after_dedrm_connector_update_edid_property (connector, aconnector->edid); - aconnector->num_modes =drm_add_edid_modes (connector, aconnector->edid); -drm_connector_list_update (connector); +drm_add_edid_modes (connector, aconnector->edid);if (aconnector->dc_link->aux_mode) drm_dp_cec_set_edid(&aconnector->dm_dp_aux.aux,
Greg Kroah-Hartman
maintainerPATCH 2/20 Revert "mtd: spinand: Fix OOB read"
In reply to Greg Kroah-HartmanFrom: Felix Fietkau <[email protected]>
This reverts stable commit baad618d078c857f99cc286ea249e9629159901f.
This commit is adding lines to spinand_write_to_cache_op, wheras the upstream commit 868cbe2a6dcee451bd8f87cbbb2a73cf463b57e5 that this was supposed to backport was touching spinand_read_from_cache_op.
It causes a crash on writing OOB data by attempting to write to read-only kernel memory.
--- drivers/mtd/nand/spi/core.c | 4 ---- 1 file changed, 4 deletions(-)
drivers/mtd/nand/spi/core.c +0 -4
@@ -318,10 +318,6 @@ static int spinand_write_to_cache_op(str buf += ret; } -if (req->ooblen) -memcpy (req->oobbuf.in, spinand->oobbuf + req->ooboffs, - req->ooblen); -return 0 ; }
Greg Kroah-Hartman
maintainerPATCH 3/20 rtc: pcf2127: move watchdog initialisation to a separate function
In reply to Greg Kroah-HartmanFrom: Uwe Kleine-König <[email protected]>
commit 5d78533a0c53af9659227c803df944ba27cd56e0 upstream.
The obvious advantages are:
- The linker can drop the watchdog functions if CONFIG_WATCHDOG is off.
- All watchdog stuff grouped together with only a single function call left in generic code.
- Watchdog register is only read when it is actually used.
- Less #ifdefery
--- drivers/rtc/rtc-pcf2127.c | 56 +++++++++++++++++++++++++--------------------- 1 file changed, 31 insertions(+), 25 deletions(-)
drivers/rtc/rtc-pcf2127.c +31 -25
@@ -331,6 +331,36 @@ static const struct watchdog_ops pcf2127 .set_timeout = pcf2127_wdt_set_timeout, }; +static int pcf2127_watchdog_init (struct device *dev,struct pcf2127 *pcf2127) +{ +u32 wdd_timeout; +int ret; + +if (!IS_ENABLED (CONFIG_WATCHDOG )) +return 0 ; + + pcf2127->wdd.parent = dev; + pcf2127->wdd.info = &pcf2127_wdt_info; + pcf2127->wdd.ops = &pcf2127_watchdog_ops; + pcf2127->wdd.min_timeout =PCF2127_WD_VAL_MIN ; + pcf2127->wdd.max_timeout =PCF2127_WD_VAL_MAX ; + pcf2127->wdd.timeout =PCF2127_WD_VAL_DEFAULT ; + pcf2127->wdd.min_hw_heartbeat_ms =500 ; + pcf2127->wdd.status =WATCHDOG_NOWAYOUT_INIT_STATUS ; + +watchdog_set_drvdata (&pcf2127->wdd, pcf2127); + +/* Test if watchdog timer is started by bootloader */ + ret =regmap_read (pcf2127->regmap,PCF2127_REG_WD_VAL , &wdd_timeout); +if (ret) +return ret; + +if (wdd_timeout) +set_bit (WDOG_HW_RUNNING , &pcf2127->wdd.status); + +return devm_watchdog_register_device (dev, &pcf2127->wdd); +} +/* Alarm */ static int pcf2127_rtc_read_alarm (struct device *dev,struct rtc_wkalrm *alrm) {
@@ -532,7 +562,6 @@ static int pcf2127_probe(struct device * int alarm_irq, const char *name, bool has_nvmem) { struct pcf2127 *pcf2127; -u32 wdd_timeout;int ret =0 ;dev_dbg (dev,"%s\n" , __func__);
@@ -571,17 +600,6 @@ static int pcf2127_probe(struct device * pcf2127->rtc->ops = &pcf2127_rtc_alrm_ops; } - pcf2127->wdd.parent = dev; - pcf2127->wdd.info = &pcf2127_wdt_info; - pcf2127->wdd.ops = &pcf2127_watchdog_ops; - pcf2127->wdd.min_timeout =PCF2127_WD_VAL_MIN ; - pcf2127->wdd.max_timeout =PCF2127_WD_VAL_MAX ; - pcf2127->wdd.timeout =PCF2127_WD_VAL_DEFAULT ; - pcf2127->wdd.min_hw_heartbeat_ms =500 ; - pcf2127->wdd.status =WATCHDOG_NOWAYOUT_INIT_STATUS ; - -watchdog_set_drvdata (&pcf2127->wdd, pcf2127); -if (has_nvmem) {struct nvmem_config nvmem_cfg = { .priv = pcf2127,
@@ -611,19 +629,7 @@ static int pcf2127_probe(struct device *return ret; } -/* Test if watchdog timer is started by bootloader */ - ret =regmap_read (pcf2127->regmap,PCF2127_REG_WD_VAL , &wdd_timeout); -if (ret) -return ret; - -if (wdd_timeout) -set_bit (WDOG_HW_RUNNING , &pcf2127->wdd.status); - -#ifdef CONFIG_WATCHDOG - ret =devm_watchdog_register_device (dev, &pcf2127->wdd); -if (ret) -return ret; -#endif /* CONFIG_WATCHDOG */ +pcf2127_watchdog_init (dev, pcf2127);/* * Disable battery low/switch-over timestamp and interrupts.
Greg Kroah-Hartman
maintainerPATCH 4/20 rtc: pcf2127: only use watchdog when explicitly available
In reply to Greg Kroah-HartmanFrom: Uwe Kleine-König <[email protected]>
commit 71ac13457d9d1007effde65b54818106b2c2b525 upstream.
Most boards using the pcf2127 chip (in my bubble) don't make use of the watchdog functionality and the respective output is not connected. The effect on such a board is that there is a watchdog device provided that doesn't work.
So only register the watchdog if the device tree has a "reset-source" property.
--- drivers/rtc/rtc-pcf2127.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/rtc/rtc-pcf2127.c +2 -1
@@ -336,7 +336,8 @@ static int pcf2127_watchdog_init(structu32 wdd_timeout;int ret; -if (!IS_ENABLED (CONFIG_WATCHDOG )) +if (!IS_ENABLED (CONFIG_WATCHDOG ) || + !device_property_read_bool (dev,"reset-source" ))return 0 ; pcf2127->wdd.parent = dev;
Greg Kroah-Hartman
maintainerPATCH 5/20 dt-bindings: rtc: add reset-source property
In reply to Greg Kroah-HartmanFrom: Rasmus Villemoes <[email protected]>
commit 320d159e2d63a97a40f24cd6dfda5a57eec65b91 upstream.
Some RTCs, e.g. the pcf2127, can be used as a hardware watchdog. But if the reset pin is not actually wired up, the driver exposes a watchdog device that doesn't actually work.
Provide a standard binding that can be used to indicate that a given RTC can perform a reset of the machine, similar to wakeup-source.
--- Documentation/devicetree/bindings/rtc/rtc.yaml | 5 +++++ 1 file changed, 5 insertions(+)
Documentation/devicetree/bindings/rtc/rtc.yaml +5 -0
@@ -63,6 +63,11 @@ properties: description: Enables wake up of host system on alarm. + reset-source: + $ref: /schemas/types.yaml#/definitions/flag + description: + The RTC is able to reset the machine. + additionalProperties: true ...
Greg Kroah-Hartman
maintainerPATCH 6/20 kdev_t: always inline major/minor helper functions
In reply to Greg Kroah-HartmanFrom: Josh Poimboeuf <[email protected]>
commit aa8c7db494d0a83ecae583aa193f1134ef25d506 upstream.
Silly GCC doesn't always inline these trivial functions.
Fixes the following warning:
arch/x86/kernel/sys_ia32.o: warning: objtool: cp_stat64()+0xd8: call to new_encode_dev() with UACCESS enabled
--- include/linux/kdev_t.h | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-)
include/linux/kdev_t.h +11 -11
@@ -21,61 +21,61 @@ })/* acceptable for old filesystems */ -static inline bool old_valid_dev (dev_t dev) +static __always_inline bool old_valid_dev(dev_t dev) {return MAJOR (dev) <256 &&MINOR (dev) <256 ; } -static inline u16 old_encode_dev (dev_t dev) +static __always_inline u16 old_encode_dev(dev_t dev) {return (MAJOR (dev) <<8 ) |MINOR (dev); } -static inline dev_t old_decode_dev (u16 val) +static __always_inline dev_t old_decode_dev(u16 val) {return MKDEV ((val >>8 ) &255 , val &255 ); } -static inline u32 new_encode_dev (dev_t dev) +static __always_inline u32 new_encode_dev(dev_t dev) {unsigned major =MAJOR (dev);unsigned minor =MINOR (dev);return (minor &0xff ) | (major <<8 ) | ((minor & ~0xff ) <<12 ); } -static inline dev_t new_decode_dev (u32 dev) +static __always_inline dev_t new_decode_dev(u32 dev) {unsigned major = (dev &0xfff00 ) >>8 ;unsigned minor = (dev &0xff ) | ((dev >>12 ) &0xfff00 );return MKDEV (major, minor); } -static inline u64 huge_encode_dev (dev_t dev) +static __always_inline u64 huge_encode_dev(dev_t dev) {return new_encode_dev (dev); } -static inline dev_t huge_decode_dev (u64 dev) +static __always_inline dev_t huge_decode_dev(u64 dev) {return new_decode_dev (dev); } -static inline int sysv_valid_dev (dev_t dev) +static __always_inline int sysv_valid_dev(dev_t dev) {return MAJOR (dev) < (1 <<14 ) &&MINOR (dev) < (1 <<18 ); } -static inline u32 sysv_encode_dev (dev_t dev) +static __always_inline u32 sysv_encode_dev(dev_t dev) {return MINOR (dev) | (MAJOR (dev) <<18 ); } -static inline unsigned sysv_major (u32 dev) +static __always_inline unsigned sysv_major (u32 dev) {return (dev >>18 ) &0x3fff ; } -static inline unsigned sysv_minor (u32 dev) +static __always_inline unsigned sysv_minor (u32 dev) {return dev &0x3ffff ; }
Greg Kroah-Hartman
maintainerPATCH 7/20 Bluetooth: Fix attempting to set RPA timeout when unsupported
In reply to Greg Kroah-HartmanFrom: Edward Vear <[email protected]>
commit a31489d2a368d2f9225ed6a6f595c63bc7d10de8 upstream.
During controller initialization, an LE Set RPA Timeout command is sent to the controller if supported. However, the value checked to determine if the command is supported is incorrect. Page 1921 of the Bluetooth Core Spec v5.2 shows that bit 2 of octet 35 of the Supported_Commands field corresponds to the LE Set RPA Timeout command, but currently bit 6 of octet 35 is checked. This patch checks the correct value instead.
This issue led to the error seen in the following btmon output during initialization of an adapter (rtl8761b) and prevented initialization from completing.
< HCI Command: LE Set Resolvable Private Address Timeout (0x08|0x002e) plen 2
Timeout: 900 seconds
Quoted 1 line
HCI Event: Command Complete (
0x0e) plen 4
LE Set Resolvable Private Address Timeout (0x08|0x002e) ncmd 2
Status: Unsupported Remote Feature / Unsupported LMP Feature (0x1a)= Close Index: 00:E0:4C:6B:E5:03
The error did not appear when running with this patch.
--- net/bluetooth/hci_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
net/bluetooth/hci_core.c +1 -1
@@ -763,7 +763,7 @@ static int hci_init3_req(struct hci_requhci_req_add (req,HCI_OP_LE_CLEAR_RESOLV_LIST ,0 ,NULL ); } -if (hdev->commands[35 ] &0x40 ) { +if (hdev->commands[35 ] &0x04 ) {__le16 rpa_timeout =cpu_to_le16 (hdev->rpa_timeout);/* Set RPA timeout */
Greg Kroah-Hartman
maintainerPATCH 8/20 ALSA: hda/realtek - Modify Dell platform name
In reply to Greg Kroah-HartmanFrom: Kailang Yang <[email protected]>
commit c1e8952395c1f44a6304c71401519d19ed2ac56a upstream.
Dell platform SSID:0x0a58 change platform name. Use the generic name instead for avoiding confusion.
--- sound/pci/hda/patch_realtek.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
sound/pci/hda/patch_realtek.c +1 -1
@@ -7885,7 +7885,7 @@ static const struct snd_pci_quirk alc269SND_PCI_QUIRK (0x1028 ,0x09bf ,"Dell Precision" ,ALC233_FIXUP_ASUS_MIC_NO_PRESENCE ),SND_PCI_QUIRK (0x1028 ,0x0a2e ,"Dell" ,ALC236_FIXUP_DELL_AIO_HEADSET_MIC ),SND_PCI_QUIRK (0x1028 ,0x0a30 ,"Dell" ,ALC236_FIXUP_DELL_AIO_HEADSET_MIC ), -SND_PCI_QUIRK (0x1028 ,0x0a58 ,"Dell Precision 3650 Tower" ,ALC255_FIXUP_DELL_HEADSET_MIC ), +SND_PCI_QUIRK (0x1028 ,0x0a58 ,"Dell" ,ALC255_FIXUP_DELL_HEADSET_MIC ),SND_PCI_QUIRK (0x1028 ,0x164a ,"Dell" ,ALC293_FIXUP_DELL1_MIC_NO_PRESENCE ),SND_PCI_QUIRK (0x1028 ,0x164b ,"Dell" ,ALC293_FIXUP_DELL1_MIC_NO_PRESENCE ), SND_PCI_QUIRK(0x103c, 0x1586, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC2),
Greg Kroah-Hartman
maintainerPATCH 9/20 ALSA: hda/hdmi: Fix incorrect mutex unlock in silent_stream_disable()
In reply to Greg Kroah-HartmanFrom: Takashi Iwai <[email protected]>
commit 3d5c5fdcee0f9a94deb0472e594706018b00aa31 upstream.
The silent_stream_disable() function introduced by the commit b1a5039759cb ("ALSA: hda/hdmi: fix silent stream for first playback to DP") takes the per_pin->lock mutex, but it unlocks the wrong one, spec->pcm_lock, which causes a deadlock. This patch corrects it.
--- sound/pci/hda/patch_hdmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
sound/pci/hda/patch_hdmi.c +1 -1
@@ -1736,7 +1736,7 @@ static void silent_stream_disable(struct per_pin->silent_stream = false; unlock_out: -mutex_unlock (&spec->pcm_lock); +mutex_unlock (&per_pin->lock); }/* update ELD and jack state via audio component */
Greg Kroah-Hartman
maintainerPATCH 10/20 drm/i915/tgl: Fix Combo PHY DPLL fractional divider for 38.4MHz ref clock
In reply to Greg Kroah-HartmanFrom: Imre Deak <[email protected]>
commit 0e2497e334de42dbaaee8e325241b5b5b34ede7e upstream.
Apply Display WA #22010492432 for combo PHY PLLs too. This should fix a problem where the PLL output frequency is slightly off with the current PLL fractional divider value.
I haven't seen an actual case where this causes a problem, but let's follow the spec. It's also needed on some EHL platforms, but for that we also need a way to distinguish the affected EHL SKUs, so I leave that for a follow-up.
v2:
- Apply the WA at one place when calculating the PLL dividers from the frequency and the frequency from the dividers for all the combo PLL use cases (DP, HDMI, TBT). (Ville)
--- drivers/gpu/drm/i915/display/intel_dpll_mgr.c | 41 +++++++++++++++----------- 1 file changed, 25 insertions(+), 16 deletions(-)
drivers/gpu/drm/i915/display/intel_dpll_mgr.c +25 -16
@@ -2622,11 +2622,22 @@ static bool cnl_ddi_hdmi_pll_dividers(streturn true; } +/* +* Display WA #22010492432: tgl +* Program half of the nominal DCO divider fraction value. +*/ +static bool +tgl_combo_pll_div_frac_wa_needed (struct drm_i915_private *i915) +{ +return IS_TIGERLAKE (i915) && i915->dpll.ref_clks.nssc ==38400 ; +} +static int __cnl_ddi_wrpll_get_freq (struct drm_i915_private *dev_priv,const struct intel_shared_dpll *pll,int ref_clock) {const struct intel_dpll_hw_state *pll_state = &pll->state.hw_state; +u32 dco_fraction;u32 p0, p1, p2, dco_freq; p0 = pll_state->cfgcr1 &DPLL_CFGCR1_PDIV_MASK ;
@@ -2669,8 +2680,13 @@ static int __cnl_ddi_wrpll_get_freq(stru dco_freq = (pll_state->cfgcr0 &DPLL_CFGCR0_DCO_INTEGER_MASK ) * ref_clock; - dco_freq += (((pll_state->cfgcr0 &DPLL_CFGCR0_DCO_FRACTION_MASK ) >> -DPLL_CFGCR0_DCO_FRACTION_SHIFT ) * ref_clock) /0x8000 ; + dco_fraction = (pll_state->cfgcr0 &DPLL_CFGCR0_DCO_FRACTION_MASK ) >> +DPLL_CFGCR0_DCO_FRACTION_SHIFT ; + +if (tgl_combo_pll_div_frac_wa_needed (dev_priv)) + dco_fraction *=2 ; + + dco_freq += (dco_fraction * ref_clock) /0x8000 ;if (drm_WARN_ON (&dev_priv->drm, p0 ==0 || p1 ==0 || p2 ==0 ))return 0 ;
@@ -2948,16 +2964,6 @@ static const struct skl_wrpll_params tgl/* the following params are unused */ }; -/* -* Display WA #22010492432: tgl -* Divide the nominal .dco_fraction value by 2. -*/ -static const struct skl_wrpll_params tgl_tbt_pll_38_4MHz_values = { - .dco_integer =0x54 , .dco_fraction =0x1800 , -/* the following params are unused */ - .pdiv =0 , .kdiv =0 , .qdiv_mode =0 , .qdiv_ratio =0 , -}; -static bool icl_calc_dp_combo_pll (struct intel_crtc_state *crtc_state,struct skl_wrpll_params *pll_params) {
@@ -2991,14 +2997,12 @@ static bool icl_calc_tbt_pll(struct inteMISSING_CASE (dev_priv->dpll.ref_clks.nssc); fallthrough;case 19200 : +case 38400 : *pll_params = tgl_tbt_pll_19_2MHz_values;break ;case 24000 : *pll_params = tgl_tbt_pll_24MHz_values;break ; -case 38400 : - *pll_params = tgl_tbt_pll_38_4MHz_values; -break ; } }else {switch (dev_priv->dpll.ref_clks.nssc) {
@@ -3065,9 +3069,14 @@ static void icl_calc_dpll_state(struct dconst struct skl_wrpll_params *pll_params, struct intel_dpll_hw_state *pll_state) { + u32 dco_fraction = pll_params->dco_fraction; +memset (pll_state,0 ,sizeof (*pll_state)); - pll_state->cfgcr0 =DPLL_CFGCR0_DCO_FRACTION (pll_params->dco_fraction) | +if (tgl_combo_pll_div_frac_wa_needed (i915)) + dco_fraction =DIV_ROUND_CLOSEST (dco_fraction,2 ); + + pll_state->cfgcr0 =DPLL_CFGCR0_DCO_FRACTION (dco_fraction) | pll_params->dco_integer; pll_state->cfgcr1 = DPLL_CFGCR1_QDIV_RATIO(pll_params->qdiv_ratio) |
Greg Kroah-Hartman
maintainerPATCH 11/20 scsi: ufs: Allow an error return value from ->device_reset()
In reply to Greg Kroah-HartmanFrom: Adrian Hunter <[email protected]>
[ Upstream commit 151f1b664ffbb847c7fbbce5a5b8580f1b9b1d98 ]
It is simpler for drivers to provide a ->device_reset() callback irrespective of whether the GPIO, or firmware interface necessary to do the reset, is discovered during probe.
Change ->device_reset() to return an error code. Drivers that provide the callback, but do not do the reset operation should return -EOPNOTSUPP.
--- drivers/scsi/ufs/ufs-mediatek.c | 4 +++- drivers/scsi/ufs/ufs-qcom.c | 6 ++++-- drivers/scsi/ufs/ufshcd.h | 11 +++++++---- 3 files changed, 14 insertions(+), 7 deletions(-)
drivers/scsi/ufs/ufs-mediatek.c +3 -1
@@ -743,7 +743,7 @@ static int ufs_mtk_link_startup_notify(struct ufs_hba *hba,return ret; } -static void ufs_mtk_device_reset (struct ufs_hba *hba) +static int ufs_mtk_device_reset (struct ufs_hba *hba) {struct arm_smccc_res res;
@@ -764,6 +764,8 @@ static void ufs_mtk_device_reset(struct ufs_hba *hba)usleep_range (10000 ,15000 );dev_info (hba->dev,"device reset done\n" ); + +return 0 ; }static int ufs_mtk_link_set_hpm (struct ufs_hba *hba)
drivers/scsi/ufs/ufs-qcom.c +4 -2
@@ -1421,13 +1421,13 @@ static void ufs_qcom_dump_dbg_regs(struct ufs_hba *hba)* * Toggles the (optional) reset line to reset the attached device. */ -static void ufs_qcom_device_reset (struct ufs_hba *hba) +static int ufs_qcom_device_reset (struct ufs_hba *hba) {struct ufs_qcom_host *host =ufshcd_get_variant (hba);/* reset gpio is optional */ if (!host->device_reset) -return ; +return -EOPNOTSUPP ;/* * The UFS device shall detect reset pulses of 1us, sleep for 10us to
@@ -1438,6 +1438,8 @@ static void ufs_qcom_device_reset(struct ufs_hba *hba)gpiod_set_value_cansleep (host->device_reset,0 );usleep_range (10 ,15 ); + +return 0 ; }#if IS_ENABLED (CONFIG_DEVFREQ_GOV_SIMPLE_ONDEMAND )
drivers/scsi/ufs/ufshcd.h +7 -4
@@ -318,7 +318,7 @@ struct ufs_hba_variant_ops {int (*resume)(struct ufs_hba *,enum ufs_pm_op );void (*dbg_register_dump)(struct ufs_hba *hba);int (*phy_initialization)(struct ufs_hba *); -void (*device_reset)(struct ufs_hba *hba); +int (*device_reset)(struct ufs_hba *hba);void (*config_scaling_param)(struct ufs_hba *hba,struct devfreq_dev_profile *profile,void *data);
@@ -1181,9 +1181,12 @@ static inline void ufshcd_vops_dbg_register_dump(struct ufs_hba *hba)static inline void ufshcd_vops_device_reset (struct ufs_hba *hba) {if (hba->vops && hba->vops->device_reset) { - hba->vops->device_reset (hba); -ufshcd_set_ufs_dev_active (hba); -ufshcd_update_reg_hist (&hba->ufs_stats.dev_reset,0 ); +int err = hba->vops->device_reset (hba); + +if (!err) +ufshcd_set_ufs_dev_active (hba); +if (err != -EOPNOTSUPP ) +ufshcd_update_reg_hist (&hba->ufs_stats.dev_reset, err); } }
Signature · 1 line
2.27.0
Greg Kroah-Hartman
maintainerPATCH 12/20 scsi: ufs: Re-enable WriteBooster after device reset
In reply to Greg Kroah-HartmanFrom: Stanley Chu <[email protected]>
[ Upstream commit bd14bf0e4a084514aa62d24d2109e0f09a93822f ]
UFS 3.1 specification mentions that the WriteBooster flags listed below will be set to their default values, i.e. disabled, after power cycle or any type of reset event. Thus we need to reset the flag variables kept in struct hba to align with the device status and ensure that WriteBooster-related functions are configured properly after device reset.
Without this fix, WriteBooster will not be enabled successfully after by ufshcd_wb_ctrl() after device reset because hba->wb_enabled remains true.
Flags required to be reset to default values:
- fWriteBoosterEn: hba->wb_enabled
- fWriteBoosterBufferFlushEn: hba->wb_buf_flush_enabled
- fWriteBoosterBufferFlushDuringHibernate: No variable mapped
--- drivers/scsi/ufs/ufshcd.h | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)
drivers/scsi/ufs/ufshcd.h +6 -1
@@ -1183,8 +1183,13 @@ static inline void ufshcd_vops_device_reset(struct ufs_hba *hba)if (hba->vops && hba->vops->device_reset) {int err = hba->vops->device_reset (hba); -if (!err) +if (!err) {ufshcd_set_ufs_dev_active (hba); +if (ufshcd_is_wb_allowed (hba)) { + hba->wb_enabled = false; + hba->wb_buf_flush_enabled = false; + } + }if (err != -EOPNOTSUPP )ufshcd_update_reg_hist (&hba->ufs_stats.dev_reset, err); }
Signature · 1 line
2.27.0
Greg Kroah-Hartman
maintainerPATCH 13/20 RDMA/core: remove use of dma_virt_ops
In reply to Greg Kroah-HartmanFrom: Christoph Hellwig <[email protected]>
[ Upstream commit 5a7a9e038b032137ae9c45d5429f18a2ffdf7d42 ]
Use the ib_dma_* helpers to skip the DMA translation instead. This removes the last user if dma_virt_ops and keeps the weird layering violation inside the RDMA core instead of burderning the DMA mapping subsystems with it. This also means the software RDMA drivers now don't have to mess with DMA parameters that are not relevant to them at all, and that in the future we can use PCI P2P transfers even for software RDMA, as there is no first fake layer of DMA mapping that the P2P DMA support.
--- drivers/infiniband/core/device.c | 43 ++++++++-------- drivers/infiniband/core/rw.c | 5 +- drivers/infiniband/sw/rdmavt/Kconfig | 1 - drivers/infiniband/sw/rdmavt/mr.c | 6 +-- drivers/infiniband/sw/rdmavt/vt.c | 8 --- drivers/infiniband/sw/rxe/Kconfig | 1 - drivers/infiniband/sw/rxe/rxe_verbs.c | 7 --- drivers/infiniband/sw/rxe/rxe_verbs.h | 1 - drivers/infiniband/sw/siw/Kconfig | 1 - drivers/infiniband/sw/siw/siw.h | 1 - drivers/infiniband/sw/siw/siw_main.c | 7 --- drivers/nvme/target/rdma.c | 3 +- include/rdma/ib_verbs.h | 73 ++++++++++++++++++--------- 13 files changed, 81 insertions(+), 76 deletions(-)
drivers/infiniband/core/device.c +23 -20
@@ -1177,25 +1177,6 @@ out:return ret; } -static void setup_dma_device (struct ib_device *device, -struct device *dma_device) -{ -/* -* If the caller does not provide a DMA capable device then the IB -* device will be used. In this case the caller should fully setup the -* ibdev for DMA. This usually means using dma_virt_ops. -*/ -#ifdef CONFIG_DMA_VIRT_OPS -if (!dma_device) { - device->dev.dma_ops = &dma_virt_ops; - dma_device = &device->dev; - } -#endif -WARN_ON (!dma_device); - device->dma_device = dma_device; -WARN_ON (!device->dma_device->dma_parms); -} -/* * setup_device() allocates memory and sets up data that requires calling the * device ops, this is the only reason these actions are not done during
@@ -1341,7 +1322,14 @@ int ib_register_device(struct ib_device *device, const char *name,if (ret)return ret; -setup_dma_device (device, dma_device); +/* +* If the caller does not provide a DMA capable device then the IB core +* will set up ib_sge and scatterlist structures that stash the kernel +* virtual address into the address field. +*/ +WARN_ON (dma_device && !dma_device->dma_parms); + device->dma_device = dma_device; + ret =setup_device (device);if (ret)return ret;
@@ -2676,6 +2664,21 @@ void ib_set_device_ops(struct ib_device *dev, const struct ib_device_ops *ops) }EXPORT_SYMBOL (ib_set_device_ops); +#ifdef CONFIG_INFINIBAND_VIRT_DMA +int ib_dma_virt_map_sg (struct ib_device *dev,struct scatterlist *sg,int nents) +{ +struct scatterlist *s; +int i; + +for_each_sg (sg, s, nents, i) { +sg_dma_address (s) = (uintptr_t )sg_virt (s); +sg_dma_len (s) = s->length; + } +return nents; +} +EXPORT_SYMBOL (ib_dma_virt_map_sg); +#endif /* CONFIG_INFINIBAND_VIRT_DMA */ +static const struct rdma_nl_cbs ibnl_ls_cb_table[RDMA_NL_LS_NUM_OPS ] = { [RDMA_NL_LS_OP_RESOLVE ] = { .doit = ib_nl_handle_resolve_resp,
drivers/infiniband/core/rw.c +4 -1
@@ -285,8 +285,11 @@ static void rdma_rw_unmap_sg(struct ib_device *dev, struct scatterlist *sg,static int rdma_rw_map_sg (struct ib_device *dev,struct scatterlist *sg,u32 sg_cnt,enum dma_data_direction dir) { -if (is_pci_p2pdma_page (sg_page (sg))) +if (is_pci_p2pdma_page (sg_page (sg))) { +if (WARN_ON_ONCE (ib_uses_virt_dma (dev))) +return 0 ;return pci_p2pdma_map_sg (dev->dma_device, sg, sg_cnt, dir); + }return ib_dma_map_sg (dev, sg, sg_cnt, dir); }
drivers/infiniband/sw/rdmavt/Kconfig +0 -1
@@ -4,6 +4,5 @@ config INFINIBAND_RDMAVT depends on INFINIBAND_VIRT_DMA depends on X86_64 depends on PCI - select DMA_VIRT_OPS help This is a common software verbs provider for RDMA networks.
drivers/infiniband/sw/rdmavt/mr.c +2 -4
@@ -324,8 +324,6 @@ static void __rvt_free_mr(struct rvt_mr *mr)* @acc: access flags * * Return: the memory region on success, otherwise returns an errno. -* Note that all DMA addresses should be created via the functions in -* struct dma_virt_ops. */ struct ib_mr *rvt_get_dma_mr (struct ib_pd *pd,int acc) {
@@ -766,7 +764,7 @@ int rvt_lkey_ok(struct rvt_lkey_table *rkt, struct rvt_pd *pd,/* * We use LKEY == zero for kernel virtual addresses -* (see rvt_get_dma_mr() and dma_virt_ops). +* (see rvt_get_dma_mr()). */ if (sge->lkey ==0 ) {struct rvt_dev_info *dev =ib_to_rvt (pd->ibpd.device);
@@ -877,7 +875,7 @@ int rvt_rkey_ok(struct rvt_qp *qp, struct rvt_sge *sge,/* * We use RKEY == zero for kernel virtual addresses -* (see rvt_get_dma_mr() and dma_virt_ops). +* (see rvt_get_dma_mr()). */ rcu_read_lock ();if (rkey ==0 ) {
drivers/infiniband/sw/rdmavt/vt.c +0 -8
@@ -524,7 +524,6 @@ static noinline int check_support(struct rvt_dev_info *rdi, int verb)int rvt_register_device (struct rvt_dev_info *rdi) {int ret =0 , i; -u64 dma_mask;if (!rdi)return -EINVAL ;
@@ -579,13 +578,6 @@ int rvt_register_device(struct rvt_dev_info *rdi)/* Completion queues */ spin_lock_init (&rdi->n_cqs_lock); -/* DMA Operations */ - rdi->ibdev.dev.dma_parms = rdi->ibdev.dev.parent->dma_parms; - dma_mask =IS_ENABLED (CONFIG_64BIT ) ?DMA_BIT_MASK (64 ) :DMA_BIT_MASK (32 ); - ret =dma_coerce_mask_and_coherent (&rdi->ibdev.dev, dma_mask); -if (ret) - goto bail_wss; -/* Protection Domain */ spin_lock_init (&rdi->n_pds_lock); rdi->n_pds_allocated =0 ;
drivers/infiniband/sw/rxe/Kconfig +0 -1
@@ -5,7 +5,6 @@ config RDMA_RXE depends on INFINIBAND_VIRT_DMA select NET_UDP_TUNNEL select CRYPTO_CRC32 - select DMA_VIRT_OPS help This driver implements the InfiniBand RDMA transport over the Linux network stack. It enables a system with a
drivers/infiniband/sw/rxe/rxe_verbs.c +0 -7
@@ -1118,7 +1118,6 @@ int rxe_register_device(struct rxe_dev *rxe, const char *ibdev_name)int err;struct ib_device *dev = &rxe->ib_dev;struct crypto_shash *tfm; -u64 dma_mask;strlcpy (dev->node_desc,"rxe" ,sizeof (dev->node_desc));
@@ -1129,12 +1128,6 @@ int rxe_register_device(struct rxe_dev *rxe, const char *ibdev_name) dev->local_dma_lkey =0 ;addrconf_addr_eui48 ((unsigned char *)&dev->node_guid, rxe->ndev->dev_addr); - dev->dev.dma_parms = &rxe->dma_parms; -dma_set_max_seg_size (&dev->dev,UINT_MAX ); - dma_mask =IS_ENABLED (CONFIG_64BIT ) ?DMA_BIT_MASK (64 ) :DMA_BIT_MASK (32 ); - err =dma_coerce_mask_and_coherent (&dev->dev, dma_mask); -if (err) -return err; dev->uverbs_cmd_mask =BIT_ULL (IB_USER_VERBS_CMD_GET_CONTEXT ) |BIT_ULL (IB_USER_VERBS_CMD_CREATE_COMP_CHANNEL )
drivers/infiniband/sw/rxe/rxe_verbs.h +0 -1
@@ -352,7 +352,6 @@ struct rxe_port {struct rxe_dev {struct ib_device ib_dev;struct ib_device_attr attr; -struct device_dma_parameters dma_parms;int max_ucontext;int max_inline_data;struct mutex usdev_lock;
drivers/infiniband/sw/siw/Kconfig +0 -1
@@ -2,7 +2,6 @@ config RDMA_SIW tristate "Software RDMA over TCP/IP (iWARP) driver" depends on INET && INFINIBAND && LIBCRC32C depends on INFINIBAND_VIRT_DMA - select DMA_VIRT_OPS help This driver implements the iWARP RDMA transport over the Linux TCP/IP network stack. It enables a system with a
drivers/infiniband/sw/siw/siw.h +0 -1
@@ -69,7 +69,6 @@ struct siw_pd {struct siw_device {struct ib_device base_dev; -struct device_dma_parameters dma_parms;struct net_device *netdev;struct siw_dev_cap attrs;
drivers/infiniband/sw/siw/siw_main.c +0 -7
@@ -306,7 +306,6 @@ static struct siw_device *siw_device_create(struct net_device *netdev)struct siw_device *sdev =NULL ;struct ib_device *base_dev;struct device *parent = netdev->dev.parent; -u64 dma_mask;int rv;if (!parent) {
@@ -383,12 +382,6 @@ static struct siw_device *siw_device_create(struct net_device *netdev)*/ base_dev->phys_port_cnt =1 ; base_dev->dev.parent = parent; - base_dev->dev.dma_parms = &sdev->dma_parms; -dma_set_max_seg_size (&base_dev->dev,UINT_MAX ); - dma_mask =IS_ENABLED (CONFIG_64BIT ) ?DMA_BIT_MASK (64 ) :DMA_BIT_MASK (32 ); -if (dma_coerce_mask_and_coherent (&base_dev->dev, dma_mask)) - goto error; - base_dev->num_comp_vectors =num_possible_cpus ();xa_init_flags (&sdev->qp_xa,XA_FLAGS_ALLOC1 );
drivers/nvme/target/rdma.c +2 -1
@@ -414,7 +414,8 @@ static int nvmet_rdma_alloc_rsp(struct nvmet_rdma_device *ndev,if (ib_dma_mapping_error (ndev->device, r->send_sge.addr)) goto out_free_rsp; - r->req.p2p_client = &ndev->device->dev; +if (!ib_uses_virt_dma (ndev->device)) + r->req.p2p_client = &ndev->device->dev; r->send_sge.length =sizeof (*r->req.cqe); r->send_sge.lkey = ndev->pd->local_dma_lkey;
include/rdma/ib_verbs.h +50 -23
139 lines not on this page · raw message
Signature · 1 line
2.27.0
Greg Kroah-Hartman
maintainerPATCH 14/20 RDMA/siw,rxe: Make emulated devices virtual in the device tree
In reply to Greg Kroah-HartmanFrom: Jason Gunthorpe <[email protected]>
[ Upstream commit a9d2e9ae953f0ddd0327479c81a085adaa76d903 ]
This moves siw and rxe to be virtual devices in the device tree:
lrwxrwxrwx 1 root root 0 Nov 6 13:55 /sys/class/infiniband/rxe0 -> ../../devices/virtual/infiniband/rxe0/
Previously they were trying to parent themselves to the physical device of their attached netdev, which doesn't make alot of sense.
My hope is this will solve some weird syzkaller hits related to sysfs as it could be possible that the parent of a netdev is another netdev, eg under bonding or some other syzkaller found netdev configuration.
Nesting a ib_device under anything but a physical device is going to cause inconsistencies in sysfs during destructions.
--- drivers/infiniband/sw/rxe/rxe_net.c | 12 ------------ drivers/infiniband/sw/rxe/rxe_verbs.c | 1 - drivers/infiniband/sw/siw/siw_main.c | 19 +------------------ 3 files changed, 1 insertion(+), 31 deletions(-)
drivers/infiniband/sw/rxe/rxe_net.c +0 -12
@@ -20,18 +20,6 @@static struct rxe_recv_sockets recv_sockets; -struct device *rxe_dma_device (struct rxe_dev *rxe) -{ -struct net_device *ndev; - - ndev = rxe->ndev; - -if (is_vlan_dev (ndev)) - ndev =vlan_dev_real_dev (ndev); - -return ndev->dev.parent; -} -int rxe_mcast_add (struct rxe_dev *rxe,union ib_gid *mgid) {int err;
drivers/infiniband/sw/rxe/rxe_verbs.c +0 -1
@@ -1124,7 +1124,6 @@ int rxe_register_device(struct rxe_dev *rxe, const char *ibdev_name) dev->node_type =RDMA_NODE_IB_CA ; dev->phys_port_cnt =1 ; dev->num_comp_vectors =num_possible_cpus (); - dev->dev.parent =rxe_dma_device (rxe); dev->local_dma_lkey =0 ;addrconf_addr_eui48 ((unsigned char *)&dev->node_guid, rxe->ndev->dev_addr);
drivers/infiniband/sw/siw/siw_main.c +1 -18
@@ -305,24 +305,8 @@ static struct siw_device *siw_device_create(struct net_device *netdev) {struct siw_device *sdev =NULL ;struct ib_device *base_dev; -struct device *parent = netdev->dev.parent;int rv; -if (!parent) { -/* -* The loopback device has no parent device, -* so it appears as a top-level device. To support -* loopback device connectivity, take this device -* as the parent device. Skip all other devices -* w/o parent device. -*/ -if (netdev->type !=ARPHRD_LOOPBACK ) { -pr_warn ("siw: device %s error: no parent device\n" , - netdev->name); -return NULL ; - } - parent = &netdev->dev; - } sdev =ib_alloc_device (siw_device, base_dev);if (!sdev)return NULL ;
@@ -381,7 +365,6 @@ static struct siw_device *siw_device_create(struct net_device *netdev)* per physical port. */ base_dev->phys_port_cnt =1 ; - base_dev->dev.parent = parent; base_dev->num_comp_vectors =num_possible_cpus ();xa_init_flags (&sdev->qp_xa,XA_FLAGS_ALLOC1 );
@@ -423,7 +406,7 @@ static struct siw_device *siw_device_create(struct net_device *netdev)atomic_set (&sdev->num_mr,0 );atomic_set (&sdev->num_pd,0 ); - sdev->numa_node =dev_to_node (parent); + sdev->numa_node =dev_to_node (&netdev->dev);spin_lock_init (&sdev->lock);return sdev;
Signature · 1 line
2.27.0
Greg Kroah-Hartman
maintainerPATCH 15/20 fuse: fix bad inode
In reply to Greg Kroah-HartmanFrom: Miklos Szeredi <[email protected]>
[ Upstream commit 5d069dbe8aaf2a197142558b6fb2978189ba3454 ]
Jan Kara's analysis of the syzbot report (edited):
The reproducer opens a directory on FUSE filesystem, it then attaches dnotify mark to the open directory. After that a fuse_do_getattr() call finds that attributes returned by the server are inconsistent, and calls make_bad_inode() which, among other things does:
inode->i_mode = S_IFREG;
This then confuses dnotify which doesn't tear down its structures properly and eventually crashes.
Avoid calling make_bad_inode() on a live inode: switch to a private flag on the fuse inode. Also add the test to ops which the bad_inode_ops would have caught.
This bug goes back to the initial merge of fuse in 2.6.14...
--- fs/fuse/acl.c | 6 ++++++ fs/fuse/dir.c | 37 ++++++++++++++++++++++++++++++++----- fs/fuse/file.c | 19 +++++++++++-------- fs/fuse/fuse_i.h | 12 ++++++++++++ fs/fuse/inode.c | 4 ++-- fs/fuse/readdir.c | 4 ++-- fs/fuse/xattr.c | 9 +++++++++ 7 files changed, 74 insertions(+), 17 deletions(-)
fs/fuse/acl.c +6 -0
@@ -19,6 +19,9 @@ struct posix_acl *fuse_get_acl(struct inode *inode, int type)void *value =NULL ;struct posix_acl *acl; +if (fuse_is_bad (inode)) +return ERR_PTR (-EIO ); +if (!fc->posix_acl || fc->no_getxattr)return NULL ;
@@ -53,6 +56,9 @@ int fuse_set_acl(struct inode *inode, struct posix_acl *acl, int type)const char *name;int ret; +if (fuse_is_bad (inode)) +return -EIO ; +if (!fc->posix_acl || fc->no_setxattr)return -EOPNOTSUPP ;
fs/fuse/dir.c +32 -5
@@ -202,7 +202,7 @@ static int fuse_dentry_revalidate(struct dentry *entry, unsigned int flags)int ret; inode =d_inode_rcu (entry); -if (inode &&is_bad_inode (inode)) +if (inode &&fuse_is_bad (inode)) goto invalid;else if (time_before64 (fuse_dentry_time (entry),get_jiffies_64 ()) || (flags &LOOKUP_REVAL )) {
@@ -463,6 +463,9 @@ static struct dentry *fuse_lookup(struct inode *dir, struct dentry *entry,bool outarg_valid = true;bool locked; +if (fuse_is_bad (dir)) +return ERR_PTR (-EIO ); + locked =fuse_lock_inode (dir); err =fuse_lookup_name (dir->i_sb,get_node_id (dir), &entry->d_name, &outarg, &inode);
@@ -606,6 +609,9 @@ static int fuse_atomic_open(struct inode *dir, struct dentry *entry,struct fuse_conn *fc =get_fuse_conn (dir);struct dentry *res =NULL ; +if (fuse_is_bad (dir)) +return -EIO ; +if (d_in_lookup (entry)) { res =fuse_lookup (dir, entry,0 );if (IS_ERR (res))
@@ -654,6 +660,9 @@ static int create_new_entry(struct fuse_mount *fm, struct fuse_args *args,int err;struct fuse_forget_link *forget; +if (fuse_is_bad (dir)) +return -EIO ; + forget =fuse_alloc_forget ();if (!forget)return -ENOMEM ;
@@ -781,6 +790,9 @@ static int fuse_unlink(struct inode *dir, struct dentry *entry)struct fuse_mount *fm =get_fuse_mount (dir);FUSE_ARGS (args); +if (fuse_is_bad (dir)) +return -EIO ; + args.opcode =FUSE_UNLINK ; args.nodeid =get_node_id (dir); args.in_numargs =1 ;
@@ -817,6 +829,9 @@ static int fuse_rmdir(struct inode *dir, struct dentry *entry)struct fuse_mount *fm =get_fuse_mount (dir);FUSE_ARGS (args); +if (fuse_is_bad (dir)) +return -EIO ; + args.opcode =FUSE_RMDIR ; args.nodeid =get_node_id (dir); args.in_numargs =1 ;
@@ -895,6 +910,9 @@ static int fuse_rename2(struct inode *olddir, struct dentry *oldent,struct fuse_conn *fc =get_fuse_conn (olddir);int err; +if (fuse_is_bad (olddir)) +return -EIO ; +if (flags & ~(RENAME_NOREPLACE |RENAME_EXCHANGE |RENAME_WHITEOUT ))return -EINVAL ;
@@ -1030,7 +1048,7 @@ static int fuse_do_getattr(struct inode *inode, struct kstat *stat,if (!err) {if (fuse_invalid_attr (&outarg.attr) || (inode->i_mode ^ outarg.attr.mode) &S_IFMT ) { -make_bad_inode (inode); +fuse_make_bad (inode); err = -EIO ; }else { fuse_change_attributes(inode, &outarg.attr,
@@ -1232,6 +1250,9 @@ static int fuse_permission(struct inode *inode, int mask)bool refreshed = false;int err =0 ; +if (fuse_is_bad (inode)) +return -EIO ; +if (!fuse_allow_current_process (fc))return -EACCES ;
@@ -1327,7 +1348,7 @@ static const char *fuse_get_link(struct dentry *dentry, struct inode *inode,int err; err = -EIO ; -if (is_bad_inode (inode)) +if (fuse_is_bad (inode)) goto out_err;if (fc->cache_symlinks)
@@ -1375,7 +1396,7 @@ static int fuse_dir_fsync(struct file *file, loff_t start, loff_t end,struct fuse_conn *fc =get_fuse_conn (inode);int err; -if (is_bad_inode (inode)) +if (fuse_is_bad (inode))return -EIO ;if (fc->no_fsyncdir)
@@ -1664,7 +1685,7 @@ int fuse_do_setattr(struct dentry *dentry, struct iattr *attr,if (fuse_invalid_attr (&outarg.attr) || (inode->i_mode ^ outarg.attr.mode) &S_IFMT ) { -make_bad_inode (inode); +fuse_make_bad (inode); err = -EIO ; goto error; }
@@ -1727,6 +1748,9 @@ static int fuse_setattr(struct dentry *entry, struct iattr *attr)struct file *file = (attr->ia_valid &ATTR_FILE ) ? attr->ia_file :NULL ;int ret; +if (fuse_is_bad (inode)) +return -EIO ; +if (!fuse_allow_current_process (get_fuse_conn (inode)))return -EACCES ;
@@ -1785,6 +1809,9 @@ static int fuse_getattr(const struct path *path, struct kstat *stat,struct inode *inode =d_inode (path->dentry);struct fuse_conn *fc =get_fuse_conn (inode); +if (fuse_is_bad (inode)) +return -EIO ; +if (!fuse_allow_current_process (fc)) {if (!request_mask) {/*
fs/fuse/file.c +11 -8
@@ -226,6 +226,9 @@ int fuse_open_common(struct inode *inode, struct file *file, bool isdir)bool dax_truncate = (file->f_flags &O_TRUNC ) && fc->atomic_o_trunc &&FUSE_IS_DAX (inode); +if (fuse_is_bad (inode)) +return -EIO ; + err =generic_file_open (inode, file);if (err)return err;
@@ -463,7 +466,7 @@ static int fuse_flush(struct file *file, fl_owner_t id)FUSE_ARGS (args);int err; -if (is_bad_inode (inode)) +if (fuse_is_bad (inode))return -EIO ; err =write_inode_now (inode,1 );
@@ -535,7 +538,7 @@ static int fuse_fsync(struct file *file, loff_t start, loff_t end,struct fuse_conn *fc =get_fuse_conn (inode);int err; -if (is_bad_inode (inode)) +if (fuse_is_bad (inode))return -EIO ;inode_lock (inode);
@@ -859,7 +862,7 @@ static int fuse_readpage(struct file *file, struct page *page)int err; err = -EIO ; -if (is_bad_inode (inode)) +if (fuse_is_bad (inode)) goto out; err =fuse_do_readpage (file, page);
@@ -952,7 +955,7 @@ static void fuse_readahead(struct readahead_control *rac)struct fuse_conn *fc =get_fuse_conn (inode);unsigned int i, max_pages, nr_pages =0 ; -if (is_bad_inode (inode)) +if (fuse_is_bad (inode))return ; max_pages = min_t(unsigned int, fc->max_pages,
@@ -1555,7 +1558,7 @@ static ssize_t fuse_file_read_iter(struct kiocb *iocb, struct iov_iter *to)struct fuse_file *ff = file->private_data;struct inode *inode =file_inode (file); -if (is_bad_inode (inode)) +if (fuse_is_bad (inode))return -EIO ;if (FUSE_IS_DAX (inode))
@@ -1573,7 +1576,7 @@ static ssize_t fuse_file_write_iter(struct kiocb *iocb, struct iov_iter *from)struct fuse_file *ff = file->private_data;struct inode *inode =file_inode (file); -if (is_bad_inode (inode)) +if (fuse_is_bad (inode))return -EIO ;if (FUSE_IS_DAX (inode))
@@ -2172,7 +2175,7 @@ static int fuse_writepages(struct address_space *mapping,int err; err = -EIO ; -if (is_bad_inode (inode)) +if (fuse_is_bad (inode)) goto out; data.inode = inode;
@@ -2954,7 +2957,7 @@ long fuse_ioctl_common(struct file *file, unsigned int cmd,if (!fuse_allow_current_process (fc))return -EACCES ; -if (is_bad_inode (inode)) +if (fuse_is_bad (inode))return -EIO ;return fuse_do_ioctl (file, cmd, arg, flags);
fs/fuse/fuse_i.h +12 -0
@@ -172,6 +172,8 @@ enum {FUSE_I_INIT_RDPLUS ,/** An operation changing file size is in progress */ FUSE_I_SIZE_UNSTABLE , +/* Bad inode */ + FUSE_I_BAD, };struct fuse_conn ;
@@ -858,6 +860,16 @@ static inline u64 fuse_get_attr_version(struct fuse_conn *fc)return atomic64_read (&fc->attr_version); } +static inline void fuse_make_bad (struct inode *inode) +{ +set_bit (FUSE_I_BAD , &get_fuse_inode (inode)->state); +} + +static inline bool fuse_is_bad (struct inode *inode) +{ +return unlikely (test_bit (FUSE_I_BAD , &get_fuse_inode (inode)->state)); +} +/** Device operations */ extern const struct file_operations fuse_dev_operations;
fs/fuse/inode.c +2 -2
@@ -132,7 +132,7 @@ static void fuse_evict_inode(struct inode *inode) fi->forget =NULL ; } } -if (S_ISREG (inode->i_mode) && !is_bad_inode (inode)) { +if (S_ISREG (inode->i_mode) && !fuse_is_bad (inode)) {WARN_ON (!list_empty (&fi->write_files));WARN_ON (!list_empty (&fi->queued_writes)); }
@@ -342,7 +342,7 @@ retry:unlock_new_inode (inode); }else if ((inode->i_mode ^ attr->mode) &S_IFMT ) {/* Inode has changed type, any I/O on the old should fail */ -make_bad_inode (inode); +fuse_make_bad (inode);iput (inode); goto retry; }
fs/fuse/readdir.c +2 -2
@@ -207,7 +207,7 @@ retry:dput (dentry); goto retry; } -if (is_bad_inode (inode)) { +if (fuse_is_bad (inode)) {dput (dentry);return -EIO ; }
@@ -568,7 +568,7 @@ int fuse_readdir(struct file *file, struct dir_context *ctx)struct inode *inode =file_inode (file);int err; -if (is_bad_inode (inode)) +if (fuse_is_bad (inode))return -EIO ;mutex_lock (&ff->readdir.lock);
fs/fuse/xattr.c +9 -0
@@ -113,6 +113,9 @@ ssize_t fuse_listxattr(struct dentry *entry, char *list, size_t size)struct fuse_getxattr_out outarg;ssize_t ret; +if (fuse_is_bad (inode)) +return -EIO ; +if (!fuse_allow_current_process (fm->fc))return -EACCES ;
@@ -178,6 +181,9 @@ static int fuse_xattr_get(const struct xattr_handler *handler, struct dentry *dentry, struct inode *inode, const char *name, void *value, size_t size) { + if (fuse_is_bad(inode)) + return -EIO; +return fuse_getxattr (inode, name, value, size); }
@@ -186,6 +192,9 @@ static int fuse_xattr_set(const struct xattr_handler *handler, const char *name, const void *value, size_t size, int flags) { + if (fuse_is_bad(inode)) + return -EIO; +if (!value)return fuse_removexattr (inode, name);
Signature · 1 line
2.27.0
Greg Kroah-Hartman
maintainerPATCH 16/20 perf: Break deadlock involving exec_update_mutex
In reply to Greg Kroah-HartmanFrom: [email protected] <[email protected]>
[ Upstream commit 78af4dc949daaa37b3fcd5f348f373085b4e858f ]
Syzbot reported a lock inversion involving perf. The sore point being perf holding exec_update_mutex() for a very long time, specifically across a whole bunch of filesystem ops in pmu::event_init() (uprobes) and anon_inode_getfile().
This then inverts against procfs code trying to take exec_update_mutex.
Move the permission checks later, such that we need to hold the mutex over less code.
--- kernel/events/core.c | 46 ++++++++++++++++++++++---------------------- 1 file changed, 23 insertions(+), 23 deletions(-)
kernel/events/core.c +23 -23
@@ -11720,24 +11720,6 @@ SYSCALL_DEFINE5(perf_event_open, goto err_task; } -if (task) { - err =mutex_lock_interruptible (&task->signal->exec_update_mutex); -if (err) - goto err_task; - -/* -* Preserve ptrace permission check for backwards compatibility. -* -* We must hold exec_update_mutex across this and any potential -* perf_install_in_context() call for this new event to -* serialize against exec() altering our credentials (and the -* perf_event_exit_task() that could imply). -*/ - err = -EACCES ; -if (!perfmon_capable () && !ptrace_may_access (task,PTRACE_MODE_READ_REALCREDS )) - goto err_cred; - } -if (flags &PERF_FLAG_PID_CGROUP ) cgroup_fd = pid;
@@ -11745,7 +11727,7 @@ SYSCALL_DEFINE5(perf_event_open, NULL, NULL, cgroup_fd);if (IS_ERR (event)) { err =PTR_ERR (event); - goto err_cred; + goto err_task; }if (is_sampling_event (event)) {
@@ -11864,6 +11846,24 @@ SYSCALL_DEFINE5(perf_event_open, goto err_context; } +if (task) { + err =mutex_lock_interruptible (&task->signal->exec_update_mutex); +if (err) + goto err_file; + +/* +* Preserve ptrace permission check for backwards compatibility. +* +* We must hold exec_update_mutex across this and any potential +* perf_install_in_context() call for this new event to +* serialize against exec() altering our credentials (and the +* perf_event_exit_task() that could imply). +*/ + err = -EACCES ; +if (!perfmon_capable () && !ptrace_may_access (task,PTRACE_MODE_READ_REALCREDS )) + goto err_cred; + } +if (move_group) { gctx =__perf_event_ctx_lock_double (group_leader, ctx);
@@ -12039,7 +12039,10 @@ err_locked:if (move_group)perf_event_ctx_unlock (group_leader, gctx);mutex_unlock (&ctx->mutex); -/* err_file: */ +err_cred: +if (task) +mutex_unlock (&task->signal->exec_update_mutex); +err_file:fput (event_file); err_context:perf_unpin_context (ctx);
@@ -12051,9 +12054,6 @@ err_alloc:*/ if (!event_file)free_event (event); -err_cred: -if (task) -mutex_unlock (&task->signal->exec_update_mutex); err_task:if (task)put_task_struct (task);
Signature · 1 line
2.27.0
Greg Kroah-Hartman
maintainerPATCH 17/20 rwsem: Implement down_read_killable_nested
In reply to Greg Kroah-HartmanFrom: Eric W. Biederman <[email protected]>
[ Upstream commit 0f9368b5bf6db0c04afc5454b1be79022a681615 ]
In preparation for converting exec_update_mutex to a rwsem so that multiple readers can execute in parallel and not deadlock, add down_read_killable_nested. This is needed so that kcmp_lock can be converted from working on a mutexes to working on rw_semaphores.
--- include/linux/rwsem.h | 2 ++ kernel/locking/rwsem.c | 14 ++++++++++++++ 2 files changed, 16 insertions(+)
include/linux/rwsem.h +2 -0
@@ -171,6 +171,7 @@ extern void downgrade_write(struct rw_semaphore *sem);* See Documentation/locking/lockdep-design.rst for more details.) */ extern void down_read_nested (struct rw_semaphore *sem,int subclass); +extern int __must_check down_read_killable_nested (struct rw_semaphore *sem,int subclass);extern void down_write_nested (struct rw_semaphore *sem,int subclass);extern int down_write_killable_nested (struct rw_semaphore *sem,int subclass);extern void _down_write_nest_lock (struct rw_semaphore *sem,struct lockdep_map *nest_lock);
@@ -191,6 +192,7 @@ extern void down_read_non_owner(struct rw_semaphore *sem);extern void up_read_non_owner (struct rw_semaphore *sem);#else # define down_read_nested (sem, subclass) down_read(sem) +# define down_read_killable_nested (sem, subclass) down_read_killable(sem)# define down_write_nest_lock (sem, nest_lock) down_write(sem)# define down_write_nested (sem, subclass) down_write(sem)# define down_write_killable_nested (sem, subclass) down_write_killable(sem)
kernel/locking/rwsem.c +14 -0
@@ -1605,6 +1605,20 @@ void down_read_nested(struct rw_semaphore *sem, int subclass) }EXPORT_SYMBOL (down_read_nested); +int down_read_killable_nested (struct rw_semaphore *sem,int subclass) +{ +might_sleep (); +rwsem_acquire_read (&sem->dep_map, subclass,0 , _RET_IP_); + +if (LOCK_CONTENDED_RETURN (sem, __down_read_trylock, __down_read_killable)) { +rwsem_release (&sem->dep_map, _RET_IP_); +return -EINTR ; + } + +return 0 ; +} +EXPORT_SYMBOL (down_read_killable_nested); +void _down_write_nest_lock (struct rw_semaphore *sem,struct lockdep_map *nest) {might_sleep ();
Signature · 1 line
2.27.0
Greg Kroah-Hartman
maintainerPATCH 18/20 rwsem: Implement down_read_interruptible
In reply to Greg Kroah-HartmanFrom: Eric W. Biederman <[email protected]>
[ Upstream commit 31784cff7ee073b34d6eddabb95e3be2880a425c ]
In preparation for converting exec_update_mutex to a rwsem so that multiple readers can execute in parallel and not deadlock, add down_read_interruptible. This is needed for perf_event_open to be converted (with no semantic changes) from working on a mutex to wroking on a rwsem.
--- include/linux/rwsem.h | 1 + kernel/locking/rwsem.c | 26 ++++++++++++++++++++++++++ 2 files changed, 27 insertions(+)
include/linux/rwsem.h +1 -0
@@ -123,6 +123,7 @@ static inline int rwsem_is_contended(struct rw_semaphore *sem)* lock for reading */ extern void down_read (struct rw_semaphore *sem); +extern int __must_check down_read_interruptible (struct rw_semaphore *sem);extern int __must_check down_read_killable (struct rw_semaphore *sem);/*
kernel/locking/rwsem.c +26 -0
@@ -1345,6 +1345,18 @@ static inline void __down_read(struct rw_semaphore *sem) } } +static inline int __down_read_interruptible (struct rw_semaphore *sem) +{ +if (!rwsem_read_trylock (sem)) { +if (IS_ERR (rwsem_down_read_slowpath (sem,TASK_INTERRUPTIBLE ))) +return -EINTR ; +DEBUG_RWSEMS_WARN_ON (!is_rwsem_reader_owned (sem), sem); + }else { +rwsem_set_reader_owned (sem); + } +return 0 ; +} +static inline int __down_read_killable (struct rw_semaphore *sem) {if (!rwsem_read_trylock (sem)) {
@@ -1495,6 +1507,20 @@ void __sched down_read(struct rw_semaphore *sem) }EXPORT_SYMBOL (down_read); +int __sched down_read_interruptible(struct rw_semaphore *sem) +{ +might_sleep (); +rwsem_acquire_read (&sem->dep_map,0 ,0 , _RET_IP_); + +if (LOCK_CONTENDED_RETURN (sem, __down_read_trylock, __down_read_interruptible)) { +rwsem_release (&sem->dep_map, _RET_IP_); +return -EINTR ; + } + +return 0 ; +} +EXPORT_SYMBOL (down_read_interruptible); + int __sched down_read_killable(struct rw_semaphore *sem) {might_sleep ();
Signature · 1 line
2.27.0
Greg Kroah-Hartman
maintainerPATCH 19/20 exec: Transform exec_update_mutex into a rw_semaphore
In reply to Greg Kroah-HartmanFrom: Eric W. Biederman <[email protected]>
[ Upstream commit f7cfd871ae0c5008d94b6f66834e7845caa93c15 ]
Recently syzbot reported[0] that there is a deadlock amongst the users of exec_update_mutex. The problematic lock ordering found by lockdep was:
perf_event_open (exec_update_mutex -> ovl_i_mutex) chown (ovl_i_mutex -> sb_writes) sendfile (sb_writes -> p->lock)
by reading from a proc file and writing to overlayfs
proc_pid_syscall (p->lock -> exec_update_mutex)
While looking at possible solutions it occured to me that all of the users and possible users involved only wanted to state of the given process to remain the same. They are all readers. The only writer is exec.
There is no reason for readers to block on each other. So fix this deadlock by transforming exec_update_mutex into a rw_semaphore named exec_update_lock that only exec takes for writing.
[0] https://lkml.kernel.org/r/[email protected]
--- fs/exec.c | 12 ++++++------ fs/proc/base.c | 10 +++++----- include/linux/sched/signal.h | 11 ++++++----- init/init_task.c | 2 +- kernel/events/core.c | 12 ++++++------ kernel/fork.c | 6 +++--- kernel/kcmp.c | 30 +++++++++++++++--------------- kernel/pid.c | 4 ++-- 8 files changed, 44 insertions(+), 43 deletions(-)
fs/exec.c +6 -6
@@ -965,8 +965,8 @@ EXPORT_SYMBOL(read_code);/* * Maps the mm_struct mm into the current task struct. -* On success, this function returns with the mutex -* exec_update_mutex locked. +* On success, this function returns with exec_update_lock +* held for writing. */ static int exec_mmap (struct mm_struct *mm) {
@@ -981,7 +981,7 @@ static int exec_mmap(struct mm_struct *mm)if (old_mm)sync_mm_rss (old_mm); - ret =mutex_lock_killable (&tsk->signal->exec_update_mutex); + ret =down_write_killable (&tsk->signal->exec_update_lock);if (ret)return ret;
@@ -995,7 +995,7 @@ static int exec_mmap(struct mm_struct *mm)mmap_read_lock (old_mm);if (unlikely (old_mm->core_state)) {mmap_read_unlock (old_mm); -mutex_unlock (&tsk->signal->exec_update_mutex); +up_write (&tsk->signal->exec_update_lock);return -EINTR ; } }
@@ -1382,7 +1382,7 @@ int begin_new_exec(struct linux_binprm * bprm)return 0 ; out_unlock: -mutex_unlock (&me->signal->exec_update_mutex); +up_write (&me->signal->exec_update_lock); out:return retval; }
@@ -1423,7 +1423,7 @@ void setup_new_exec(struct linux_binprm * bprm)* some architectures like powerpc */ me->mm->task_size =TASK_SIZE ; -mutex_unlock (&me->signal->exec_update_mutex); +up_write (&me->signal->exec_update_lock);mutex_unlock (&me->signal->cred_guard_mutex); }EXPORT_SYMBOL (setup_new_exec);
fs/proc/base.c +5 -5
@@ -405,11 +405,11 @@ print0:static int lock_trace (struct task_struct *task) { -int err =mutex_lock_killable (&task->signal->exec_update_mutex); +int err =down_read_killable (&task->signal->exec_update_lock);if (err)return err;if (!ptrace_may_access (task,PTRACE_MODE_ATTACH_FSCREDS )) { -mutex_unlock (&task->signal->exec_update_mutex); +up_read (&task->signal->exec_update_lock);return -EPERM ; }return 0 ;
@@ -417,7 +417,7 @@ static int lock_trace(struct task_struct *task)static void unlock_trace (struct task_struct *task) { -mutex_unlock (&task->signal->exec_update_mutex); +up_read (&task->signal->exec_update_lock); }#ifdef CONFIG_STACKTRACE
@@ -2930,7 +2930,7 @@ static int do_io_accounting(struct task_struct *task, struct seq_file *m, int whunsigned long flags;int result; - result =mutex_lock_killable (&task->signal->exec_update_mutex); + result =down_read_killable (&task->signal->exec_update_lock);if (result)return result;
@@ -2966,7 +2966,7 @@ static int do_io_accounting(struct task_struct *task, struct seq_file *m, int wh result =0 ; out_unlock: -mutex_unlock (&task->signal->exec_update_mutex); +up_read (&task->signal->exec_update_lock);return result; }
include/linux/sched/signal.h +6 -5
@@ -228,12 +228,13 @@ struct signal_struct {* credential calculations * (notably. ptrace) * Deprecated do not use in new code. -* Use exec_update_mutex instead. -*/ -struct mutex exec_update_mutex;/* Held while task_struct is being -* updated during exec, and may have -* inconsistent permissions. +* Use exec_update_lock instead. */ +struct rw_semaphore exec_update_lock;/* Held while task_struct is +* being updated during exec, +* and may have inconsistent +* permissions. +*/ } __randomize_layout;/*
init/init_task.c +1 -1
@@ -26,7 +26,7 @@ static struct signal_struct init_signals = { .multiprocess = HLIST_HEAD_INIT, .rlim = INIT_RLIMITS, .cred_guard_mutex = __MUTEX_INITIALIZER(init_signals.cred_guard_mutex), - .exec_update_mutex =__MUTEX_INITIALIZER (init_signals.exec_update_mutex), + .exec_update_lock =__RWSEM_INITIALIZER (init_signals.exec_update_lock), #ifdef CONFIG_POSIX_TIMERS .posix_timers =LIST_HEAD_INIT (init_signals.posix_timers), .cputimer = {
kernel/events/core.c +6 -6
@@ -1325,7 +1325,7 @@ static void put_ctx(struct perf_event_context *ctx)* function. * * Lock order: -* exec_update_mutex +* exec_update_lock * task_struct::perf_event_mutex * perf_event_context::mutex * perf_event::child_mutex;
@@ -11847,14 +11847,14 @@ SYSCALL_DEFINE5(perf_event_open, }if (task) { - err =mutex_lock_interruptible (&task->signal->exec_update_mutex); + err =down_read_interruptible (&task->signal->exec_update_lock);if (err) goto err_file;/* * Preserve ptrace permission check for backwards compatibility. * -* We must hold exec_update_mutex across this and any potential +* We must hold exec_update_lock across this and any potential * perf_install_in_context() call for this new event to * serialize against exec() altering our credentials (and the * perf_event_exit_task() that could imply).
@@ -12017,7 +12017,7 @@ SYSCALL_DEFINE5(perf_event_open,mutex_unlock (&ctx->mutex);if (task) { -mutex_unlock (&task->signal->exec_update_mutex); +up_read (&task->signal->exec_update_lock);put_task_struct (task); }
@@ -12041,7 +12041,7 @@ err_locked:mutex_unlock (&ctx->mutex); err_cred:if (task) -mutex_unlock (&task->signal->exec_update_mutex); +up_read (&task->signal->exec_update_lock); err_file:fput (event_file); err_context:
@@ -12358,7 +12358,7 @@ static void perf_event_exit_task_context(struct task_struct *child, int ctxn)/* * When a child task exits, feed back event values to parent events. * -* Can be called with exec_update_mutex held when called from +* Can be called with exec_update_lock held when called from * setup_new_exec(). */ void perf_event_exit_task (struct task_struct *child)
kernel/fork.c +3 -3
@@ -1222,7 +1222,7 @@ struct mm_struct *mm_access(struct task_struct *task, unsigned int mode)struct mm_struct *mm;int err; - err =mutex_lock_killable (&task->signal->exec_update_mutex); + err =down_read_killable (&task->signal->exec_update_lock);if (err)return ERR_PTR (err);
@@ -1232,7 +1232,7 @@ struct mm_struct *mm_access(struct task_struct *task, unsigned int mode)mmput (mm); mm =ERR_PTR (-EACCES ); } -mutex_unlock (&task->signal->exec_update_mutex); +up_read (&task->signal->exec_update_lock);return mm; }
@@ -1592,7 +1592,7 @@ static int copy_signal(unsigned long clone_flags, struct task_struct *tsk) sig->oom_score_adj_min = current->signal->oom_score_adj_min;mutex_init (&sig->cred_guard_mutex); -mutex_init (&sig->exec_update_mutex); +init_rwsem (&sig->exec_update_lock);return 0 ; }
kernel/kcmp.c +15 -15
@@ -75,25 +75,25 @@ get_file_raw_ptr(struct task_struct *task, unsigned int idx)return file; } -static void kcmp_unlock (struct mutex *m1,struct mutex *m2) +static void kcmp_unlock (struct rw_semaphore *l1,struct rw_semaphore *l2) { -if (likely (m2 != m1)) -mutex_unlock (m2); -mutex_unlock (m1); +if (likely (l2 != l1)) +up_read (l2); +up_read (l1); } -static int kcmp_lock (struct mutex *m1,struct mutex *m2) +static int kcmp_lock (struct rw_semaphore *l1,struct rw_semaphore *l2) {int err; -if (m2 > m1) -swap (m1, m2); +if (l2 > l1) +swap (l1, l2); - err =mutex_lock_killable (m1); -if (!err &&likely (m1 != m2)) { - err =mutex_lock_killable_nested (m2,SINGLE_DEPTH_NESTING ); + err =down_read_killable (l1); +if (!err &&likely (l1 != l2)) { + err =down_read_killable_nested (l2,SINGLE_DEPTH_NESTING );if (err) -mutex_unlock (m1); +up_read (l1); }return err;
@@ -173,8 +173,8 @@ SYSCALL_DEFINE5(kcmp, pid_t, pid1, pid_t, pid2, int, type,/* * One should have enough rights to inspect task details. */ - ret =kcmp_lock (&task1->signal->exec_update_mutex, - &task2->signal->exec_update_mutex); + ret =kcmp_lock (&task1->signal->exec_update_lock, + &task2->signal->exec_update_lock);if (ret) goto err; if (!ptrace_may_access(task1, PTRACE_MODE_READ_REALCREDS) ||
@@ -229,8 +229,8 @@ SYSCALL_DEFINE5(kcmp, pid_t, pid1, pid_t, pid2, int, type, } err_unlock: -kcmp_unlock (&task1->signal->exec_update_mutex, - &task2->signal->exec_update_mutex); +kcmp_unlock (&task1->signal->exec_update_lock, + &task2->signal->exec_update_lock); err:put_task_struct (task1);put_task_struct (task2);
kernel/pid.c +2 -2
@@ -628,7 +628,7 @@ static struct file *__pidfd_fget(struct task_struct *task, int fd)struct file *file;int ret; - ret =mutex_lock_killable (&task->signal->exec_update_mutex); + ret =down_read_killable (&task->signal->exec_update_lock);if (ret)return ERR_PTR (ret);
@@ -637,7 +637,7 @@ static struct file *__pidfd_fget(struct task_struct *task, int fd)else file =ERR_PTR (-EPERM ); -mutex_unlock (&task->signal->exec_update_mutex); +up_read (&task->signal->exec_update_lock);return file ?:ERR_PTR (-EBADF ); }
Signature · 1 line
2.27.0
Greg Kroah-Hartman
maintainerPATCH 20/20 mwifiex: Fix possible buffer overflows in mwifiex_cmd_802_11_ad_hoc_start
In reply to Greg Kroah-HartmanFrom: Zhang Xiaohui <[email protected]>
[ Upstream commit 5c455c5ab332773464d02ba17015acdca198f03d ]
mwifiex_cmd_802_11_ad_hoc_start() calls memcpy() without checking the destination size may trigger a buffer overflower, which a local user could use to cause denial of service or the execution of arbitrary code.
Fix it by putting the length check before calling memcpy().
--- drivers/net/wireless/marvell/mwifiex/join.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/net/wireless/marvell/mwifiex/join.c +2 -0
@@ -877,6 +877,8 @@ mwifiex_cmd_802_11_ad_hoc_start(struct mwifiex_private *priv,memset (adhoc_start->ssid,0 ,IEEE80211_MAX_SSID_LEN ); +if (req_ssid->ssid_len >IEEE80211_MAX_SSID_LEN ) + req_ssid->ssid_len =IEEE80211_MAX_SSID_LEN ;memcpy (adhoc_start->ssid, req_ssid->ssid, req_ssid->ssid_len); mwifiex_dbg(adapter, INFO, "info: ADHOC_S_CMD: SSID = %s\n",
Signature · 1 line
2.27.0
Quoted 9 lines · Greg Kroah-Hartman
This is the start of the stable review cycle for the 5.10.6 release. There are 20 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Sat, 09 Jan 2021 14:30:35 +0000. Anything received after that time might be too late.
The whole patch series can be found in one patch at:
Quoted 8 lines
https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.6-rc1.gzor in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.gitlinux-5.10.y
and the diffstat can be found below.thanks,
greg k-h
All tests passing for Tegra ...
Test results for stable-v5.10:
12 builds: 12 pass, 0 fail
26 boots: 26 pass, 0 fail
64 tests: 64 pass, 0 failLinux version: 5.10.6-rc1-g208f314c03c5
Boards tested: tegra124-jetson-tk1, tegra186-p2771-0000,
tegra194-p2972-0000, tegra20-ventana,
tegra210-p2371-2180, tegra210-p3450-0000,
tegra30-cardhu-a04Jon
Greg Kroah-Hartman
maintainerQuoted 26 lines · Jon Hunter
Quoted 9 lines · Greg Kroah-Hartman
This is the start of the stable review cycle for the 5.10.6 release. There are 20 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Sat, 09 Jan 2021 14:30:35 +0000. Anything received after that time might be too late.
The whole patch series can be found in one patch at:
Quoted 8 lines
https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.6-rc1.gzor in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.gitlinux-5.10.y
and the diffstat can be found below.thanks,
greg k-h
All tests passing for Tegra ...
Test results for stable-v5.10:
12 builds: 12 pass, 0 fail 26 boots: 26 pass, 0 fail 64 tests: 64 pass, 0 fail
Quoted 7 lines
Linux version: 5.10.6-rc1-g208f314c03c5
Boards tested: tegra124-jetson-tk1, tegra186-p2771-0000,tegra194-p2972-0000, tegra20-ventana, tegra210-p2371-2180, tegra210-p3450-0000, tegra30-cardhu-a04Tested-by Jon Hunter <[email protected]>
Thanks for testing all of these and letting me know.
greg k-h
Quoted 9 lines · Greg Kroah-Hartman
This is the start of the stable review cycle for the 5.10.6 release. There are 20 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Sat, 09 Jan 2021 14:30:35 +0000. Anything received after that time might be too late.
The whole patch series can be found in one patch at:
Quoted 9 lines
https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.6-rc1.gzor in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.gitlinux-5.10.y
and the diffstat can be found below.thanks,
greg k-h
Compiled and booted on my test system. No dmesg regressions.
thanks,
-- Shuah
Greg Kroah-Hartman
maintainerQuoted 15 lines · Shuah Khan
Quoted 14 lines · Greg Kroah-Hartman
This is the start of the stable review cycle for the 5.10.6 release. There are 20 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Sat, 09 Jan 2021 14:30:35 +0000. Anything received after that time might be too late.
The whole patch series can be found in one patch at:
https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.6-rc1.gzor in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.gitlinux-5.10.y
and the diffstat can be found below.
Quoted 8 lines
Quoted 4 lines
thanks,
greg k-h
Compiled and booted on my test system. No dmesg regressions.
Tested-by Shuah Khan <[email protected]>
Thanks for testing them and letting me know.
greg k-h
Quoted 10 lines · Greg Kroah-Hartman
This is the start of the stable review cycle for the 5.10.6 release. There are 20 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Sat, 09 Jan 2021 14:30:35 +0000. Anything received after that time might be too late.
The whole patch series can be found in one patch at:
Quoted 9 lines
https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.6-rc1.gzor in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.gitlinux-5.10.y
and the diffstat can be found below.thanks,
greg k-h
Results from Linaro’s test farm.
No regressions on arm64, arm, x86_64, and i386.
Summary
------------------------------------------------------------------------
kernel: 5.10.6-rc1
git repo: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
git branch: linux-5.10.y
git commit: 208f314c03c52f01c09eaff3018fd704c2f8fbe2
git describe: v5.10.5-21-g208f314c03c5
Test details: https://qa-reports.linaro.org/lkft/linux-stable-rc-linux-5.10.y/build/v5.10.5-21-g208f314c03c5
No regressions (compared to build v5.10.5)
No fixes (compared to build v5.10.5)
Ran 56928 total tests in the following environments and test suites.
Environments
--------------
- arc
- arm
- arm64
- dragonboard-410c
- hi6220-hikey
- i386
- juno-r2
- juno-r2-compat
- juno-r2-kasan
- mips
- nxp-ls2088
- parisc
- powerpc
- qemu-arm-clang
- qemu-arm64-clang
- qemu-arm64-kasan
- qemu-i386-clang
- qemu-x86_64-clang
- qemu-x86_64-kasan
- qemu-x86_64-kcsan
- qemu_arm
- qemu_arm64
- qemu_arm64-compat
- qemu_i386
- qemu_x86_64
- qemu_x86_64-compat
- riscv
- s390
- sh
- sparc
- x15
- x86
- x86-kasan
Test Suites
-----------
* build
* linux-log-parser
* install-android-platform-tools-r2600
* kselftest
* libhugetlbfs
* ltp-commands-tests
* ltp-cve-tests
* ltp-fcntl-locktests-tests
* ltp-filecaps-tests
* ltp-fs_bind-tests
* ltp-fs_perms_simple-tests
* ltp-fsx-tests
* ltp-hugetlb-tests
* ltp-ipc-tests
* ltp-math-tests
* ltp-mm-tests
* ltp-nptl-tests
* ltp-pty-tests
* ltp-sched-tests
* ltp-securebits-tests
* ltp-syscalls-tests
* ltp-tracing-tests
* v4l2-compliance
* fwts
* ltp-cap_bounds-tests
* ltp-containers-tests
* ltp-cpuhotplug-tests
* ltp-crypto-tests
* ltp-dio-tests
* ltp-io-tests
* network-basic-tests
* perf
* ltp-controllers-tests
* ltp-fs-tests
* ltp-open-posix-tests
* kvm-unit-tests
* kunit
* rcutorture
* kselftest-vsyscall-mode-native
* kselftest-vsyscall-mode-none
Signature · 2 lines
Linaro LKFT https://lkft.linaro.org
Greg Kroah-Hartman
maintainerQuoted 19 lines · Naresh Kamboju
Quoted 17 lines · Greg Kroah-Hartman
This is the start of the stable review cycle for the 5.10.6 release. There are 20 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Sat, 09 Jan 2021 14:30:35 +0000. Anything received after that time might be too late.
The whole patch series can be found in one patch at:
https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.6-rc1.gzor in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.gitlinux-5.10.y
and the diffstat can be found below.thanks,
Quoted 7 lines
Quoted 2 lines
greg k-h
Results from Linaro’s test farm.
No regressions on arm64, arm,x86_64, and i386.
Great, thansk for letting me know.
greg k-h
Quoted 8 lines · Greg Kroah-Hartman
This is the start of the stable review cycle for the 5.10.6 release. There are 20 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Sat, 09 Jan 2021 14:30:35 +0000. Anything received after that time might be too late.
Build results:
total: 154 pass: 154 fail: 0 Qemu test results: total: 427 pass: 427 fail: 0
Guenter
Greg Kroah-Hartman
maintainerQuoted 10 lines · Guenter Roeck
Quoted 8 lines · Greg Kroah-Hartman
This is the start of the stable review cycle for the 5.10.6 release. There are 20 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Sat, 09 Jan 2021 14:30:35 +0000. Anything received after that time might be too late.
Quoted 6 lines
Build results:
total: 154 pass: 154 fail: 0 Qemu test results: total: 427 pass: 427 fail: 0Tested-by Guenter Roeck <[email protected]>
Thanks for testing them all and letting me know.
greg k-h