target/s390x: Fix ALGSI
PATCH 1/1 target/s390x: Fix ALGSI
Looks like something went wrong while touching that line. Instead of "r1" we need a new temporary. Also, we have to pass MO_TEQ, to indicate that we are working with 64-bit values. Let's revert these changes.
Fixes ff26d287bddc ("target/s390x: Improve cc computation for ADD LOGICAL")
Signed-off-by David Hildenbrand <[email protected]>
--- target/s390x/insn-data.def | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
target/s390x/insn-data.def +1 -1
@@ -76,7 +76,7 @@ /* ADD LOGICAL WITH SIGNED IMMEDIATE */ D(0xeb6e, ALSI, SIY, GIE, la1, i2_32u, new, 0, asi, addu32, MO_TEUL) C(0xecda, ALHSIK, RIE_d, DO, r3_32u, i2_32u, new, r1_32, add, addu32) - C(0xeb7e, ALGSI, SIY, GIE, la1, i2, r1, 0, asiu64, addu64) + D(0xeb7e, ALGSI, SIY, GIE, la1, i2, new, 0, asiu64, addu64, MO_TEQ) C(0xecdb, ALGHSIK, RIE_d, DO, r3, i2, r1, 0, addu64, addu64) /* ADD LOGICAL WITH SIGNED IMMEDIATE HIGH */ C(0xcc0a, ALSIH, RIL_a, HW, r1_sr32, i2_32u, new, r1_32h, add, addu32)
Signature · 1 line
2.29.2
Quoted 16 lines · David Hildenbrand
Looks like something went wrong while touching that line. Instead of "r1" we need a new temporary. Also, we have to pass
MO_TEQ, to indicate that we are working with 64-bit values. Let's revert these changes.Fixes ff26d287bddc ("target/s390x: Improve cc computation for ADD LOGICAL")Signed-off-by David Hildenbrand <[email protected]>--- target/s390x/insn-data.def | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)target/s390x/insn-data.def +0
-0
target/s390x/insn-data.def line 82
Quoted 8 lines
target/s390x/insn-data.def +1
-1@@ -76,7 +76,7 @@ /* ADD LOGICAL WITH SIGNED IMMEDIATE */ D(0xeb6e, ALSI, SIY, GIE, la1, i2_32u, new, 0, asi, addu32, MO_TEUL) C(0xecda, ALHSIK, RIE_d, DO, r3_32u, i2_32u, new, r1_32, add, addu32) - C(0xeb7e, ALGSI, SIY, GIE, la1, i2, r1, 0, asiu64, addu64) + D(0xeb7e, ALGSI, SIY, GIE, la1, i2, new, 0, asiu64, addu64, MO_TEQ) C(0xecdb, ALGHSIK, RIE_d, DO, r3, i2, r1, 0, addu64, addu64) /* ADD LOGICAL WITH SIGNED IMMEDIATE HIGH */ C(0xcc0a, ALSIH, RIL_a, HW, r1_sr32, i2_32u, new, r1_32h, add, addu32)
Subject should be "s390x/tcg" ...
Signature · 3 lines
Thanks, David / dhildenb